Re: [Nfs-ganesha-devel] multi fd support

[Frank Filz]

> Hi Frank,
> Don't we need fsal_close() to call close2() ?
> We need the owner so we can release only the locks for this fd before
> closing it.
> Marc.

With support_ex enabled, fsal_close is only called when the fsal_obj_handle
is being disposed of or when the LRU thread is closing open file descriptors
(which will now only be those open file descriptors not associated with
state), and it's purpose is only to close the global/anonymous file
descriptor. There should be no locks associated with the global file
descriptor.

A few notes for you:

1. Not having a delegation aware FSAL to work on, I did not explore all the
implications of delegations with support_ex. A delegation probably should
inherit the file descriptor from the initial open state, but maybe it needs
it's own.

2. For NFS v4 locks, the support_ex API SHOULD allow you to just have an
open file descriptor associated with the open state and not have to have one
per lock state (per lock owner) since your locks already have owners
associated without having to have separate file descriptors. For NFS v3
locks of course there is no way (currently) to tie to an open state (even if
there is an NLM_SHARE from the same process). I would like to eventually
look for ties and create them if possible. Of course if it benefits you to
have an open fd per lock owner, that's fine too. And actually, you can even
fall back to using the global file descriptor (and note that now the FSAL
actually gets to control when that's opened or closed).

3. I'm not sure you caught that you need to protect the global file
descriptor with the fsal_obj_handle->lock since the content_lock is no
more...

I'm on vacation the rest of the week so I may not be able to respond until
next week.

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] multi fd support

[Marc Eshel]

Hi Frank,
Don't we need fsal_close() to call close2() ?
We need the owner so we can release only the locks for this fd before 
closing it.
Marc.


--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Simplify nfs_admin_thread.c signalling

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded a new change for review.

  https://review.gerrithub.io/287712

Change subject: Simplify nfs_admin_thread.c signalling
..

Simplify nfs_admin_thread.c signalling

Fixes CID 132617

Change-Id: I708def3daa032abc25ea57d2520166455609539d
Signed-off-by: Frank S. Filz 
---
M src/MainNFSD/nfs_admin_thread.c
1 file changed, 20 insertions(+), 57 deletions(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/12/287712/1
-- 
To view, visit https://review.gerrithub.io/287712
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I708def3daa032abc25ea57d2520166455609539d
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Frank Filz 

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: If the return from atomic_inc or atomic_dec unused (void) call

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded a new change for review.

  https://review.gerrithub.io/287713

Change subject: If the return from atomic_inc or atomic_dec unused (void) call
..

If the return from atomic_inc or atomic_dec unused (void) call

This provides consistency and fixes CID 144636 (Unchecked return value).

Change-Id: I0f66017c123d114f7b6c61aa8638065453de3b75
Signed-off-by: Frank S. Filz 
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_lru.c
M src/FSAL/fsal_helper.c
M src/MainNFSD/9p_dispatcher.c
M src/MainNFSD/nfs_rpc_dispatcher_thread.c
M src/MainNFSD/nfs_worker_thread.c
M src/Protocols/9P/9p_proto_tools.c
M src/Protocols/NLM/nlm_Lock.c
M src/SAL/nlm_owner.c
M src/SAL/state_share.c
M src/include/export_mgr.h
M src/include/fsal.h
M src/include/fsal_api.h
M src/include/gsh_rpc.h
M src/include/pnfs_utils.h
M src/include/sal_functions.h
M src/support/exports.c
16 files changed, 28 insertions(+), 28 deletions(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/13/287713/1
-- 
To view, visit https://review.gerrithub.io/287713
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I0f66017c123d114f7b6c61aa8638065453de3b75
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Frank Filz 

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: multilock: Revamp to use correct buffer sizes

[GerritHub]

>From Frank Filz :

Frank Filz has uploaded a new change for review.

  https://review.gerrithub.io/287715

Change subject: multilock: Revamp to use correct buffer sizes
..

multilock: Revamp to use correct buffer sizes

Fixes a host of Coverity issues.

Change-Id: I905e68753116b891cb4a95a5e45a6dbd6a972090
Signed-off-by: Frank S. Filz 
---
M src/tools/multilock/README
M src/tools/multilock/ml_cephfs_client.c
M src/tools/multilock/ml_console.c
M src/tools/multilock/ml_functions.c
M src/tools/multilock/ml_posix_client.c
M src/tools/multilock/multilock.h
6 files changed, 490 insertions(+), 403 deletions(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/15/287715/1
-- 
To view, visit https://review.gerrithub.io/287715
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I905e68753116b891cb4a95a5e45a6dbd6a972090
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Frank Filz 

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Avoid unnecessary CRIT message in claim_posix_filesystems()

[GerritHub]

>From Malahal :

Malahal has uploaded a new change for review.

  https://review.gerrithub.io/287695

Change subject: Avoid unnecessary CRIT message in claim_posix_filesystems()
..

Avoid unnecessary CRIT message in claim_posix_filesystems()

commit 7067bf09249d891c0204128ae199407874e406fd added rescanning file
systems if not found. callers of this function already log CRIT message
if needed after rescanning.

Change-Id: Ie97e621b10ed2a8ecc354dfea72e2e283e620d5b
Signed-off-by: Malahal Naineni 
---
M src/FSAL/commonlib.c
1 file changed, 0 insertions(+), 3 deletions(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/95/287695/1
-- 
To view, visit https://review.gerrithub.io/287695
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie97e621b10ed2a8ecc354dfea72e2e283e620d5b
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Malahal 

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel