date:20160823

[Nfs-ganesha-devel] Dynamic Export Update Changes

2016-08-23 Thread Frank Filz

There were some problems with the first pass of dynamic export update. If
you have an interest, please test with my new patch.

The major change is it pretty much now ignores the FSAL block in the EXPORT,
so it doesn't call create_export and very specifically doesn't try to do the
pnfs stuff that caused problems.

There are a few other minor issues addressed.

Thanks

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Centos CI

2016-08-23 Thread Frank Filz

I'd love to see some improvements here:

1. Maybe this has been addressed, but reduce spam, only place comments in
Gerrithub for failures

2. Don't abort on checkpatch failures, please do put a gerrithub comment,
but sometimes checkpatch is wrong or there is no convenient way to code
differently, so we want to continue to do other validation.

3. At least at the point where Centos CI is running actual tests, if
everything (other than checkpatch) passes, it should do a +1 Verify

4. As long as we have reasonably reliable tests, and have quick response if
there are spurious test failures and such, it would be nice if test failures
would post a -1 Verify. Another option would be for someone responsible to
review the failure and if looks like a real failure, post a -1 Verify. A key
here is that if the failure is not actually due to the patch in question,
that someone is able to change the Centos CI vote since there is no +2 to
override a -1.

Thanks

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix up dynamic export update

2016-08-23 Thread GerritHub

>From Frank Filz :

Frank Filz has uploaded a new change for review.

  https://review.gerrithub.io/288628

Change subject: Fix up dynamic export update
..

Fix up dynamic export update

- Fix a case where we should have done unlock instead of rdlock...

- Replace fsal_cfg_commit with fsal_update_cfg_commit for export update
  in order to avoid doing create_export which is not appropriate if we
  are just updating the export.

- That also means we can't verify the FSAL Name is the same (so effectively
  we parse the FSAL block, but we otherwise ignore it).

- Don't update atomic options if there was an error.

- A few logging changes

Change-Id: Ifc825b6939b033f0476aa266d6c54abd21904498
Signed-off-by: Frank S. Filz 
---
M src/support/exports.c
1 file changed, 238 insertions(+), 105 deletions(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/28/288628/1
-- 
To view, visit https://review.gerrithub.io/288628
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ifc825b6939b033f0476aa266d6c54abd21904498
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Frank Filz 

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Use roundup macro for file handle length alignment.

2016-08-23 Thread GerritHub

>From Malahal :

Malahal has uploaded a new change for review.

  https://review.gerrithub.io/288627

Change subject: Use roundup macro for file handle length alignment.
..

Use roundup macro for file handle length alignment.

nfs3_sizeof_handle() now uses roundup macro.

Change-Id: I5e072119f06c05cb62562b78dff02acaba7bc7de
Signed-off-by: Malahal Naineni 
---
M src/include/nfs_file_handle.h
1 file changed, 5 insertions(+), 5 deletions(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/27/288627/1
-- 
To view, visit https://review.gerrithub.io/288627
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5e072119f06c05cb62562b78dff02acaba7bc7de
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Malahal 

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Add blocking locks to multi-fd.

2016-08-23 Thread GerritHub

>From :

es...@us.ibm.com has uploaded a new change for review.

  https://review.gerrithub.io/288614

Change subject: Add blocking locks to multi-fd.
..

Add blocking locks to multi-fd.

Change-Id: I73e72c3246b9bc10a3efa5fbe12754c8631aebf6
Signed-off-by: Marc Eshel 
---
M src/FSAL/FSAL_GPFS/file.c
M src/FSAL/FSAL_GPFS/fsal_up.c
2 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/14/288614/1
-- 
To view, visit https://review.gerrithub.io/288614
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I73e72c3246b9bc10a3efa5fbe12754c8631aebf6
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: es...@us.ibm.com

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: 9p proto tools/clunk: check setextattr success

2016-08-23 Thread GerritHub

>From Dominique Martinet :

Dominique Martinet has uploaded a new change for review.

  https://review.gerrithub.io/288593

Change subject: 9p proto tools/clunk: check setextattr success
..

9p proto tools/clunk: check setextattr success

Fix coverity CID144646

Change-Id: Ic2199551d9533bfc971006d7291226a46f20501b
Signed-off-by: Dominique Martinet 
---
M src/Protocols/9P/9p_proto_tools.c
1 file changed, 4 insertions(+), 0 deletions(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/93/288593/1
-- 
To view, visit https://review.gerrithub.io/288593
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic2199551d9533bfc971006d7291226a46f20501b
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Dominique Martinet 

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] MDC up call

2016-08-23 Thread Daniel Gryniewicz

Hi, Soumya.

I've updated the PR.  Can you test again?

On Tue, Aug 23, 2016 at 10:24 AM, Daniel Gryniewicz  wrote:
> Thanks.  I'll look at it.
>
> Daniel
>
> On Tue, Aug 23, 2016 at 8:51 AM, Soumya Koduri  wrote:
>> Hi Dan,
>>
>> On 08/22/2016 05:40 PM, Daniel Gryniewicz wrote:
>>>
>>> Excellent Marc, thanks.
>>>
>>> Soumya, could you test this with the Gluster up-calls to make sure I
>>> didn't break them?
>>
>>
>> I hit below crash when tested with the latest patchset -
>>
>> Program received signal SIGSEGV, Segmentation fault.
>> [Switching to Thread 0x7f2ca4f45700 (LWP 6475)]
>> 0x00523598 in mdc_up_invalidate (export=0x1b73f60,
>> handle=0x7f2cb4001b08, flags=271)
>> at
>> /home/guest/Documents/workspace/nfs-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c:55
>> 55  key.fsal = export->sub_export->fsal;
>> (gdb) bt
>> #0  0x00523598 in mdc_up_invalidate (export=0x1b73f60,
>> handle=0x7f2cb4001b08, flags=271)
>> at
>> /home/guest/Documents/workspace/nfs-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c:55
>> #1  0x00436ea2 in queue_invalidate (ctx=0x7f2cb4001b60) at
>> /home/guest/Documents/workspace/nfs-ganesha/src/FSAL_UP/fsal_up_async.c:81
>> #2  0x004fbcb7 in fridgethr_start_routine (arg=0x7f2cb4001b60) at
>> /home/guest/Documents/workspace/nfs-ganesha/src/support/fridgethr.c:550
>> #3  0x7f2cdffc860a in start_thread (arg=0x7f2ca4f45700) at
>> pthread_create.c:334
>> #4  0x7f2cdf8e1bbd in clone () at
>> ../sysdeps/unix/sysv/linux/x86_64/clone.S:109
>> (gdb) p export
>> $1 = (struct fsal_export *) 0x1b73f60
>> (gdb) p export->sub_export
>> $2 = (struct fsal_export *) 0x0
>> (gdb)
>>
>> Thanks,
>> Soumya
>>
>>>
>>> Thanks,
>>> Daniel
>>>
>>> On Sun, Aug 21, 2016 at 8:07 PM, Marc Eshel  wrote:

 This time it did work.
 Marc.



 From:   Daniel Gryniewicz 
 To: Marc Eshel/Almaden/IBM@IBMUS
 Cc: Frank Filz , NFS Ganesha Developers
 
 Date:   08/21/2016 02:45 PM
 Subject:Re: MDC up call



 In general, MDCACHE assumes it has op_ctx set, and I'd prefer to not
 have that assumption violated, as it will complicate the code a lot.

 It appears that the export passed into the upcalls is already the
 MDCACHE export, not the sub-export.  I've uploaded a new version of
 the patch with that change.  Coud you try it again?

 On Fri, Aug 19, 2016 at 4:56 PM, Marc Eshel  wrote:
>
> I am not sure you need to set op_ctx
> I fixed it for this path by not calling  mdc_check_mapping() from
> mdcache_find_keyed() if op_ctx is NULL
> I think the mapping should already exist for calls that are coming from
> up-call.
> Marc.
>
>
>
> From:   Daniel Gryniewicz 
> To: Marc Eshel/Almaden/IBM@IBMUS
> Cc: Frank Filz ,
> nfs-ganesha-devel@lists.sourceforge.net
> Date:   08/19/2016 06:13 AM
> Subject:Re: MDC up call
>
>
>
> Marc, could you try with this patch: https://review.gerrithub.io/287904
>
> Daniel
>
> On 08/18/2016 06:55 PM, Marc Eshel wrote:
>>
>> Was up-call with MDC tested?
>> It looks like it is trying to use op_ctx which is NULL.
>> Marc.
>>
>>
>> Program received signal SIGSEGV, Segmentation fault.
>> [Switching to Thread 0x7fe867fff700 (LWP 18907)]
>> 0x00532b76 in mdc_cur_export () at
>>
>

 /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h:376
>>
>> 376 return mdc_export(op_ctx->fsal_export);
>> (gdb) where
>> #0  0x00532b76 in mdc_cur_export () at
>>
>

 /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h:376
>>
>> #1  0x005342a1 in mdc_check_mapping (entry=0x7fe870001530) at
>>
>

 /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:210
>>
>> #2  0x0053584c in mdcache_find_keyed (key=0x7fe867ffe470,
>> entry=0x7fe867ffe468) at
>>
>

 /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:636
>>
>> #3  0x005358c1 in mdcache_locate_keyed (key=0x7fe867ffe470,
>> export=0x12d8f40, entry=0x7fe867ffe468, attrs_out=0x0)
>> at
>>
>

 /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:670
>>
>> #4  0x0052feac in mdcache_create_handle (exp_hdl=0x12d8f40,
>> hdl_desc=0x7fe880001088, handle=0x7fe867ffe4e8, attrs_out=0x0)
>> at
>>
>

 /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1629
>>
>> #5

Re: [Nfs-ganesha-devel] MDC up call

2016-08-23 Thread Soumya Koduri

Hi Dan,

On 08/22/2016 05:40 PM, Daniel Gryniewicz wrote:
> Excellent Marc, thanks.
>
> Soumya, could you test this with the Gluster up-calls to make sure I
> didn't break them?

I hit below crash when tested with the latest patchset -

Program received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7f2ca4f45700 (LWP 6475)]
0x00523598 in mdc_up_invalidate (export=0x1b73f60, 
handle=0x7f2cb4001b08, flags=271)
 at 
/home/guest/Documents/workspace/nfs-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c:55
55  key.fsal = export->sub_export->fsal;
(gdb) bt
#0  0x00523598 in mdc_up_invalidate (export=0x1b73f60, 
handle=0x7f2cb4001b08, flags=271)
 at 
/home/guest/Documents/workspace/nfs-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_up.c:55
#1  0x00436ea2 in queue_invalidate (ctx=0x7f2cb4001b60) at 
/home/guest/Documents/workspace/nfs-ganesha/src/FSAL_UP/fsal_up_async.c:81
#2  0x004fbcb7 in fridgethr_start_routine (arg=0x7f2cb4001b60) 
at /home/guest/Documents/workspace/nfs-ganesha/src/support/fridgethr.c:550
#3  0x7f2cdffc860a in start_thread (arg=0x7f2ca4f45700) at 
pthread_create.c:334
#4  0x7f2cdf8e1bbd in clone () at 
../sysdeps/unix/sysv/linux/x86_64/clone.S:109
(gdb) p export
$1 = (struct fsal_export *) 0x1b73f60
(gdb) p export->sub_export
$2 = (struct fsal_export *) 0x0
(gdb)

Thanks,
Soumya
>
> Thanks,
> Daniel
>
> On Sun, Aug 21, 2016 at 8:07 PM, Marc Eshel  wrote:
>> This time it did work.
>> Marc.
>>
>>
>>
>> From:   Daniel Gryniewicz 
>> To: Marc Eshel/Almaden/IBM@IBMUS
>> Cc: Frank Filz , NFS Ganesha Developers
>> 
>> Date:   08/21/2016 02:45 PM
>> Subject:Re: MDC up call
>>
>>
>>
>> In general, MDCACHE assumes it has op_ctx set, and I'd prefer to not
>> have that assumption violated, as it will complicate the code a lot.
>>
>> It appears that the export passed into the upcalls is already the
>> MDCACHE export, not the sub-export.  I've uploaded a new version of
>> the patch with that change.  Coud you try it again?
>>
>> On Fri, Aug 19, 2016 at 4:56 PM, Marc Eshel  wrote:
>>> I am not sure you need to set op_ctx
>>> I fixed it for this path by not calling  mdc_check_mapping() from
>>> mdcache_find_keyed() if op_ctx is NULL
>>> I think the mapping should already exist for calls that are coming from
>>> up-call.
>>> Marc.
>>>
>>>
>>>
>>> From:   Daniel Gryniewicz 
>>> To: Marc Eshel/Almaden/IBM@IBMUS
>>> Cc: Frank Filz ,
>>> nfs-ganesha-devel@lists.sourceforge.net
>>> Date:   08/19/2016 06:13 AM
>>> Subject:Re: MDC up call
>>>
>>>
>>>
>>> Marc, could you try with this patch: https://review.gerrithub.io/287904
>>>
>>> Daniel
>>>
>>> On 08/18/2016 06:55 PM, Marc Eshel wrote:
 Was up-call with MDC tested?
 It looks like it is trying to use op_ctx which is NULL.
 Marc.


 Program received signal SIGSEGV, Segmentation fault.
 [Switching to Thread 0x7fe867fff700 (LWP 18907)]
 0x00532b76 in mdc_cur_export () at

>>>
>> /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h:376
 376 return mdc_export(op_ctx->fsal_export);
 (gdb) where
 #0  0x00532b76 in mdc_cur_export () at

>>>
>> /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_int.h:376
 #1  0x005342a1 in mdc_check_mapping (entry=0x7fe870001530) at

>>>
>> /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:210
 #2  0x0053584c in mdcache_find_keyed (key=0x7fe867ffe470,
 entry=0x7fe867ffe468) at

>>>
>> /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:636
 #3  0x005358c1 in mdcache_locate_keyed (key=0x7fe867ffe470,
 export=0x12d8f40, entry=0x7fe867ffe468, attrs_out=0x0)
 at

>>>
>> /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c:670
 #4  0x0052feac in mdcache_create_handle (exp_hdl=0x12d8f40,
 hdl_desc=0x7fe880001088, handle=0x7fe867ffe4e8, attrs_out=0x0)
 at

>>>
>> /nas/ganesha/new-ganesha/src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c:1629
 #5  0x00433f36 in lock_avail (export=0x12d8f40,
 file=0x7fe880001088, owner=0x7fe87c302dc0, lock_param=0x7fe8800010a0)
>> at
 /nas/ganesha/new-ganesha/src/FSAL_UP/fsal_up_top.c:172
 #6  0x00438142 in queue_lock_avail (ctx=0x7fe880001100) at
 /nas/ganesha/new-ganesha/src/FSAL_UP/fsal_up_async.c:243
 #7  0x0050156f in fridgethr_start_routine (arg=0x7fe880001100)
>>> at
 /nas/ganesha/new-ganesha/src/support/fridgethr.c:550
 #8  0x7fea288a0df3 in start_thread (arg=0x7fe867fff700) at
 pthread_create.c:308
 #9  0x7fea27f603dd in clone () at

[Nfs-ganesha-devel] Dynamic Export Update Changes

[Nfs-ganesha-devel] Centos CI

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix up dynamic export update

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Use roundup macro for file handle length alignment.

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Add blocking locks to multi-fd.

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: 9p proto tools/clunk: check setextattr success

Re: [Nfs-ganesha-devel] MDC up call

Re: [Nfs-ganesha-devel] MDC up call

8 matches

Site Navigation

Mail list logo

Footer information