[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_GPFS: fix exclusive create and setattr for open2

[GerritHub]

>From :

es...@us.ibm.com has uploaded a new change for review.

  https://review.gerrithub.io/290390

Change subject: FSAL_GPFS: fix exclusive create and setattr for open2
..

FSAL_GPFS: fix exclusive create and setattr for open2

Change-Id: Ib6a24f8cdfa6542dee07c5319f1a2baeee94ce34
Signed-off-by: Marc Eshel 
---
M src/FSAL/FSAL_GPFS/file.c
M src/FSAL/FSAL_GPFS/fsal_create.c
M src/FSAL/FSAL_GPFS/fsal_fileop.c
M src/FSAL/FSAL_GPFS/fsal_internal.h
4 files changed, 78 insertions(+), 18 deletions(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/90/290390/1
-- 
To view, visit https://review.gerrithub.io/290390
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib6a24f8cdfa6542dee07c5319f1a2baeee94ce34
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: es...@us.ibm.com

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] NLM async locking

[Marc Eshel]

Did you get a chance to look at this problem?
Marc.



From:   "Frank Filz" 
To: Marc Eshel/Almaden/IBM@IBMUS
Cc: "'nfs-ganesha-devel'" 
Date:   08/29/2016 02:37 PM
Subject:RE: NLM async locking



> I see the following failure:
> 1. Get conflicting locks from 3 clients
> cli 1 gets 0-100
> cli 2 is blocked on 0-1000
> cli 3 is blocked on 0-1
> 2. cli 1 unlocks
> up-call for cli 2 and 3 to retry
> cli 2 gets 0-1000
> cli 3 is blocked on 0-1000
> 3. cli 2 unlocks
> up-call for cli 3 but Ganesha fails
> 
> /* We must be out of sync with FSAL, this is fatal */
> LogLockDesc(COMPONENT_STATE, NIV_MAJ, "Blocked Lock Not Found
> for"
> ,
> obj, owner, lock);
> LogFatal(COMPONENT_STATE, "Locks out of sync with FSAL");
> 
> I think the problem is in step 2, after cli 3 failed for the second time
it is not
> put back in queue, the sbd_list.
> 
> Can you please confirm this logic is very complicated.

That sounds like a likely problem. I'd have to dig into the code to see
why... May take me a day or two to investigate.

Frank



---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus






--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Announce Push of V2.4-rc3

[Frank Filz]

Branch next

Note: A quick push to get some stuff that is ready to go and facilitate
folks rebasing on top of some of these.

Tag:V2.4-rc3

Release Highlights

* FSAL_RGW converted to support_ex

* Fix some RQUOTA issues

* Fix a Coverity issue

Signed-off-by: Frank S. Filz 

Contents:

3c01390 Frank S. Filz V2.4-rc3
9d6b05d Daniel Gryniewicz Fix coverity issue #152525 - unchecked return
493b8ef Madhu Thorat Use ext_setquota_args for RQUOTA version 2
88d55c5 Madhu Thorat Use GPFS OPENHANDLE_QUOTA to get/set quota
301bcd6 Matt Benjamin RGW: implement support_ex


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] [ntirpc] refcount issue ?

[Matt Benjamin]

Hi,

inline

- Original Message -
> From: "Swen Schillig" 
> To: "Matt Benjamin" , "Daniel Gryniewicz" 
> 
> Cc: "nfs-ganesha-devel" 
> Sent: Tuesday, September 6, 2016 4:10:32 PM
> Subject: [ntirpc] refcount issue ?
> 
> Matt, Dan.
> 
> Could you please have a look at the following code areas and verify
> what I think is a refcount issue.
> 
> clnt_vc_ncreate2()
> {
> ...
>   if ((oflags & RPC_DPLX_LKP_OFLAG_ALLOC) || (!rec->hdl.xd)) {
>   xd = rec->hdl.xd = alloc_x_vc_data();
>   ...
>   } else {
>   xd = rec->hdl.xd;
>   ++(xd->refcnt);     <=== this is not right. we're not taking an 
> addtl' ref

Aren't we?  We now share a ref to previously allocated rec->hdl.xd.

>   here.
>   }
> ...
>   clnt->cl_p1 = xd;           <=== but here we should increment the 
> refocunt.
> }
> 
> another code section with the same handling.
> 
> makefd_xprt()
> {
> ...
>   if ((oflags & RPC_DPLX_LKP_OFLAG_ALLOC) || (!rec->hdl.xd)) {
>   newxd = true;
>   xd = rec->hdl.xd = alloc_x_vc_data();
>   ...
>   } else {
>   xd = (struct x_vc_data *)rec->hdl.xd;
>   /* dont return destroyed xprts */
>   if (!(xd->flags & X_VC_DATA_FLAG_SVC_DESTROYED)) {
>   if (rec->hdl.xprt) {
>   xprt = rec->hdl.xprt;
>   /* inc xprt refcnt */
>   SVC_REF(xprt, SVC_REF_FLAG_NONE);
>   } else
>   ++(xd->refcnt);    < not right, no addtl' 
> ref to xd taken.

so this looks more likely to be incorrect, need to review

>   }
>   /* return extra ref */
>   rpc_dplx_unref(rec,
>      RPC_DPLX_FLAG_LOCKED | RPC_DPLX_FLAG_UNLOCK);
>   *allocated = FALSE;
> 
>   /* return ref'd xprt */
>   goto done_xprt;
>   }
>   ...
>   xprt->xp_p1 = xd;    < but here we should increment the refcount
>   
>   ...
> }
> 
> Both areas handle the refcount'ing wrong, but it might balance out
> sometimes.
> 
> 
> What do you think ?
> 
> Cheers Swen
> 
> 

-- 
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://www.redhat.com/en/technologies/storage

tel.  734-707-0660
fax.  734-769-8938
cel.  734-216-5309

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Enable purging netgroups cache

[GerritHub]

>From Malahal :

Malahal has uploaded a new change for review.

  https://review.gerrithub.io/290351

Change subject: Enable purging netgroups cache
..

Enable purging netgroups cache

The cache entries of innetgr() calls auto expire after 30 minutes. If an
admin wants to make a netgroups config change effective sooner, he could
now use "ganesha_mgr purge netgroups"

Change-Id: Icb95438b423d36447fb7db08adebb39ffe6cafb5
Signed-off-by: Malahal Naineni 
---
M src/MainNFSD/nfs_admin_thread.c
M src/scripts/ganeshactl/Ganesha/ganesha_mgr_utils.py
M src/scripts/ganeshactl/ganesha_mgr.py
3 files changed, 63 insertions(+), 0 deletions(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/51/290351/1
-- 
To view, visit https://review.gerrithub.io/290351
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Icb95438b423d36447fb7db08adebb39ffe6cafb5
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Malahal 

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] could you have a look at swen's PR when you get a chance?

[Matt Benjamin]

ok, merged

- Original Message -
> From: "Matt Benjamin" 
> To: "Daniel Gryniewicz" 
> Cc: "nfs-ganesha-devel" 
> Sent: Tuesday, September 6, 2016 1:07:05 PM
> Subject: [Nfs-ganesha-devel] could you have a look at swen's PR when you get  
> a chance?
> 
> https://github.com/nfs-ganesha/ntirpc/pull/18
> 
> I've flagged 1 (out of 2) changed sections as potentially suspicious, and
> would could use a cross-check.
> 
> Thanks!
> 
> Matt
> 
> --
> Matt Benjamin
> Red Hat, Inc.
> 315 West Huron Street, Suite 140A
> Ann Arbor, Michigan 48103
> 
> http://www.redhat.com/en/technologies/storage
> 
> tel.  734-707-0660
> fax.  734-769-8938
> cel.  734-216-5309
> 
> --
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
> 

-- 
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://www.redhat.com/en/technologies/storage

tel.  734-707-0660
fax.  734-769-8938
cel.  734-216-5309

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Exit upon an error in option parsing in ganesha_mgr script.

[GerritHub]

>From Malahal :

Malahal has uploaded a new change for review.

  https://review.gerrithub.io/290352

Change subject: Exit upon an error in option parsing in ganesha_mgr script.
..

Exit upon an error in option parsing in ganesha_mgr script.

Change-Id: I61f3bd6d35320b495473e5e54c0c646bc239fe86
Signed-off-by: Malahal Naineni 
---
M src/scripts/ganeshactl/ganesha_mgr.py
1 file changed, 9 insertions(+), 1 deletion(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/52/290352/1
-- 
To view, visit https://review.gerrithub.io/290352
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I61f3bd6d35320b495473e5e54c0c646bc239fe86
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Malahal 

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] could you have a look at swen's PR when you get a chance?

[Matt Benjamin]

https://github.com/nfs-ganesha/ntirpc/pull/18

I've flagged 1 (out of 2) changed sections as potentially suspicious, and would 
could use a cross-check.

Thanks!

Matt

-- 
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://www.redhat.com/en/technologies/storage

tel.  734-707-0660
fax.  734-769-8938
cel.  734-216-5309

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix coverity issue #152525 - unchecked return

[GerritHub]

>From Daniel Gryniewicz :

Daniel Gryniewicz has uploaded a new change for review.

  https://review.gerrithub.io/290340

Change subject: Fix coverity issue #152525 - unchecked return
..

Fix coverity issue #152525 - unchecked return

Change-Id: I09dcffd3a69f0a76ff338bff538441ec24e57e91
Signed-off-by: Daniel Gryniewicz 
---
M src/include/sal_functions.h
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/40/290340/1
-- 
To view, visit https://review.gerrithub.io/290340
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I09dcffd3a69f0a76ff338bff538441ec24e57e91
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Daniel Gryniewicz 

--
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel