[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: [nfs_rpc_callback.c] Added missing mutex unlock, code improv...

2017-01-19 Thread GerritHub 
>From Swen Schillig :

Swen Schillig has uploaded a new change for review. ( 
https://review.gerrithub.io/343795


Change subject: [nfs_rpc_callback.c] Added missing mutex unlock, code 
improvements.
..

[nfs_rpc_callback.c] Added missing mutex unlock, code improvements.

Added missing unlock in function nfs_rpc_create_chan_v41.
Removed unused code, removed magic numbers and
added some more minor code cleanup.

Change-Id: I70d461b99ffc26e0231457124942ca33db141676
Signed-off-by: Swen Schillig 
---
M src/MainNFSD/nfs_rpc_callback.c
1 file changed, 207 insertions(+), 252 deletions(-)



  git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha 
refs/changes/95/343795/1
-- 
To view, visit https://review.gerrithub.io/343795
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I70d461b99ffc26e0231457124942ca33db141676
Gerrit-Change-Number: 343795
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Swen Schillig 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Readdir results for FSAL_CEPH

2017-01-19 Thread Daniel Gryniewicz 
So, it sounds like there's a small benefit to the caching, but not much. 
  I'll look into that initial jump, to see if it's caused by my 
stop-caching code.

Daniel

On 01/19/2017 05:09 AM, Jiffin Tony Thottan wrote:
> Hi,
>
> I have done similar exercise on FSAL_GLUSTER
>
> configuration :
>
> gluster volume 2x2 using 4 servers with 4GB RAM and IGB ethernet cable
> b/w them
>
> It was export by one of the above server and mounted in another client
> machine,
>
> created 1 1kb files
>
> Got a similar kind of result like FSAL_CEPH
>
> i) dirent caching enabled
> real0m2.518s
> real0m2.706s
> real0m2.628s
> real0m2.712s
> real0m2.197s
> real0m2.065s
> real0m2.072s
> real0m2.674s
> real0m2.649s
> real0m2.652s
>
> ii.) dirent caching disabled
> real0m6.178s
> real0m2.638s
> real0m2.481s
> real0m2.501s
> real0m2.524s
> real0m2.515s
> real0m2.476s
> real0m2.551s
> real0m2.580s
> real0m2.543s
>
> Regards,
> Jiffin
>
> On 14/01/17 02:31, Frank Filz wrote:
>> Here are the FSAL_CEPH results:
>>
>> With 1 files, dirent caching enabled
>> real 0m1.032s
>> real 0m1.315s
>> real 0m1.421s
>> real 0m1.429s
>> real 0m1.377s
>> real 0m1.344s
>> real 0m0.667s
>> real 0m1.400s
>> real 0m1.389s
>> real 0m1.728s
>> With 1 files, dirent caching disabled
>> real 0m15.483s
>> real 0m1.457s
>> real 0m1.487s
>> real 0m1.511s
>> real 0m1.498s
>> real 0m1.765s
>> real 0m1.445s
>> real 0m0.930s
>> real 0m0.793s
>> real 0m1.178s
>>
>> We need to investigate why in the uncached case it takes 15 seconds for the
>> initial readdir. I repeated the experiment several times cached and uncached
>> and consistently got comparable results.
>>
>> Ceph (as was expected) saw less differentiation between cached and uncached,
>> there might still be a small advantage to the cached, but it may not be
>> statistically significant.
>>
>> Frank
>>
>>
>> ---
>> This email has been checked for viruses by Avast antivirus software.
>> https://www.avast.com/antivirus
>>
>>
>> --
>> Developer Access Program for Intel Xeon Phi Processors
>> Access to Intel Xeon Phi processor-based developer platforms.
>> With one year of Intel Parallel Studio XE.
>> Training and support from Colfax.
>> Order your platform today. http://sdm.link/xeonphi
>> ___
>> Nfs-ganesha-devel mailing list
>> Nfs-ganesha-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: WIP: Fix a race in nfs_dupreq_put_drc with nfs_dupreq_get_drc

2017-01-19 Thread GerritHub 
>From Malahal :

Malahal has uploaded a new change for review. ( 
https://review.gerrithub.io/343710


Change subject: WIP: Fix a race in nfs_dupreq_put_drc with nfs_dupreq_get_drc
..

WIP: Fix a race in nfs_dupreq_put_drc with nfs_dupreq_get_drc

When the drc refcount goes to zero, nfs_dupreq_put_drc() puts the drc
into a recyle list. The list insertion and the flag bit DRC_FLAG_RECYCLE
should be atomic.  nfs_dupreq_put_drc() needs to recheck the flag after
dropping the lock and re-acquiring it.

Change-Id: I6081f4496e82f7b7c9ea79a0c58cbd3c91417e87
Signed-off-by: Malahal Naineni 
---
M src/RPCAL/nfs_dupreq.c
1 file changed, 31 insertions(+), 16 deletions(-)



  git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha 
refs/changes/10/343710/1
-- 
To view, visit https://review.gerrithub.io/343710
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I6081f4496e82f7b7c9ea79a0c58cbd3c91417e87
Gerrit-Change-Number: 343710
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: Malahal 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Readdir results for FSAL_CEPH

2017-01-19 Thread Jiffin Tony Thottan 
Hi,

I have done similar exercise on FSAL_GLUSTER

configuration :

gluster volume 2x2 using 4 servers with 4GB RAM and IGB ethernet cable 
b/w them

It was export by one of the above server and mounted in another client 
machine,

created 1 1kb files

Got a similar kind of result like FSAL_CEPH

i) dirent caching enabled
real0m2.518s
real0m2.706s
real0m2.628s
real0m2.712s
real0m2.197s
real0m2.065s
real0m2.072s
real0m2.674s
real0m2.649s
real0m2.652s

ii.) dirent caching disabled
real0m6.178s
real0m2.638s
real0m2.481s
real0m2.501s
real0m2.524s
real0m2.515s
real0m2.476s
real0m2.551s
real0m2.580s
real0m2.543s

Regards,
Jiffin

On 14/01/17 02:31, Frank Filz wrote:
> Here are the FSAL_CEPH results:
>
> With 1 files, dirent caching enabled
> real  0m1.032s
> real  0m1.315s
> real  0m1.421s
> real  0m1.429s
> real  0m1.377s
> real  0m1.344s
> real  0m0.667s
> real  0m1.400s
> real  0m1.389s
> real  0m1.728s
> With 1 files, dirent caching disabled
> real  0m15.483s
> real  0m1.457s
> real  0m1.487s
> real  0m1.511s
> real  0m1.498s
> real  0m1.765s
> real  0m1.445s
> real  0m0.930s
> real  0m0.793s
> real  0m1.178s
>
> We need to investigate why in the uncached case it takes 15 seconds for the
> initial readdir. I repeated the experiment several times cached and uncached
> and consistently got comparable results.
>
> Ceph (as was expected) saw less differentiation between cached and uncached,
> there might still be a small advantage to the cached, but it may not be
> statistically significant.
>
> Frank
>
>
> ---
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
>
>
> --
> Developer Access Program for Intel Xeon Phi Processors
> Access to Intel Xeon Phi processor-based developer platforms.
> With one year of Intel Parallel Studio XE.
> Training and support from Colfax.
> Order your platform today. http://sdm.link/xeonphi
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel