[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Fix the log message

[GerritHub]

>From :

supriti.si...@suse.com has uploaded a new change for review. ( 
https://review.gerrithub.io/350650


Change subject: Fix the log message
..

Fix the log message

Change-Id: Ibf0f62fea91deacb4d1f70d28963a34baf129ec2
Signed-off-by: Supriti Singh 
---
M src/MainNFSD/nfs_init.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.gerrithub.io:29419/ffilz/nfs-ganesha 
refs/changes/50/350650/1
-- 
To view, visit https://review.gerrithub.io/350650
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf0f62fea91deacb4d1f70d28963a34baf129ec2
Gerrit-Change-Number: 350650
Gerrit-PatchSet: 1
Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-Owner: supriti.si...@suse.com
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] ganesha config editor user interface thoughts

[Dominique Martinet]

Malahal Naineni wrote on Sat, Feb 25, 2017 at 03:33:17PM +0530:
> - All config is in blocks
> - Most blocks are unique with their tag names
>   - exceptions: "export" and "client" blocks.
>   - "export" is unique by "path" value

More like unique by pseudo path; path can be identical for various
reasons (e.g. exporting the same backend multiple times with different
options)

>   - "client" is unique by "clients" value with in the export block.
> - Log blocks have few subblocks.

export can also have an arbitrary number of sub-blocks (for FSAL and
stackable FSALs); I think the syntax here should be generic enough and
recursively handled e.g. maybe
ganesha_config set blockname.subblock[.subblock[...]] key value

-- 
Dominique

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] ganesha config editor user interface thoughts

[Malahal Naineni]

Based on Sriram's options idea:

"ganesha_config set blocknames [sub-blocknames] --parameter value"
will created block/subblocks if doesn't exist and will add the given
parameter values inside the block.

For example, "ganesha_config set NFS_CORE_PARAM --MNT_port " will
create nfs_core_param block if it is not already there and will add
MNT_port as .

"ganesha_config set LOG COMPONENTS --IDMAPPER FULL_DEBUG"  will create

 LOG {
 COMPONENTS {
   IDMAPPER = FULL_DEBUG;
 }
}

Regards, Malahal.



On Mon, Feb 27, 2017 at 12:45 PM, sriram patil  wrote:
> Hi Malahal,
>
> Can we have the key value pairs as options to the commands? For example,
>
> ganesha_config add export path --pseudo  --protocols 4 --access
> RW --exportid 30
>
> This way the block can be setup in a single command. Also, one does not have
> to worry about the exact key and cases (like Export_id).
>
> But, the line of code will increase for sure.
>
> Thanks,
> Sriram
>
>
> On Sun, Feb 26, 2017 at 9:26 AM, Frank Filz  wrote:
>>
>> There are Sind empty blocks such as log components can be empty.
>>
>> Sent from my iPhone
>>
>> > On Feb 25, 2017, at 7:20 PM, Malahal Naineni  wrote:
>> >
>> > Assuming that there is no point in creating empty blocks, then we can
>> > just have "set" and "del" commands. The "set" command's last two
>> > arguments are always "key, value" pairs.
>> >
>> > ganesha_conf set block [subblocks] key value
>> > ganesha_conf del block [subblocks] [key]
>> >
>> > We might need a show command  to complement this as well.
>> >
>> >> On Sat, Feb 25, 2017 at 3:33 PM, Malahal Naineni 
>> >> wrote:
>> >> Hi All, As as I said last week, here are my thoughts on command line
>> >> interface to edit ganesha config. Appreciate any thoughts on this.
>> >>
>> >> Observations:
>> >>
>> >> - All config is in blocks
>> >> - Most blocks are unique with their tag names
>> >>  - exceptions: "export" and "client" blocks.
>> >>  - "export" is unique by "path" value
>> >>  - "client" is unique by "clients" value with in the export block.
>> >> - Log blocks have few subblocks.
>> >> - Blocks contain a list of key value pairs and possibly some subblocks.
>> >>
>> >> Commands to create a block/subblock
>> >> (block and subblock names should be validated)
>> >>
>> >> ganesha_config add blockname
>> >> ganesha_config add log [subblocks]
>> >> ganesha_config add export path
>> >> ganesha_config add export path client clients
>> >>
>> >> Add, delete, modify a key value pair in a block/subblock
>> >> (key and values need to be validated)
>> >>
>> >> ganehsa_config mod blockname key value
>> >> ganesha_config mod log [sub-blocks] key value
>> >> ganesha_config mod export path key value
>> >> ganehsa_config mod export path client clients key value
>> >>
>> >> Absence of "value" will delete the key itself from the block. This
>> >> means "key"
>> >> name can't be a subblock name. Is this true today and want to preserve
>> >> this
>> >> behavior? Otherwise, we will have to use "delete" as a special reserved
>> >> value to delete a key. Any thoughts?
>> >>
>> >>
>> >> Commands to delete a block/subblock (same as their "add" counter parts)
>> >>
>> >> ganesha_config del blockname
>> >> ganesha_config del log [subblocks]
>> >> ganesha_config del export path
>> >> ganesha_config del export path client clients
>> >
>> >
>> > --
>> > Check out the vibrant tech community on one of the world's most
>> > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> > ___
>> > Nfs-ganesha-devel mailing list
>> > Nfs-ganesha-devel@lists.sourceforge.net
>> > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>>
>>
>>
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> ___
>> Nfs-ganesha-devel mailing list
>> Nfs-ganesha-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>
>

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] file lock requests hang on nfs client

[Naresh Babu]

My bad. Thought I had it covered. But, a restart changed the port (Fixed it
by using NLM_Port config option). Thanks for the help.

On Sun, Feb 26, 2017 at 11:33 PM, Soumya Koduri  wrote:

> Do you have firewalld/iptables enabled? If yes, you may need to unblock
> the ports being used by nlockmgr and statd (ports used shall be listed via
> cmd 'rpcinfo -p').
>
> Thanks,
> Soumya
>
> On 02/27/2017 05:03 AM, Naresh Babu wrote:
>
>> I don't see lockd process running on the system and I don't have any NFS
>> mounts.
>>
>> On Feb 26, 2017 1:45 AM, "Malahal Naineni" > > wrote:
>>
>> nfs-ganesha NFSv3 locking will not work if you use the computer
>> running nfs-ganesha as NFS client as well. The NFS lock requests may
>> go to kernel lockd.
>>
>> Regards, Malahal.
>>
>> On Sun, Feb 26, 2017 at 2:38 PM, Naresh Babu > > wrote:
>> > I ran into a very basic issue with file locking on ganesha nfs
>> mount. When I
>> > tried to issue a fcntl to lock a file, the call hangs on client.
>> NLM request
>> > didn't get to ganesha.nfsd process (verified through gdb). Do I
>> need to
>> > enable something or install/copy something to get file locking
>> working with
>> > ganesha nfs. Please advise. As I am new to using ganesha nfs, this
>> could be
>> > a setup problem.
>> >
>> > Thanks,
>> > Naresh
>> >
>> >
>> 
>> --
>> > Check out the vibrant tech community on one of the world's most
>> > engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> > ___
>> > Nfs-ganesha-devel mailing list
>> > Nfs-ganesha-devel@lists.sourceforge.net
>> 
>> > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>> 
>> >
>>
>>
>>
>> 
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>
>>
>>
>> ___
>> Nfs-ganesha-devel mailing list
>> Nfs-ganesha-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>>
>>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel