Re: [Nfs-ganesha-devel] READDIR readahead

2017-04-03 Thread Matt Benjamin 
inline

- Original Message -
> From: "Frank Filz" 
> To: nfs-ganesha-devel@lists.sourceforge.net
> Sent: Monday, April 3, 2017 6:56:45 PM
> Subject: [Nfs-ganesha-devel] READDIR readahead
> 

Not a bug, really, I had not actually implemented the stop conditions, pending 
further changes.  Need to plumb them back into librgw, too, I'm pretty 
sure--thanks for updating here, though.

Thanks!

Matt

> Along the way, I also realized there was a bug in FSAL_RGW...
> 

> 

-- 
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://www.redhat.com/en/technologies/storage

tel.  734-821-5101
fax.  734-769-8938
cel.  734-216-5309

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] READDIR readahead

2017-04-03 Thread Matt Benjamin 
Thanks, Frank, will explore w/RGW.

Matt

- Original Message -
> From: "Frank Filz" 
> To: nfs-ganesha-devel@lists.sourceforge.net
> Sent: Monday, April 3, 2017 6:56:45 PM
> Subject: [Nfs-ganesha-devel] READDIR readahead
> 
> Matt had asked for an ability for readdir chunking to be able to absorb more
> than one chunks worth of entries if it made sense for the FSAL to read a
> larger number of entries in one go.
> 
> It turns out that it was very simple to support this.
> 
> And for gravy, there's an example of FSAL_VFS which increases the getdents
> buffer size and supports readahead.
> 
> Along the way, I also realized there was a bug in FSAL_RGW...
> 
> It may be worth asking if we should make the FSAL_VFS readdir buffer
> resizable and allow enabling readahead.
> 
> You can find it in my readahead branch:
> 
> https://github.com/ffilz/nfs-ganesha/commits/readahead
> 
> Or review on gerrithub:
> 
> https://review.gerrithub.io/#/c/32/
> https://review.gerrithub.io/#/c/355563/
> https://review.gerrithub.io/#/c/355564/
> https://review.gerrithub.io/#/c/355565/
> 
> You can also pull the whole branch from gerrithub with this command (which
> will create and checkout a branch called readahead in your repo):
> 
> git fetch https://ff...@review.gerrithub.io/a/ffilz/nfs-ganesha
> refs/changes/65/355565/1 && git checkout FETCH_HEAD -b readahead
> 
> This last is taken from the download menu in the final patch, you chose the
> checkout option, cut and paste that. I always add the -b {branchname} to the
> end of it to actually checkout a branch. This can be used to pull down
> anyone's patch set even if they don't have a github repo (or you don't know
> what it is, or they didn't push to it). I use this all the time for doing
> weekly merges if someone has a patchset with more than 2 or 3 patches.
> 
> Thanks
> 
> Frank
> 
> 
> ---
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
> 
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
> 

-- 
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://www.redhat.com/en/technologies/storage

tel.  734-821-5101
fax.  734-769-8938
cel.  734-216-5309

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] READDIR readahead

2017-04-03 Thread Frank Filz 
Matt had asked for an ability for readdir chunking to be able to absorb more
than one chunks worth of entries if it made sense for the FSAL to read a
larger number of entries in one go.

It turns out that it was very simple to support this.

And for gravy, there's an example of FSAL_VFS which increases the getdents
buffer size and supports readahead.

Along the way, I also realized there was a bug in FSAL_RGW...

It may be worth asking if we should make the FSAL_VFS readdir buffer
resizable and allow enabling readahead.

You can find it in my readahead branch:

https://github.com/ffilz/nfs-ganesha/commits/readahead

Or review on gerrithub:

https://review.gerrithub.io/#/c/32/
https://review.gerrithub.io/#/c/355563/
https://review.gerrithub.io/#/c/355564/
https://review.gerrithub.io/#/c/355565/

You can also pull the whole branch from gerrithub with this command (which
will create and checkout a branch called readahead in your repo):

git fetch https://ff...@review.gerrithub.io/a/ffilz/nfs-ganesha
refs/changes/65/355565/1 && git checkout FETCH_HEAD -b readahead

This last is taken from the download menu in the final patch, you chose the
checkout option, cut and paste that. I always add the -b {branchname} to the
end of it to actually checkout a branch. This can be used to pull down
anyone's patch set even if they don't have a github repo (or you don't know
what it is, or they didn't push to it). I use this all the time for doing
weekly merges if someone has a patchset with more than 2 or 3 patches.

Thanks

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FYI FSAL_VFS: Do readdir readahead

2017-04-03 Thread GerritHub 
>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/355565


Change subject: FYI FSAL_VFS: Do readdir readahead
..

FYI FSAL_VFS: Do readdir readahead

Enlarge the getdents buffer to allow reading more entries, and then use them
to do readahead.

Change-Id: Ia168f5a689d55962096e0761bd11206c0dbbbd4c
Signed-off-by: Frank S. Filz 
---
M src/FSAL/FSAL_VFS/handle.c
1 file changed, 8 insertions(+), 4 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/65/355565/1
-- 
To view, visit https://review.gerrithub.io/355565
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia168f5a689d55962096e0761bd11206c0dbbbd4c
Gerrit-Change-Number: 355565
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MDCACHE: Enable readdir readahead

2017-04-03 Thread GerritHub 
>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/355564


Change subject: MDCACHE: Enable readdir readahead
..

MDCACHE: Enable readdir readahead

Change-Id: I8618fa87e7a2f50359455cb79e2c381d8c2eaa40
Signed-off-by: Frank S. Filz 
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
1 file changed, 80 insertions(+), 19 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/64/355564/1
-- 
To view, visit https://review.gerrithub.io/355564
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8618fa87e7a2f50359455cb79e2c381d8c2eaa40
Gerrit-Change-Number: 355564
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Allow for readdir readahead

2017-04-03 Thread GerritHub 
>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/355563


Change subject: Allow for readdir readahead
..

Allow for readdir readahead

Currently no one who calls FSAL's readdir will allow readahead, and no
FSAL implements it, but put the plumbing in place.

Change-Id: I058deaaef5d1c233072f90e2ae54244663d50fd4
Signed-off-by: Frank S. Filz 
---
M src/FSAL/FSAL_CEPH/handle.c
M src/FSAL/FSAL_GLUSTER/handle.c
M src/FSAL/FSAL_GPFS/handle.c
M src/FSAL/FSAL_PROXY/handle.c
M src/FSAL/FSAL_PSEUDO/handle.c
M src/FSAL/FSAL_RGW/handle.c
M src/FSAL/FSAL_VFS/handle.c
M src/FSAL/FSAL_ZFS/handle.c
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_handle.c
M src/FSAL/commonlib.c
M src/FSAL/fsal_helper.c
M src/include/fsal_api.h
12 files changed, 35 insertions(+), 9 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/63/355563/1
-- 
To view, visit https://review.gerrithub.io/355563
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I058deaaef5d1c233072f90e2ae54244663d50fd4
Gerrit-Change-Number: 355563
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Log correct supported mask. CID #161249

2017-04-03 Thread GerritHub 
>From Daniel Gryniewicz :

Daniel Gryniewicz has uploaded this change for review. ( 
https://review.gerrithub.io/355497


Change subject: Log correct supported mask. CID #161249
..

Log correct supported mask. CID #161249

Change-Id: If47e73cc5cbc4702a43e2d2b1dd46308a1cf87eb
Signed-off-by: Daniel Gryniewicz 
---
M src/FSAL/commonlib.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/97/355497/1
-- 
To view, visit https://review.gerrithub.io/355497
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: If47e73cc5cbc4702a43e2d2b1dd46308a1cf87eb
Gerrit-Change-Number: 355497
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: PROXY - handle error from pxy_do_close() CID #161035

2017-04-03 Thread GerritHub 
>From Daniel Gryniewicz :

Daniel Gryniewicz has uploaded this change for review. ( 
https://review.gerrithub.io/355499


Change subject: PROXY - handle error from pxy_do_close() CID #161035
..

PROXY - handle error from pxy_do_close() CID #161035

Change-Id: Iff7990e2b42667883256521c1b2154a815833c91
Signed-off-by: Daniel Gryniewicz 
---
M src/FSAL/FSAL_PROXY/handle.c
1 file changed, 2 insertions(+), 0 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/99/355499/1
-- 
To view, visit https://review.gerrithub.io/355499
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iff7990e2b42667883256521c1b2154a815833c91
Gerrit-Change-Number: 355499
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MDCACHE - don't use for() and while(). CID #161250

2017-04-03 Thread GerritHub 
>From Daniel Gryniewicz :

Daniel Gryniewicz has uploaded this change for review. ( 
https://review.gerrithub.io/355496


Change subject: MDCACHE - don't use for() and while(). CID #161250
..

MDCACHE - don't use for() and while(). CID #161250

Change-Id: I0201da264999fb1d2fd730a5acb59edd1aa6e939
Signed-off-by: Daniel Gryniewicz 
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_helpers.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/96/355496/1
-- 
To view, visit https://review.gerrithub.io/355496
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0201da264999fb1d2fd730a5acb59edd1aa6e939
Gerrit-Change-Number: 355496
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: MDCAHCE - Fix GUARDED_CREATE exists path

2017-04-03 Thread GerritHub 
>From Daniel Gryniewicz :

Daniel Gryniewicz has uploaded this change for review. ( 
https://review.gerrithub.io/355473


Change subject: MDCAHCE - Fix GUARDED_CREATE exists path
..

MDCAHCE - Fix GUARDED_CREATE exists path

If an entry exists on GUARDED_CREATE, then put the found entry, not the
(NULL) returned entry.  Bug #1437248

Change-Id: I2e2a42b045532c5fc925a7997ef536a91ecd21f0
Signed-off-by: Daniel Gryniewicz 
---
M src/FSAL/Stackable_FSALs/FSAL_MDCACHE/mdcache_file.c
1 file changed, 4 insertions(+), 5 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/73/355473/1
-- 
To view, visit https://review.gerrithub.io/355473
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2e2a42b045532c5fc925a7997ef536a91ecd21f0
Gerrit-Change-Number: 355473
Gerrit-PatchSet: 1
Gerrit-Owner: Daniel Gryniewicz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel