[Nfs-ganesha-devel] Announce Push of V2.6-dev.17

2017-11-12 Thread Frank Filz 
Branch next

Tag:V2.6-dev.17

Sorry for the delay on this, forgot to send before I came up from office on
Friday...

NOTE: This merge includes an ntirpc pullup, please update your submodule.

Release Highlights

* ntirpc pullup

* SAL: Various cleanup of state recovery bits

* SAL: allow grace period to be lifted early if all clients have sent
RECLAIM_COMPLETE

* CEPH: do an inode lookup vs. MDS when the Inode is not in cache

* 9P lock: aquire state_lock properly

* Set thread names in FSAL_PROXY and ntirpc initiated threads

* Allow configuration of NFSv4 minor versions.

* Lower message log level for a non-existent user

* Fix cmake failure when /etc/os-release is not present

* GLUSTER: glusterfs_create_export() SEGV for typo ganesha.conf

* handle hosts via libcidr to unify IPv4/IPv4 host/network clients

* Add some detail to config documentation

* NFSv4.1+ return special invalid stateid on close per Section 8.2.3

* Give temp fd in fsal_reopen_obj when verification fails for a fd's
openflags

* GPFS: Set a FDs 'openflags=FSAL_O_CLOSED' when fd=-1 is set

* Various RPC callback and timeout fixes

Signed-off-by: Frank S. Filz 

Contents:

d8e89f7 Frank S. Filz V2.6-dev.17
542ea90 William Allen Simpson Pull up NTIRPC through #91
645f410 Madhu Thorat [GPFS] Set a FDs 'openflags=FSAL_O_CLOSED' when fd=-1
is set
482672a Madhu Thorat Give temp fd in fsal_reopen_obj when verification fails
for a fd's openflags
05ade07 Frank S. Filz NFSv4.1+ return special invalid stateid on close per
Section 8.2.3
9bd00bd Frank S. Filz Add some detail to config documentation
5ca449d Jan-Martin Rämer handle hosts via libcidr to unify IPv4/IPv4
host/network clients
0819dc4 Kaleb S. KEITHLEY fsal_gluster: glusterfs_create_export() SEGV for
typo ganesha.conf
a5da1a0 Malahal Naineni Fix cmake failure when /etc/os-release is not
present
ed4bace Malahal Naineni Lower message log level for a non-existent user
abcd932 Malahal Naineni Allow configuration of NFSv4 minor versions.
1a9f1e0 Dominique Martinet FSAL_PROXY: set thread names for logging
3b857f1 Dominique Martinet 9P lock: aquire state_lock properly
302ab52 Jeff Layton SAL: allow grace period to be lifted early if all
clients have sent RECLAIM_COMPLETE
476c206 Jeff Layton FSAL_CEPH: do an inode lookup vs. MDS when the Inode is
not in cache
08a953a Jeff Layton recovery_fs: ensure we free the cid_recov_tag when
removing the entry
0f34e77 Jeff Layton recovery_fs: remove unnecessary conditionals from
fs_read_recov_clids_impl
875495c Jeff Layton NFSv4: remove stable-storage client record on
DESTROY_CLIENTID
35ba7dd Jeff Layton NFSv4: make cid_allow_reclaim a bool
e016e58 Jeff Layton SAL: fix locking around clnt->cid_recov_tag
3e228c8 Jeff Layton SAL: remove check_clid recovery operation
e132294 Jeff Layton SAL: clean up nfs4_check_deleg_reclaim a bit


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: config_parsing: reset err_type->dispose at err_out in proc_b...

2017-11-12 Thread GerritHub 
>From Kinglong Mee :

Kinglong Mee has uploaded this change for review. ( 
https://review.gerrithub.io/386776


Change subject: config_parsing: reset err_type->dispose at err_out in proc_block
..

config_parsing: reset err_type->dispose at err_out in proc_block

If don't reset err_type->dispose to false when committing fail,
it will pollute the next entry.

For example, if the committing of FSAL failed, a double free may happens.
EXPORT {
 FSAL {
  Name = GLUSTER;
  ... ...
 }
 CLIENT {
  ... ...
 }
}

0  0x7f056cebb50a in FreeClientList ()
1  0x7f056cebe035 in free_export_resources ()
2  0x7f056cecdc53 in free_export ()
3  0x7f056cebb5f4 in export_init ()
4  0x7f056cef6f0d in proc_block ()
5  0x7f056cef7ab0 in load_config_from_parse ()
6  0x7f056cebd9db in ReadExports ()
7  0x7f056ce0b5e1 in main ()

Change-Id: Ief54601a3d1b7559b7f132b720095b811f2eddf2
Signed-off-by: Kinglong Mee 
---
M src/config_parsing/config_parsing.c
1 file changed, 1 insertion(+), 0 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/76/386776/1
-- 
To view, visit https://review.gerrithub.io/386776
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ief54601a3d1b7559b7f132b720095b811f2eddf2
Gerrit-Change-Number: 386776
Gerrit-PatchSet: 1
Gerrit-Owner: Kinglong Mee 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: export: fix use after free in free_export

2017-11-12 Thread GerritHub 
>From Kinglong Mee :

Kinglong Mee has uploaded this change for review. ( 
https://review.gerrithub.io/386777


Change subject: export: fix use after free in free_export
..

export: fix use after free in free_export

Change-Id: I1ac37aaf97824939daf9b9df7356413948bcc2c9
Signed-off-by: Kinglong Mee 
---
M src/support/export_mgr.c
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/77/386777/1
-- 
To view, visit https://review.gerrithub.io/386777
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1ac37aaf97824939daf9b9df7356413948bcc2c9
Gerrit-Change-Number: 386777
Gerrit-PatchSet: 1
Gerrit-Owner: Kinglong Mee 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Subfsal export

2017-11-12 Thread sriram patil 
Thanks for the help Frank and Daniel. I figured it is much easy to enable
"mount_path_pseudo" and use pseudo path instead of using symlinks. No code
changes required. The sole purpose was to hide the original path because it
is long or cryptic.

Thanks,
Sriram

On Fri, Nov 10, 2017 at 6:58 PM, Daniel Gryniewicz  wrote:

> You can do this with a stackable FSAL, since it's on top, not underneath,
> so it can override anything you want.  You can even just put the symlink
> part in your FSAL, and defer everything else so VFS, if you want.
>
> Daniel
>
> On 11/08/2017 03:04 PM, Frank Filz wrote:
>
>> Yea, in the case of wanting to allow symlink exports, you would need to
>> replace the method. I’d be interested in why you want to allow them. That
>> is something that actually could be handled by a config or compile option.
>>
>> Frank
>>
>> *From:*sriram patil [mailto:spsrirampa...@gmail.com]
>> *Sent:* Wednesday, November 8, 2017 10:20 AM
>> *To:* Frank Filz 
>> *Cc:* d...@redhat.com; nfs-ganesha-devel@lists.sourceforge.net
>> *Subject:* Re: [Nfs-ganesha-devel] Subfsal export
>>
>> Hi,
>>
>> In case of stackable FSALs, what if I want the underlying FSAL behave
>> differently. For example, VFS does not allow symlink exports, lookup_path
>> fails if we try to export symlink pointing to a directory. There can be
>> such cases where I want to defer (very small changes) from the underlying
>> "sub fsal". For bypassing some part of the underlying fsal function, is
>> rewriting the function the only way?
>>
>> Thanks,
>>
>> Sriram
>>
>> On Wed, Nov 8, 2017 at 11:22 PM, sriram patil > > wrote:
>>
>> Hmm stackable FSAL sounds like a good option. Let me investigate on
>> that. I was mainly going with sub fsal because of xfs.
>>
>> I agree with both of you about pushing FSAL changes to upstream. Let
>> me see if I can make that happen.
>>
>> Thanks,
>>
>> Sriram
>>
>> On 08-Nov-2017 11:03 PM, "Frank Filz" > > wrote:
>>
>>  > You might want to consider a stackable FSAL instead.
>>  FSAL_NULL is a good
>>  > example to start from.  It's much more flexible than
>> sub_fsals for VFS.
>> If I
>>  > was implementing PanFS now, I'd use a stackable FSAL instead.
>>
>> Yea, this is a good point. Probably even the XFS/VFS split
>> should be done
>> with stackable FSAL.
>>
>>  > Ganesha is LGPL specifically to allow non-FOSS FSALs.
>>  However, if the
>> FSAL
>>  > itself does not require proprietary code, there are many
>> advantages to
>> open
>>  > sourcing it and getting it upstream.  Not the least is that
>> changes to
>> APIs and
>>  > the build system will be fixed by the community, so there
>> will be fewer
>> cases
>>  > of sudden breakage for you to fix.
>>
>> On top of direct API impacts, it also helps to understand how
>> other FSALs
>> are using Ganesha so that not only do we not break the API, but
>> don't break
>> other assumptions that were made. It also is a better platform for
>> requesting FSAL specific API accommodation (for a recent
>> example, see
>> compute_readdir_cookie and whence_is_name support that was added
>> for
>> FSAL_RGW, though added in a generic way so other FSALs might use
>> it).
>>
>> Frank
>>
>>  > Daniel
>>  >
>>  > On 11/08/2017 10:51 AM, sriram patil wrote:
>>  > > Yes, I am making a new sub fsal. May not push it to
>> upstream because
>>  > > it will not be useful without the whole framework/product.
>> As part of
>>  > > that, I wanted to allocate an export object which has some
>> extra
>>  > > fields, other than the ones in vfs_fsal_export.
>>  > >
>>  > > Also, I hope creating a sub fsal and not making the
>> implementation
>>  > > opensource does not violate any license terms.
>>  > >
>>  > > Thanks,
>>  > > Sriram
>>  > >
>>  > > On 08-Nov-2017 8:19 PM, "Daniel Gryniewicz"
>> 
>>  > > >> wrote:
>>  > >
>>  > > On 11/08/2017 02:41 AM, sriram patil wrote:
>>  > >
>>  > > Hi,
>>  > >
>>  > > In the subfsal framework, I see that subfsals can
>> have their own
>>  > > fsal_obj_handles by implementing
>> vfs_sub_alloc_handle and then
>>  > > use subfsal specific variables using container_of.
>>  > >
>>  > > It does not provide same functionality for
>>