[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Pullup NTIRPC through #98

2017-12-14 Thread GerritHub 
>From :

william.allen.simp...@gmail.com has uploaded this change for review. ( 
https://review.gerrithub.io/391872


Change subject: Pullup NTIRPC through #98
..

Pullup NTIRPC through #98

 * xdr_reply_encode MSG_DENIED header
 * Raise thread stack size to 1M
 * Remove cl_geterr
 * rpc_raw dummy
 * Remove RPC_SOC definitions

Change-Id: I789b76f8c5c5a158b846281d1c4491d3ccde538c
Signed-off-by: William Allen Simpson 
---
M src/MainNFSD/nfs_rpc_callback.c
M src/Protocols/NLM/nlm_async.c
M src/Protocols/NLM/nsm.c
M src/Protocols/NLM/sm_notify.c
M src/RPCAL/rpc_tools.c
M src/libntirpc
6 files changed, 51 insertions(+), 41 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/72/391872/1
-- 
To view, visit https://review.gerrithub.io/391872
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I789b76f8c5c5a158b846281d1c4491d3ccde538c
Gerrit-Change-Number: 391872
Gerrit-PatchSet: 1
Gerrit-Owner: william.allen.simp...@gmail.com
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Reorganize nfs4_Compound

2017-12-14 Thread GerritHub 
>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/391871


Change subject: Reorganize nfs4_Compound
..

Reorganize nfs4_Compound

Use a single log function call to manage all the bad_op_state
conditions.

Fix up some white space issues.

Move some other opcode stuff to the top of the loop so it can be used
more commonly.

Change-Id: I4cfe6db648cce6b21806d6b4e6915a8da8fc9054
Signed-off-by: Frank S. Filz 
---
M src/Protocols/NFS/nfs4_Compound.c
1 file changed, 98 insertions(+), 87 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/71/391871/1
-- 
To view, visit https://review.gerrithub.io/391871
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4cfe6db648cce6b21806d6b4e6915a8da8fc9054
Gerrit-Change-Number: 391871
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Announce Push of V2.6-dev.21

2017-12-14 Thread Frank Filz 
 
> On 12/12/17 4:39 PM, Frank Filz wrote:
> > Branch next
> >
> > Tag:V2.6-dev.21
> >
> > Release Highlights
> >
> > * new version of checkpatch
> >
> > * checkpatch fixes for existing code
> >
> I'd been hoping that a mid-week release meant the crash during shutdown
> was fixed, but apparently not:
> 
> 
> Thread 270 "ganesha.nfsd" received signal SIGSEGV, Segmentation fault.
> [Switching to Thread 0x7fff6808a700 (LWP 18755)]
> 0x7fffef8ca739 in release (exp_hdl=0x6130cec0)
>  at /home/bill/rdma/nfs-ganesha/src/FSAL/FSAL_VFS/export.c:79
> 79LogDebug(COMPONENT_FSAL, "Releasing VFS export for
> %s",

Sorry, midweek merge was JUST to push out a huge set of checkpatch stuff... So 
everything else could be rebased on top of THAT (and any manual merges taken 
care of). Only after I pushed that did I have a chance to look at the crash. 
Note that the crash is in a LogDebug so important but not quite so important as 
to require a mid-week merge. It also happened to expose some refcount issues 
which I ALSO fixed.

I did ask you to try my fix branch to see if all was well for you now... Or at 
least I thought I did. If you didn't see it, please rebase your code on top of:

https://github.com/ffilz/nfs-ganesha/commits/fix21

and see if your issues go away.

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: Consolidate COMPOUND structure checks and fix DESTROY_SESSIO...

2017-12-14 Thread GerritHub 
>From Frank Filz :

Frank Filz has uploaded this change for review. ( 
https://review.gerrithub.io/391862


Change subject: Consolidate COMPOUND structure checks and fix DESTROY_SESSION 
check
..

Consolidate COMPOUND structure checks and fix DESTROY_SESSION check

Correct the DESTROY_SESSION check if it's in a COMPOUND with
SEQUENCE, if it's for the same session, it must be the final op.

Apparently you can destroy as many sessions as you want in a single
COMPOUND so long as if you are destroying THAT session you do it
last... Which all makes sense and is cool.

Change-Id: I4c9320a5f9a79d79e8369f287824873bf8bf6a31
Signed-off-by: Frank S. Filz 
---
M src/Protocols/NFS/nfs4_Compound.c
M src/Protocols/NFS/nfs4_op_sequence.c
2 files changed, 44 insertions(+), 24 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/62/391862/1
-- 
To view, visit https://review.gerrithub.io/391862
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4c9320a5f9a79d79e8369f287824873bf8bf6a31
Gerrit-Change-Number: 391862
Gerrit-PatchSet: 1
Gerrit-Owner: Frank Filz 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] XID missing in error path for RPC AUTH failure.

2017-12-14 Thread William Allen Simpson 

This is May 2015 code, based upon 2012 code.  Obviously, we haven't been
testing error responses ;)

Not quite.  That would need to be duplicated for each of the error
conditions.  Instead, it should be a bit higher in the function.

Still, I'll keep it duplicated from the ACCEPTED code path, for
trivial efficiency.

On 12/13/17 1:22 AM, Matt Benjamin wrote:

That sounds right, I'm uncertain whether this has regressed in the
text, or maybe in the likelihood of inlining in the new dispatch
model.  Bill?

Matt

On Wed, Dec 13, 2017 at 9:38 AM, Pradeep  wrote:

Hello,

When using krb5 exports, I noticed that TIRPC does not send XID in response
- see xdr_reply_encode() for MSG_DENIED case. Looks like Linux clients can't
decode the message and go in to an infinite loop retrying the same NFS
operation. I tried adding XID back (like it is done for normal case) and it
seems to have fixed the problem. Is this the right thing to do?

diff --git a/src/rpc_dplx_msg.c b/src/rpc_dplx_msg.c
index 01e5a5c..a585e8a 100644
--- a/src/rpc_dplx_msg.c
+++ b/src/rpc_dplx_msg.c
@@ -194,9 +194,12 @@ xdr_reply_encode(XDR *xdrs, struct rpc_msg *dmsg)
 __warnx(TIRPC_DEBUG_FLAG_RPC_MSG,
 "%s:%u DENIED AUTH",
 __func__, __LINE__);
-   buf = XDR_INLINE(xdrs, 2 * BYTES_PER_XDR_UNIT);
+   buf = XDR_INLINE(xdrs, 5 * BYTES_PER_XDR_UNIT);

 if (buf != NULL) {
+   IXDR_PUT_INT32(buf, dmsg->rm_xid);
+   IXDR_PUT_ENUM(buf, dmsg->rm_direction);
+   IXDR_PUT_ENUM(buf, dmsg->rm_reply.rp_stat);
 IXDR_PUT_ENUM(buf, rr->rj_stat);
 IXDR_PUT_ENUM(buf, rr->rj_why);
 } else if (!xdr_putenum(xdrs, rr->rj_stat)) {

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel








--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Announce Push of V2.6-dev.21

2017-12-14 Thread William Allen Simpson 

On 12/12/17 4:39 PM, Frank Filz wrote:

Branch next

Tag:V2.6-dev.21

Release Highlights

* new version of checkpatch

* checkpatch fixes for existing code


I'd been hoping that a mid-week release meant the crash during
shutdown was fixed, but apparently not:


Thread 270 "ganesha.nfsd" received signal SIGSEGV, Segmentation fault.
[Switching to Thread 0x7fff6808a700 (LWP 18755)]
0x7fffef8ca739 in release (exp_hdl=0x6130cec0)
at /home/bill/rdma/nfs-ganesha/src/FSAL/FSAL_VFS/export.c:79
79  LogDebug(COMPONENT_FSAL, "Releasing VFS export for %s",

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

[Nfs-ganesha-devel] Change in ffilz/nfs-ganesha[next]: FSAL_CEPH: no need to set credentials

2017-12-14 Thread GerritHub 
>From Jeff Layton :

Jeff Layton has uploaded this change for review. ( 
https://review.gerrithub.io/391830


Change subject: FSAL_CEPH: no need to set credentials
..

FSAL_CEPH: no need to set credentials

libcephfs doesn't require us to run as root or set the task's creds when
doing various operations. Removing this allows us to run ganesha as an
unprivileged user.

Change-Id: I367b7e9e2e51f8980d1296dfee50b6c847cd0ad2
Signed-off-by: Jeff Layton 
---
M src/FSAL/FSAL_CEPH/handle.c
1 file changed, 0 insertions(+), 3 deletions(-)



  git pull ssh://review.gerrithub.io:29418/ffilz/nfs-ganesha 
refs/changes/30/391830/1
-- 
To view, visit https://review.gerrithub.io/391830
To unsubscribe, visit https://review.gerrithub.io/settings

Gerrit-Project: ffilz/nfs-ganesha
Gerrit-Branch: next
Gerrit-MessageType: newchange
Gerrit-Change-Id: I367b7e9e2e51f8980d1296dfee50b6c847cd0ad2
Gerrit-Change-Number: 391830
Gerrit-PatchSet: 1
Gerrit-Owner: Jeff Layton 
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] NFS-Ganesha v2.5.2 Ceph and RGW Peformance

2017-12-14 Thread Matt Benjamin 
Hi Supriti,

On Thu, Dec 14, 2017 at 4:26 PM, Supriti Singh  wrote:
> Hello all,
>
> At SUSE, we did a performance benchmarking for nfs-ganesha v2.5.2 for FSAL
> Ceph and RGW. For FSAL CEPH, we did a comparison for kernel cephfs client
> and nfs-ganesha. Please find report attached.
>
> Key points
> 1. Earlier, I shared results on ceph-devel mailing list as well. I have
> added comparison between those results and current results on page 9. In
> earlier test, I did not tune the parameters "Dispatch_Max_Reqs" and cephfs
> default pool size. That could be one reason, why ganesha performs better in
> the current test. Thanks to Malahal for pointing out the parameters.
>
> 2. For multiple clients and multiple jobs, single nfs-ganesha server
> performance degrades significantly. As we go ahead, active-active
> nfs-ganesha server or pnfs may improve performance. Any thoughts on this? I
> did stumble upon Jeff's blog:
> https://jtlayton.wordpress.com/2017/11/07/active-active-nfs-over-cephfs/ Is
> this something already in loop for 2.7?

I have reason to believe that the request queuing and throttling
behavior in versions before 2.6 is responsible for a lot of the
degradation, even with good tuning.  I'm very interested to see your
results with 2.6.  Looking forwards, yes, I think pNFS hsa the
potential to help out a lot.  Also, I believe there are available
speedups in libcephfs, but I haven't worked with it in a long time.

>
> 3. For NFS-RGW, as it supports only sync write, I was not able to use fio
> for testing. Is there any other tool that someone else has used?

The semantics of FSAL_RGW were designed as those of upload, not full
NFS semantics, so the usual benchmarks dont really work.  Im not sure
what to suggest, beyond less general benchmarking, like copying up
some large files.  I'm working on removing the restricted upload
semantics in Mimic.

>
> 4. For 2.6, I am aware that "Dispatch_Max_Reqs" goes away. But I have not
> looked into code, so please excuse if question is not to the point. Are
> those changes expected to improve performance?

Yes.  Fairness between clients should be improved.  You may want to
experiment with different (larger) values of nb_worker in 2.6.  post
2.6 we're moving to async dispatch.

>
> 5. Also, I think it would be nice to have event messages for tunable
> parameters. So that if nfs-ganesha is slowing down, because some parameters
> have reached threshold values, users can understand for the log messages. I
> am only aware of health messages, but it does not explain what could be
> wrong.
>
> Please let me know your feedback, if I missed out on some optimization or
> analysis.
>
> Thanks,
> Supriti
>
> --
> Supriti Singh
> SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton,
> HRB 21284 (AG Nürnberg)
>
>

Matt

-- 

Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://www.redhat.com/en/technologies/storage

tel.  734-821-5101
fax.  734-769-8938
cel.  734-216-5309

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel