Re: [Nfs-ganesha-devel] NTIRPC ENOMEM

2017-12-20 Thread Matt Benjamin
The established plan is to finish async and evaluate.

Matt

On Dec 20, 2017 5:02 AM, "William Allen Simpson" <
william.allen.simp...@gmail.com> wrote:

> DanG has raised an interesting issue about recovery from low memory.
> In Ganesha, we've been assiduously changing NULL checks to assert or
> segfault on alloc failures.  Just had a few more patches by Kaleb.
>
> Since 2013 or 2014, we've been doing the same to NTIRPC.  There are
> currently 105 mem_.*alloc locations, and almost all of them
> deliberately segfault.
>
> DanG argues that we should report the ENOMEM in an error return, or
> in the alternative return NULL in those cases, and let the caller
> decide what to do, to make the library more general.
>
> The current TI-RPC does return NULL in many cases.  Rarely reports
> ENOMEM.  And often segfaults.
>
> This would be a major reworking.  Should we do this?  If so, what is
> the target date?
>
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, Slashdot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


[Nfs-ganesha-devel] NTIRPC ENOMEM

2017-12-20 Thread William Allen Simpson

DanG has raised an interesting issue about recovery from low memory.
In Ganesha, we've been assiduously changing NULL checks to assert or
segfault on alloc failures.  Just had a few more patches by Kaleb.

Since 2013 or 2014, we've been doing the same to NTIRPC.  There are
currently 105 mem_.*alloc locations, and almost all of them
deliberately segfault.

DanG argues that we should report the ENOMEM in an error return, or
in the alternative return NULL in those cases, and let the caller
decide what to do, to make the library more general.

The current TI-RPC does return NULL in many cases.  Rarely reports
ENOMEM.  And often segfaults.

This would be a major reworking.  Should we do this?  If so, what is
the target date?

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel