Re: [Nfs-ganesha-devel] Dirent invalidation on up call

[Frank Filz]

> On 02/16/2017 12:21 PM, Frank Filz wrote:
> >> mdcache_readdir() checks !mdc_dircache_trusted(), and calls
> >> mdcache_dirent_populate(), which calls mdcache_dirent_invalidate_all().
> >
> > Ah, ok. Good.
> >
> > Path will be slightly re-worked with chunking, but will do that.
> >
> > I wonder if we should just always mark contents un-trusted and then in
> > readdir, lookup, and create, dump the entries?
> >
> > Frank
> 
> I don't have a strong opinion about that...  It's this way because that's
how
> cache_inode did it, not because I chose to do it that way.
> 
> Upcalls have the desired property, I think, of not introducing extra
latency
> into a thread owned by another system.  I guess it might be good to remove
> that latency from unlink/rename/etc.?  But on the other hand, it frees
> memory now that may never be freed otherwise, which can be beneficial...

Hmm, that might be a good point. With chunking at least we won't have the
memory sitting forever since LRU will dispose of chunks that haven't been
used in a while, combined with limit on number of chunks in play.

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

[Daniel Gryniewicz]

On 02/16/2017 12:21 PM, Frank Filz wrote:
>> mdcache_readdir() checks !mdc_dircache_trusted(), and calls
>> mdcache_dirent_populate(), which calls mdcache_dirent_invalidate_all().
>
> Ah, ok. Good.
>
> Path will be slightly re-worked with chunking, but will do that.
>
> I wonder if we should just always mark contents un-trusted and then in
> readdir, lookup, and create, dump the entries?
>
> Frank

I don't have a strong opinion about that...  It's this way because 
that's how cache_inode did it, not because I chose to do it that way.

Upcalls have the desired property, I think, of not introducing extra 
latency into a thread owned by another system.  I guess it might be good 
to remove that latency from unlink/rename/etc.?  But on the other hand, 
it frees memory now that may never be freed otherwise, which can be 
beneficial...

Daniel


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

[Frank Filz]

> mdcache_readdir() checks !mdc_dircache_trusted(), and calls
> mdcache_dirent_populate(), which calls mdcache_dirent_invalidate_all().

Ah, ok. Good.

Path will be slightly re-worked with chunking, but will do that.

I wonder if we should just always mark contents un-trusted and then in
readdir, lookup, and create, dump the entries?

Frank


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

[Daniel Gryniewicz]

mdcache_readdir() checks !mdc_dircache_trusted(), and calls 
mdcache_dirent_populate(), which calls mdcache_dirent_invalidate_all().

Daniel

On 02/16/2017 11:23 AM, Frank Filz wrote:
> Where does that happen? It wasn't clear to me.
>
> Frank
>
> Sent from my iPhone
>
>> On Feb 16, 2017, at 6:31 AM, Daniel Gryniewicz  wrote:
>>
>> The dirents will get cleared out the next time a readdir happens.
>>
>> Daniel
>>
>> On 02/16/2017 12:20 AM, Frank Filz wrote:
 er, oh noes...
>>>
>>> The problem I think I see is that the directory never gets cleaned out in 
>>> this case...
>>>
>>> I get that we may not want to dispose of the dirents on the upcall thread, 
>>> but we should dispose of them the next time we do a lookup or readdir...
>>>
>>> Everything else that invalidates a directory cleans out the dirents inline.
>>>
>>> Frank
>>>
> I'm looking at when dirents are invalidated, and it looks like
> MDCACHE_DIR_POPULATED is cleared on up call, but nothing actually
> cleans out the dirents...
>
> Is this an omission?
>
> Frank
>
>
> ---
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
>
>
> --
>  Check out the vibrant tech community on one of the world's
> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>

 --
 Matt Benjamin
 Red Hat, Inc.
 315 West Huron Street, Suite 140A
 Ann Arbor, Michigan 48103

 http://www.redhat.com/en/technologies/storage

 tel.  734-821-5101
 fax.  734-769-8938
 cel.  734-216-5309
>>>
>>>
>>> ---
>>> This email has been checked for viruses by Avast antivirus software.
>>> https://www.avast.com/antivirus
>>>
>>>
>>> --
>>> Check out the vibrant tech community on one of the world's most
>>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>> ___
>>> Nfs-ganesha-devel mailing list
>>> Nfs-ganesha-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>>>
>>
>>
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> ___
>> Nfs-ganesha-devel mailing list
>> Nfs-ganesha-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

[Frank Filz]

Where does that happen? It wasn't clear to me. 

Frank

Sent from my iPhone

> On Feb 16, 2017, at 6:31 AM, Daniel Gryniewicz  wrote:
> 
> The dirents will get cleared out the next time a readdir happens.
> 
> Daniel
> 
> On 02/16/2017 12:20 AM, Frank Filz wrote:
>>> er, oh noes...
>> 
>> The problem I think I see is that the directory never gets cleaned out in 
>> this case...
>> 
>> I get that we may not want to dispose of the dirents on the upcall thread, 
>> but we should dispose of them the next time we do a lookup or readdir...
>> 
>> Everything else that invalidates a directory cleans out the dirents inline.
>> 
>> Frank
>> 
 I'm looking at when dirents are invalidated, and it looks like
 MDCACHE_DIR_POPULATED is cleared on up call, but nothing actually
 cleans out the dirents...
 
 Is this an omission?
 
 Frank
 
 
 ---
 This email has been checked for viruses by Avast antivirus software.
 https://www.avast.com/antivirus
 
 
 --
  Check out the vibrant tech community on one of the world's
 most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
 ___
 Nfs-ganesha-devel mailing list
 Nfs-ganesha-devel@lists.sourceforge.net
 https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
 
>>> 
>>> --
>>> Matt Benjamin
>>> Red Hat, Inc.
>>> 315 West Huron Street, Suite 140A
>>> Ann Arbor, Michigan 48103
>>> 
>>> http://www.redhat.com/en/technologies/storage
>>> 
>>> tel.  734-821-5101
>>> fax.  734-769-8938
>>> cel.  734-216-5309
>> 
>> 
>> ---
>> This email has been checked for viruses by Avast antivirus software.
>> https://www.avast.com/antivirus
>> 
>> 
>> --
>> Check out the vibrant tech community on one of the world's most
>> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>> ___
>> Nfs-ganesha-devel mailing list
>> Nfs-ganesha-devel@lists.sourceforge.net
>> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>> 
> 
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

[Daniel Gryniewicz]

The dirents will get cleared out the next time a readdir happens.

Daniel

On 02/16/2017 12:20 AM, Frank Filz wrote:
>> er, oh noes...
>
> The problem I think I see is that the directory never gets cleaned out in 
> this case...
>
> I get that we may not want to dispose of the dirents on the upcall thread, 
> but we should dispose of them the next time we do a lookup or readdir...
>
> Everything else that invalidates a directory cleans out the dirents inline.
>
> Frank
>
>>> I'm looking at when dirents are invalidated, and it looks like
>>> MDCACHE_DIR_POPULATED is cleared on up call, but nothing actually
>>> cleans out the dirents...
>>>
>>> Is this an omission?
>>>
>>> Frank
>>>
>>>
>>> ---
>>> This email has been checked for viruses by Avast antivirus software.
>>> https://www.avast.com/antivirus
>>>
>>>
>>> --
>>>  Check out the vibrant tech community on one of the world's
>>> most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
>>> ___
>>> Nfs-ganesha-devel mailing list
>>> Nfs-ganesha-devel@lists.sourceforge.net
>>> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>>>
>>
>> --
>> Matt Benjamin
>> Red Hat, Inc.
>> 315 West Huron Street, Suite 140A
>> Ann Arbor, Michigan 48103
>>
>> http://www.redhat.com/en/technologies/storage
>>
>> tel.  734-821-5101
>> fax.  734-769-8938
>> cel.  734-216-5309
>
>
> ---
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
>
>
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
>


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

[Frank Filz]

> er, oh noes...

The problem I think I see is that the directory never gets cleaned out in this 
case...

I get that we may not want to dispose of the dirents on the upcall thread, but 
we should dispose of them the next time we do a lookup or readdir...

Everything else that invalidates a directory cleans out the dirents inline.

Frank

> > I'm looking at when dirents are invalidated, and it looks like
> > MDCACHE_DIR_POPULATED is cleared on up call, but nothing actually
> > cleans out the dirents...
> >
> > Is this an omission?
> >
> > Frank
> >
> >
> > ---
> > This email has been checked for viruses by Avast antivirus software.
> > https://www.avast.com/antivirus
> >
> >
> > --
> >  Check out the vibrant tech community on one of the world's
> > most engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> > ___
> > Nfs-ganesha-devel mailing list
> > Nfs-ganesha-devel@lists.sourceforge.net
> > https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
> >
> 
> --
> Matt Benjamin
> Red Hat, Inc.
> 315 West Huron Street, Suite 140A
> Ann Arbor, Michigan 48103
> 
> http://www.redhat.com/en/technologies/storage
> 
> tel.  734-821-5101
> fax.  734-769-8938
> cel.  734-216-5309


---
This email has been checked for viruses by Avast antivirus software.
https://www.avast.com/antivirus


--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel

Re: [Nfs-ganesha-devel] Dirent invalidation on up call

[Matt Benjamin]

er, oh noes...

Matt

- Original Message -
> From: "Frank Filz" 
> To: nfs-ganesha-devel@lists.sourceforge.net
> Sent: Wednesday, February 15, 2017 7:43:40 PM
> Subject: [Nfs-ganesha-devel] Dirent invalidation on up call
> 
> I'm looking at when dirents are invalidated, and it looks like
> MDCACHE_DIR_POPULATED is cleared on up call, but nothing actually cleans out
> the dirents...
> 
> Is this an omission?
> 
> Frank
> 
> 
> ---
> This email has been checked for viruses by Avast antivirus software.
> https://www.avast.com/antivirus
> 
> 
> --
> Check out the vibrant tech community on one of the world's most
> engaging tech sites, SlashDot.org! http://sdm.link/slashdot
> ___
> Nfs-ganesha-devel mailing list
> Nfs-ganesha-devel@lists.sourceforge.net
> https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel
> 

-- 
Matt Benjamin
Red Hat, Inc.
315 West Huron Street, Suite 140A
Ann Arbor, Michigan 48103

http://www.redhat.com/en/technologies/storage

tel.  734-821-5101
fax.  734-769-8938
cel.  734-216-5309

--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
___
Nfs-ganesha-devel mailing list
Nfs-ganesha-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs-ganesha-devel