[njs] Time zone name has been removed from unit tests.

[Igor Sysoev]

details:   http://hg.nginx.org/njs/rev/d882561d50e8
branches:  
changeset: 377:d882561d50e8
user:  Igor Sysoev 
date:  Fri Jun 23 15:49:09 2017 +0300
description:
Time zone name has been removed from unit tests.

diffstat:

 njs/test/njs_unit_test.c |  13 ++---
 1 files changed, 6 insertions(+), 7 deletions(-)

diffs (27 lines):

diff -r e33bea39c650 -r d882561d50e8 njs/test/njs_unit_test.c
--- a/njs/test/njs_unit_test.c  Fri Jun 23 15:27:28 2017 +0300
+++ b/njs/test/njs_unit_test.c  Fri Jun 23 15:49:09 2017 +0300
@@ -6361,17 +6361,16 @@ static njs_unit_test_t  njs_test[] =
 { nxt_string("var d = new Date(2011, 5, 24, 18, 45); d.valueOf()"),
   nxt_string("130889520") },
 
-{ nxt_string("var d = new Date(2011, 5, 24, 18, 45); d"),
-  nxt_string("Fri Jun 24 2011 18:45:00 GMT+1245 (CHAST)") },
-
-{ nxt_string("var d = new Date(2011, 5, 24, 18, 45); d.toString()"),
-  nxt_string("Fri Jun 24 2011 18:45:00 GMT+1245 (CHAST)") },
+{ nxt_string("var d = new Date(2011, 5, 24, 18, 45);"
+ "d.toString().slice(0, 33)"),
+  nxt_string("Fri Jun 24 2011 18:45:00 GMT+1245") },
 
 { nxt_string("var d = new Date(2011, 5, 24, 18, 45); d.toDateString()"),
   nxt_string("Fri Jun 24 2011") },
 
-{ nxt_string("var d = new Date(2011, 5, 24, 18, 45); d.toTimeString()"),
-  nxt_string("18:45:00 GMT+1245 (CHAST)") },
+{ nxt_string("var d = new Date(2011, 5, 24, 18, 45);"
+ "d.toTimeString().slice(0, 17)"),
+  nxt_string("18:45:00 GMT+1245") },
 
 { nxt_string("var d = new Date(2011, 5, 24, 18, 45); d.toUTCString()"),
   nxt_string("Fri Jun 24 2011 06:00:00 GMT") },
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: [PATCH] HTTP/2: add support for HPACK encoding

[Valentin V. Bartenev]

On Thursday 22 June 2017 18:23:46 Vlad Krasnov via nginx-devel wrote:
> # HG changeset patch
> # User Vlad Krasnov 
> # Date 1498167669 25200
> #  Thu Jun 22 14:41:09 2017 -0700
> # Node ID 895cea03ac21fb18d2c2ba32389cd67dc74ddbd0
> # Parent  a39bc74873faf9e5bea616561b43f6ecc55229f9
> HTTP/2: add support for HPACK encoding
> 
> Add support for full HPACK encoding as per RFC7541.
> This modification improves header compression ratio by 5-10% for the first
> response, and by 40-95% for consequential responses on the connection.
> The implementation is similar to the one used by Cloudflare.
> 
[..]

Thank you for the patch.

Sorry, I'm busy with other work.  I'll look on it later, as time permits.

  wbr, Valentin V. Bartenev

___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel

[njs] Fixed processing of large array indexes.

[Igor Sysoev]

details:   http://hg.nginx.org/njs/rev/e33bea39c650
branches:  
changeset: 376:e33bea39c650
user:  Igor Sysoev 
date:  Fri Jun 23 15:27:28 2017 +0300
description:
Fixed processing of large array indexes.

diffstat:

 njs/njs_vm.c |  13 +++--
 njs/test/njs_unit_test.c |   3 +++
 2 files changed, 10 insertions(+), 6 deletions(-)

diffs (53 lines):

diff -r 44ca33e6afdb -r e33bea39c650 njs/njs_vm.c
--- a/njs/njs_vm.c  Thu Jun 22 18:56:26 2017 +0300
+++ b/njs/njs_vm.c  Fri Jun 23 15:27:28 2017 +0300
@@ -73,7 +73,7 @@ struct njs_property_next_s {
 static nxt_noinline njs_ret_t njs_property_query(njs_vm_t *vm,
 njs_property_query_t *pq, njs_value_t *object, njs_value_t *property);
 static njs_ret_t njs_array_property_query(njs_vm_t *vm,
-njs_property_query_t *pq, njs_value_t *object, int32_t index);
+njs_property_query_t *pq, njs_value_t *object, uint32_t index);
 static njs_ret_t njs_object_property_query(njs_vm_t *vm,
 njs_property_query_t *pq, njs_value_t *value, njs_object_t *object);
 static njs_ret_t njs_method_private_copy(njs_vm_t *vm,
@@ -1054,21 +1054,22 @@ njs_property_query(njs_vm_t *vm, njs_pro
 
 static njs_ret_t
 njs_array_property_query(njs_vm_t *vm, njs_property_query_t *pq,
-njs_value_t *object, int32_t index)
+njs_value_t *object, uint32_t index)
 {
-int32_t  size;
+uint32_t size;
 njs_ret_tret;
 njs_value_t  *value;
 njs_array_t  *array;
 
 array = object->data.u.array;
-size = index - array->length;
-
-if (size >= 0) {
+
+if (index >= array->length) {
 if (pq->query != NJS_PROPERTY_QUERY_SET) {
 return NXT_DECLINED;
 }
 
+size = index - array->length;
+
 ret = njs_array_expand(vm, array, 0, size + 1);
 if (nxt_slow_path(ret != NXT_OK)) {
 return ret;
diff -r 44ca33e6afdb -r e33bea39c650 njs/test/njs_unit_test.c
--- a/njs/test/njs_unit_test.c  Thu Jun 22 18:56:26 2017 +0300
+++ b/njs/test/njs_unit_test.c  Fri Jun 23 15:27:28 2017 +0300
@@ -2487,6 +2487,9 @@ static njs_unit_test_t  njs_test[] =
 { nxt_string("var a = [ 1, 2, 3 ]; a[4294967296] = 4; a + a[4294967296]"),
   nxt_string("1,2,34") },
 
+{ nxt_string("delete[]['4e9']"),
+  nxt_string("false") },
+
 { nxt_string("var n = 1, a = [ n += 1 ]; a"),
   nxt_string("2") },
 
___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel