Re: 3rd party modules requiring ngx_http_postpone_filter_module

[Yichun Zhang (agentzh)]

Hello!

On Wed, Apr 20, 2016 at 7:16 AM, Maxim Dounin wrote:
> I personally think that documenting that SSI module should not be
> excluded from a build is good enough approach for all practical
> reasons.
>

As the author of the ngx_echo and ngx_srcache modules that require the
http postpone module, I must say I disagree with you here. There is
just no reason to include unrelated standard modules like SSI or
Addition when they are not really required.

Regards,
-agentzh

___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel

Re: 3rd party modules requiring ngx_http_postpone_filter_module

[Maxim Dounin]

Hello!

On Wed, Apr 20, 2016 at 12:33:17AM -0400, Anthony Ryan wrote:

> Hello,
> 
> I'm currently looking for ideas to resolve a 3rd party module
> regression[1][2] that I keep running into, and figured it would be
> best to consult the experts.
> 
> The ngx_http_postpone_filter_module is a critical helper for many
> modules to ensure subrequests are properly ordered. But I can't seem
> to find a proper way to ensure it's included for a 3rd party module.
> 
> All of the internal modules which use it have a special declaration in
> the auto/modules file enabling postpone, but among the 3rd party
> modules there has only ever been crappy workarounds (documentation
> saying to enable the SSI module or another which pulls in postpone) or
> hacks to add HTTP_POSTPONE_FILTER_SRCS to HTTP_SRCS.

I personally think that documenting that SSI module should not be 
excluded from a build is good enough approach for all practical 
reasons.

Hacks that use HTTP_POSTPONE_FILTER_SRCS are certainly hacks and 
they were expected to fail sooner or later.

[...]

-- 
Maxim Dounin
http://nginx.org/

___
nginx-devel mailing list
nginx-devel@nginx.org
http://mailman.nginx.org/mailman/listinfo/nginx-devel