Branch: refs/heads/master
  Home:   https://github.com/NixOS/nix
  Commit: 649a81bcd6445d3b00f400cd6017d184bf0aaa25
      
https://github.com/NixOS/nix/commit/649a81bcd6445d3b00f400cd6017d184bf0aaa25
  Author: Tuomas Tynkkynen <tuo...@tuxera.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M src/nix-daemon/nix-daemon.cc

  Log Message:
  -----------
  nix-daemon: Don't splice with len=SIZE_MAX

Currently, 'nix-daemon --stdio' is always failing for me, due to the
splice call always failing with (on a 32-bit host):

splice(0, NULL, 3, NULL, 4294967295, SPLICE_F_MOVE) = -1 EINVAL (Invalid 
argument)

With a bit of ftracing (and luck) the problem seems to be that splice()
always fails with EINVAL if the len cast as ssize_t is negative:
http://lxr.free-electrons.com/source/fs/read_write.c?v=4.4#L384

So use SSIZE_MAX instead of SIZE_MAX.


  Commit: 77a78af6786234871f713631b12abf9d8d428daa
      
https://github.com/NixOS/nix/commit/77a78af6786234871f713631b12abf9d8d428daa
  Author: Eelco Dolstra <eelco.dols...@logicblox.com>
  Date:   2017-02-13 (Mon, 13 Feb 2017)

  Changed paths:
    M src/nix-daemon/nix-daemon.cc

  Log Message:
  -----------
  Merge pull request #1233 from dezgeg/splice

nix-daemon: Don't splice with len=SIZE_MAX


Compare: https://github.com/NixOS/nix/compare/4724903c78e8...77a78af67862
_______________________________________________
nix-commits mailing list
nix-comm...@lists.science.uu.nl
http://lists.science.uu.nl/mailman/listinfo/nix-commits

Reply via email to