Re: [Nix-dev] php-packages fix (broken since multiple outputs)
Excerpts from Alastair Pharo's message of dom abr 23 13:34:51 + 2017: > Sorry, I mangled the link to my PR in my previous email. The correct > link is https://github.com/NixOS/nixpkgs/pull/24648. This is another > attempt to fix the PHP situation, quite similar to your fix. Great - didn't look at configure. You took care about php-config and phpize, so I guess your patch should be preferred. Who is going to merge it and fix the brokeness? Marc Weber ___ nix-dev mailing list nix-dev@lists.science.uu.nl https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] php-packages fix (broken since multiple outputs)
Sorry, I mangled the link to my PR in my previous email. The correct link is https://github.com/NixOS/nixpkgs/pull/24648. This is another attempt to fix the PHP situation, quite similar to your fix. On 23 April 2017, [Marc Weber](mailto:marco-owe...@gmx.de) wrote: > FYI I have an open PR for this on github as well: > > https://github.com/NixOS/nixpkgs/pull/2464. Maybe we can compare notes. > This issue is labeled "systemd-fstab-generator doesn't find fsck.ext3" > thus seems unrelated. > > There is not much to discuss because > * current situation is broken > * its known why (includes aren't found) > * The best way to fix it is fixing php-config (because it makes all > packages compile) > > => The only think to discuss is the "assert" stuff so that in future all > packages can be tested by php71Packages or such (better php71.packages) > even better (php7x.packages) -> but that's another story: > - https://github.com/NixOS/nixpkgs/issues/24432 > - adding tests that the modules actually "work" as expected on multiple > platforms > [ > The current situation is a stopper for me -> and the fix doesn't make > things worse (testing is as good/bad as it previously was). > > Marc Weber ___ nix-dev mailing list nix-dev@lists.science.uu.nl https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] php-packages fix (broken since multiple outputs)
FYI I have an open PR for this on github as well: > https://github.com/NixOS/nixpkgs/pull/2464. Maybe we can compare notes. This issue is labeled "systemd-fstab-generator doesn't find fsck.ext3" thus seems unrelated. There is not much to discuss because * current situation is broken * its known why (includes aren't found) * The best way to fix it is fixing php-config (because it makes all packages compile) => The only think to discuss is the "assert" stuff so that in future all packages can be tested by php71Packages or such (better php71.packages) even better (php7x.packages) -> but that's another story: - https://github.com/NixOS/nixpkgs/issues/24432 - adding tests that the modules actually "work" as expected on multiple platforms The current situation is a stopper for me -> and the fix doesn't make things worse (testing is as good/bad as it previously was). Marc Weber ___ nix-dev mailing list nix-dev@lists.science.uu.nl https://mailman.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] php-packages fix (broken since multiple outputs)
Hi there, FYI I have an open PR for this on github as well: https://github.com/NixOS/nixpkgs/pull/2464. Maybe we can compare notes. -Alastair On 23 April 2017, [Marc Weber](mailto:marco-owe...@gmx.de) wrote: > Problem: Since outputs = ["out" "dev"] a lot of php-packages stopped > compiling because php-config provided wrong includes > > http://mawercer.de/tmp/php-packages-out-dev.patch > - moves php-config into php.dev > - patches the includes directory so that headers are found > - The patch also rewrites the assertion so that I could test all > packages easily by > > nix-build -A php71Packages > > My question is, is there a different way to run nix-build -A > php71Packages > ignoring assertions so that all php packages can be tested easily? > > I'd like to prepare a PR. > > Marc Weber > ___ > nix-dev mailing list > nix-dev@lists.science.uu.nl > https://mailman.science.uu.nl/mailman/listinfo/nix-dev ___ nix-dev mailing list nix-dev@lists.science.uu.nl https://mailman.science.uu.nl/mailman/listinfo/nix-dev
[Nix-dev] php-packages fix (broken since multiple outputs)
Problem: Since outputs = ["out" "dev"] a lot of php-packages stopped compiling because php-config provided wrong includes http://mawercer.de/tmp/php-packages-out-dev.patch - moves php-config into php.dev - patches the includes directory so that headers are found - The patch also rewrites the assertion so that I could test all packages easily by nix-build -A php71Packages My question is, is there a different way to run nix-build -A php71Packages ignoring assertions so that all php packages can be tested easily? I'd like to prepare a PR. Marc Weber ___ nix-dev mailing list nix-dev@lists.science.uu.nl https://mailman.science.uu.nl/mailman/listinfo/nix-dev
