Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
I do not have access to commit. Can somebody commit this for me. Oddly, I can also no longer add comments to the review. -Corey O'Connor coreyocon...@gmail.com http://corebotllc.com/ On Mon, Mar 26, 2012 at 6:07 AM, Shea Levy s...@shealevy.com wrote: This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ Ship it! Ship It! - Shea On March 26th, 2012, 7:03 a.m., Corey O'Connor wrote: Review request for NixOS developers. By Corey O'Connor. *Updated March 26, 2012, 7:03 a.m.* Description Adds memcached server to pkgs/servers Testing nix-env -i memcached Diffs - nixpkgs/trunk/pkgs/lib/maintainers.nix (33342) - nixpkgs/trunk/pkgs/servers/memcached/default.nix (PRE-CREATION) - nixpkgs/trunk/pkgs/top-level/all-packages.nix (33342) View Diff http://reviewboard.loegria.net/r/15/diff/ ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
On March 26, 2012, 10:02 a.m., Yury Kudryashov wrote: Ship It! Should I commit this for you? - Yury --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review18 --- On March 26, 2012, 7:03 a.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 26, 2012, 7:03 a.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/lib/maintainers.nix 33342 nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION nixpkgs/trunk/pkgs/top-level/all-packages.nix 33342 Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review20 --- Ship it! Ship It! - Shea Levy On March 26, 2012, 7:03 a.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 26, 2012, 7:03 a.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/lib/maintainers.nix 33342 nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION nixpkgs/trunk/pkgs/top-level/all-packages.nix 33342 Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 26, 2012, 7:03 a.m.) Review request for NixOS developers. Changes --- adds Corey O'Connor (coconnor) to maintainers. Uses nickname in memcached meta. Description --- Adds memcached server to pkgs/servers Diffs (updated) - nixpkgs/trunk/pkgs/lib/maintainers.nix 33342 nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION nixpkgs/trunk/pkgs/top-level/all-packages.nix 33342 Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review17 --- nixpkgs/trunk/pkgs/servers/memcached/default.nix http://reviewboard.loegria.net/r/15/#comment1 Could you please add yourself to pkgs/lib/maintainers.nix, and use stdenv.lib.maintainers.yournickname? - Yury Kudryashov On March 24, 2012, 5:23 a.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 24, 2012, 5:23 a.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION nixpkgs/trunk/pkgs/top-level/all-packages.nix 33342 Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 24, 2012, 5:23 a.m.) Review request for NixOS developers. Changes --- oops. adding back in the all-packages.nix patch. Description --- Adds memcached server to pkgs/servers Diffs (updated) - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION nixpkgs/trunk/pkgs/top-level/all-packages.nix 33342 Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review8 --- Please follow the guidelines at http://hydra.nixos.org/build/2315779/download/2/manual/#chap-meta regarding meta attributes. In particular, your 'description' is too long and, if possible, a 'maintainers' and 'platforms' section would be appreciated. - Shea Levy On March 22, 2012, 7:30 p.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 22, 2012, 7:30 p.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION nixpkgs/trunk/pkgs/top-level/all-packages.nix 33342 Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
On March 22, 2012, 8:49 p.m., Shea Levy wrote: Please follow the guidelines at http://hydra.nixos.org/build/2315779/download/2/manual/#chap-meta regarding meta attributes. In particular, your 'description' is too long and, if possible, a 'maintainers' and 'platforms' section would be appreciated. Also, are you certain you need autoconf and automake in buildInputs? - Shea --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review8 --- On March 22, 2012, 7:30 p.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 22, 2012, 7:30 p.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION nixpkgs/trunk/pkgs/top-level/all-packages.nix 33342 Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review10 --- Do I see that you added it under DEVELOPMENT / INTERPRETERS? - Lluís On March 22, 2012, 7:30 p.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 22, 2012, 7:30 p.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION nixpkgs/trunk/pkgs/top-level/all-packages.nix 33342 Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
On March 22, 2012, 10:44 p.m., Lluís wrote: Do I see that you added it under DEVELOPMENT / INTERPRETERS? ah! to all-packages? it would appear so. My mistake. all-packages should really be broken up IMO. Kinda getting crazy hunting for the right place in all-packages to add something ;-) - Corey --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review10 --- On March 22, 2012, 7:30 p.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 22, 2012, 7:30 p.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION nixpkgs/trunk/pkgs/top-level/all-packages.nix 33342 Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
On March 22, 2012, 8:49 p.m., Shea Levy wrote: Please follow the guidelines at http://hydra.nixos.org/build/2315779/download/2/manual/#chap-meta regarding meta attributes. In particular, your 'description' is too long and, if possible, a 'maintainers' and 'platforms' section would be appreciated. Shea Levy wrote: Also, are you certain you need autoconf and automake in buildInputs? Will update diff with meta attribute changes. Not sure if I need autoconf and automake. I'll try without it. - Corey --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review8 --- On March 22, 2012, 7:30 p.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 22, 2012, 7:30 p.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION nixpkgs/trunk/pkgs/top-level/all-packages.nix 33342 Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 22, 2012, 11:09 p.m.) Review request for NixOS developers. Changes --- removed automake and autoconf dependency. updated meta attributes to follow convention. moved addition to all-packages to SERVERS. Description --- Adds memcached server to pkgs/servers Diffs (updated) - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
--- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review13 --- Ship it! Ship It! - Shea Levy On March 22, 2012, 11:09 p.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 22, 2012, 11:09 p.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
On March 23, 2012, 3:36 a.m., Shea Levy wrote: Ship It! If you don't have commit access, I will commit this tomorrow in absence of any negative feedback. - Shea --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review13 --- On March 22, 2012, 11:09 p.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 22, 2012, 11:09 p.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
Re: [Nix-dev] Review Request: Adds memcached server to nixpkgs
On March 23, 2012, 3:36 a.m., Shea Levy wrote: Ship It! Shea Levy wrote: If you don't have commit access, I will commit this tomorrow in absence of any negative feedback. Wait, where's the all-packages addition? - Shea --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/#review13 --- On March 22, 2012, 11:09 p.m., Corey O'Connor wrote: --- This is an automatically generated e-mail. To reply, visit: http://reviewboard.loegria.net/r/15/ --- (Updated March 22, 2012, 11:09 p.m.) Review request for NixOS developers. Description --- Adds memcached server to pkgs/servers Diffs - nixpkgs/trunk/pkgs/servers/memcached/default.nix PRE-CREATION Diff: http://reviewboard.loegria.net/r/15/diff/ Testing --- nix-env -i memcached Thanks, Corey O'Connor ___ nix-dev mailing list nix-dev@lists.science.uu.nl http://lists.science.uu.nl/mailman/listinfo/nix-dev
