[GitHub] ctubbsii commented on a change in pull request #479: More intellij automated fixes
ctubbsii commented on a change in pull request #479: More intellij automated
fixes
URL: https://github.com/apache/accumulo/pull/479#discussion_r186915153
##
File path:
server/base/src/main/java/org/apache/accumulo/server/init/Initialize.java
##
@@ -607,7 +607,7 @@ private static void initZooKeeper(Opts opts, String uuid,
String instanceNamePat
zoo.recursiveDelete(instanceNamePath, NodeMissingPolicy.SKIP);
zoo.putPersistentData(instanceNamePath, uuid.getBytes(UTF_8),
NodeExistsPolicy.FAIL);
-final byte[] EMPTY_BYTE_ARRAY = new byte[0], ZERO_CHAR_ARRAY = new byte[]
{'0'};
+final byte[] EMPTY_BYTE_ARRAY = new byte[0], ZERO_CHAR_ARRAY = {'0'};
Review comment:
Variables should really have their own declarations with their own
modifiers. I wonder if we can enforce this with checkstyle.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #479: More intellij automated fixes
ctubbsii commented on a change in pull request #479: More intellij automated
fixes
URL: https://github.com/apache/accumulo/pull/479#discussion_r186915619
##
File path:
server/base/src/test/java/org/apache/accumulo/server/util/FileSystemMonitorTest.java
##
@@ -37,7 +37,7 @@
@Test
public void testFilteredMountEntries() throws Exception {
-String[] mountEntries = new String[] {"rootfs / rootfs rw 0 0",
+String[] mountEntries = {"rootfs / rootfs rw 0 0",
Review comment:
Thoughts: I really wonder about the portability of this FileSystemMonitor.
It seems dubious. I'm not even sure if it works properly with systemd or
recognizes m.2 and nvme drives. The FileSystemMonitor seems more like a
monitoring utility which should exist separate from Accumulo.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #479: More intellij automated fixes
ctubbsii commented on a change in pull request #479: More intellij automated
fixes
URL: https://github.com/apache/accumulo/pull/479#discussion_r186914630
##
File path:
client/mapreduce/src/test/java/org/apache/accumulo/core/client/mapreduce/impl/BatchInputSplitTest.java
##
@@ -44,7 +44,7 @@
@Test
public void testSimpleWritable() throws IOException {
-Range[] ranges = new Range[] {new Range(new Key("a"), new Key("b"))};
+Range[] ranges = {new Range(new Key("a"), new Key("b"))};
BatchInputSplit split = new BatchInputSplit("table", Table.ID.of("1"),
Arrays.asList(ranges),
Review comment:
This could be further simplified with `Collections.singletonList()` instead
of allocating an intermediate array. I saw a few cases of this "array of
singleton" case.
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Accumulo-Pull-Requests - Build # 1198 - Fixed
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1198) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1198/ to view the results.
[GitHub] mikewalch opened a new pull request #479: More intellij automated fixes
mikewalch opened a new pull request #479: More intellij automated fixes URL: https://github.com/apache/accumulo/pull/479 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mikewalch closed pull request #478: Removed unnecessary calls to toString()
mikewalch closed pull request #478: Removed unnecessary calls to toString()
URL: https://github.com/apache/accumulo/pull/478
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java
b/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java
index 36792a7c5a..49bab9a037 100644
---
a/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java
+++
b/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AbstractInputFormat.java
@@ -461,7 +461,7 @@ private void setupIterators(JobConf job, ScannerBase
scanner, String tableName,
*/
public void initialize(InputSplit inSplit, JobConf job) throws IOException
{
baseSplit = (org.apache.accumulo.core.client.mapreduce.RangeInputSplit)
inSplit;
- log.debug("Initializing input split: " + baseSplit.toString());
+ log.debug("Initializing input split: " + baseSplit);
Instance instance = baseSplit.getInstance(getClientConfiguration(job));
if (null == instance) {
@@ -559,8 +559,7 @@ public void initialize(InputSplit inSplit, JobConf job)
throws IOException {
scanner.setRange(baseSplit.getRange());
scannerBase = scanner;
} else {
-throw new IllegalArgumentException(
-"Can not initialize from " + baseSplit.getClass().toString());
+throw new IllegalArgumentException("Can not initialize from " +
baseSplit.getClass());
}
Collection> columns = baseSplit.getFetchedColumns();
diff --git
a/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java
b/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java
index 32a2b61925..3bb86cab96 100644
---
a/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java
+++
b/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloInputFormat.java
@@ -64,7 +64,7 @@
log.setLevel(level);
}
} else {
- throw new IllegalArgumentException("No RecordReader for " +
split.getClass().toString());
+ throw new IllegalArgumentException("No RecordReader for " +
split.getClass());
}
RecordReaderBase recordReader = new
RecordReaderBase() {
diff --git
a/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java
b/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java
index c273892d3b..9fdacc9bfe 100644
---
a/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java
+++
b/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapred/AccumuloOutputFormat.java
@@ -444,7 +444,7 @@ public void write(Text table, Mutation mutation) throws
IOException {
try {
addTable(table);
} catch (final Exception e) {
- log.error("Could not add table '" + table.toString() + "'", e);
+ log.error("Could not add table '" + table + "'", e);
throw new IOException(e);
}
diff --git
a/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java
b/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java
index b7adbbb2e4..6b9679a7c9 100644
---
a/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java
+++
b/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AbstractInputFormat.java
@@ -468,7 +468,7 @@ private void setupIterators(TaskAttemptContext context,
ScannerBase scanner, Str
public void initialize(InputSplit inSplit, TaskAttemptContext attempt)
throws IOException {
split = (RangeInputSplit) inSplit;
- log.debug("Initializing input split: " + split.toString());
+ log.debug("Initializing input split: " + split);
Instance instance = split.getInstance(getClientConfiguration(attempt));
if (null == instance) {
diff --git
a/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java
b/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java
index 1dac80a2d6..efc6221a23 100644
---
a/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java
+++
b/client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/AccumuloInputFormat.java
@@ -64,7 +64,7 @@
log.setLevel(level);
}
} else {
- throw new
Accumulo-Pull-Requests - Build # 1197 - Failure
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1197) Status: Failure Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1197/ to view the results.
[GitHub] mikewalch opened a new pull request #478: Removed unnecessary calls to toString()
mikewalch opened a new pull request #478: Removed unnecessary calls to toString() URL: https://github.com/apache/accumulo/pull/478 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii closed pull request #83: Beginning of 1.9.1 release notes
ctubbsii closed pull request #83: Beginning of 1.9.1 release notes URL: https://github.com/apache/accumulo-website/pull/83 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request (from a fork), the diff is supplied below (as it won't show otherwise due to GitHub magic): diff --git a/_posts/release/2018-05-08-accumulo-1.9.1.md b/_posts/release/2018-05-08-accumulo-1.9.1.md new file mode 100644 index ..841928cb --- /dev/null +++ b/_posts/release/2018-05-08-accumulo-1.9.1.md @@ -0,0 +1,19 @@ +--- +title: Apache Accumulo 1.9.1 +draft: true +--- + +Accumulo 1.9.1 contains multiple bug fixes for write ahead log recovery. Write +ahead log recovery is the process of restoring data that was in memory when a +tablet server died. These bugs could lead to data loss and are present in +1.8.0, 1.8.1, and 1.9.0. Because the bugs can negatively impact Accumulo's +metadata table, even users that mainly use bulk import may be affected. It is +recommended that anyone using 1.8.0 or greater upgrade immediately. For more +information see issues [#441] and [#449]. These issues were fixed in pull +request [#443] and [#458]. + +[#441]:https://github.com/apache/accumulo/issues/441 +[#449]:https://github.com/apache/accumulo/issues/449 +[#443]:https://github.com/apache/accumulo/issues/443 +[#458]:https://github.com/apache/accumulo/issues/458 + This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on a change in pull request #83: Beginning of 1.9.1 release notes
milleruntime commented on a change in pull request #83: Beginning of 1.9.1 release notes URL: https://github.com/apache/accumulo-website/pull/83#discussion_r186837826 ## File path: _posts/release/2018-05-08-accumulo-1.9.1.md ## @@ -0,0 +1,19 @@ +--- +title: Apache Accumulo 1.9.1 +draft: true +--- + +Accumulo 1.9.1 contains multiple bug fixes for write ahead log recovery. Write +ahead log recovery is the process of restoring data that was in memory when a +tablet server died. These bugs could lead to data loss and are present in +1.8.0, 1.8.1, and 1.9.0. Because the bugs can negatively impact Accumulo's +metadata table, even users that mainly use bulk import may be affected. It is Review comment: Could make this sentence more clear... "Systems that mainly use bulk import for ingest are also affected since the bugs can negatively impact the metadata table." This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii closed pull request #466: Remove the fate module by combining it into core
ctubbsii closed pull request #466: Remove the fate module by combining it into
core
URL: https://github.com/apache/accumulo/pull/466
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git a/assemble/bin/accumulo-util b/assemble/bin/accumulo-util
index 71aea89a81..fe62ad31ec 100755
--- a/assemble/bin/accumulo-util
+++ b/assemble/bin/accumulo-util
@@ -218,7 +218,6 @@ function hadoop_jar() {
ZOOKEEPER_LIB=$(eval "$ZOOKEEPER_CMD")
CORE_LIB="${lib}/accumulo-core.jar"
- FATE_LIB="${lib}/accumulo-fate.jar"
THRIFT_LIB="${lib}/libthrift.jar"
JCOMMANDER_LIB="${lib}/jcommander.jar"
COMMONS_VFS_LIB="${lib}/commons-vfs2.jar"
@@ -244,8 +243,8 @@ function hadoop_jar() {
fi
done
-
LIB_JARS="$THRIFT_LIB,$CORE_LIB,$FATE_LIB,$ZOOKEEPER_LIB,$JCOMMANDER_LIB,$COMMONS_VFS_LIB,$GUAVA_LIB,$HTRACE_LIB"
-
H_JARS="$THRIFT_LIB:$CORE_LIB:$FATE_LIB:$ZOOKEEPER_LIB:$JCOMMANDER_LIB:$COMMONS_VFS_LIB:$GUAVA_LIB:$HTRACE_LIB"
+
LIB_JARS="$THRIFT_LIB,$CORE_LIB,$ZOOKEEPER_LIB,$JCOMMANDER_LIB,$COMMONS_VFS_LIB,$GUAVA_LIB,$HTRACE_LIB"
+
H_JARS="$THRIFT_LIB:$CORE_LIB:$ZOOKEEPER_LIB:$JCOMMANDER_LIB:$COMMONS_VFS_LIB:$GUAVA_LIB:$HTRACE_LIB"
for jar in $USERJARS; do
LIB_JARS="$LIB_JARS,$jar"
diff --git a/assemble/pom.xml b/assemble/pom.xml
index 0aba9cbcb2..31f9a9915a 100644
--- a/assemble/pom.xml
+++ b/assemble/pom.xml
@@ -120,11 +120,6 @@
accumulo-core
true
-
- org.apache.accumulo
- accumulo-fate
- true
-
org.apache.accumulo
accumulo-gc
diff --git a/client/mapreduce/pom.xml b/client/mapreduce/pom.xml
index 2ecce2d556..acfe3f51ac 100644
--- a/client/mapreduce/pom.xml
+++ b/client/mapreduce/pom.xml
@@ -43,10 +43,6 @@
org.apache.accumulo
accumulo-core
-
- org.apache.accumulo
- accumulo-fate
-
org.slf4j
slf4j-api
diff --git a/core/pom.xml b/core/pom.xml
index 87dcd282c7..53e32cec62 100644
--- a/core/pom.xml
+++ b/core/pom.xml
@@ -79,10 +79,6 @@
log4j
log4j
-
- org.apache.accumulo
- accumulo-fate
-
org.apache.accumulo
accumulo-start
diff --git a/core/src/main/findbugs/exclude-filter.xml
b/core/src/main/findbugs/exclude-filter.xml
index 56d3659c2b..a3db72f205 100644
--- a/core/src/main/findbugs/exclude-filter.xml
+++ b/core/src/main/findbugs/exclude-filter.xml
@@ -94,7 +94,10 @@
-
+
+
+
+
diff --git
a/fate/src/main/java/org/apache/accumulo/fate/AcceptableException.java
b/core/src/main/java/org/apache/accumulo/fate/AcceptableException.java
similarity index 100%
rename from fate/src/main/java/org/apache/accumulo/fate/AcceptableException.java
rename to core/src/main/java/org/apache/accumulo/fate/AcceptableException.java
diff --git a/fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java
b/core/src/main/java/org/apache/accumulo/fate/AdminUtil.java
similarity index 100%
rename from fate/src/main/java/org/apache/accumulo/fate/AdminUtil.java
rename to core/src/main/java/org/apache/accumulo/fate/AdminUtil.java
diff --git a/fate/src/main/java/org/apache/accumulo/fate/AgeOffStore.java
b/core/src/main/java/org/apache/accumulo/fate/AgeOffStore.java
similarity index 100%
rename from fate/src/main/java/org/apache/accumulo/fate/AgeOffStore.java
rename to core/src/main/java/org/apache/accumulo/fate/AgeOffStore.java
diff --git a/fate/src/main/java/org/apache/accumulo/fate/Fate.java
b/core/src/main/java/org/apache/accumulo/fate/Fate.java
similarity index 100%
rename from fate/src/main/java/org/apache/accumulo/fate/Fate.java
rename to core/src/main/java/org/apache/accumulo/fate/Fate.java
diff --git a/fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java
b/core/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java
similarity index 100%
rename from fate/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java
rename to core/src/main/java/org/apache/accumulo/fate/ReadOnlyRepo.java
diff --git a/fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java
b/core/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java
similarity index 100%
rename from fate/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java
rename to core/src/main/java/org/apache/accumulo/fate/ReadOnlyStore.java
diff --git a/fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java
b/core/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java
similarity index 100%
rename from fate/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java
rename to core/src/main/java/org/apache/accumulo/fate/ReadOnlyTStore.java
diff --git a/fate/src/main/java/org/apache/accumulo/fate/Repo.java
b/core/src/main/java/org/apache/accumulo/fate/Repo.java
similarity index 100%
rename from
Accumulo-Pull-Requests - Build # 1196 - Fixed
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1196) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1196/ to view the results.
[GitHub] mikewalch commented on issue #64: Add Luis Tavarez to PMC/committers
mikewalch commented on issue #64: Add Luis Tavarez to PMC/committers URL: https://github.com/apache/accumulo-website/issues/64#issuecomment-387499018 Fixed by 1b51af3360b6f37c This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mikewalch closed issue #64: Add Luis Tavarez to PMC/committers
mikewalch closed issue #64: Add Luis Tavarez to PMC/committers URL: https://github.com/apache/accumulo-website/issues/64 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mikewalch commented on issue #70: Add search to documentation
mikewalch commented on issue #70: Add search to documentation URL: https://github.com/apache/accumulo-website/issues/70#issuecomment-387497296 Fixed by #81 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] mikewalch closed issue #70: Add search to documentation
mikewalch closed issue #70: Add search to documentation URL: https://github.com/apache/accumulo-website/issues/70 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner opened a new pull request #83: Beginning of 1.9.1 release notes
keith-turner opened a new pull request #83: Beginning of 1.9.1 release notes URL: https://github.com/apache/accumulo-website/pull/83 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476#discussion_r186818829 ## File path: pom.xml ## @@ -1776,6 +1776,41 @@ src/main/findbugs/exclude-filter.xml + + overrides Review comment: Evidently, I'm wrong. Some elements, including `` cannot appear in the settings.xml profiles. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Accumulo-Master - Build # 2343 - Fixed
The Apache Jenkins build system has built Accumulo-Master (build #2343) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Master/2343/ to view the results.
[GitHub] ctubbsii commented on issue #436: ACCUMULO-4813 New bulk import process and API
ctubbsii commented on issue #436: ACCUMULO-4813 New bulk import process and API URL: https://github.com/apache/accumulo/pull/436#issuecomment-387485112 Since this PR was merged, should the ACCUMULO-4813 JIRA issue be closed now? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
ctubbsii commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476#discussion_r186810642 ## File path: pom.xml ## @@ -1776,6 +1776,41 @@ src/main/findbugs/exclude-filter.xml + + overrides Review comment: Any profile you can put in a POM, can also be placed in settings.xml. You could just cut/paste from pom.xml to settings.xml and it will work the same way, activated by `-Pname` or whatever activation is configured for that profile. Additionally, you can automatically activate profiles (regardless of whether they are in pom.xml or settings.xml) by setting the `` section appropriately: https://maven.apache.org/settings.html#Active_Profiles This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner commented on issue #459: Re-implement write ahead log archiving
keith-turner commented on issue #459: Re-implement write ahead log archiving URL: https://github.com/apache/accumulo/issues/459#issuecomment-387481402 I think the archiving functionality should be removed in favor of hdfs trash as discussed in #463 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] jmark99 commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations
jmark99 commented on a change in pull request #476: ACCUMULO-2537 Add @Override Annotations URL: https://github.com/apache/accumulo/pull/476#discussion_r186803975 ## File path: pom.xml ## @@ -1776,6 +1776,41 @@ src/main/findbugs/exclude-filter.xml + + overrides Review comment: Updated to address your comments. I would be interested in the idea of having the plugin activated via one's own personal settings.xml file. That would allow individual users to add additional checks according to their interest. I'm not that familiar on the use of the settings.xml file. I was having issues trying to find info/examples on how I could enable a plugin via that file. The profile examples I found were used to set properties the pom.xml would make use of based upon profile definitions. Do you have any examples of how the settings.xml file could be used to enable a plugin? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Accumulo-Pull-Requests - Build # 1195 - Failure
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1195) Status: Failure Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1195/ to view the results.
[GitHub] milleruntime commented on a change in pull request #465: Initial ideas for new Encryption interface
milleruntime commented on a change in pull request #465: Initial ideas for new
Encryption interface
URL: https://github.com/apache/accumulo/pull/465#discussion_r186796958
##
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##
@@ -45,78 +45,14 @@
// Crypto-related properties
@Experimental
CRYPTO_PREFIX("crypto.", null, PropertyType.PREFIX,
- "Properties in this category related to the configuration of both
default and custom crypto"
- + " modules."),
+ "Properties related to encryption."),
Review comment:
Roger
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] milleruntime commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438
milleruntime commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438 URL: https://github.com/apache/accumulo/pull/456#discussion_r186794976 ## File path: client/mapreduce/src/main/java/org/apache/accumulo/core/client/mapreduce/lib/impl/FileOutputConfigurator.java ## @@ -135,14 +135,15 @@ public static AccumuloConfiguration getAccumuloConfiguration(Class implementi * @param conf * the Hadoop configuration object to configure * @param compressionType - * one of "none", "gz", "lzo", or "snappy" + * one of "none", "gz", "lzo", "snappy", or "zst" Review comment: Sounds good, "zstd" it is. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on a change in pull request #456: Add ZStandard compression codec. Fixes #438
milleruntime commented on a change in pull request #456: Add ZStandard
compression codec. Fixes #438
URL: https://github.com/apache/accumulo/pull/456#discussion_r186794664
##
File path:
core/src/main/java/org/apache/accumulo/core/file/rfile/bcfile/Compression.java
##
@@ -456,6 +458,122 @@ public boolean isSupported() {
return snappyCodec != null;
}
+},
+
+ZSTANDARD(COMPRESSION_ZSTD) {
Review comment:
They do support snappy and zstandard but somewhere else in the code I guess?
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Accumulo-1.9 - Build # 300 - Fixed
The Apache Jenkins build system has built Accumulo-1.9 (build #300) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-1.9/300/ to view the results.
Accumulo-Master - Build # 2342 - Failure
The Apache Jenkins build system has built Accumulo-Master (build #2342) Status: Failure Check console output at https://builds.apache.org/job/Accumulo-Master/2342/ to view the results.
[GitHub] keith-turner closed issue #449: Seeing more data loss when running continuous ingest with agitation.
keith-turner closed issue #449: Seeing more data loss when running continuous ingest with agitation. URL: https://github.com/apache/accumulo/issues/449 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] keith-turner closed issue #477: -1 tablet log id used in WAL when table durability is set to None
keith-turner closed issue #477: -1 tablet log id used in WAL when table durability is set to None URL: https://github.com/apache/accumulo/issues/477 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
Accumulo-Pull-Requests - Build # 1194 - Fixed
The Apache Jenkins build system has built Accumulo-Pull-Requests (build #1194) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Pull-Requests/1194/ to view the results.
[GitHub] keith-turner closed pull request #458: fixes #449 fix two bugs with WAL recovery
keith-turner closed pull request #458: fixes #449 fix two bugs with WAL recovery
URL: https://github.com/apache/accumulo/pull/458
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):
diff --git
a/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
b/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
index a0c2a815ce..f87841db38 100644
--- a/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
+++ b/server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
@@ -3276,12 +3276,12 @@ public int compare(LogEntry e1, LogEntry e2) {
logger.recover(fs, extent, tconf, recoveryLogs, tabletFiles,
mutationReceiver);
}
- public int createLogId(KeyExtent tablet) {
-AccumuloConfiguration acuTableConf = getTableConfiguration(tablet);
-if (DurabilityImpl.fromString(acuTableConf.get(Property.TABLE_DURABILITY))
!= Durability.NONE) {
- return logIdGenerator.incrementAndGet();
+ public int createLogId() {
+int logId = logIdGenerator.incrementAndGet();
+if (logId < 0) {
+ throw new IllegalStateException("Log Id rolled");
}
-return -1;
+return logId;
}
public TableConfiguration getTableConfiguration(KeyExtent extent) {
diff --git
a/server/tserver/src/main/java/org/apache/accumulo/tserver/log/CloseableIterator.java
b/server/tserver/src/main/java/org/apache/accumulo/tserver/log/CloseableIterator.java
new file mode 100644
index 00..59623dc38d
--- /dev/null
+++
b/server/tserver/src/main/java/org/apache/accumulo/tserver/log/CloseableIterator.java
@@ -0,0 +1,25 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.accumulo.tserver.log;
+
+import java.io.IOException;
+import java.util.Iterator;
+
+public interface CloseableIterator extends Iterator, AutoCloseable {
+ @Override
+ public void close() throws IOException;
+}
diff --git
a/server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
b/server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
index 6aa4964af6..263f0c8d26 100644
---
a/server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
+++
b/server/tserver/src/main/java/org/apache/accumulo/tserver/log/DfsLogger.java
@@ -601,7 +601,7 @@ public synchronized void defineTablet(long seq, int tid,
KeyExtent tablet) throw
final LogFileKey key = new LogFileKey();
key.event = DEFINE_TABLET;
key.seq = seq;
-key.tid = tid;
+key.tabletId = tid;
key.tablet = tablet;
try {
write(key, EMPTY);
@@ -662,7 +662,7 @@ public LoggerOperation logManyTablets(List
mutations) throws IO
LogFileKey key = new LogFileKey();
key.event = MANY_MUTATIONS;
key.seq = tabletMutations.getSeq();
- key.tid = tabletMutations.getTid();
+ key.tabletId = tabletMutations.getTid();
LogFileValue value = new LogFileValue();
value.mutations = tabletMutations.getMutations();
data.add(new Pair<>(key, value));
@@ -688,7 +688,7 @@ public LoggerOperation minorCompactionFinished(long seq,
int tid, String fqfn,
LogFileKey key = new LogFileKey();
key.event = COMPACTION_FINISH;
key.seq = seq;
-key.tid = tid;
+key.tabletId = tid;
return logFileData(Collections.singletonList(new Pair<>(key, EMPTY)),
durability);
}
@@ -697,7 +697,7 @@ public LoggerOperation minorCompactionStarted(long seq, int
tid, String fqfn,
LogFileKey key = new LogFileKey();
key.event = COMPACTION_START;
key.seq = seq;
-key.tid = tid;
+key.tabletId = tid;
key.filename = fqfn;
return logFileData(Collections.singletonList(new Pair<>(key, EMPTY)),
durability);
}
diff --git
a/server/tserver/src/main/java/org/apache/accumulo/tserver/log/MultiReader.java
b/server/tserver/src/main/java/org/apache/accumulo/tserver/log/RecoveryLogReader.java
similarity index 52%
rename from
