[GitHub] [accumulo] keith-turner opened a new issue #1502: Determine if files are deleted from metadata table when using volume.replacements

[GitBox]

keith-turner opened a new issue #1502: Determine if files are deleted from 
metadata table when using volume.replacements
URL: https://github.com/apache/accumulo/issues/1502
 
 
   It's possible that when a tablet is loading and it replaces volumes that it 
may forget the original strings that are stored in the metadata table.  This 
would cause compactions to not delete the files being compacted from the 
metadata table.  Not completely sure if this is the case, opening this issue to 
investigate.  Noticed this while reviewing #1501


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [accumulo] keith-turner commented on a change in pull request #1501: Use TabletFile for Tablet, Scans and compaction

[GitBox]

keith-turner commented on a change in pull request #1501: Use TabletFile for 
Tablet, Scans and compaction
URL: https://github.com/apache/accumulo/pull/1501#discussion_r377342835
 
 

 ##
 File path: 
server/base/src/main/java/org/apache/accumulo/server/fs/VolumeUtil.java
 ##
 @@ -159,14 +160,14 @@ public static TabletFiles 
updateTabletVolumes(ServerContext context, ZooLock zoo
   }
 }
 
-for (Entry entry : 
tabletFiles.datafiles.entrySet()) {
-  String metaPath = entry.getKey().meta().toString();
+for (Entry entry : 
tabletFiles.datafiles.entrySet()) {
+  String metaPath = entry.getKey().getNormalizedPath();
   Path switchedPath = switchVolume(metaPath, FileType.TABLE, replacements);
   if (switchedPath != null) {
 filesToRemove.add(entry.getKey());
-FileRef switchedRef = new FileRef(switchedPath.toString(), 
switchedPath);
-filesToAdd.put(switchedRef, entry.getValue());
-ret.datafiles.put(switchedRef, entry.getValue());
+TabletFile switchedFile = new TabletFile(switchedPath, 
switchedPath.toString());
 
 Review comment:
   I was looking at the code and it seems like there may be an existing bug.  I 
opened #1501


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Accumulo-Master - Build # 3016 - Still Unstable

[Apache Jenkins Server]

The Apache Jenkins build system has built Accumulo-Master (build #3016)

Status: Still Unstable

Check console output at https://builds.apache.org/job/Accumulo-Master/3016/ to 
view the results.

[GitHub] [accumulo] milleruntime commented on issue #1488: ManyWriteAheadLogsIT is flakey

[GitBox]

milleruntime commented on issue #1488: ManyWriteAheadLogsIT is flakey
URL: https://github.com/apache/accumulo/issues/1488#issuecomment-584344043
 
 
   This test is passing for me in master branch.


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [accumulo] Manno15 commented on a change in pull request #1453: Update Last Location. Solution for #1169

[GitBox]

Manno15 commented on a change in pull request #1453: Update Last Location. 
Solution for #1169
URL: https://github.com/apache/accumulo/pull/1453#discussion_r377224453
 
 

 ##
 File path: 
server/tserver/src/main/java/org/apache/accumulo/tserver/TabletServer.java
 ##
 @@ -2523,6 +2523,12 @@ public void run() {
 Assignment assignment = new Assignment(extent, getTabletSession());
 TabletStateStore.setLocation(getContext(), assignment);
 
 Review comment:
   This method seems to work pretty well. There are some instances where it is 
brought back up in a slightly unbalanced state but it is very minimal. Taking 
that and performance into consideration, this method is probably the most ideal 
option all around. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

[GitHub] [accumulo] milleruntime commented on issue #1486: Broken SplitRecoveryIT

[GitBox]

milleruntime commented on issue #1486: Broken SplitRecoveryIT
URL: https://github.com/apache/accumulo/issues/1486#issuecomment-584184862
 
 
   This should be fixed when #1501 is merged. I think this was a case where 
TabletFile was used for part of the code, mismatching types and caused the 
ImmutableMap to fail. 


This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services