[GitHub] [accumulo-website] gramhagen opened a new pull request #224: fixing typo in masc blog
gramhagen opened a new pull request #224: fixing typo in masc blog URL: https://github.com/apache/accumulo-website/pull/224 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] ctubbsii commented on a change in pull request #1537: Add PrintInfo options to dump full keys, apply formatter
ctubbsii commented on a change in pull request #1537: Add PrintInfo options to
dump full keys, apply formatter
URL: https://github.com/apache/accumulo/pull/1537#discussion_r385477423
##
File path:
core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java
##
@@ -119,6 +182,18 @@ public String keyword() {
return "rfile-info";
}
+ protected Class getFormater(String formatterClazz) {
+try {
+ if (formatterClazz != null) {
+return this.getClass().getClassLoader().loadClass(formatterClazz)
+.asSubclass(Formatter.class);
+ }
+} catch (ClassNotFoundException e) {
+ System.err.println("Could not find formatter class: " + formatterClazz);
+}
+return null;
+ }
+
Review comment:
I think this will work fine in Java 11, since it uses the class loader of
the current class, and not the system class loader.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] EdColeman commented on a change in pull request #1537: Add PrintInfo options to dump full keys, apply formatter
EdColeman commented on a change in pull request #1537: Add PrintInfo options to
dump full keys, apply formatter
URL: https://github.com/apache/accumulo/pull/1537#discussion_r385475020
##
File path:
core/src/main/java/org/apache/accumulo/core/file/rfile/PrintInfo.java
##
@@ -119,6 +182,18 @@ public String keyword() {
return "rfile-info";
}
+ protected Class getFormater(String formatterClazz) {
+try {
+ if (formatterClazz != null) {
+return this.getClass().getClassLoader().loadClass(formatterClazz)
+.asSubclass(Formatter.class);
+ }
+} catch (ClassNotFoundException e) {
+ System.err.println("Could not find formatter class: " + formatterClazz);
+}
+return null;
+ }
+
Review comment:
This is a general question - would this reflection code need to change for
jdk-11+ (for when this is merged forward)? Specifically, is this still the
standard way to use reflection, or has the "standard" changed? From what I've
read it looks okay, but thought it warranted checking.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
Accumulo-Master - Build # 3040 - Unstable
The Apache Jenkins build system has built Accumulo-Master (build #3040) Status: Unstable Check console output at https://builds.apache.org/job/Accumulo-Master/3040/ to view the results.
[GitHub] [accumulo] keith-turner commented on issue #1451: Support external compactions in containers
keith-turner commented on issue #1451: Support external compactions in containers URL: https://github.com/apache/accumulo/issues/1451#issuecomment-592255829 An alternative approach : apache/accumulo-website#223 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo-website] keith-turner opened a new pull request #223: Adds a design document for external compactions
keith-turner opened a new pull request #223: Adds a design document for external compactions URL: https://github.com/apache/accumulo-website/pull/223 In a conversation with @ctubbsii one day he asked me if a distributed queue could be used instead of the approach proposed in #1451. A few weeks later I brought this up in a discussion with @billierinaldi and we worked out a possible way to do this on a whiteboard. This document captures that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] drewfarris opened a new pull request #1537: Add PrintInfo options to dump full keys, apply formatter
drewfarris opened a new pull request #1537: Add PrintInfo options to dump full keys, apply formatter URL: https://github.com/apache/accumulo/pull/1537 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] EdColeman opened a new pull request #1536: Improve master metrics rported via hadoop metrics
EdColeman opened a new pull request #1536: Improve master metrics rported via hadoop metrics URL: https://github.com/apache/accumulo/pull/1536 Adds FATE transaction state and op types Improves metrics tests Add IT to verify that enabling legacy metrics does not crash master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] asfgit closed issue #1532: Class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration
asfgit closed issue #1532: Class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration URL: https://github.com/apache/accumulo/issues/1532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] ctubbsii commented on issue #1532: Class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration
ctubbsii commented on issue #1532: Class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration URL: https://github.com/apache/accumulo/issues/1532#issuecomment-592144911 Fixed in 3779cf9de0a286d951f0bd92553edb345f1ada8e This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] lbschanno commented on a change in pull request #1518: Fix #1430 Enforce table name limit for new tables
lbschanno commented on a change in pull request #1518: Fix #1430 Enforce table
name limit for new tables
URL: https://github.com/apache/accumulo/pull/1518#discussion_r385329687
##
File path: test/src/main/java/org/apache/accumulo/test/TableOperationsIT.java
##
@@ -189,6 +190,18 @@ public void createTable() throws TableExistsException,
AccumuloException,
accumuloClient.tableOperations().delete(tableName);
}
+ @Test(expected = IllegalArgumentException.class)
+ public void createTableWithTableNameLengthLimit()
+ throws AccumuloException, AccumuloSecurityException,
TableExistsException {
+StringBuilder tableNameBuilder = new StringBuilder();
+for (int i = 0; i <= MAX_TABLE_NAME_LEN; i++) {
+ tableNameBuilder.append('a');
+}
+String tableName = tableNameBuilder.toString();
+accumuloClient.tableOperations().create(tableName);
+assertTrue(!accumuloClient.tableOperations().exists(tableName));
Review comment:
```suggestion
assertFalse(accumuloClient.tableOperations().exists(tableName));
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] lbschanno commented on a change in pull request #1518: Fix #1430 Enforce table name limit for new tables
lbschanno commented on a change in pull request #1518: Fix #1430 Enforce table
name limit for new tables
URL: https://github.com/apache/accumulo/pull/1518#discussion_r385329530
##
File path: test/src/main/java/org/apache/accumulo/test/NamespacesIT.java
##
@@ -191,6 +192,18 @@ public void createTableInMissingNamespace() throws
Exception {
}
}
+ @Test(expected = IllegalArgumentException.class)
+ public void createNamespaceWithNamespaceLengthLimit()
+ throws AccumuloException, AccumuloSecurityException,
NamespaceExistsException {
+StringBuilder namespaceBuilder = new StringBuilder();
+for (int i = 0; i <= MAX_NAMESPACE_LEN; i++) {
+ namespaceBuilder.append('a');
+}
+String namespace = namespaceBuilder.toString();
+c.namespaceOperations().create(namespace);
+assertTrue(!c.namespaceOperations().exists(namespace));
Review comment:
```suggestion
assertFalse(c.namespaceOperations().exists(namespace));
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] lbschanno commented on a change in pull request #1518: Fix #1430 Enforce table name limit for new tables
lbschanno commented on a change in pull request #1518: Fix #1430 Enforce table
name limit for new tables
URL: https://github.com/apache/accumulo/pull/1518#discussion_r385328300
##
File path:
server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java
##
@@ -716,6 +736,24 @@ private void validateArgumentCount(List
arguments, TableOperation op
private String validateNamespaceArgument(ByteBuffer namespaceArg,
TableOperation op,
Validator userValidator) throws ThriftTableOperationException {
String namespace = namespaceArg == null ? null :
ByteBufferUtil.toString(namespaceArg);
+if ((namespace != null) && (namespace.length() > MAX_NAMESPACE_LEN)) {
+ log.warn("Namespaces greater than " + MAX_NAMESPACE_LEN
+ + " characters should be renamed to conform to a 1024 character
limit. "
Review comment:
```suggestion
+ " characters should be renamed to conform to a
"+MAX_NAMESPACE_LEN+" character limit. "
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] lbschanno commented on a change in pull request #1518: Fix #1430 Enforce table name limit for new tables
lbschanno commented on a change in pull request #1518: Fix #1430 Enforce table
name limit for new tables
URL: https://github.com/apache/accumulo/pull/1518#discussion_r385327853
##
File path:
server/master/src/main/java/org/apache/accumulo/master/FateServiceHandler.java
##
@@ -697,10 +699,28 @@ private TableId validateTableIdArgument(ByteBuffer
tableIdArg, TableOperation op
}
}
- // Verify table name arguments are valid, and match any additional
restrictions
+ // Verify older table name arguments are valid, and match any additional
restrictions
private String validateTableNameArgument(ByteBuffer tableNameArg,
TableOperation op,
Validator userValidator) throws ThriftTableOperationException {
String tableName = tableNameArg == null ? null :
ByteBufferUtil.toString(tableNameArg);
+if ((tableName != null) && (tableName.length() > MAX_TABLE_NAME_LEN)) {
+ log.warn("Table names greater than " + MAX_TABLE_NAME_LEN
+ + " characters should be renamed to conform to a 1024 character
limit. "
Review comment:
```suggestion
+ " characters should be renamed to conform to a
"+MAX_TABLE_NAME_LEN+" character limit. "
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] milleruntime opened a new issue #1535: Investigate empty files in Major Compactions
milleruntime opened a new issue #1535: Investigate empty files in Major Compactions URL: https://github.com/apache/accumulo/issues/1535 I noticed while working on #1519 that if a Major compaction produces an empty file that it will still be added to the list of majorCompactingFiles. This happens [here](https://github.com/apache/accumulo/blob/1.9/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L596). This is different from the rest of the code which checks if ```DataFileValue.getNumEntries() > 0```. This file will be deleted towards the beginning of ```bringMajorCompactionOnline()``` [here](https://github.com/apache/accumulo/blob/1.9/server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/DatafileManager.java#L541). The list files is cleared at the end of the MajC but there parts of the code which check the size of the list that this could effect. If there is no reason why we care about an empty file that is already deleted, then this is a bug and the file shouldn't be added to the list. The place were this file is deleted for MajC also seems sub-optimal since we are renaming the file immediately before removing it. Minor compactions will do one or the other. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] milleruntime closed issue #1507: Throw Exception to prevent incorrect metadata
milleruntime closed issue #1507: Throw Exception to prevent incorrect metadata URL: https://github.com/apache/accumulo/issues/1507 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] milleruntime merged pull request #1519: Create StoredTabletFile to use in different situations
milleruntime merged pull request #1519: Create StoredTabletFile to use in different situations URL: https://github.com/apache/accumulo/pull/1519 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] ctubbsii commented on issue #1532: Class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration
ctubbsii commented on issue #1532: Class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration URL: https://github.com/apache/accumulo/issues/1532#issuecomment-592049874 I see. Since we've already dropped support for the legacy metrics in 2.x and upgraded to commons-configuration2, it kind of feels like this backport might be more trouble than it's worth... causing us to revisit already solved issues. If backporting these GC metrics to 1.x is going to cause significant problems that can't easily be worked around, I'm inclined to just revert those changes in 1.x and make people wait until they upgrade to get the new GC metrics if they need them. If it's an easy fix, though... without breaking the legacy metrics in 1.x, that's preferred, of course (best of both worlds, and all that). Is it possible to just throw ant on the class path ourselves (as optional) to fix the problem? And, if that works, we can just tell people they might need ant on their class path to get the feature in 1.x. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] milleruntime commented on issue #1532: Class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration
milleruntime commented on issue #1532: Class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration URL: https://github.com/apache/accumulo/issues/1532#issuecomment-592041713 If this a conflict with the legacy metrics and the GC metrics, we may have to drop the support for legacy metrics if it is polluting the classpath with really old commons-configuration. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] milleruntime commented on issue #1532: Build environment - class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration
milleruntime commented on issue #1532: Build environment - class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration URL: https://github.com/apache/accumulo/issues/1532#issuecomment-592040265 This isn't a build environment issue. I was able to reproduce this error on the command line running the GcMetricsIT and enabling the two properties, ```gc.metrics.enabled``` and ```general.legacy.metrics```. The issue was introduced with the backport of GC_METRICS_ENABLED in the commit 0d7d976085ca06ce0d303151803824386dbc6ad2. There should be a test for this feature as well. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] EdColeman opened a new issue #1532: Build environment - class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration
EdColeman opened a new issue #1532: Build environment - class not found org/apache/tools/ant/taskdefs/Execute - used by commons-configuration URL: https://github.com/apache/accumulo/issues/1532 This is likely something in my environment / tooling but wanted to document what I am seeing in case this is a more general issue with dependencies / java runtime version. Environment: Accumulo: current 1.9 branch (1.9.3+) java: openjdk full version "12.0.1+12" IntelliJ: IntelliJ IDEA 2019.3.3 Build #IU-193.6494.35, built on February 10, 2020 macOS 10.15.3 Trying to run IT tests with legacy metrics enabled causes the master to die with the stack trace below. This happens with the commons-configuration in the pom left at 1.6. Changing the version to 1.10, the tests can be launched / run with the IntelliJ IDE without issue. The release notes for commons-configuration 1.7 references https://issues.apache.org/jira/browse/CONFIGURATION-436 to change the group id for Apache Ant > org.apache.ant is the standard groupId used by the Apache Ant project. Please start using it instead of the ant groupId. Full stack track from the mini Master log: ` java.lang.NoClassDefFoundError: org/apache/tools/ant/taskdefs/Execute at org.apache.commons.configuration.EnvironmentConfiguration.extractProperties14(EnvironmentConfiguration.java:160) at org.apache.commons.configuration.EnvironmentConfiguration.(EnvironmentConfiguration.java:77) at org.apache.accumulo.server.metrics.MetricsConfiguration.getEnvironmentConfiguration(MetricsConfiguration.java:114) at org.apache.accumulo.server.metrics.MetricsConfiguration.loadConfiguration(MetricsConfiguration.java:155) at org.apache.accumulo.server.metrics.MetricsConfiguration.getMetricsConfiguration(MetricsConfiguration.java:145) at org.apache.accumulo.server.metrics.MetricsConfiguration.(MetricsConfiguration.java:108) at org.apache.accumulo.server.metrics.AbstractMetricsImpl.(AbstractMetricsImpl.java:118) at org.apache.accumulo.server.metrics.ThriftMetrics.(ThriftMetrics.java:30) at org.apache.accumulo.server.metrics.MetricsFactory.createThriftMetrics(MetricsFactory.java:46) at org.apache.accumulo.server.rpc.TimedProcessor.(TimedProcessor.java:47) at org.apache.accumulo.server.rpc.TimedProcessor.(TimedProcessor.java:41) at org.apache.accumulo.server.rpc.TServerUtils.startServer(TServerUtils.java:152) at org.apache.accumulo.master.Master.run(Master.java:1382) at org.apache.accumulo.master.Master.main(Master.java:1664) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:567) at org.apache.accumulo.start.Main$2.run(Main.java:170) at java.base/java.lang.Thread.run(Thread.java:835) Caused by: java.lang.ClassNotFoundException: org.apache.tools.ant.taskdefs.Execute at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:583) at java.base/jdk.internal.loader.ClassLoaders$AppClassLoader.loadClass(ClassLoaders.java:178) at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:521) ... 20 more ` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo-website] ctubbsii merged pull request #222: Add eisber/Markus Cozowicz to contributor
ctubbsii merged pull request #222: Add eisber/Markus Cozowicz to contributor URL: https://github.com/apache/accumulo-website/pull/222 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] milleruntime commented on issue #1507: Throw Exception to prevent incorrect metadata
milleruntime commented on issue #1507: Throw Exception to prevent incorrect metadata URL: https://github.com/apache/accumulo/issues/1507#issuecomment-591999750 Yes it is almost completed in #1519. Thanks for the ping though I had forgotten I created an issue! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] cradal commented on issue #1507: Throw Exception to prevent incorrect metadata
cradal commented on issue #1507: Throw Exception to prevent incorrect metadata URL: https://github.com/apache/accumulo/issues/1507#issuecomment-591983733 @milleruntime Hello. I was looking at this issue as my possible next task, but I see some things which indicate some work might have already been done. For example, the metadataEntry field in TabletFile errors out if an attempt is made to instantiate it with a null metadataEntry. Hence, it seems that any call to getMetaDataEntry() will return something. Also, getMetadataEntry() is already being called on createDeleteMutation and minor/major compactions. Has this issue already been worked? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] Manno15 commented on issue #1453: Update Last Location. Solution for #1169
Manno15 commented on issue #1453: Update Last Location. Solution for #1169 URL: https://github.com/apache/accumulo/pull/1453#issuecomment-591979867 I removed setting last location after compactions. I am going to test out clearing out previous last locations on assignment so I haven't pushed those changes yet. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] milleruntime opened a new issue #1534: GarbageCollectorIT.gcLotsOfCandidatesIT failure
milleruntime opened a new issue #1534: GarbageCollectorIT.gcLotsOfCandidatesIT failure URL: https://github.com/apache/accumulo/issues/1534 The GarbageCollectorIT is currently failing, specifically gcLotsOfCandidatesIT is timing out. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] milleruntime opened a new issue #1533: Convert Translators to lambdas
milleruntime opened a new issue #1533: Convert Translators to lambdas URL: https://github.com/apache/accumulo/issues/1533 The custom paramaterized classes [Translators](https://github.com/apache/accumulo/blob/master/core/src/main/java/org/apache/accumulo/core/clientImpl/Translators.java) and [Translator](https://github.com/apache/accumulo/blob/master/core/src/main/java/org/apache/accumulo/core/clientImpl/Translator.java) can now be replaced with Java built in Lambda functions. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] [accumulo] milleruntime commented on a change in pull request #1519: Create StoredTabletFile to use in different situations
milleruntime commented on a change in pull request #1519: Create
StoredTabletFile to use in different situations
URL: https://github.com/apache/accumulo/pull/1519#discussion_r385124570
##
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/Translator.java
##
@@ -103,7 +104,14 @@ public TRange translate(Range input) {
public static class TabletFileTranslator extends
Translator {
@Override
public String translate(TabletFile input) {
- return input.getMetadataEntry();
+ return input.getPathStr();
+}
+ }
+
+ public static class StoredTabletFileTranslator extends
Translator {
+@Override
+public String translate(StoredTabletFile input) {
+ return input.getPathStr();
Review comment:
Opened #1533
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo-website] gramhagen commented on issue #221: MASC blog post
gramhagen commented on issue #221: MASC blog post URL: https://github.com/apache/accumulo-website/pull/221#issuecomment-591914309 Looks great. Thanks for the help @ctubbsii and @keith-turner! You can mention @gramhagen in the tweet if you like. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
