[jira] [Commented] (ACCUMULO-2844) Remove master/slave terminology
[ https://issues.apache.org/jira/browse/ACCUMULO-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17137921#comment-17137921 ] Christopher Tubbs commented on ACCUMULO-2844: - [~phrocker], you are commenting on a closed issue, and we no longer use JIRA to track issues. If there is more to work regarding this, please consider opening a discussion on the mailing list or opening a new GitHub issue for specific work. > Remove master/slave terminology > --- > > Key: ACCUMULO-2844 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2844 > Project: Accumulo > Issue Type: Task >Affects Versions: 1.5.0, 1.5.1, 1.6.0 >Reporter: Sean Busbey >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > I'd like to remove our use of master/slave terminology in favor of something > that doesn't carry a racially charged meaning. > As a side effect I'd also like to pick names that carry better meaning of how > things work within Accumulo. > In the case of a single cluster, I'd like to > * Change the Master role to Coordinator > * Change the associated master server package to coordinator > * Change the master configuration file to be named coordinators > * Change the slaves configuration file to be named tservers > In the case of the in-progress replication work I'd like to change > terminology: > * use _Primary Cluster_ in place of _Master Cluster_ > * use _Replica Clusters_ in place of _Slave Clusters_ > I intend to do this in all active branches in a way that maintains > compatibility of existing configuration files and serialized actions (i.e. > fate operations) within their major branch. In the current unreleased major > branch I expect upgrading will require user action (e.g. renaming > configuration files). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [accumulo] keith-turner commented on a change in pull request #1605: Fixes #564 adds support multiple compaction executors
keith-turner commented on a change in pull request #1605: URL: https://github.com/apache/accumulo/pull/1605#discussion_r441058243 ## File path: core/src/main/java/org/apache/accumulo/core/client/admin/ActiveCompaction.java ## @@ -35,9 +35,9 @@ */ MINOR, /** - * compaction to flush a tablets memory and merge it with the tablets smallest file. This type - * compaction is done when a tablet has too many files + * Accumulo no longer does merging minor compactions. Review comment: Yes This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
Accumulo-Master - Build # 3113 - Unstable
The Apache Jenkins build system has built Accumulo-Master (build #3113) Status: Unstable Check console output at https://builds.apache.org/job/Accumulo-Master/3113/ to view the results.
[GitHub] [accumulo] milleruntime closed issue #1619: Improve Javadoc in new Bulk import API
milleruntime closed issue #1619: URL: https://github.com/apache/accumulo/issues/1619 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #1626: Add javadoc explaining parameter behavior. Closes #1619
milleruntime merged pull request #1626: URL: https://github.com/apache/accumulo/pull/1626 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] milleruntime commented on a change in pull request #1605: Fixes #564 adds support multiple compaction executors
milleruntime commented on a change in pull request #1605:
URL: https://github.com/apache/accumulo/pull/1605#discussion_r440813813
##
File path:
core/src/main/java/org/apache/accumulo/core/client/admin/CompactionConfig.java
##
@@ -21,25 +21,37 @@
import static java.util.Objects.requireNonNull;
import static
org.apache.accumulo.core.clientImpl.CompactionStrategyConfigUtil.DEFAULT_STRATEGY;
-import java.util.ArrayList;
import java.util.Collections;
import java.util.List;
+import java.util.Map;
+import java.util.function.BooleanSupplier;
import org.apache.accumulo.core.client.IteratorSetting;
+import org.apache.accumulo.core.client.admin.compaction.CompactionConfigurer;
+import org.apache.accumulo.core.client.admin.compaction.CompactionSelector;
+import org.apache.accumulo.core.clientImpl.CompactionStrategyConfigUtil;
+import org.apache.accumulo.core.clientImpl.UserCompactionUtils;
import org.apache.hadoop.io.Text;
+import com.google.common.base.Preconditions;
+
/**
* This class exist to pass parameters to {@link
TableOperations#compact(String, CompactionConfig)}
*
* @since 1.7.0
*/
public class CompactionConfig {
+
private Text start = null;
private Text end = null;
private boolean flush = true;
private boolean wait = true;
private List iterators = Collections.emptyList();
+ @SuppressWarnings("removal")
private CompactionStrategyConfig compactionStrategy = DEFAULT_STRATEGY;
+ private Map hints = Map.of();
+ private PluginConfig selectorConfig = UserCompactionUtils.DEFAULT_CSC;
Review comment:
I think these names weren't updated after previous changes.
```suggestion
private PluginConfig selectorConfig = UserCompactionUtils.DEFAULT_SELECTOR;
```
##
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/compaction/EverythingCompactionStrategy.java
##
@@ -22,7 +22,7 @@
* The default compaction strategy for user initiated compactions. This
strategy will always select
* all files.
*/
-
+@SuppressWarnings("removal")
Review comment:
You don't want warnings for this class? It is no longer used with this
change.
##
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##
@@ -646,10 +690,30 @@
"After a tablet has been idle (no mutations) for this time period it may
have its "
+ "in-memory map flushed to disk in a minor compaction. There is no
guarantee an idle "
+ "tablet will be compacted."),
- TABLE_MINC_MAX_MERGE_FILE_SIZE("table.compaction.minor.merge.file.size.max",
"0",
- PropertyType.BYTES,
- "The max RFile size used for a merging minor compaction. The default"
- + " value of 0 disables a max file size."),
+ TABLE_COMPACTION_DISPATCHER("table.compaction.dispatcher",
+ SimpleCompactionDispatcher.class.getName(), PropertyType.CLASSNAME,
+ "A configurable dispatcher that decides what comaction service a table
should use."),
Review comment:
```suggestion
"A configurable dispatcher that decides what compaction service a
table should use."),
```
##
File path:
core/src/main/java/org/apache/accumulo/core/clientImpl/UserCompactionUtils.java
##
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.accumulo.core.clientImpl;
+
+import java.io.ByteArrayInputStream;
+import java.io.ByteArrayOutputStream;
+import java.io.DataInput;
+import java.io.DataInputStream;
+import java.io.DataOutput;
+import java.io.DataOutputStream;
+import java.io.IOException;
+import java.io.UncheckedIOException;
+import java.util.ArrayList;
+import java.util.HashMap;
+import java.util.Map;
+import java.util.Map.Entry;
+
+import org.apache.accumulo.core.client.IteratorSetting;
+import org.apache.accumulo.core.client.admin.CompactionConfig;
+import org.apache.accumulo.core.client.admin.PluginConfig;
+import org.apache.hadoop.io.Text;
+
+import com.google.common.base.Preconditions;
+
+public class UserCompactionUtils {
+
+ private static final int MAGIC = 0x02040810;
+ private static final int SELECTOR_MAGIC = 0xae9270bf;
+ private static final int CONFIGURER_MAGIC = 0xf93e570a;
+
+
[jira] [Comment Edited] (ACCUMULO-2844) Remove master/slave terminology
[ https://issues.apache.org/jira/browse/ACCUMULO-2844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17136024#comment-17136024 ] Marc Parisi edited comment on ACCUMULO-2844 at 6/16/20, 2:46 PM: - I think as situations evolve so do our understandings and opinions. Therefore, [~busbey], do you think this deserves to be re-visited? I do but am curious of your perspective ( I suspect you would given what you've said previously). May be useful to have a follow up that gets others discussing a rename for master. Do you think we should open up a follow up on GH or in slack? was (Author: phrocker): I think as situations evolve so do our understandings and opinions. Therefore, [~busbey], do you think this deserves to be re-visited? I do but am curious of your perspective. May be useful to have a follow up that gets others discussing a rename for master. > Remove master/slave terminology > --- > > Key: ACCUMULO-2844 > URL: https://issues.apache.org/jira/browse/ACCUMULO-2844 > Project: Accumulo > Issue Type: Task >Affects Versions: 1.5.0, 1.5.1, 1.6.0 >Reporter: Sean Busbey >Priority: Major > Fix For: 2.0.0 > > Time Spent: 1h > Remaining Estimate: 0h > > I'd like to remove our use of master/slave terminology in favor of something > that doesn't carry a racially charged meaning. > As a side effect I'd also like to pick names that carry better meaning of how > things work within Accumulo. > In the case of a single cluster, I'd like to > * Change the Master role to Coordinator > * Change the associated master server package to coordinator > * Change the master configuration file to be named coordinators > * Change the slaves configuration file to be named tservers > In the case of the in-progress replication work I'd like to change > terminology: > * use _Primary Cluster_ in place of _Master Cluster_ > * use _Replica Clusters_ in place of _Slave Clusters_ > I intend to do this in all active branches in a way that maintains > compatibility of existing configuration files and serialized actions (i.e. > fate operations) within their major branch. In the current unreleased major > branch I expect upgrading will require user action (e.g. renaming > configuration files). -- This message was sent by Atlassian Jira (v8.3.4#803005)
[GitHub] [accumulo] phrocker commented on a change in pull request #1622: fixes #1621: The ClientPool thread pool allows all core threads to time out
phrocker commented on a change in pull request #1622:
URL: https://github.com/apache/accumulo/pull/1622#discussion_r440832957
##
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##
@@ -452,6 +458,9 @@
"The time to wait for a tablet server to process a bulk import
request."),
TSERV_MINTHREADS("tserver.server.threads.minimum", "20", PropertyType.COUNT,
"The minimum number of threads to use to handle incoming requests."),
+ TSERV_MINTHREADS_ALLOW_TIMEOUT("tserver.server.thread.timeout.allowed",
"false",
+ PropertyType.BOOLEAN,
+ "True if the incoming request threads are allowed to timeout with no
work available."),
Review comment:
minor nit: I think this is a great set of features; however, I had a
question about the wording. "True... if... allowed" made me think another
setting would impact this, but I imagine it is the case that if this is true
then timeouts can occur.
"Allows request threads to time out when no work is available" might be more
clear but @keith-turner spent more time here so he can likely correct me from
his perspective -- and it may be the case that my interpretation is wrong.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [accumulo] phrocker commented on a change in pull request #1622: fixes #1621: The ClientPool thread pool allows all core threads to time out
phrocker commented on a change in pull request #1622:
URL: https://github.com/apache/accumulo/pull/1622#discussion_r440832957
##
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##
@@ -452,6 +458,9 @@
"The time to wait for a tablet server to process a bulk import
request."),
TSERV_MINTHREADS("tserver.server.threads.minimum", "20", PropertyType.COUNT,
"The minimum number of threads to use to handle incoming requests."),
+ TSERV_MINTHREADS_ALLOW_TIMEOUT("tserver.server.thread.timeout.allowed",
"false",
+ PropertyType.BOOLEAN,
+ "True if the incoming request threads are allowed to timeout with no
work available."),
Review comment:
minor nit: I think this is a great set of features; however, I had a
question about the wording. "True... if... allowed" made me think another
setting would impact this, but I imagine it is the case that if this is true
then timeouts can occur.
"Allows request threads to time out when no work is available" might be more
clear but @keith-turner spent more time here so he can likely correct me from
his perspective.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
