[GitHub] [accumulo] keith-turner commented on a change in pull request #1654: Added unit test to exercise bulk import range sanity check code #1618
keith-turner commented on a change in pull request #1654: URL: https://github.com/apache/accumulo/pull/1654#discussion_r454061205 ## File path: core/src/test/java/org/apache/accumulo/core/clientImpl/bulk/BulkImportTest.java ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.clientImpl.bulk; + +import static org.junit.Assert.assertEquals; + +import java.util.SortedMap; +import java.util.TreeMap; + +import org.apache.accumulo.core.clientImpl.bulk.Bulk.FileInfo; +import org.apache.accumulo.core.clientImpl.bulk.Bulk.Files; +import org.apache.accumulo.core.data.TableId; +import org.apache.accumulo.core.dataImpl.KeyExtent; +import org.apache.hadoop.io.Text; +import org.junit.Assert; +import org.junit.Test; + Review comment: I updated to static imports in bc6fdc1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] keith-turner commented on a change in pull request #1632: Fix #1609 dynamically reinitialize compaction services when config ch…
keith-turner commented on a change in pull request #1632:
URL: https://github.com/apache/accumulo/pull/1632#discussion_r454059617
##
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/CompactionManager.java
##
@@ -20,34 +20,89 @@
import java.util.HashMap;
import java.util.Map;
+import java.util.Objects;
import java.util.Set;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit;
+import org.apache.accumulo.core.conf.AccumuloConfiguration;
import org.apache.accumulo.core.conf.Property;
import org.apache.accumulo.core.dataImpl.KeyExtent;
import org.apache.accumulo.core.spi.compaction.CompactionKind;
import org.apache.accumulo.core.spi.compaction.CompactionServiceId;
import org.apache.accumulo.core.spi.compaction.CompactionServices;
-import org.apache.accumulo.core.spi.compaction.DefaultCompactionPlanner;
import org.apache.accumulo.core.util.NamingThreadFactory;
import org.apache.accumulo.fate.util.Retry;
import org.apache.accumulo.server.ServerContext;
-import org.apache.accumulo.tserver.TabletServerResourceManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import com.google.common.collect.Sets;
+
public class CompactionManager {
private static final Logger log =
LoggerFactory.getLogger(CompactionManager.class);
private Iterable compactables;
- private Map services;
+ private volatile Map services;
Review comment:
I am using Map.copyOf() for the maps, so its a volatile pointer to an
immutable map. Whenever its updated the entire map is replaced with another
immutable map. This pattern is good for maps that are concurrently read a lot
and updated infrequently. The internal pointers in concurrent hash map are
volatile, making all operations on the map slower. The internal pointers in an
immutable map are probably not volatile, just our pointer to the entire map is.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Accumulo-Master - Build # 3120 - Fixed
The Apache Jenkins build system has built Accumulo-Master (build #3120) Status: Fixed Check console output at https://builds.apache.org/job/Accumulo-Master/3120/ to view the results.
[GitHub] [accumulo] milleruntime commented on a change in pull request #1632: Fix #1609 dynamically reinitialize compaction services when config ch…
milleruntime commented on a change in pull request #1632:
URL: https://github.com/apache/accumulo/pull/1632#discussion_r453879887
##
File path:
server/tserver/src/main/java/org/apache/accumulo/tserver/compactions/CompactionManager.java
##
@@ -20,34 +20,89 @@
import java.util.HashMap;
import java.util.Map;
+import java.util.Objects;
import java.util.Set;
import java.util.concurrent.LinkedBlockingQueue;
import java.util.concurrent.TimeUnit;
+import org.apache.accumulo.core.conf.AccumuloConfiguration;
import org.apache.accumulo.core.conf.Property;
import org.apache.accumulo.core.dataImpl.KeyExtent;
import org.apache.accumulo.core.spi.compaction.CompactionKind;
import org.apache.accumulo.core.spi.compaction.CompactionServiceId;
import org.apache.accumulo.core.spi.compaction.CompactionServices;
-import org.apache.accumulo.core.spi.compaction.DefaultCompactionPlanner;
import org.apache.accumulo.core.util.NamingThreadFactory;
import org.apache.accumulo.fate.util.Retry;
import org.apache.accumulo.server.ServerContext;
-import org.apache.accumulo.tserver.TabletServerResourceManager;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
+import com.google.common.collect.Sets;
+
public class CompactionManager {
private static final Logger log =
LoggerFactory.getLogger(CompactionManager.class);
private Iterable compactables;
- private Map services;
+ private volatile Map services;
Review comment:
Did you consider using a ConcurrentHashMap here? I see you made the map
volatile, but was wondering if it would help prevent concurrency issues to have
a ConcurrentHashMap as well.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [accumulo] milleruntime merged pull request #1635: Create bulkRename method in VolumeManager
milleruntime merged pull request #1635: URL: https://github.com/apache/accumulo/pull/1635 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] cradal commented on pull request #1654: Added unit test to exercise bulk import range sanity check code #1618
cradal commented on pull request #1654: URL: https://github.com/apache/accumulo/pull/1654#issuecomment-657677277 @keith-turner The test runs fine. Looks good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] cradal commented on a change in pull request #1654: Added unit test to exercise bulk import range sanity check code #1618
cradal commented on a change in pull request #1654: URL: https://github.com/apache/accumulo/pull/1654#discussion_r453765121 ## File path: core/src/test/java/org/apache/accumulo/core/clientImpl/bulk/BulkImportTest.java ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.clientImpl.bulk; + +import static org.junit.Assert.assertEquals; + +import java.util.SortedMap; +import java.util.TreeMap; + +import org.apache.accumulo.core.clientImpl.bulk.Bulk.FileInfo; +import org.apache.accumulo.core.clientImpl.bulk.Bulk.Files; +import org.apache.accumulo.core.data.TableId; +import org.apache.accumulo.core.dataImpl.KeyExtent; +import org.apache.hadoop.io.Text; +import org.junit.Assert; +import org.junit.Test; + Review comment: @keith-turner Try adding this line. Looks like the checkstyle is expecting Assert methods to be static imports. import static org.junit.Assert.assertEquals; This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] cradal commented on a change in pull request #1654: Added unit test to exercise bulk import range sanity check code #1618
cradal commented on a change in pull request #1654: URL: https://github.com/apache/accumulo/pull/1654#discussion_r453765121 ## File path: core/src/test/java/org/apache/accumulo/core/clientImpl/bulk/BulkImportTest.java ## @@ -0,0 +1,106 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.accumulo.core.clientImpl.bulk; + +import static org.junit.Assert.assertEquals; + +import java.util.SortedMap; +import java.util.TreeMap; + +import org.apache.accumulo.core.clientImpl.bulk.Bulk.FileInfo; +import org.apache.accumulo.core.clientImpl.bulk.Bulk.Files; +import org.apache.accumulo.core.data.TableId; +import org.apache.accumulo.core.dataImpl.KeyExtent; +import org.apache.hadoop.io.Text; +import org.junit.Assert; +import org.junit.Test; + Review comment: @keith-turner Try adding this line. Looks like the checkstyle is execting Assert methods to be static imports. import static org.junit.Assert.assertEquals; This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] milleruntime commented on issue #1618: Investigate TODO in exception message in new Bulk Import
milleruntime commented on issue #1618: URL: https://github.com/apache/accumulo/issues/1618#issuecomment-657547239 Thanks @keith-turner and @cradal for figuring this out! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Created] (ACCUMULO-4870) 洪洞县花呗提现
xiaojian created ACCUMULO-4870: -- Summary: 洪洞县花呗提现 Key: ACCUMULO-4870 URL: https://issues.apache.org/jira/browse/ACCUMULO-4870 Project: Accumulo Issue Type: New Feature Components: client Environment: 洪洞县花呗提现【联系/薇信:18502021565】 Reporter: xiaojian 洪洞县花呗提现【联系/薇信:18502021565】 -- This message was sent by Atlassian Jira (v8.3.4#803005)
