[GitHub] [accumulo-docker] ddanielr commented on issue #29: Verify the accumulo-docker is registered under Apache OSS program
ddanielr commented on issue #29:
URL: https://github.com/apache/accumulo-docker/issues/29#issuecomment-1473087194
Organization Details
The [Apache Software Foundation user](https://hub.docker.com/u/apache) in
Dockerhub has 231 repositories currently listed under it and is identified as a
"Sponsored OSS" user. This means it falls under the [Docker-Sponsored Open
Source (DSOS)](https://www.docker.com/community/open-source/application/)
program and is exempt from the Free Team Org sunsetting.
>Docker continues to offer a specific Docker-Sponsored Open Source (DSOS)
program
>for open source projects, and it is not affected by the sunsetting of Free
Team
>organizations.
https://web.docker.com/rs/790-SSB-375/images/privatereposfaq.pdf
Since ASF has an apache dockerhub user, it should own the `apache/` org
prefix on dockerhub.
DockerHub Registration
Looking at Infra tickets, the registration process seems to be just
submitted a ticket to ASF Infra with the request to create a dockerhub repo of
`apache/accumulo`
https://issues.apache.org/jira/browse/INFRA-20220
https://issues.apache.org/jira/browse/INFRA-16647
Individual dockerhub users can be added to the push permissions as well.
https://issues.apache.org/jira/browse/INFRA-18167
This process matches up with the Docker Hub use policy for ASF Infra, which
mentions limited seats for DockerHub access.
https://infra.apache.org/docker-hub-policy.html
I can't find an infra ticket requesting a dockerhub project be created for
accumulo. And `apache/accumulo` is not currently listed on dockerhub.
So, I think the next step is submitting an Infra ticket for creation of the
`apache/accumulo` dockerhub repo.
As I'm not an ASF committer yet, I don't have a JIRA login for submitting
the Infra ticket. But if someone else can do that step then I think we can
proceed.
This is all separate from actually releasing a docker image and pushing it
to the repository.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on a diff in pull request #3219: Use AtomicInteger for index pointers in SeekableByteArrayInputStream
ctubbsii commented on code in PR #3219:
URL: https://github.com/apache/accumulo/pull/3219#discussion_r1139350080
##
core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/SeekableByteArrayInputStream.java:
##
@@ -124,26 +145,24 @@ public void close() throws IOException {}
public SeekableByteArrayInputStream(byte[] buf) {
requireNonNull(buf, "bug argument was null");
this.buffer = buf;
-this.cur = 0;
this.max = buf.length;
}
public SeekableByteArrayInputStream(byte[] buf, int maxOffset) {
requireNonNull(buf, "bug argument was null");
this.buffer = buf;
-this.cur = 0;
this.max = maxOffset;
}
public void seek(int position) {
if (position < 0 || position >= max) {
throw new IllegalArgumentException("position = " + position + "
maxOffset = " + max);
}
-this.cur = position;
+this.cur.set(position);
}
public int getPosition() {
-return this.cur;
+return this.cur.get();
}
byte[] getBuffer() {
Review Comment:
I think we can merge it as-is. The leak of the byte array is a problem
unchanged by this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [accumulo] ctubbsii commented on issue #3198: FileManager.filePermits semaphore is unfair, blocking scans under high load
ctubbsii commented on issue #3198: URL: https://github.com/apache/accumulo/issues/3198#issuecomment-1472723310 I added 2.1.1 as a version in which this is fixed, since the fix for this will appear in both the 1.10.3 and the 2.1.1 patch releases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo-docker] ctubbsii commented on issue #29: Verify the accumulo-docker is registered under Apache OSS program
ctubbsii commented on issue #29: URL: https://github.com/apache/accumulo-docker/issues/29#issuecomment-1472672605 We've never attempted to publish this to DockerHub. And, we should not do so, except for ASF-released versions of the contents of this repository. An ASF release requires a PMC vote, and that release needs to occur before we can publish anything from this to DockerHub. However, we can at least verify that we're registered properly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[jira] [Resolved] (ACCUMULO-1949) Tablet server does not track tablet memory usage during recovery
[ https://issues.apache.org/jira/browse/ACCUMULO-1949?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christopher Tubbs resolved ACCUMULO-1949. - Resolution: Not A Problem As far as I can tell, this doesn't seem to have been a problem since this issue was created. Closing this stale issue. If this is still a desired feature, please open a new issue or PR at https://github.com/apache/accumulo > Tablet server does not track tablet memory usage during recovery > > > Key: ACCUMULO-1949 > URL: https://issues.apache.org/jira/browse/ACCUMULO-1949 > Project: Accumulo > Issue Type: Bug >Reporter: Keith Turner >Priority: Major > > It seems like the tablet server does not track memory usage of a tablet thats > recovering. The following is an example situation I am thinking of. > # Tablet server is hosting tablets that are using a alot of memory > # Tablet server is asked to load a tablet the needs recovery > # Tablet server recovers tablet and load a lot of data into memory, this > exceeds amount of memory tablet server should use. -- This message was sent by Atlassian Jira (v8.20.10#820010)
[GitHub] [accumulo] dlmarion opened a new issue, #3243: Metrics: Emit metric when server is low on memory
dlmarion opened a new issue, #3243: URL: https://github.com/apache/accumulo/issues/3243 Each server process extends `AbstractServer` and calls `MetricsUtil.initializeProducers()` passing in a list of `MetricsProducer` implementations. Modify `AbstractServer` to also implement `MetricsProducer` and modify the calls to `MetricsUtil.initializeProducers()` to include `this`. I'm thinking that the metric should be a Gauge with either the value of 0 or 1, which will allow a downstream metric collector to determine how many servers of a given type of running low on memory. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] DomGarguilo commented on a diff in pull request #3219: Use AtomicInteger for index pointers in SeekableByteArrayInputStream
DomGarguilo commented on code in PR #3219:
URL: https://github.com/apache/accumulo/pull/3219#discussion_r1139163864
##
core/src/main/java/org/apache/accumulo/core/file/blockfile/impl/SeekableByteArrayInputStream.java:
##
@@ -124,26 +145,24 @@ public void close() throws IOException {}
public SeekableByteArrayInputStream(byte[] buf) {
requireNonNull(buf, "bug argument was null");
this.buffer = buf;
-this.cur = 0;
this.max = buf.length;
}
public SeekableByteArrayInputStream(byte[] buf, int maxOffset) {
requireNonNull(buf, "bug argument was null");
this.buffer = buf;
-this.cur = 0;
this.max = maxOffset;
}
public void seek(int position) {
if (position < 0 || position >= max) {
throw new IllegalArgumentException("position = " + position + "
maxOffset = " + max);
}
-this.cur = position;
+this.cur.set(position);
}
public int getPosition() {
-return this.cur;
+return this.cur.get();
}
byte[] getBuffer() {
Review Comment:
It looks like this is only used in one place.
`SeekableByteArrayInputStream.getBuffer()` is used in
`CachableBlockFile.CachedBlockRead.getBuffer()` which is only called in
`MultiLevelIndex.IndexBlock.readFields()`. There is a comment that says `this
block is cached, so avoid copy` in `readFields()` so making a copy to avoid
altering the original buffer might not be an option here. As far as I can tell
though, the byte[] returned by `getBuffer()` is never altered, only read, so it
might not be an issue in the current code. Would be nice to make it immutable
but there is no immutable byte array in java.
I'm not too sure how your concern should be addressed @ctubbsii. Do you have
any ideas? If not do you think this PR is ready to merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [accumulo-docker] ddanielr commented on issue #29: Verify the accumulo-docker is registered under Apache OSS program
ddanielr commented on issue #29: URL: https://github.com/apache/accumulo-docker/issues/29#issuecomment-1472380082 I can do this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] dlmarion merged pull request #3241: Fix conditional in LowMemoryDetector
dlmarion merged PR #3241: URL: https://github.com/apache/accumulo/pull/3241 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] dlmarion closed issue #3240: LowMemoryDetector check incorrect
dlmarion closed issue #3240: LowMemoryDetector check incorrect URL: https://github.com/apache/accumulo/issues/3240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] dlmarion opened a new issue, #3242: Compact command creates fate operation for offline table
dlmarion opened a new issue, #3242: URL: https://github.com/apache/accumulo/issues/3242 **Describe the bug** The `compact` command will successfully create a fate operation to compact an offline table (the fate operation will eventually fail). I found this while testing the ondemand tables as I expected it to fail. For example, when I run a `merge` or `addsplits` operations against an offline table, I get the error: ``` [shell.Shell] ERROR: org.apache.accumulo.core.client.TableOfflineException: Table test (3) is offline ``` **Versions (OS, Maven, Java, and others, as appropriate):** - Affected version(s) of this project: 3.0, probable that 1.10 and 2.1 are affected as well **To Reproduce** ``` createtable test offline test addsplits m -t test merge -b a -e z -t test compact -t test ``` **Expected behavior** I would expect the shell to return: ``` [shell.Shell] ERROR: org.apache.accumulo.core.client.TableOfflineException: Table test (3) is offline ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3221: Do not calculate split point in Tablet.needsSplit()
dlmarion commented on PR #3221: URL: https://github.com/apache/accumulo/pull/3221#issuecomment-1472090682 Full IT build passed successfully. @keith-turner - Do you think we should wait to merge this until you have the follow-on ready? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo-docker] EdColeman opened a new issue, #29: Verify the accumulo-docker is registered under Apache OSS program
EdColeman opened a new issue, #29: URL: https://github.com/apache/accumulo-docker/issues/29 Docker may be changing registration requirements or process relating to organizations with publishing artifacts in DockerHub. Accumulo docker is likely covered under the Apache umbrella. Check that accumulo-docker is properly registered as an Apache project, and if not, complete the necessary registration process for DockerHub. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] dlmarion opened a new pull request, #3241: Fix conditional in LowMemoryDetector
dlmarion opened a new pull request, #3241: URL: https://github.com/apache/accumulo/pull/3241 The check was executing the action before returning whether or not the server was running low on memory. For actions that included a wait, this would cause those processes to wait unnecessarily. This changes the method such that the action is only executed if the server is running low on memory Closes #3240 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
