[GitHub] [accumulo] dlmarion commented on pull request #3189: Add group argument to server processes
dlmarion commented on PR #3189: URL: https://github.com/apache/accumulo/pull/3189#issuecomment-1429658915 Another Full IT build passed. I believe I resolved all issues. I'm going to merge this morning. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3189: Add group argument to server processes
dlmarion commented on PR #3189: URL: https://github.com/apache/accumulo/pull/3189#issuecomment-1428518639 > It may help if the internal representations of the lock data were more encapsulated so that the storage type was not visible outside of the LockData Can you be more specific about what you think should be changed? The storage type is a JSON string. The only serialization / deserialization that happens is inside of ServiceLockData. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3189: Add group argument to server processes
dlmarion commented on PR #3189: URL: https://github.com/apache/accumulo/pull/3189#issuecomment-1428512631 Full IT build passed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3189: Add group argument to server processes
dlmarion commented on PR #3189: URL: https://github.com/apache/accumulo/pull/3189#issuecomment-1426166049 Created #3192 to remove arguments from the server processes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3189: Add group argument to server processes
dlmarion commented on PR #3189: URL: https://github.com/apache/accumulo/pull/3189#issuecomment-1422704728 Considering the information about the configuration, I think I'll work on a PR to get rid of server process arguments, and replace them with properties. Then, once that is merged in, I can update this PR which should just be the ServiceLockData changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [accumulo] dlmarion commented on pull request #3189: Add group argument to server processes
dlmarion commented on PR #3189: URL: https://github.com/apache/accumulo/pull/3189#issuecomment-1421525073 > I like the changes to the ServiceLockData abstraction. I think that's a useful change on its own. After that change is done, I think the changes to add the service group are probably relatively minimal, so it's probably okay (meaning, I think I'd be in favor), but I'd like to see what this PR looks like after the ServiceLockData abstraction is done first, without the addition of the group. Would you be willing to do that? Yes, I would be willing to do that. However, if the ServiceLockData object doesn't support the [group](https://github.com/apache/accumulo/blob/main/server/tserver/src/main/java/org/apache/accumulo/tserver/ScanServer.java#L340), then that will break the [client](https://github.com/apache/accumulo/blob/main/core/src/main/java/org/apache/accumulo/core/clientImpl/ClientContext.java#L409) and likely break the build. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@accumulo.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
