[GitHub] [accumulo] keith-turner commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable
keith-turner commented on a change in pull request #1569: Fixes #1464 -
SimpleThreadPool for importtable
URL: https://github.com/apache/accumulo/pull/1569#discussion_r397901620
##
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##
@@ -248,9 +248,16 @@
"The number of threads to use when coordinating a bulk import."),
MASTER_BULK_TIMEOUT("master.bulk.timeout", "5m", PropertyType.TIMEDURATION,
"The time to wait for a tablet server to process a bulk import request"),
+ MASTER_RENAME_THREADS("master.rename.threadpool.size", "20",
PropertyType.COUNT,
+ "The number of threads to use when renaming user files during table
import or bulk ingest."),
+ @Deprecated
+ @ReplacedBy(property = MASTER_RENAME_THREADS)
MASTER_BULK_RENAME_THREADS("master.bulk.rename.threadpool.size", "20",
PropertyType.COUNT,
"The number of threads to use when moving user files to bulk ingest "
+ "directories under accumulo control"),
+
MASTER_IMPORTTABLE_RENAME_THREADS("master.importtable.rename.threadpool.size",
"20",
Review comment:
Can this be removed?
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] keith-turner commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable
keith-turner commented on a change in pull request #1569: Fixes #1464 -
SimpleThreadPool for importtable
URL: https://github.com/apache/accumulo/pull/1569#discussion_r397903548
##
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##
@@ -248,9 +248,16 @@
"The number of threads to use when coordinating a bulk import."),
MASTER_BULK_TIMEOUT("master.bulk.timeout", "5m", PropertyType.TIMEDURATION,
"The time to wait for a tablet server to process a bulk import request"),
+ MASTER_RENAME_THREADS("master.rename.threadpool.size", "20",
PropertyType.COUNT,
+ "The number of threads to use when renaming user files during table
import or bulk ingest."),
+ @Deprecated
+ @ReplacedBy(property = MASTER_RENAME_THREADS)
MASTER_BULK_RENAME_THREADS("master.bulk.rename.threadpool.size", "20",
PropertyType.COUNT,
"The number of threads to use when moving user files to bulk ingest "
Review comment:
Some of the deprecated properties have the following in their description.
I think this is nice for the generated documentation.
```suggestion
"This property is deprecated since 2.1.0. The number of threads to use
when moving user files to bulk ingest "
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
[GitHub] [accumulo] keith-turner commented on a change in pull request #1569: Fixes #1464 - SimpleThreadPool for importtable
keith-turner commented on a change in pull request #1569: Fixes #1464 -
SimpleThreadPool for importtable
URL: https://github.com/apache/accumulo/pull/1569#discussion_r397182330
##
File path: core/src/main/java/org/apache/accumulo/core/conf/Property.java
##
@@ -251,6 +251,9 @@
MASTER_BULK_RENAME_THREADS("master.bulk.rename.threadpool.size", "20",
PropertyType.COUNT,
"The number of threads to use when moving user files to bulk ingest "
+ "directories under accumulo control"),
+
MASTER_IMPORTTABLE_RENAME_THREADS("master.importtable.rename.threadpool.size",
"20",
+ PropertyType.COUNT,
+ "The number of threads to use when renaming user files when importing a
table."),
Review comment:
Could deprecate the bulk.rename prop and have a new
`master.import.rename.threadpool.size`. Could use the
AccumuloConfiguration.resolve() method in the bulk import code to get the
correct property.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
