[GitHub] alerman commented on issue #496: Update formatter codestyle
alerman commented on issue #496: Update formatter codestyle URL: https://github.com/apache/accumulo/issues/496#issuecomment-395489335 Should we just reuse the one from [here](https://github.com/google/styleguide/blob/gh-pages/eclipse-java-google-style.xml). Are there other settings you think should be different then googles? Should we copy this in to our repo, or maybe just sub-tree it so we can get the updates? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alerman commented on issue #496: Update formatter codestyle
alerman commented on issue #496: Update formatter codestyle URL: https://github.com/apache/accumulo/issues/496#issuecomment-395336060 @ctubbsii my mistake. I must have misread the linked document with regards to line wrapping. I hadn't thought about the reasons you gave and you definitely convinced me. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] alerman commented on issue #496: Update formatter codestyle
alerman commented on issue #496: Update formatter codestyle URL: https://github.com/apache/accumulo/issues/496#issuecomment-395169508 +1 the 100 character line wrap seems pretty low and ends up causing a lot of unused space in my IDE This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services