[GitHub] milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor URL: https://github.com/apache/accumulo/pull/289#issuecomment-349452476 Created https://issues.apache.org/jira/browse/ACCUMULO-4756 for this issue This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor URL: https://github.com/apache/accumulo/pull/289#issuecomment-349438276 @glitch I noticed that the getTables validation will fail on all of the accumulo table IDs. The ALPHA_NUM_REGEX doesn't like "+" or the "!0" ID. I am not sure what the best way to fix this would be. We could either add a more complicated regex that will allow the special IDs or change the REST interface to use table names instead of IDs. Thoughts? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor URL: https://github.com/apache/accumulo/pull/289#issuecomment-349086232 Thanks @glitch ! I will merge this This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor URL: https://github.com/apache/accumulo/pull/289#issuecomment-347922436 The Travis build from my commit last night passed: https://travis-ci.org/apache/accumulo/builds/308707934 But it didn't run the ITs. When I run WebViewsIT by itself (mvn clean verify -Dit.test=WebViewsIT -Dtest=foo -Dfindbugs.skip -Dcheckstyle.skip -DfailIfNoTests=false) I get the wrong HTTP status returned in 2 of the tests: ``` WebViewsIT.testGetTablesConstraintViolations:85 should return status 400 expected:<400> but was:<500> WebViewsIT.testGetTracesSummaryValidationConstraint:129 should return status 400 expected:<400> but was:<500> ``` This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor URL: https://github.com/apache/accumulo/pull/289#issuecomment-347916546 > If you have further changes to the WebViews class etc. go ahead and make them and let me know when they are done Nope, good to go! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor URL: https://github.com/apache/accumulo/pull/289#issuecomment-347701597 I think i fixed the dependency issues with test pom with d3cf72f but the WevViewsiT is still failing. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor URL: https://github.com/apache/accumulo/pull/289#issuecomment-347633985 @glitch If you want me to fix the conflicts for you, just let me know. I can check out the PR, squash and merge it all up since your work looks complete. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor URL: https://github.com/apache/accumulo/pull/289#issuecomment-347632590 @glitch Sorry for the conflicts, I had wrapped up ACCUMULO-4739 yesterday but missed a few updates. My changes to WebViews should be isolated to the new method I created though. I will put off the rest of the changes I wanted to make to the Monitor until we can get this merged up. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor URL: https://github.com/apache/accumulo/pull/289#issuecomment-347247307 I thought I saw a comment from @ctubbsii but I don't see it here? Perhaps it was lost in your last rebase... either way, if he is good with this PR, I can merge it. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
[GitHub] milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor
milleruntime commented on issue #289: ACCUMULO-4677 Sanitizing PathParam values in REST-based Monitor URL: https://github.com/apache/accumulo/pull/289#issuecomment-347236790 > I think I may have found some bugs in the monitor itself regarding some of the links (i.e. localhost:9995/tables/ displays tables but the hyperlink path ends with [object Object] +1 For the new ticket you created. I noticed this while working on ACCUMULO-4739 but forgot to create a ticket. Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services
