[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[ https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049715#comment-16049715 ] Josh Elser commented on ACCUMULO-4606: -- bq. I am OK with the accumulo-util script being removed if we add documentation or blog posts for the tasks done by these scripts. However, this work should be done in another ticket. ACCUMULO-4653 > Host scripts are not created by `accumulo-util create-config` > - > > Key: ACCUMULO-4606 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4606 > Project: Accumulo > Issue Type: Bug > Components: scripts >Affects Versions: 2.0.0 >Reporter: Josh Elser > > Not sure if this was an intended divergence from previous, but the generated > configuration files don't include defaults of "localhost" as previous. > [~mikewalch], can you confirm? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049562#comment-16049562
]
Mike Walch commented on ACCUMULO-4606:
--
I am OK with the {{accumulo-util}} script being removed if we add documentation
or blog posts for the tasks done by these scripts. However, this work should
be done in another ticket.
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Affects Versions: 2.0.0
>Reporter: Josh Elser
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049435#comment-16049435
]
Josh Elser commented on ACCUMULO-4606:
--
I think the only one I'd be reticent to remove is {{build-native}}. While it is
trivial in nature, I think the value from generated by it is significant (small
but impactful). I think [~kturner] had once mentioned to me off the cuff how
that script was nice.
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Affects Versions: 2.0.0
>Reporter: Josh Elser
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[ https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049375#comment-16049375 ] Christopher Tubbs commented on ACCUMULO-4606: - Agree that "util" is overloaded and un-descriptive. I took a look at the other commands that the script was responsible for, and I think most of them aren't really needed: * *build-native*: not really needed; this replaces a very simple (untar && make && cp) one-liner which could be in the INSTALL.md * *hadoop-jar*: convenient, but probably not needed as something baked in to Accumulo scripts; only really useful for launching certain MapReduce jobs from the command-line; could be replaced with a blog post explaining how to construct a class path for launching MapReduce jobs * *gen-monitor-cert*: probably not needed; makes a lot of assumptions about keystore creation params and only creates a self-signed cert only useful for testing; a good blog post could replace this and enable users to create better certs * *load-jars-hdfs*: probably not needed; only useful when using vfs classloader; can be replaced with a good blog post, which gives users more ability to understand what they are setting up > Host scripts are not created by `accumulo-util create-config` > - > > Key: ACCUMULO-4606 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4606 > Project: Accumulo > Issue Type: Bug > Components: scripts >Affects Versions: 2.0.0 >Reporter: Josh Elser > > Not sure if this was an intended divergence from previous, but the generated > configuration files don't include defaults of "localhost" as previous. > [~mikewalch], can you confirm? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[ https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16049308#comment-16049308 ] Josh Elser commented on ACCUMULO-4606: -- bq. Move create-config and build-native into the accumulo command and drop accumulo-util bq. Can this be resolved? The create-config command was removed from accumulo-util. I had to re-read the thread (including what I wrote), but I think I still like the idea of one less script. Probably because I think "util" is such an overloaded/un-descriptive word for computering. I'll have to stew on it -- hopefully I'll think of something before a 2.0 release comes out. > Host scripts are not created by `accumulo-util create-config` > - > > Key: ACCUMULO-4606 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4606 > Project: Accumulo > Issue Type: Bug > Components: scripts >Affects Versions: 2.0.0 >Reporter: Josh Elser > > Not sure if this was an intended divergence from previous, but the generated > configuration files don't include defaults of "localhost" as previous. > [~mikewalch], can you confirm? -- This message was sent by Atlassian JIRA (v6.4.14#64029)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16048377#comment-16048377
]
Mike Walch commented on ACCUMULO-4606:
--
Can this be resolved? The {{create-config}} command was removed from
{{accumulo-util}}. The only existence of this command is in
{{accumulo-cluster}} to create the host files needed for the accumulo-cluster
script. This should reduce confusion. See
https://github.com/apache/accumulo/blob/master/INSTALL.md#run-an-accumulo-cluster
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Reporter: Josh Elser
> Fix For: 2.0.0
>
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922991#comment-15922991
]
Christopher Tubbs commented on ACCUMULO-4606:
-
bq. Can you pivot this list into solutions that you would be OK with?
Sure. I'd be okay with:
* Move {{create-config}} and {{build-native}} into the {{accumulo}} command and
drop {{accumulo-util}}, OR
* Leave {{create-config}} and {{build-native}} in {{accumulo-util}} and drop
the rest, OR
* Do nothing, and defer the discussion about whether to drop the other
subcommands to a future date.
Everything else I mentioned is follow-on actions for documentation of whatever
we decide.
I may also be okay with things not in the above list, but I'll consider them
when/if they are proposed.
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Reporter: Josh Elser
> Fix For: 2.0.0
>
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[ https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922799#comment-15922799 ] Josh Elser commented on ACCUMULO-4606: -- bq. My only concerns would be: Can you pivot this list into solutions that you would be OK with? I'm having a hard time translating these concerns into what changes you would be happy with. Aside from the one you presented earlier (dropping move some commands to accumulo and drop the rest from accumulo-util). > Host scripts are not created by `accumulo-util create-config` > - > > Key: ACCUMULO-4606 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4606 > Project: Accumulo > Issue Type: Bug > Components: scripts >Reporter: Josh Elser > Fix For: 2.0.0 > > > Not sure if this was an intended divergence from previous, but the generated > configuration files don't include defaults of "localhost" as previous. > [~mikewalch], can you confirm? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922782#comment-15922782
]
Christopher Tubbs commented on ACCUMULO-4606:
-
> Isn't this just an implementation detail? If we figure that out (some
> subset/category of subcommands that requires an env to be created), that
> sounds like it will pay down on some future debt.
Well, yes. Right now, the dividing line is all of the commands executed by the
{{accumulo}} command (because they are all Java commands, which this script is
wrapping), and none of the commands executed by the {{accumulo-util}} command
(which are all bash utility commands).
Another line dividing them is that everything in {{accumulo}} is required
(because we need a wrapper around the Java commands), and everything in
{{accumulo-util}} is optional (because they may not be needed for your
particular packaging/deployment strategy).
There may be implementation details which break these two ways of dividing
things up... but these two ways are how I currently think about their separate
responsibilities.
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Reporter: Josh Elser
> Fix For: 2.0.0
>
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922754#comment-15922754
]
Josh Elser commented on ACCUMULO-4606:
--
bq. The accumulo command requires the environment and configs to already be set
up
Isn't this just an implementation detail? If we figure that out (some
subset/category of subcommands that requires an env to be created), that sounds
like it will pay down on some future debt.
bq. 'accumulo' script is now very simple wrapper around call to Java.
I can see this being a good argument against it.
bq. Don't forget about 'accumulo-service' which starts/stops each service using
pid files
Oh right. I did forget. I was thinking that {{accumulo}} had subsumed
{{accumulo-service}}. Maybe rolling it into {{accumulo-service}} would make
more sense?
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Reporter: Josh Elser
> Fix For: 2.0.0
>
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[ https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922736#comment-15922736 ] Christopher Tubbs commented on ACCUMULO-4606: - > I think Christopher might have had some additional concerns. My only concerns would be: # bloat in the main command (I don't think those 3 subcommands I mentioned should be part of the main command), # documentation for bootstrapping, and # usage documentation (some commands are pure bash... some are Java, based on self-documenting KeywordExecutables from the classpath... usage for both would need to coalesce nicely) - this one relates to ACCUMULO-4605 > Host scripts are not created by `accumulo-util create-config` > - > > Key: ACCUMULO-4606 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4606 > Project: Accumulo > Issue Type: Bug > Components: scripts >Reporter: Josh Elser > Fix For: 2.0.0 > > > Not sure if this was an intended divergence from previous, but the generated > configuration files don't include defaults of "localhost" as previous. > [~mikewalch], can you confirm? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[ https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922716#comment-15922716 ] Mike Walch commented on ACCUMULO-4606: -- bq. Do you recall what that was? It doesn't seem like something to need to differentiate to me. There was some concern about having some bash script commands (current accumulo-util commands) mixed in with mostly Java commands (current accumulo commands) so they were moved out. For example, the usage for 'accumulo' script is printed by Java but if bash commands are included it will need to print their usage as well. Also, 'accumulo' script is now very simple wrapper around call to Java. Adding bash 'accumulo-util' will complicated the script. bq. Simplifying the command-line "entrypoint" to just two scripts (local and potentially distributed commands) sounds like a very good idea. accumulo and accumulo-cluster sounds like a good idea to me. Don't forget about 'accumulo-service' which starts/stops each service using pid files. I am OK with combining accumulo & accumulo-util so we have 3 scripts: accumulo-cluster, accumulo-service, & accumulo. I think the issues I mentioned about are not a big deal but I think Christopher might have had some additional concerns. > Host scripts are not created by `accumulo-util create-config` > - > > Key: ACCUMULO-4606 > URL: https://issues.apache.org/jira/browse/ACCUMULO-4606 > Project: Accumulo > Issue Type: Bug > Components: scripts >Reporter: Josh Elser > Fix For: 2.0.0 > > > Not sure if this was an intended divergence from previous, but the generated > configuration files don't include defaults of "localhost" as previous. > [~mikewalch], can you confirm? -- This message was sent by Atlassian JIRA (v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922702#comment-15922702
]
Christopher Tubbs commented on ACCUMULO-4606:
-
> Do you recall what that was?
At least one issue is with bootstrapping. The {{accumulo}} command requires the
environment and configs to already be set up. The {{accumulo-util}} command is
a utility script to assist a user creating those configs. I guess it also has
other utility commands.
Personally, I think we can get of the {{hadoop-jar}}, {{gen-monitor-cert}}, and
{{load-jars-hdfs}} subcommands. Those can easily be converted to simple
instructions which we can document. If we get rid of those, the remaining
{{create-config}} and {{build-native}} commands can be rolled in to the
{{accumulo}} command, but it needs to be *well-documented* that these need to
be run before any other commands, in order to set up the user's environment
with the appropriate libs/configs.
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Reporter: Josh Elser
> Fix For: 2.0.0
>
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922685#comment-15922685
]
Josh Elser commented on ACCUMULO-4606:
--
bq. there was some concern about having some bash script commands mixed in with
mostly Java commands so they were moved out
Do you recall what that was? It doesn't seem like something to need to
differentiate to me.
bq. I think we should either move all of accumulo-util commands to accumulo
script
Simplifying the command-line "entrypoint" to just two scripts (local and
potentially distributed commands) sounds like a very good idea. {{accumulo}}
and {{accumulo-cluster}} sounds like a good idea to me.
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Reporter: Josh Elser
> Fix For: 2.0.0
>
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15922681#comment-15922681
]
Mike Walch commented on ACCUMULO-4606:
--
Below are the current commands in accumulo-util. The 'create-config' and
'build-native' commands used to exist in 'accumulo' script. However, there was
some concern about having some bash script commands mixed in with mostly Java
commands so they were moved out. For example, the usage for script is printed
by Java but included usage for bash commands. Also, 'accumulo' script is now
very simple wrapper around call to Java.
As for future direction, I think we should either move all of accumulo-util
commands to accumulo script or leave as is.
{noformat}
$ accumulo-util
'' is an invalid
Usage: accumulo-util ( ...)
Commands:
create-config Creates Accumulo configuration
build-nativeBuilds Accumulo native libraries
hadoop-jar Runs 'hadoop jar' command with Accumulo jars
gen-monitor-certGenerates Accumulo monitor certficate
load-jars-hdfs Loads Accumulo jars in lib/ to HDFS for VFS classloader
{noformat}
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Reporter: Josh Elser
> Fix For: 2.0.0
>
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15919354#comment-15919354
]
Christopher Tubbs commented on ACCUMULO-4606:
-
I could be wrong, but I thought that at least one earlier iteration of
[~mikewalch]'s changes did consolidate the {{accumulo-util}} commands into the
{{accumulo}} script, but that he had rejected it for some reason. I could be
mis-remembering.
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Reporter: Josh Elser
> Fix For: 2.0.0
>
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907907#comment-15907907
]
Josh Elser commented on ACCUMULO-4606:
--
bq. The cluster host files are not generated by 'accumulo-util create-config'.
They are generated by 'accumulo-cluster create-config' as only that script uses
those files
It took me about three times reading this to actually see that there was a
difference in what you wrote :D
Open-ended question: should {{accumulo-util create-config}} exist under
{{accumulo create-config}} instead? I am thinking that since {{accumulo}} is
the localhost sibling to {{accumulo-cluster}} (for "many" nodes), it would make
sense to associate the local config generation to that script (instead of
{{accumulo-util}} which is generic to both standalone or distributed "modes").
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Reporter: Josh Elser
> Fix For: 2.0.0
>
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
[jira] [Commented] (ACCUMULO-4606) Host scripts are not created by `accumulo-util create-config`
[
https://issues.apache.org/jira/browse/ACCUMULO-4606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15907868#comment-15907868
]
Mike Walch commented on ACCUMULO-4606:
--
The cluster host files are not generated by 'accumulo-util create-config'.
They are generated by 'accumulo-cluster create-config' as only that script uses
those files. We wanted to separate generation of Accumulo config files and
host files necessary to manage cluster as Accumulo can be packaged without
'accumulo-cluster' and 'accumulo-service' to encourage use of systemd or init.d
scripts.
{noformat}
$ accumulo-cluster -h
Invalid arguments: '-h' is an invalid
Usage: accumulo-cluster ( ...)
Commands:
create-config Creates cluster config
start Starts Accumulo cluster
stopStops Accumulo cluster
start-non-tservers Starts all services except tservers
start-tservers Starts all tservers on cluster
stop-tservers Stops all tservers on cluster
start-here Starts all services on this node
stop-here Stops all services on this node
{noformat}
> Host scripts are not created by `accumulo-util create-config`
> -
>
> Key: ACCUMULO-4606
> URL: https://issues.apache.org/jira/browse/ACCUMULO-4606
> Project: Accumulo
> Issue Type: Bug
> Components: scripts
>Reporter: Josh Elser
> Fix For: 2.0.0
>
>
> Not sure if this was an intended divergence from previous, but the generated
> configuration files don't include defaults of "localhost" as previous.
> [~mikewalch], can you confirm?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
