[Bug 26453] Exec task displays 'error' mesage "Result: XX"

2024-01-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=26453

Jaikiran Pai  changed:

   What|Removed |Added

   Target Milestone|--- |1.10.15

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 26453] Exec task displays 'error' mesage "Result: XX"

2024-01-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=26453

Jaikiran Pai  changed:

   What|Removed |Added

 Resolution|--- |FIXED
 Status|NEW |RESOLVED

--- Comment #7 from Jaikiran Pai  ---
Hello Chris, I've now pushed a change to the Ant project which will now log
this at INFO level. If you know and have previously built Ant from source then
you can give that a try, else our nightly builds at
https://ci-builds.apache.org/job/Ant/job/Ant_Nightly/ will have the build
artifacts with this change in a while (job number 202 or higher), which you can
give a try.

-- 
You are receiving this mail because:
You are the assignee for the bug.

(ant) branch master updated: add bz-26453 to WHATSNEW

2024-01-02 Thread jaikiran
This is an automated email from the ASF dual-hosted git repository.

jaikiran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ant.git


The following commit(s) were added to refs/heads/master by this push:
 new c737d645f add bz-26453 to WHATSNEW
c737d645f is described below

commit c737d645f984f3fefeff308a9609f86e2cda8e2d
Author: Jaikiran Pai 
AuthorDate: Wed Jan 3 06:15:37 2024 +0530

add bz-26453 to WHATSNEW
---
 WHATSNEW | 11 +++
 1 file changed, 11 insertions(+)

diff --git a/WHATSNEW b/WHATSNEW
index cde56282d..5a9793663 100644
--- a/WHATSNEW
+++ b/WHATSNEW
@@ -1,6 +1,17 @@
 Changes from Ant 1.10.14 TO Ant 1.10.15
 ===
 
+Other changes:
+--
+
+ * exec task now logs the process' non-zero exit code at INFO
+   level instead of the previous ERROR level. The following
+   message from exec task is the one who's level has been changed:
+
+   Result: 1
+
+   Bugzilla Report 26453
+
 Fixed bugs:
 ---
 



(ant) branch master updated: bz-26453 use INFO log level to print the result log message from exec task, when the process returns non-zero exit code

2024-01-02 Thread jaikiran
This is an automated email from the ASF dual-hosted git repository.

jaikiran pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ant.git


The following commit(s) were added to refs/heads/master by this push:
 new f229cdd23 bz-26453 use INFO log level to print the result log message 
from exec task, when the process returns non-zero exit code
f229cdd23 is described below

commit f229cdd233da9d7e9f7d1f93da98f506afc7313e
Author: Jaikiran Pai 
AuthorDate: Wed Jan 3 06:10:50 2024 +0530

bz-26453 use INFO log level to print the result log message from exec task, 
when the process returns non-zero exit code
---
 src/main/org/apache/tools/ant/taskdefs/ExecTask.java | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/main/org/apache/tools/ant/taskdefs/ExecTask.java 
b/src/main/org/apache/tools/ant/taskdefs/ExecTask.java
index eebf6ae12..5657134b9 100644
--- a/src/main/org/apache/tools/ant/taskdefs/ExecTask.java
+++ b/src/main/org/apache/tools/ant/taskdefs/ExecTask.java
@@ -674,7 +674,7 @@ public class ExecTask extends Task {
 throw new BuildException(getTaskType() + " returned: "
 + returnCode, getLocation());
 }
-log("Result: " + returnCode, Project.MSG_ERR);
+log("Result: " + returnCode, Project.MSG_INFO);
 }
 } else {
 exe.spawn();



[Bug 26453] Exec task displays 'error' mesage "Result: XX"

2024-01-02 Thread bugzilla
https://bz.apache.org/bugzilla/show_bug.cgi?id=26453

--- Comment #6 from Chris Fairman  ---
(In reply to Jaikiran Pai from comment #5)
> > Does that help your use case?
> 
> Just to be clear, what I meant was, if we did do that change in the Ant code
> to move that log message to INFO level, would that help you?


Hey Jaikiran!

Sorry for the late reply!

I think making that change is reasonable.

I'd be happy to test/confirm once the change is in place.

Let me know,
-Chris

-- 
You are receiving this mail because:
You are the assignee for the bug.