DO NOT REPLY [Bug 45902] Up-to-date checks for JARs broken due to comparison of dir timestamps

2009-07-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45902





--- Comment #8 from Stefan Bodewig bode...@apache.org  2009-07-15 03:32:57 
PST ---
svn revision 794215 ( https://svn.apache.org/viewcvs.cgi?view=revrev=794215 ) 
should fix the dir timestamp issue for all except for the
same directory comes from multiple sources case - which we have in our
AntUnit test so it still fails.

The problem with directories from multiple sources is that Ant only adds the
first directory encountered - and now preserves that timestamp - but may later
find there are more recent directories in other places.

The way I intend to work on this is to perform some global sort on all
directory resources making sure they get added in the right order and only the
most recent timestamps get recorded - this is going to take some additional
plumbing.

The same issue could come up with file timestamps but is less likely o happen
since archives with multiple entries for the same file are less common (and you
get a warning message in verbose mode anyway).

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45902] Up-to-date checks for JARs broken due to comparison of dir timestamps

2009-07-15 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45902


Stefan Bodewig bode...@apache.org changed:

   What|Removed |Added

 Status|REOPENED|RESOLVED
 Resolution||FIXED




--- Comment #9 from Stefan Bodewig bode...@apache.org  2009-07-15 06:11:36 
PST ---
After coding the logic described in comment #8 I realized it was complicating
the task even more, so I settled with a more humble goal.

svn revision 794255 ( https://svn.apache.org/viewcvs.cgi?view=revrev=794255 ) 
(which will be followed by an extract method refactoring)
will compare file timestamps and recreate the archive if new directories have
been added.  It will record a directories timestamp but not compare it with the
dir timestamps when updating an archive.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45902] Up-to-date checks for JARs broken due to comparison of dir timestamps

2009-05-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45902


Jay Berkenbilt e...@ql.org changed:

   What|Removed |Added

 CC||e...@ql.org




--- Comment #6 from Jay Berkenbilt e...@ql.org  2009-05-25 13:52:27 PST ---
For what it's worth, I think I have a simpler way to reproduce this.

Create a/dir/1 and b/dir/2

Then run ant twice with this build.xml:

project default=default
 target name=default
  jar destfile=a.jar
   fileset dir=a/
   fileset dir=b/
  /jar
 /target
/project

With 1.7.0, the second ant does correctly does nothing.  Verbose output:

  [jar] dir omitted as /home/jberkenb/tmp/z/a.jar:dir/ is up to date.
  [jar] dir/1 omitted as /home/jberkenb/tmp/z/a.jar:dir/1 is up to date.
  [jar] dir omitted as /home/jberkenb/tmp/z/a.jar:dir/ is up to date.
  [jar] dir/2 omitted as /home/jberkenb/tmp/z/a.jar:dir/2 is up to date.

With 1.7.1, the second ant rebuilds:

  [jar] dir omitted as /home/jberkenb/tmp/z/a.jar:dir/ is up to date.
  [jar] dir/1 omitted as /home/jberkenb/tmp/z/a.jar:dir/1 is up to date.
  [jar] dir added as dir/ is outdated.
  [jar] dir/2 omitted as /home/jberkenb/tmp/z/a.jar:dir/2 is up to date.
  [jar] Building jar: /home/jberkenb/tmp/z/a.jar
  [jar] adding directory META-INF/
  [jar] adding entry META-INF/MANIFEST.MF
  [jar] adding directory dir/
  [jar] adding entry dir/1
  [jar] adding entry dir/2

Notice that the second time dir is checked, ant 1.7.1 just says that dir/
is outdated, while ant 1.7.0 reports that /home/jberkenb/tmp/z/a.jar:dir/ is
up to date.

My current directory is /home/jberkenb/tmp/z as I run this

I'm not sure whether this is a manifestation of the same bug, but it would be
great to see if it works with the fix applied to correct this bug.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45902] Up-to-date checks for JARs broken due to comparison of dir timestamps

2009-05-25 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45902





--- Comment #7 from Jay Berkenbilt e...@ql.org  2009-05-25 13:56:11 PST ---
Most likely you can just disregard my comment.  I see the posted test case is
doing the same thing with the multiple jar tasks and creation of
files/directories called from the test case.  My observation is that the
problem happens when the same directory is added from two different filesets. 
I'm not sure that explicit observation is of any use or not.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45902] Up-to-date checks for JARs broken due to comparison of dir timestamps

2009-01-30 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45902


Emmanuel Bourg ebo...@apache.org changed:

   What|Removed |Added

 CC||ebo...@apache.org




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45902] Up-to-date checks for JARs broken due to comparison of dir timestamps

2009-01-29 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45902


Stefan Bodewig bode...@apache.org changed:

   What|Removed |Added

 CC||ken.cor...@hp.com




--- Comment #5 from Stefan Bodewig bode...@apache.org  2009-01-29 07:03:22 
PST ---
*** Bug 29683 has been marked as a duplicate of this bug. ***


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45902] Up-to-date checks for JARs broken due to comparison of dir timestamps

2009-01-28 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45902


Stefan Bodewig bode...@apache.org changed:

   What|Removed |Added

 Status|RESOLVED|REOPENED
 Resolution|FIXED   |




--- Comment #3 from Stefan Bodewig bode...@apache.org  2009-01-28 01:23:06 
PST ---
I have a few issues that I'm going to raise on the dev list.

I've created an AntUnit test from your testcase: svn revision 738412 ( 
https://svn.apache.org/viewcvs.cgi?view=revrev=738412 )


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45902] Up-to-date checks for JARs broken due to comparison of dir timestamps

2009-01-27 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45902


Jesse Glick jgl...@netbeans.org changed:

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution||FIXED
   Target Milestone|--- |1.8.0




--- Comment #2 from Jesse Glick jgl...@netbeans.org  2009-01-27 17:17:41 PST 
---
I think fixed in SVN rev 738330. Reviews welcome.


-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.


DO NOT REPLY [Bug 45902] Up-to-date checks for JARs broken due to comparison of dir timestamps

2008-09-26 Thread bugzilla
https://issues.apache.org/bugzilla/show_bug.cgi?id=45902


Michel Graciano [EMAIL PROTECTED] changed:

   What|Removed |Added

 CC||[EMAIL PROTECTED]




-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are the assignee for the bug.