[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1469: test: Remove wait Reduce test time
codecov-io edited a comment on pull request #1469: URL: https://github.com/apache/apisix-dashboard/pull/1469#issuecomment-776850658 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=h1) Report > Merging [#1469](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=desc) (9744ac7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `8.98%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1469 +/- ## == - Coverage 68.95% 59.97% -8.99% == Files 48 48 Lines3038 3038 == - Hits 2095 1822 -273 - Misses705 975 +270 - Partials 238 241 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `7.14% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `30.24% <0.00%> (-34.68%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `45.91% <0.00%> (-28.58%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `52.94% <0.00%> (-12.95%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=footer). Last update [bd5ed03...9744ac7](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1469: test: Remove wait Reduce test time
codecov-io edited a comment on pull request #1469: URL: https://github.com/apache/apisix-dashboard/pull/1469#issuecomment-776850658 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=h1) Report > Merging [#1469](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=desc) (9744ac7) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `17.32%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1469 +/- ## === - Coverage 68.95% 51.63% -17.33% === Files 48 39-9 Lines3038 2597 -441 === - Hits 2095 1341 -754 - Misses705 1082 +377 + Partials 238 174 -64 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.49%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1469/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=footer). Last update [bd5ed03...9744ac7](https://codecov.io/gh/apache/apisix-dashboard/pull/1469?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1480: Popup when deleting an Upstream which is bound with Route
membphis commented on issue #1480: URL: https://github.com/apache/apisix-dashboard/issues/1480#issuecomment-782816173 > What about We add a `force` parameter. When this parameter is false or without this parameter, it cannot be deleted, and the backend returns a specific code, When `force` is true, it can be deleted ? agree +1 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3516: request help:
Firstsawyou commented on issue #3516:
URL: https://github.com/apache/apisix/issues/3516#issuecomment-782814932
> 参考测试用例执行，缺少 issuedFor，该值指的是什么？
> {"error":"invalid_request","error_description":"You must provide the
issuedFor"}
I'm very sorry, I did not reply to your message in time.
This error message is returned by `keycloack`, you can refer to the solution
here: https://stackoverflow.com/questions/63566261/postman-keycloack-issuedfor
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #3573: docs: added users to PoweredBy
juzhiyuan commented on pull request #3573: URL: https://github.com/apache/apisix/pull/3573#issuecomment-782814661 https://github.com/apache/apisix/blob/1abda84d0b9bff24ed8f74f9c2ec7d9b9f99163a/doc/powered-by.md cc @membphis to take a look at the latest commit. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3573: docs: added users to PoweredBy
membphis commented on pull request #3573: URL: https://github.com/apache/apisix/pull/3573#issuecomment-782814128  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
membphis commented on issue #1468: URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-782814027 > duplicate is allowed > Cover the duplicate data they are both not good. Are there any fields like ID to identify a specific object (such as route, upstream, etc.)? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1493: Support More selectors on List page
juzhiyuan opened a new issue #1493: URL: https://github.com/apache/apisix-dashboard/issues/1493 # Feature request ## Please describe your feature Support More Actions selector on the List page, to prevent too many buttons.  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan opened a new issue #1492: Support fuzzy search in every List page
juzhiyuan opened a new issue #1492: URL: https://github.com/apache/apisix-dashboard/issues/1492 # Feature request ## Please describe your feature Support fuzzy search in every List page. Just like:  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1491: add tips on login page
codecov-io edited a comment on pull request #1491: URL: https://github.com/apache/apisix-dashboard/pull/1491#issuecomment-782809151 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=h1) Report > Merging [#1491](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=desc) (5558c19) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **increase** coverage by `0.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1491 +/- ## == + Coverage 68.43% 68.53% +0.09% == Files 48 48 Lines3038 3038 == + Hits 2079 2082 +3 + Misses720 717 -3 Partials 239 239 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `86.14% <0.00%> (-0.61%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `45.45% <0.00%> (+3.63%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=footer). Last update [65f792a...5558c19](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch juzhiyuan-patch-1 updated (b60bb01 -> 1abda84)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a change to branch juzhiyuan-patch-1
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from b60bb01 Update powered-by.md
add 0b6d35d test: split prometheus test case (#3563)
add b64a1b8 docs: update the content of the FAQ document (#3574)
add aea13f2 ci: create dependabot config file (#3578)
add fcc1630 docs: update README (#3580)
add 7bdb05a test: add fuzzing on apisix dp (#3525)
add 78e544b docs: fix spelling 'filer' should be 'filter' (#3589)
add 0f55e08 docs: fix typo, `customs plugin` -> `custom plugin`. (#3591)
add 696cb50 feat(CI): check for trailing whitespace (#3250)
add 82018b9 fix: should assign value to `api_ctx.global_rules` before
running global rules (#3595)
add 2a9a522 test: fix grammar (#3584)
add 34268f5 docs: tweak install-dependencies.md (#3576)
add c14aa47 chore(deps): update actions/setup-node requirement to v2.1.4
(#3583)
add 5f4e8df feat: support listen http2 with plaintext (#3547)
add 95a149e ci: add release check (#3521)
add b777146 refactor: combine the Lint and Markdown link checker GitHub
Actions i… (#3590)
add 017298d chore(deps): bump actions/upload-artifact from v1 to v2.2.2
(#3607)
add 5656649 ci: use httpbin.org in chaos test to make CI works (#3614)
add 18909a2 feat: allow disabling search option in resolv.conf (#3609)
add ea1ac0f test: ensure all plugins have unique priority (#3582)
add 2401ad5 fix: don't use port 80 for all schemes (#3544)
add 7dde426 refactor: remove unused core.http (#3555)
add bee574f fix: use openssl111 in openresty dir in precedence (#3603)
add 013db0d feat: support to bind plugin config by `plugin_config_id`
(#3567)
add 8369292 fix: delete the old Markdown link checker (#3619)
add fb83857 feat: translate the README to Spanish (#3597)
add 1abda84 Merge branch 'master' into juzhiyuan-patch-1
No new revisions were added by this update.
Summary of changes:
.github/dependabot.yml | 10 +
.github/workflows/build.yml| 28 +-
.github/workflows/chaos.yml| 2 +-
.github/workflows/fuzzing-ci.yaml | 61 ++
.github/workflows/lint.yml | 31 +-
.github/workflows/markdown-link-checker.yml| 27 -
.github/workflows/misc-checker.yml | 2 +-
.gitignore | 2 +-
.travis/linux_openresty_common_runner.sh | 10 +
FAQ.md | 16 +-
FAQ_CN.md | 16 +-
Makefile | 40 +-
README.md | 6 +-
README_CN.md | 4 +-
README_ES.md | 344 ++
apisix/admin/init.lua | 1 +
.../admin/{global_rules.lua => plugin_config.lua} | 31 +-
apisix/admin/routes.lua| 17 +
apisix/api_router.lua | 1 -
apisix/cli/etcd.lua| 2 +-
apisix/cli/ngx_tpl.lua | 8 +-
apisix/cli/ops.lua | 14 +-
apisix/core.lua| 1 -
apisix/core/http.lua | 42 --
apisix/core/utils.lua | 16 +-
apisix/init.lua| 15 +-
apisix/plugin.lua | 4 +
apisix/plugin_config.lua | 71 ++
apisix/plugins/error-log-logger.lua| 2 +-
apisix/plugins/example-plugin.lua | 4 +-
apisix/plugins/sls-logger.lua | 2 +-
apisix/router.lua | 3 +
apisix/schema_def.lua | 19 +-
apisix/upstream.lua| 24 +-
conf/config-default.yaml | 1 +
doc/admin-api.md | 30 +
doc/architecture-design.md | 126 +++-
doc/grpc-proxy.md | 27 +-
doc/images/apisix.png | Bin 179067 -> 378174 bytes
doc/install-dependencies.md| 12 +-
doc/plugins/echo.md| 2 +-
doc/zh-cn/admin-api.md | 34 +
doc/zh-cn/architecture-design.md | 125 +++-
doc/zh-cn/grpc-proxy.md| 28 +-
doc/zh-cn/install-dependencies.md | 12 +-
doc/zh-cn/plugins/echo.md | 2 +-
t/APISIX.pm| 10 +
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1491: add tips on login page
juzhiyuan commented on pull request #1491: URL: https://github.com/apache/apisix-dashboard/pull/1491#issuecomment-782809459 @Baoyuantop Hi, could you please take some screenshots on Login page? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1491: add tips on login page
juzhiyuan commented on a change in pull request #1491:
URL: https://github.com/apache/apisix-dashboard/pull/1491#discussion_r579759905
##
File path: web/src/pages/User/locales/en-US.ts
##
@@ -25,6 +25,8 @@ export default {
'component.user.loginMethodPassword.incorrectPassword': 'Incorrect username
or password',
'component.user.loginMethodPassword.fieldInvalid': 'Please check username
and password',
'component.user.loginMethodPassword.success': 'Login Success',
+ 'component.user.loginMethodPassword.changeDefaultAccount': 'How to update
username/password ?',
Review comment:
```suggestion
'component.user.loginMethodPassword.changeDefaultAccount': 'How to update
username/password?',
```
##
File path: web/src/pages/User/locales/zh-CN.ts
##
@@ -25,6 +25,8 @@ export default {
'component.user.loginMethodPassword.incorrectPassword': '账号或密码错误',
'component.user.loginMethodPassword.fieldInvalid': '请检查账号和密码',
'component.user.loginMethodPassword.success': '登录成功',
+ 'component.user.loginMethodPassword.changeDefaultAccount': '如何修改默认账户和密码 ？',
Review comment:
```suggestion
'component.user.loginMethodPassword.changeDefaultAccount': '如何修改默认账户和密码？',
```
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1491: add tips on login page
codecov-io edited a comment on pull request #1491: URL: https://github.com/apache/apisix-dashboard/pull/1491#issuecomment-782809151 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=h1) Report > Merging [#1491](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=desc) (5558c19) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `8.82%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1491 +/- ## == - Coverage 68.43% 59.61% -8.83% == Files 48 48 Lines3038 3038 == - Hits 2079 1811 -268 - Misses720 988 +268 Partials 239 239 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `7.14% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `30.24% <0.00%> (-34.68%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `45.91% <0.00%> (-24.49%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `52.94% <0.00%> (-12.95%)` | :arrow_down: | | ... and [9 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=footer). Last update [65f792a...5558c19](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1491: add tips on login page
codecov-io commented on pull request #1491: URL: https://github.com/apache/apisix-dashboard/pull/1491#issuecomment-782809151 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=h1) Report > Merging [#1491](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=desc) (5558c19) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `16.83%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1491 +/- ## === - Coverage 68.43% 51.59% -16.84% === Files 48 39-9 Lines3038 2597 -441 === - Hits 2079 1340 -739 - Misses720 1083 +363 + Partials 239 174 -65 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1491/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=footer). Last update [65f792a...5558c19](https://codecov.io/gh/apache/apisix-dashboard/pull/1491?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop opened a new pull request #1491: add tips on login page
Baoyuantop opened a new pull request #1491: URL: https://github.com/apache/apisix-dashboard/pull/1491 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #1488 ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Please add the corresponding test cases if necessary. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch juzhiyuan-patch-1 updated (49175a1 -> b60bb01)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. from 49175a1 Update powered-by.md add b60bb01 Update powered-by.md No new revisions were added by this update. Summary of changes: doc/powered-by.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
[GitHub] [apisix-dashboard] Firstsawyou commented on issue #1484: doc: the FAQ doc add the steps of how to load a custom plugin to the plugin list
Firstsawyou commented on issue #1484: URL: https://github.com/apache/apisix-dashboard/issues/1484#issuecomment-782808794 > ping @Firstsawyou There has been a PR to resolve this issue, and this issue has been closed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch juzhiyuan-patch-1 updated (e1b8b01 -> 49175a1)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. from e1b8b01 Update powered-by.md add 49175a1 Update powered-by.md No new revisions were added by this update. Summary of changes: doc/powered-by.md | 86 +++ 1 file changed, 43 insertions(+), 43 deletions(-)
[apisix] branch juzhiyuan-patch-1 updated (b6af7ac -> e1b8b01)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch juzhiyuan-patch-1 in repository https://gitbox.apache.org/repos/asf/apisix.git. from b6af7ac Update powered-by.md add e1b8b01 Update powered-by.md No new revisions were added by this update. Summary of changes: doc/powered-by.md | 86 +++ 1 file changed, 43 insertions(+), 43 deletions(-)
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1465: feat(be): Online debug function adds support for transfer files
codecov-io edited a comment on pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#issuecomment-775915860 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=h1) Report > Merging [#1465](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=desc) (a373354) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `0.00%`. > The diff coverage is `74.07%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1465 +/- ## == - Coverage 68.95% 68.95% -0.01% == Files 48 48 Lines3038 3047 +9 == + Hits 2095 2101 +6 - Misses705 707 +2 - Partials 238 239 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) | Coverage Δ | | |---|---|---| | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `74.50% <74.07%> (+0.70%)` | :arrow_up: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.34% <0.00%> (-0.61%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=footer). Last update [bd5ed03...a373354](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1465: feat(be): Online debug function adds support for transfer files
codecov-io edited a comment on pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#issuecomment-775915860 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=h1) Report > Merging [#1465](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=desc) (a373354) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `7.98%`. > The diff coverage is `74.07%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1465 +/- ## == - Coverage 68.95% 60.97% -7.99% == Files 48 48 Lines3038 3047 +9 == - Hits 2095 1858 -237 - Misses705 943 +238 - Partials 238 246 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) | Coverage Δ | | |---|---|---| | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `74.50% <74.07%> (+0.70%)` | :arrow_up: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `30.24% <0.00%> (-34.68%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `50.00% <0.00%> (-24.49%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `52.94% <0.00%> (-12.95%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=footer). Last update [bd5ed03...a373354](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1465: feat(be): Online debug function adds support for transfer files
codecov-io edited a comment on pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#issuecomment-775915860 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=h1) Report > Merging [#1465](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=desc) (a373354) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `17.36%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1465 +/- ## === - Coverage 68.95% 51.59% -17.37% === Files 48 39-9 Lines3038 2597 -441 === - Hits 2095 1340 -755 - Misses705 1083 +378 + Partials 238 174 -64 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.49%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [28 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=footer). Last update [bd5ed03...a373354](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1483: [discuss]: how to use apisix for proxy access to dashboard
juzhiyuan closed issue #1483: URL: https://github.com/apache/apisix-dashboard/issues/1483 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on a change in pull request #1465: feat(be): Online debug function adds support for transfer files
Jaycean commented on a change in pull request #1465:
URL: https://github.com/apache/apisix-dashboard/pull/1465#discussion_r579756889
##
File path: api/internal/handler/route_online_debug/route_online_debug.go
##
@@ -63,66 +66,87 @@ type Result struct {
Datainterface{} `json:"data,omitempty"`
}
-func DebugRequestForwarding(c droplet.Context) (interface{}, error) {
+func (h *Handler) DebugRequestForwarding(c droplet.Context) (interface{},
error) {
//TODO: other Protocols, e.g: grpc, websocket
- paramsInput := c.Input().(*ParamsInput)
- requestProtocol := paramsInput.RequestProtocol
- if requestProtocol == "" {
- requestProtocol = "http"
+ input := c.Input().(*DebugOnlineInput)
+ protocol := input.RequestProtocol
+ if protocol == "" {
+ protocol = "http"
}
protocolMap := make(map[string]ProtocolSupport)
protocolMap["http"] = {}
protocolMap["https"] = {}
- if v, ok := protocolMap[requestProtocol]; ok {
- return v.RequestForwarding(c)
- } else {
- return {StatusCode:
http.StatusBadRequest},
- fmt.Errorf("Protocol unsupported %s, only http or https
is allowed, but given %s", paramsInput.RequestProtocol,
paramsInput.RequestProtocol)
+ if v, ok := protocolMap[protocol]; ok {
+ ret, err := v.RequestForwarding(c)
+ return ret, err
}
+
+ return {StatusCode: http.StatusBadRequest},
fmt.Errorf("protocol unspported %s", protocol)
}
type HTTPProtocolSupport struct {
}
func (h *HTTPProtocolSupport) RequestForwarding(c droplet.Context)
(interface{}, error) {
- paramsInput := c.Input().(*ParamsInput)
- bodyParams := paramsInput.BodyParams
- client := {}
+ input := c.Input().(*DebugOnlineInput)
+ url := input.URL
+ method := input.Method
+ body := input.Body
+ contentType := input.ContentType
+
+ if url == "" || method == "" {
+ return {StatusCode:
http.StatusBadRequest}, fmt.Errorf("parameters error")
+ }
+ client := {}
client.Timeout = 5 * time.Second
- req, err := http.NewRequest(strings.ToUpper(paramsInput.Method),
paramsInput.URL, strings.NewReader(bodyParams))
+
+ var tempMap map[string][]string
+ err := json.Unmarshal([]byte(input.HeaderParams), )
+
+ if err != nil {
+ return {StatusCode:
http.StatusInternalServerError}, err
+ }
+
+ req, err := http.NewRequest(strings.ToUpper(method), url,
bytes.NewReader(body))
if err != nil {
return {StatusCode:
http.StatusInternalServerError}, err
}
- for k, v := range paramsInput.HeaderParams {
+
+ req.Header.Add("Content-Type", contentType)
+ for k, v := range tempMap {
for _, v1 := range v {
req.Header.Add(k, v1)
}
}
+
resp, err := client.Do(req)
if err != nil {
return {StatusCode:
http.StatusInternalServerError}, err
}
- defer resp.Body.Close()
+ defer func() {
+ if resp != nil {
+ resp.Body.Close()
+ }
+ }()
Review comment:
done.
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1484: doc: the FAQ doc add the steps of how to load a custom plugin to the plugin list
juzhiyuan closed issue #1484: URL: https://github.com/apache/apisix-dashboard/issues/1484 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1465: feat(be): Online debug function adds support for transfer files
codecov-io edited a comment on pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#issuecomment-775915860 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=h1) Report > Merging [#1465](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=desc) (5ef853a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `0.23%`. > The diff coverage is `74.07%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1465 +/- ## == - Coverage 68.95% 68.72% -0.24% == Files 48 48 Lines3038 3047 +9 == - Hits 2095 2094 -1 - Misses705 713 +8 - Partials 238 240 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) | Coverage Δ | | |---|---|---| | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `74.50% <74.07%> (+0.70%)` | :arrow_up: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `70.40% <0.00%> (-4.09%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (-3.64%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=footer). Last update [bd5ed03...5ef853a](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1465: feat(be): Online debug function adds support for transfer files
codecov-io edited a comment on pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#issuecomment-775915860 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=h1) Report > Merging [#1465](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=desc) (5ef853a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `7.88%`. > The diff coverage is `74.07%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1465 +/- ## == - Coverage 68.95% 61.07% -7.89% == Files 48 48 Lines3038 3047 +9 == - Hits 2095 1861 -234 - Misses705 941 +236 - Partials 238 245 +7 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) | Coverage Δ | | |---|---|---| | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `74.50% <74.07%> (+0.70%)` | :arrow_up: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `30.24% <0.00%> (-34.68%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `50.00% <0.00%> (-24.49%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `52.94% <0.00%> (-12.95%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=footer). Last update [bd5ed03...5ef853a](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1465: feat(be): Online debug function adds support for transfer files
codecov-io edited a comment on pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#issuecomment-775915860 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=h1) Report > Merging [#1465](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=desc) (5ef853a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `17.32%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1465 +/- ## === - Coverage 68.95% 51.63% -17.33% === Files 48 39-9 Lines3038 2597 -441 === - Hits 2095 1341 -754 - Misses705 1082 +377 + Partials 238 174 -64 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.49%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [28 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=footer). Last update [bd5ed03...5ef853a](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1039: Build plugin form according to its jsonschema
nic-chen commented on issue #1039: URL: https://github.com/apache/apisix-dashboard/issues/1039#issuecomment-782794608 I have a little doubt, where does the configuration template come from? And how do we maintain them. Thanks. @liuxiran This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1480: Popup when deleting an Upstream which is bound with Route
nic-chen commented on issue #1480: URL: https://github.com/apache/apisix-dashboard/issues/1480#issuecomment-782794338 > @nic-chen what do you think? I think it’s good for us. This avoids the inability to delete, and prevents users from deleting without their knowledge. What about We add a `force` parameter. When this parameter is false or without this parameter, it cannot be deleted, and the backend returns a specific code, When `force` is true, it can be deleted ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1483: [discuss]: how to use apisix for proxy access to dashboard
nic-chen commented on issue #1483: URL: https://github.com/apache/apisix-dashboard/issues/1483#issuecomment-782793397 To use APISIX proxy Dashboard, you need to set `enable admin` to false (because the path of the Admin API and the path of the Manager API are the same, not setting it to false will request to apis of Admin API), and then follow the normal route configuration. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
nic-chen commented on issue #1468: URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-782792334 > * duplicate is allowed `duplicate is allowed` is good. but I'm not sure about `Cover the duplicate data`, there are certain risks in doing so. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1477: feat: support etcd prefix as apisix does
nic-chen commented on pull request #1477: URL: https://github.com/apache/apisix-dashboard/pull/1477#issuecomment-782790672 @liuyang211 please have a look at https://github.com/apache/apisix-dashboard/blob/master/.github/workflows/backend-cli-test.yml#L27-L31 If there is something not good, you could fix it. thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1470: Backend E2E failed
nic-chen commented on issue #1470: URL: https://github.com/apache/apisix-dashboard/issues/1470#issuecomment-782790162 yes, it is solved This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen closed issue #1470: Backend E2E failed
nic-chen closed issue #1470: URL: https://github.com/apache/apisix-dashboard/issues/1470 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1486: chore: update doc about JSONSchema sync and remove useless codes
codecov-io edited a comment on pull request #1486: URL: https://github.com/apache/apisix-dashboard/pull/1486#issuecomment-782488058 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=h1) Report > Merging [#1486](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=desc) (5e6cf5b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **increase** coverage by `0.26%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1486 +/- ## == + Coverage 68.43% 68.69% +0.26% == Files 48 48 Lines3038 3038 == + Hits 2079 2087 +8 + Misses720 712 -8 Partials 239 239 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (+1.20%)` | :arrow_up: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `47.27% <0.00%> (+5.45%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=footer). Last update [65f792a...5e6cf5b](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1486: chore: update doc about JSONSchema sync and remove useless codes
codecov-io edited a comment on pull request #1486: URL: https://github.com/apache/apisix-dashboard/pull/1486#issuecomment-782488058 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=h1) Report > Merging [#1486](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=desc) (5e6cf5b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `8.45%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1486 +/- ## == - Coverage 68.43% 59.97% -8.46% == Files 48 48 Lines3038 3038 == - Hits 2079 1822 -257 - Misses720 974 +254 - Partials 239 242 +3 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `7.14% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `30.24% <0.00%> (-34.68%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `45.91% <0.00%> (-24.49%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `52.94% <0.00%> (-12.95%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=footer). Last update [65f792a...5e6cf5b](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1465: feat(be): Online debug function adds support for transfer files
codecov-io edited a comment on pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#issuecomment-775915860 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=h1) Report > Merging [#1465](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=desc) (465de84) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `0.03%`. > The diff coverage is `74.07%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1465 +/- ## == - Coverage 68.95% 68.92% -0.04% == Files 48 48 Lines3038 3047 +9 == + Hits 2095 2100 +5 - Misses705 707 +2 - Partials 238 240 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) | Coverage Δ | | |---|---|---| | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `74.50% <74.07%> (+0.70%)` | :arrow_up: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `49.09% <0.00%> (-1.82%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=footer). Last update [bd5ed03...465de84](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1486: chore: update doc about JSONSchema sync and remove useless codes
codecov-io edited a comment on pull request #1486: URL: https://github.com/apache/apisix-dashboard/pull/1486#issuecomment-782488058 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=h1) Report > Merging [#1486](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=desc) (5e6cf5b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `16.79%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1486 +/- ## === - Coverage 68.43% 51.63% -16.80% === Files 48 39-9 Lines3038 2597 -441 === - Hits 2079 1341 -738 - Misses720 1082 +362 + Partials 239 174 -65 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1486/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=footer). Last update [65f792a...5e6cf5b](https://codecov.io/gh/apache/apisix-dashboard/pull/1486?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1465: feat(be): Online debug function adds support for transfer files
codecov-io edited a comment on pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#issuecomment-775915860 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=h1) Report > Merging [#1465](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=desc) (465de84) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `7.62%`. > The diff coverage is `74.07%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1465 +/- ## == - Coverage 68.95% 61.33% -7.63% == Files 48 48 Lines3038 3047 +9 == - Hits 2095 1869 -226 - Misses705 932 +227 - Partials 238 246 +8 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) | Coverage Δ | | |---|---|---| | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `74.50% <74.07%> (+0.70%)` | :arrow_up: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `30.24% <0.00%> (-34.68%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `54.08% <0.00%> (-20.41%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `52.94% <0.00%> (-12.95%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=footer). Last update [bd5ed03...465de84](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1465: feat(be): Online debug function adds support for transfer files
codecov-io edited a comment on pull request #1465: URL: https://github.com/apache/apisix-dashboard/pull/1465#issuecomment-775915860 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=h1) Report > Merging [#1465](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=desc) (465de84) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50?el=desc) (bd5ed03) will **decrease** coverage by `17.32%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1465 +/- ## === - Coverage 68.95% 51.63% -17.33% === Files 48 39-9 Lines3038 2597 -441 === - Hits 2095 1341 -754 - Misses705 1082 +377 + Partials 238 174 -64 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.49%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [28 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1465/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=footer). Last update [bd5ed03...465de84](https://codecov.io/gh/apache/apisix-dashboard/pull/1465?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3597: feat: translate the README to Spanish
membphis commented on pull request #3597: URL: https://github.com/apache/apisix/pull/3597#issuecomment-782785941 nice job @jbampton This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: feat: translate the README to Spanish (#3597)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new fb83857 feat: translate the README to Spanish (#3597) fb83857 is described below commit fb83857d289acf537a8feb65a1ef633e5c5c3e97 Author: John Bampton AuthorDate: Sun Feb 21 12:50:00 2021 +1000 feat: translate the README to Spanish (#3597) The Spanish translation work was done by Jorge > @summerhill5 refs #3587 --- .github/workflows/misc-checker.yml | 2 +- README_ES.md | 344 + 2 files changed, 345 insertions(+), 1 deletion(-) diff --git a/.github/workflows/misc-checker.yml b/.github/workflows/misc-checker.yml index 1ec12ef..146d2f6 100644 --- a/.github/workflows/misc-checker.yml +++ b/.github/workflows/misc-checker.yml @@ -14,7 +14,7 @@ jobs: wget -O - -q https://git.io/misspell | sh -s -- -b . - name: Misspell run: | - find *.md apisix doc bin t -not -path "t/toolkit/*.lua" -type f | xargs ./misspell -error + find *.md apisix doc bin t -not -path "README_ES.md" -not -path "t/toolkit/*.lua" -type f | xargs ./misspell -error - name: Merge conflict run: | grep "^<<< HEAD" $(git ls-files | grep -v "t/toolkit" | xargs) && exit 1 || true diff --git a/README_ES.md b/README_ES.md new file mode 100644 index 000..c49ab2c --- /dev/null +++ b/README_ES.md @@ -0,0 +1,344 @@ + + +# Apache APISIX + +https://svn.apache.org/repos/asf/comdev/project-logos/originals/apisix.svg; alt="APISIX logo" height="150px" align="right" /> + +[](https://github.com/apache/apisix/actions) +[](https://github.com/apache/apisix/blob/master/LICENSE) + +**Apache APISIX** es un portal API en tiempo real, dinámico y de alto rendimiento. + +APISIX proporciona variadas opciones de manejo de tráfico tales como balanceo de cargas, upstream dinámico, comprobación tipo despliegue de canarios (canary release), interrupción de circuitos, autenticación, observabilidad y más. + +Usted puede usar Apache APISIX para manejar el tráfico tradicional norte-sur, +así como tráfico este-oeste entre servicios. +También puede usarse como [k8s ingress controller (control de ingreso)](https://github.com/apache/apisix-ingress-controller). + +La arquitectura técnica de Apache APISIX: + + + +## Communidad + +- Lista de Correos: Enviar correos a dev-subscr...@apisix.apache.org, luego siga la respuesta para suscribirse a la Lista de Correos. +- QQ Group - 578997126 +- [Slack Workspace](http://s.apache.org/slack-invite) - únase a `#apisix` en nuestro Slack para encontrarse con el equipo y formular preguntas +-  - síganos e interactúe con nosotros usando hashtag `#ApacheAPISIX` +- [bilibili video](https://space.bilibili.com/551921247) +- **Good first issues**: + - [Apache APISIX](https://github.com/apache/apisix/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [Controlador de ingreso Apache APISIX](https://github.com/apache/apisix-ingress-controller/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [Tablero Apache APISIX](https://github.com/apache/apisix-dashboard/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [Carta Helm Apache APISIX](https://github.com/apache/apisix-helm-chart/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [Distribución de Dockers para APISIX](https://github.com/apache/apisix-docker/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [Sitio Web Apache APISIX](https://github.com/apache/apisix-website/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + - [El Plano de Control para APISIX](https://github.com/apache/apisix-control-plane/issues?q=is%3Aissue+is%3Aopen+label%3A%22good+first+issue%22) + +## Características + +Usted puede usar Apache APISIX como un acceso de tráfico para procesar todos los datos del negocio, incluyendo direccionamiento dinámico (dynamic routing), upstream dinámico, certificados dinámicos, +ensayos A/B, ensayos de despliegue de canarios (canary release), despliegue azul-verde (blue-green), límite de tasa, defensa contra ataques maliciosos, métrica, monitoreo de alarmas, visibilidad de servicios, gobernabilidad de servicios, etc. + +- **Todas las Plataformas** + + - Nativo de la Nube: Agnóstico de Plataforma, libre de restricciones del vendedor, APISIX puede ejecutarse desde metal desnudo hasta Kubernetes. + - Entorno de Ejecución: Soporta tanto OpenResty como Tengine. + - Soporta ARM64: No hay que preocuparse por las
[GitHub] [apisix] membphis merged pull request #3597: feat: translate the README to Spanish
membphis merged pull request #3597: URL: https://github.com/apache/apisix/pull/3597 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3579: refactor: clean up GitHub workflow YAML files
membphis commented on pull request #3579: URL: https://github.com/apache/apisix/pull/3579#issuecomment-782785000 > Hi @jbampton need to merge master to make CI works seems that you have done this step, all right? @jbampton This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3494: docs: update the docs of the prometheus plugin
membphis commented on pull request #3494: URL: https://github.com/apache/apisix/pull/3494#issuecomment-782782578 @Yiyiyimu Chaos Test failed, please take a look This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3573: docs: added users to PoweredBy
membphis commented on pull request #3573: URL: https://github.com/apache/apisix/pull/3573#issuecomment-782782035 @juzhiyuan please merge the master branch @idbeta you can take a look the ci too: https://github.com/apache/apisix/pull/3573/checks?check_run_id=1869908569#step:10:703 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3575: bug: fail to run make deps on MacOS with luarocks 3.5
membphis commented on issue #3575: URL: https://github.com/apache/apisix/issues/3575#issuecomment-782781871 @lilien1010 do you still have this issue? if yes, please let us know This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis edited a comment on issue #3545: request help: Configuration of the routing and upstream through apisix proxy access, the original project access address 127.0.0.1 / token,
membphis edited a comment on issue #3545: URL: https://github.com/apache/apisix/issues/3545#issuecomment-782781583 Has your problem been solved? If yes, we can close this issue @xuyancheng24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3545: request help: Configuration of the routing and upstream through apisix proxy access, the original project access address 127.0.0.1 / token, apisix
membphis commented on issue #3545: URL: https://github.com/apache/apisix/issues/3545#issuecomment-782781583 can we close this issue now? @xuyancheng24 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3516: request help:
membphis commented on issue #3516: URL: https://github.com/apache/apisix/issues/3516#issuecomment-782781514 ping @Firstsawyou This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1484: doc: the FAQ doc add the steps of how to load a custom plugin to the plugin list
membphis commented on issue #1484: URL: https://github.com/apache/apisix-dashboard/issues/1484#issuecomment-782780805 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1470: Backend E2E failed
membphis commented on issue #1470: URL: https://github.com/apache/apisix-dashboard/issues/1470#issuecomment-782780074 can we close this issue now? @nic-chen This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1450: feat: support exposing schema of route, upstream, service and ssl through Manager API
membphis commented on issue #1450: URL: https://github.com/apache/apisix-dashboard/issues/1450#issuecomment-782779861 @nic-chen I think you need to write more description about why we need this feature. this is very important This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1039: Build plugin form according to its jsonschema
membphis commented on issue #1039: URL: https://github.com/apache/apisix-dashboard/issues/1039#issuecomment-782777991 LGTM @liuxiran This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3597: feat: translate the README to Spanish
moonming commented on pull request #3597: URL: https://github.com/apache/apisix/pull/3597#issuecomment-782777175 thanks，great work This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1473: docs: update architecture diagram.
juzhiyuan merged pull request #1473: URL: https://github.com/apache/apisix-dashboard/pull/1473 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: docs: update architecture diagram. (#1473)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new bd5ed03 docs: update architecture diagram. (#1473) bd5ed03 is described below commit bd5ed03e3256437ed3b54ad10b0ab7b30bbb0b50 Author: YuanSheng Wang AuthorDate: Sun Feb 21 05:18:28 2021 +0800 docs: update architecture diagram. (#1473) --- docs/images/architecture.png | Bin 162681 -> 386018 bytes 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/docs/images/architecture.png b/docs/images/architecture.png index 2fee176..d73ab53 100644 Binary files a/docs/images/architecture.png and b/docs/images/architecture.png differ
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1489: Backport v2.4 changelog and version
juzhiyuan merged pull request #1489: URL: https://github.com/apache/apisix-dashboard/pull/1489 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: Backport v2.4 changelog and version (#1489)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new b40cb40 Backport v2.4 changelog and version (#1489) b40cb40 is described below commit b40cb404273baf7360dd248a4e8278a605bbf2e3 Author: liuxiran AuthorDate: Sun Feb 21 05:16:32 2021 +0800 Backport v2.4 changelog and version (#1489) --- CHANGELOG.md| 46 ++ api/VERSION | 2 +- docs/deploy-with-rpm.md | 2 +- docs/deploy.md | 2 +- docs/develop.md | 2 +- web/package.json| 2 +- 6 files changed, 51 insertions(+), 5 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 0dc3323..a7bb9f6 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ # Table of Contents +- [2.4.0](#240) - [2.3.0](#230) - [2.2.0](#220) - [2.1.1](#211) @@ -27,6 +28,51 @@ - [1.5.0](#150) - [1.0.0](#100) +# 2.4.0 + +This release mainly improves basic features, bugfix and adds test cases. + +`Manager API` 2.4 should be used with [Apache APISIX 2.3](https://github.com/apache/apisix/releases/tag/2.3). It is not recommended to use with other Apache APISIX versions. + +### Core + +- Support to show warning notification when dashboard version not matching apisix. [#1435](https://github.com/apache/apisix-dashboard/pull/1435) +- Support mTLS connection to ETCD. [#1437](https://github.com/apache/apisix-dashboard/pull/1437) +- Support IP allow list. [#1424](https://github.com/apache/apisix-dashboard/pull/1424) +- Support to get manager-api version through API. [#1429](https://github.com/apache/apisix-dashboard/pull/1429) +- Support import route from OpenAPI specification3.0. [#1102](https://github.com/apache/apisix-dashboard/pull/1102) +- Support export route from OpenAPI specification3.0. [#1245](https://github.com/apache/apisix-dashboard/pull/1245) +- Support string type for the script field in Route. [#1289](https://github.com/apache/apisix-dashboard/pull/1289) +- Feat: add script_id field in Route.entity. [#1386](https://github.com/apache/apisix-dashboard/pull/1386) +- Feat: add stop subcommand. [#741](https://github.com/apache/apisix-dashboard/pull/741) +- Feat: add e2e test coverage. [#1270](https://github.com/apache/apisix-dashboard/pull/1270) +- Feat: add returning value for HTTP PUT and PATCH methods. [#1322](https://github.com/apache/apisix-dashboard/pull/1322) +- Feat: user can skip upstream when select service_id [#1302](https://github.com/apache/apisix-dashboard/pull/1302) + +### Bugfix + +- Fix: add defer recover for goroutines to prevent abnormal crash. [#1419](https://github.com/apache/apisix-dashboard/pull/1419) +- Fix: add version ldflags when building manager-api in Dockerfile. [#1393](https://github.com/apache/apisix-dashboard/pull/1393) +- Fix: Upgrade gjson and protobuf to avoid security problem. [#1366](https://github.com/apache/apisix-dashboard/pull/1366) +- Fix: Incomplete label display. [#1252](https://github.com/apache/apisix-dashboard/pull/1252) +- Fix: Redirect plugin should not show in route step3 [#1276](https://github.com/apache/apisix-dashboard/pull/1276) +- Fix: Editing a Service, the upstream info will be lost. [#1347](https://github.com/apache/apisix-dashboard/pull/1347) + +### Test Case + +- Use ginkgo framwork to do backend E2E testing. [#1319](https://github.com/apache/apisix-dashboard/pull/1319) +- Add action to check the version for release. [#1418](https://github.com/apache/apisix-dashboard/pull/1418) +- Add test for make build. [#1421](https://github.com/apache/apisix-dashboard/pull/1421) +- Remove the etcd dependency in part of unit test. [#1169](https://github.com/apache/apisix-dashboard/pull/1469) +- Skip Cypress binary install when build. [#1248](https://github.com/apache/apisix-dashboard/pull/1248) +- Enhance plugin schema smoke test [#1261](https://github.com/apache/apisix-dashboard/pull/1261) +- Delete unnecessary wait in front-end test. [#1370](https://github.com/apache/apisix-dashboard/pull/1370) +- Add edit the plugin testcase [#1372](https://github.com/apache/apisix-dashboard/pull/1372) + +### Doc + +- Doc: add document for introducing bakend e2e test. [#1381](https://github.com/apache/apisix-dashboard/pull/1381) + # 2.3.0 ### Core diff --git a/api/VERSION b/api/VERSION index bb576db..6b4950e 100644 --- a/api/VERSION +++ b/api/VERSION @@ -1 +1 @@ -2.3 +2.4 diff --git a/docs/deploy-with-rpm.md b/docs/deploy-with-rpm.md index 407b7f2..1b77720 100644 --- a/docs/deploy-with-rpm.md +++ b/docs/deploy-with-rpm.md @@ -24,7 +24,7 @@ ## Install from RPM ```sh -$ sudo yum install -y https://github.com/apache/apisix-dashboard/releases/download/v2.3/apisix-dashboard-v2.3-1.x86_64.rpm +$ sudo yum install -y
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1487: Support duplicate one existing Route
juzhiyuan commented on issue #1487: URL: https://github.com/apache/apisix-dashboard/issues/1487#issuecomment-782750641 Ya, that would be better indeed, and we could separate this feature into 2 steps: 1. Copy one existing Route's configuration directly. 2. Allow users to modify then create a new one. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1490: feat: support yaml to config plugin in plugin config page
codecov-io edited a comment on pull request #1490: URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=h1) Report > Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=desc) (f57a2bc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `12.96%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1490 +/- ## === - Coverage 68.43% 55.46% -12.97% === Files 48 48 Lines3038 3038 === - Hits 2079 1685 -394 - Misses720 1072 +352 - Partials 239 281 +42 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `54.25% <0.00%> (-37.24%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `34.69% <0.00%> (-34.19%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `41.66% <0.00%> (-30.56%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `60.24% <0.00%> (-26.51%)` | :arrow_down: | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: | | ... and [16 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=footer). Last update [65f792a...f57a2bc](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1039: Build plugin form according to its jsonschema
juzhiyuan commented on issue #1039: URL: https://github.com/apache/apisix-dashboard/issues/1039#issuecomment-782748232 Great! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1490: feat: support yaml to config plugin in plugin config page
codecov-io commented on pull request #1490: URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-782748155 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=h1) Report > Merging [#1490](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=desc) (f57a2bc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `45.75%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1490 +/- ## === - Coverage 68.43% 22.67% -45.76% === Files 48 48 Lines3038 3038 === - Hits 2079 689 -1390 - Misses720 2207 +1487 + Partials 239 142 -97 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | `0.00% <0.00%> (-88.10%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: | | [api/internal/core/store/selector.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc2VsZWN0b3IuZ28=) | `0.00% <0.00%> (-75.93%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `8.91% <0.00%> (-72.28%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `21.27% <0.00%> (-70.22%)` | :arrow_down: | | [api/internal/handler/plugin/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luL3BsdWdpbi5nbw==) | `16.66% <0.00%> (-70.00%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `20.56% <0.00%> (-68.23%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `7.14% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | ... and [23 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1490/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=footer). Last update [65f792a...f57a2bc](https://codecov.io/gh/apache/apisix-dashboard/pull/1490?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1490: feat: support yaml to config plugin in plugin config page
liuxiran opened a new pull request #1490: URL: https://github.com/apache/apisix-dashboard/pull/1490 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues Part of #1039 ___ ### New feature or improvement - Describe the details and related test reports. 1  2  Notice: all above are just transforms in FE, it would not disturb the interface data transfer ___ ### Please add the corresponding test cases if necessary. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran removed a comment on issue #1039: Build plugin form according to its jsonschema
liuxiran removed a comment on issue #1039: URL: https://github.com/apache/apisix-dashboard/issues/1039#issuecomment-782746157 The implement of https://github.com/apache/apisix-dashboard/issues/1039#issuecomment-771504973 will be divided into four parts: - [ ] FE: support `yaml` to config plugin in plugin page, `json` at the same time will still be available. - [ ] DOC: add plugin templates, in fact this step is the most important part and will be a long term target - [ ] BE: manager-api provides api to get plugin templates - [ ] FE: support choose template before config the plugin we will try to do it step by step, welcome any suggestions to improve the program, thanks very much~ cc @juzhiyuan @LiteSun @imjoey @membphis This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1039: Build plugin form according to its jsonschema
liuxiran commented on issue #1039: URL: https://github.com/apache/apisix-dashboard/issues/1039#issuecomment-782746152 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton opened a new pull request #3622: docs: fix markdown links
jbampton opened a new pull request #3622: URL: https://github.com/apache/apisix/pull/3622 ### What this PR does / why we need it: Fixes some links. ### Pre-submission checklist: * [X] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on issue #1487: Support duplicate one existing Route
imjoey commented on issue #1487: URL: https://github.com/apache/apisix-dashboard/issues/1487#issuecomment-782729434 > A useful feature that would help user quickly create a route based on the exist route . Do we allow edit configuration item during the duplication? which means, after click the `Duplicate button`, we will go to the create route page, and fill in the configuration items with the target route data, if user wants to change some of the configuration, they could change them before create action. +1 agreed. The `Duplicate` button acts more like the `Edit` button, which provides the route editable for every configuration item. In addition, we should explicitly reset the name of the new route in case of name conflicts, how about add `_duplicated` as the suffix of the name of existing route? @juzhiyuan @liuxiran any feedback is welcome. Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3551: feat(zipkin): support b3 req header
membphis commented on pull request #3551: URL: https://github.com/apache/apisix/pull/3551#issuecomment-782725212 @Yiyiyimu Chaos Test failed, do you have time to look at this PR? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on issue #1487: Support duplicate one existing Route
liuxiran commented on issue #1487: URL: https://github.com/apache/apisix-dashboard/issues/1487#issuecomment-782723205 A useful feature that would help user quickly create a route based on the exist route . Do we allow edit configuration item during the duplication? which means, after click the `Duplicate button`, we will go to the create route page, and fill in the configuration items with the target route data, if user wants to change some of the configuration, they could change them before create action. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] imjoey commented on pull request #1489: Backport v2.4 changelog and version
imjoey commented on pull request #1489: URL: https://github.com/apache/apisix-dashboard/pull/1489#issuecomment-782718920 @liuxiran Good catch, thank you so much. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1489: Backport v2.4 changelog and version
codecov-io edited a comment on pull request #1489: URL: https://github.com/apache/apisix-dashboard/pull/1489#issuecomment-782718468 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=h1) Report > Merging [#1489](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=desc) (714288a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `8.52%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1489 +/- ## == - Coverage 68.43% 59.90% -8.53% == Files 48 48 Lines3038 3038 == - Hits 2079 1820 -259 - Misses720 977 +257 - Partials 239 241 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `18.75% <0.00%> (-81.25%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `7.14% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `30.24% <0.00%> (-34.68%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `25.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `45.91% <0.00%> (-24.49%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `34.48% <0.00%> (-24.14%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `30.00% <0.00%> (-20.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `52.94% <0.00%> (-12.95%)` | :arrow_down: | | ... and [8 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=footer). Last update [65f792a...714288a](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1489: Backport v2.4 changelog and version
codecov-io commented on pull request #1489: URL: https://github.com/apache/apisix-dashboard/pull/1489#issuecomment-782718468 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=h1) Report > Merging [#1489](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=desc) (714288a) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/65f792ad1477fe5aca4f964431e69ee29eedc5c0?el=desc) (65f792a) will **decrease** coverage by `16.79%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1489 +/- ## === - Coverage 68.43% 51.63% -16.80% === Files 48 39-9 Lines3038 2597 -441 === - Hits 2079 1341 -738 - Misses720 1082 +362 + Partials 239 174 -65 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1489/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=footer). Last update [65f792a...714288a](https://codecov.io/gh/apache/apisix-dashboard/pull/1489?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1489: Backport v2.4 changelog and version
liuxiran opened a new pull request #1489: URL: https://github.com/apache/apisix-dashboard/pull/1489 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches ___ ### Backport patches - Why need to backport?  when I ran manager-api locally, I found that the `Version` is still `2.3`, the reason is that we forgot to backport the changlog and version from branch v2.4 to master. - Source branch v2.4 - Related commits and pull requests pr: #1460 #1462 #1463 commit: 148b4ea36eb68b479994cbafee4e41af6e3b833e (the version in `README.md` has already modified by #1478, so this commit does not need to backport ) - Target branch master This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3621: ci: auto release and check for rpm
Yiyiyimu commented on a change in pull request #3621: URL: https://github.com/apache/apisix/pull/3621#discussion_r579681687 ## File path: .github/workflows/centos7-ci.yml ## @@ -29,6 +29,15 @@ jobs: with: submodules: recursive +- name: Build rpm package + run: | +sudo gem install --no-document fpm +# WOULD CHANGE TO MASTER WHEN PR GOT MERGED Review comment: Thanks! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton commented on a change in pull request #3621: ci: auto release and check for rpm
jbampton commented on a change in pull request #3621: URL: https://github.com/apache/apisix/pull/3621#discussion_r579679112 ## File path: .github/workflows/centos7-ci.yml ## @@ -29,6 +29,15 @@ jobs: with: submodules: recursive +- name: Build rpm package + run: | +sudo gem install --no-document fpm +# WOULD CHANGE TO MASTER WHEN PR GOT MERGED Review comment: ```suggestion # WOULD CHANGE TO MASTER WHEN PR GETS MERGED ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu opened a new pull request #3621: ci: auto release and check for rpm
Yiyiyimu opened a new pull request #3621: URL: https://github.com/apache/apisix/pull/3621 Signed-off-by: yiyiyimu ### What this PR does / why we need it: Currently we have methods to make rpm package in https://github.com/api7/apisix-build-tools/pull/14. Create this PR to make it automized. Ref: #3521 Todo: - [ ] add test for also deb - [ ] use master branch of apisix-build-tools when PR merged - [ ] use the same kind of release branch check to create package ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1466: feat(fe): support file transfer in online debug
codecov-io commented on pull request #1466: URL: https://github.com/apache/apisix-dashboard/pull/1466#issuecomment-782707636 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=h1) Report > Merging [#1466](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=desc) (d576ae8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/8e1854704d5545f7574fb69fe2710f19871279fd?el=desc) (8e18547) will **decrease** coverage by `17.06%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1466 +/- ## === - Coverage 68.69% 51.63% -17.07% === Files 48 39-9 Lines3038 2597 -441 === - Hits 2087 1341 -746 - Misses712 1082 +370 + Partials 239 174 -65 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-70.41%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1466/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=footer). Last update [8e18547...d576ae8](https://codecov.io/gh/apache/apisix-dashboard/pull/1466?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #3579: refactor: clean up GitHub workflow YAML files
Yiyiyimu commented on pull request #3579: URL: https://github.com/apache/apisix/pull/3579#issuecomment-782705406 Hi @jbampton need to merge master to make CI works This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj commented on issue #24: apisix-ingress install fail because of etcd not start
gxthrj commented on issue #24: URL: https://github.com/apache/apisix-helm-chart/issues/24#issuecomment-782701588 Any update? @zhangxiaohui123456 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] Firstsawyou commented on a change in pull request #134: docs: improve the documentation of alpine
Firstsawyou commented on a change in pull request #134: URL: https://github.com/apache/apisix-docker/pull/134#discussion_r579672549 ## File path: alpine/README.MD ## @@ -1,5 +1,7 @@ ### When building with `alpine` basic image, please specify `APISIX_VERSION` through `build-arg` ``` Review comment: updated. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on issue #248: discuss: ApisixRoute change struct
gxthrj commented on issue #248: URL: https://github.com/apache/apisix-ingress-controller/issues/248#issuecomment-782701398 > > We need a field to specify whether to use `pod IP` or `cluster service`. > > We always use Cluster Service, why we need this field? I mean is to give users the ability to choose whether to automatically register the pod IP. The difference is that the node under upstream in APISIX is the pod IP or the cluster server name. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu merged pull request #3619: fix: delete the old Markdown link checker
Yiyiyimu merged pull request #3619: URL: https://github.com/apache/apisix/pull/3619 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (013db0d -> 8369292)
This is an automated email from the ASF dual-hosted git repository. shuyangw pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 013db0d feat: support to bind plugin config by `plugin_config_id` (#3567) add 8369292 fix: delete the old Markdown link checker (#3619) No new revisions were added by this update. Summary of changes: .github/workflows/markdown-link-checker.yml | 27 --- 1 file changed, 27 deletions(-) delete mode 100644 .github/workflows/markdown-link-checker.yml
[GitHub] [apisix-helm-chart] gxthrj commented on a change in pull request #26: chore: fix the template of deployment.yaml and add hints for affinity setting in values.yaml
gxthrj commented on a change in pull request #26: URL: https://github.com/apache/apisix-helm-chart/pull/26#discussion_r579672239 ## File path: README.md ## @@ -21,5 +21,77 @@ Apache APISIX Helm Charts provide the installation of [Apache APISIX](https://github.com/apache/apisix#apache-apisix) components for kubernetes. +Update the dependency chart Review comment: Yes, It has been moved to [Apache APISIX Helm Chart](https://github.com/apache/apisix-helm-chart/tree/master/charts/apisix) @TkClark Please have a look. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jp-gouin commented on issue #3593: request help: OIDC missing Authorization header in CORS
jp-gouin commented on issue #3593: URL: https://github.com/apache/apisix/issues/3593#issuecomment-782698877 Ok i see what you mean, i copied the function from jwt-auth to authz-keycloak but no luck so far. I cannot see how to fetch the jwt token from the session cookie... Do you have an idea of how openid-connect plugin is doing this ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] gxthrj commented on a change in pull request #134: docs: improve the documentation of alpine
gxthrj commented on a change in pull request #134: URL: https://github.com/apache/apisix-docker/pull/134#discussion_r579670742 ## File path: alpine/README.MD ## @@ -1,5 +1,7 @@ ### When building with `alpine` basic image, please specify `APISIX_VERSION` through `build-arg` ``` -docker build --build-arg APISIX_VERSION=$APISIX_VERSION -t $IMAGE_NAME . -``` \ No newline at end of file +$ docker build --build-arg APISIX_VERSION=$APISIX_VERSION -t $IMAGE_NAME . +``` + +Note: The minimum version of docker that supports building image is `docker 17.05.0-ce`. Review comment: I think use `docker 17.05.0-ce` is ok Ref to: https://github.com/docker/docker/pull/31352 https://docs.docker.com/engine/release-notes/17.05 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton opened a new pull request #3620: refactor: add the spell checker to the lint workflow
jbampton opened a new pull request #3620: URL: https://github.com/apache/apisix/pull/3620 The spell checker only needs to run on pull request. This also gives separate steps for each test on the pull request page instead of having `misspell` and the `merge conflict` tests as one step. Makes it easier and quicker to see which test is failing. ### What this PR does / why we need it: Clearer to see which steps fail quicker. ### Pre-submission checklist: * [X] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1488: Add tips on the Login page
juzhiyuan commented on issue #1488: URL: https://github.com/apache/apisix-dashboard/issues/1488#issuecomment-782663566 Go This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yocaning commented on issue #3616: request help: how nodes will be recovered from unhealthy
yocaning commented on issue #3616:
URL: https://github.com/apache/apisix/issues/3616#issuecomment-782663578
`{"id":"1","update_time":1613734165,"upstream":{"checks":{"active":{"healthy":{"interval":3,"successes":2},"unhealthy":
{ "interval": 10,"http_failures":
2},"concurrency":10,"timeout":1,"https_verify_certificate":true,"http_path":"/status?cmd=6003","type":"http","req_headers":
["Content-Seq:3"]},"passive":{"timeout":5,"healthy":{"http_statuses":[200,201],"successes":3},"type":"http","unhealthy":{"http_statuses":[500,504],"timeouts":3,"tcp_failures":1,"http_failures":1}}},"nodes":{"***:8080":1,"***:8080":1},"timeout":{"connect":3,"read":3,"send":3},"pass_host":"pass","hash_on":"vars","type":"roundrobin"},"methods":["PUT","GET"],"status":1,"create_time":1613722689,"priority":0,"uri":"/cmd"}`
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] yocaning commented on issue #3616: request help: how nodes will be recovered from unhealthy
yocaning commented on issue #3616: URL: https://github.com/apache/apisix/issues/3616#issuecomment-782660832 > > > > > several > > > > > > > > > > > > it does not work ,because no active path to check > > > > > > > > > You should use `active.unhealthy.interval` in active health check. > > > If it does not work, you should provide the configuration information. > > > > > > 背景再描述一下，我选用的是被动检查也就是passive，在某个node被检查成为unhealthy之后，我该如何使其复原 > > Actually you cannot only enable passive healthy check, the active one also woks even if you don't configure it. > The below is some snippets of the schema (https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L98). > >  yes，i set it both passive and active ，but still not work，i will show my all config right now This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Baoyuantop commented on issue #1488: Add tips on the Login page
Baoyuantop commented on issue #1488: URL: https://github.com/apache/apisix-dashboard/issues/1488#issuecomment-782659678 I can add it @juzhiyuan This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yocaning commented on issue #3616: request help: how nodes will be recovered from unhealthy
yocaning commented on issue #3616: URL: https://github.com/apache/apisix/issues/3616#issuecomment-782659680 > > 但是实际上并不工作，没有生效 > > please provide a minimum reproduction step. Don't you read the above？i showed my configuration This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton opened a new pull request #3619: fix: delete the old Markdown link checker
jbampton opened a new pull request #3619: URL: https://github.com/apache/apisix/pull/3619 Seems I forgot to delete the old workflow when I merged it to the `lint.yml` ### What this PR does / why we need it: Removes the duplicate Markdown link checker. https://user-images.githubusercontent.com/418747/108596180-228ca800-73cf-11eb-9a14-bed5e64ea4c3.png;> ### Pre-submission checklist: * [X] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3567: feat: add plugin config
membphis commented on pull request #3567: URL: https://github.com/apache/apisix/pull/3567#issuecomment-782633819 merged, many thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis merged pull request #3567: feat: add plugin config
membphis merged pull request #3567: URL: https://github.com/apache/apisix/pull/3567 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #3532: request help: what's the plan of plugin reference
membphis closed issue #3532: URL: https://github.com/apache/apisix/issues/3532 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (bee574f -> 013db0d)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git.
from bee574f fix: use openssl111 in openresty dir in precedence (#3603)
add 013db0d feat: support to bind plugin config by `plugin_config_id`
(#3567)
No new revisions were added by this update.
Summary of changes:
apisix/admin/init.lua | 1 +
.../admin/{global_rules.lua => plugin_config.lua} | 31 +-
apisix/admin/routes.lua| 17 +
apisix/cli/etcd.lua| 2 +-
apisix/init.lua| 14 +
apisix/plugin_config.lua | 71
apisix/plugins/example-plugin.lua | 4 +-
apisix/router.lua | 3 +
apisix/schema_def.lua | 19 +-
doc/admin-api.md | 30 ++
doc/architecture-design.md | 124 +++
doc/zh-cn/admin-api.md | 34 ++
doc/zh-cn/architecture-design.md | 123 +++
t/admin/{global-rules.t => plugin-configs.t} | 362 +++--
t/admin/routes2.t | 34 ++
.../{global-rule.t => plugin-configs.t}| 118 ---
t/config-center-yaml/route.t | 22 ++
t/lib/test_admin.lua | 17 +-
t/node/plugin-configs.t| 125 +++
t/plugin/example.t | 4 +-
20 files changed, 759 insertions(+), 396 deletions(-)
copy apisix/admin/{global_rules.lua => plugin_config.lua} (80%)
create mode 100644 apisix/plugin_config.lua
copy t/admin/{global-rules.t => plugin-configs.t} (50%)
copy t/config-center-yaml/{global-rule.t => plugin-configs.t} (55%)
create mode 100644 t/node/plugin-configs.t
