[GitHub] [apisix] batman-ezio commented on issue #3763: feat: add "allow_origins_by_regex" to cors plugin
batman-ezio commented on issue #3763: URL: https://github.com/apache/apisix/issues/3763#issuecomment-799132045 @spacewander can you assign this to me This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton opened a new pull request #3825: feat: first attempt at APISIX overall GitHub leaderboard
jbampton opened a new pull request #3825: URL: https://github.com/apache/apisix/pull/3825 - Thought it would be good to have an AUTHORS file and I think that RAILS does it well: https://contributors.rubyonrails.org/ - Could be expanded in future to match on names too - Was a quick Ruby script ### What this PR does / why we need it: Shows all contributors more than 100. ### Pre-submission checklist: * [X] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3787: [discuss]: does the traffic-split plugin has a way to implement the original capabilities without corrupting the data?
Firstsawyou commented on issue #3787: URL: https://github.com/apache/apisix/issues/3787#issuecomment-799131511 @tzssangglass uses the method of `"when the route is configured with an upstream_id, the upstream_id is passed into the server_list"` to solve it. Thank you very much @tzssangglass . This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error
stu01509 commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r594059146 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component": "umi test ./src/components", "tsc": "tsc", -"cypress:open": "CYPRESS_SERVE_ENV=test cypress open", -"cypress:open-dev": "CYPRESS_SERVE_ENV=dev cypress open", -"cypress:run-ci": "CYPRESS_SERVE_ENV=test cypress run" +"cypress:open": "cross-env CYPRESS_SERVE_ENV=test cypress open", Review comment: Fail on Windows, working in Linux successfully This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) (35f722e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc) (e22de29) will **decrease** coverage by `11.21%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1538 +/- ## === - Coverage 69.01% 57.80% -11.22% === Files 132 132 Lines5374 5375+1 Branches 592 592 === - Hits 3709 3107 -602 - Misses 1417 1983 +566 - Partials 248 285 +37 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `46.37% <ø> (+0.09%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `72.45% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `52.00% <100.00%> (+2.00%)` | :arrow_up: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-70.76%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-41.67%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `52.12% <0.00%> (-39.37%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-38.71%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `57.22% <0.00%> (-30.73%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `48.95% <0.00%> (-29.29%)` | :arrow_down: | | ... and [15 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer). Last update [e22de29...35f722e](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) (35f722e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc) (e22de29) will **decrease** coverage by `11.28%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1538 +/- ## === - Coverage 69.01% 57.73% -11.29% === Files 132 132 Lines5374 5375+1 Branches 592 592 === - Hits 3709 3103 -606 - Misses 1417 1989 +572 - Partials 248 283 +35 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `46.24% <ø> (-0.04%)` | :arrow_down: | | backend-unit-test | `?` | | | frontend-e2e-test | `72.45% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `52.00% <100.00%> (+2.00%)` | :arrow_up: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-70.76%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-41.67%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `52.12% <0.00%> (-39.37%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-38.71%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `56.02% <0.00%> (-31.93%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `48.95% <0.00%> (-29.29%)` | :arrow_down: | | ... and [16 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer). Last update [e22de29...35f722e](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1538: fix: Incomplete i18n coverage
codecov-io edited a comment on pull request #1538: URL: https://github.com/apache/apisix-dashboard/pull/1538#issuecomment-788590625 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=h1) Report > Merging [#1538](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=desc) (35f722e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc) (e22de29) will **increase** coverage by `3.43%`. > The diff coverage is `100.00%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1538 +/- ## == + Coverage 69.01% 72.45% +3.43% == Files 132 86 -46 Lines5374 2356-3018 Branches 592 592 == - Hits 3709 1707-2002 + Misses 1417 649 -768 + Partials 2480 -248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `72.45% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/pages/Route/components/Step3/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL1N0ZXAzL2luZGV4LnRzeA==) | `52.00% <100.00%> (+2.00%)` | :arrow_up: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | | | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | | | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | | | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | ... and [37 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1538/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=footer). Last update [e22de29...35f722e](https://codecov.io/gh/apache/apisix-dashboard/pull/1538?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] tokers commented on issue #746: Bugs in GenericStore.Create and GenericStore.Update
tokers commented on issue #746: URL: https://github.com/apache/apisix-dashboard/issues/746#issuecomment-799081930 @nic-chen I'm still busying on other things, if this stuff is not so emergency, maybe we can do it later. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1558: feat:Support duplicate one existing Route
nic-chen commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799079221 > Why backend failed? need some time to check for it This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1554: bug: 通过API创建的upstream和route，在dashboard的route详情页面中显示不完整
nic-chen commented on issue #1554: URL: https://github.com/apache/apisix-dashboard/issues/1554#issuecomment-799077359 @miaoyb could you provide the version of APISIX and Dashboard, and the config you created the route and upstream ? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1580: fix: fix the upstream timeout unit
codecov-io edited a comment on pull request #1580: URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=h1) Report > Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=desc) (4a50bfd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc) (e22de29) will **not change** coverage. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1580 +/- ## === Coverage 66.34% 66.34% === Files 46 46 Lines3019 3019 === Hits 2003 2003 - Misses768 770+2 + Partials 248 246-2 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `46.27% <ø> (ø)` | | | backend-unit-test | `51.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `86.74% <0.00%> (-1.21%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `45.45% <0.00%> (+1.81%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=footer). Last update [e22de29...4a50bfd](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on pull request #300: add chinese version of decument
membphis commented on pull request #300: URL: https://github.com/apache/apisix-ingress-controller/pull/300#issuecomment-799074256 @soulsoul this pr is big, and I think you can split it into multiple small PRs. it is easier to review and merge. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1580: fix: fix the upstream timeout unit
codecov-io edited a comment on pull request #1580: URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-797511954 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=h1) Report > Merging [#1580](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=desc) (4a50bfd) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/e22de2966fe322ee26b8023e9a5e493cfa643535?el=desc) (e22de29) will **decrease** coverage by `14.80%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1580 +/- ## === - Coverage 66.34% 51.54% -14.81% === Files 46 37-9 Lines3019 2555 -464 === - Hits 2003 1317 -686 - Misses768 1057 +289 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.54% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-67.29%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-52.11%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `63.82% <0.00%> (-27.66%)` | :arrow_down: | | ... and [32 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1580/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=footer). Last update [e22de29...4a50bfd](https://codecov.io/gh/apache/apisix-dashboard/pull/1580?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1558: feat:Support duplicate one existing Route
juzhiyuan commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799073507 Why backend failed? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #1558: feat:Support duplicate one existing Route
starsz commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799072311 Wait for CI. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1558: feat:Support duplicate one existing Route
LiteSun commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799069875 > @batman-ezio you can make a try to merge the `master` branch Just help you sync master branch code. let's wait for CI report This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1558: feat:Support duplicate one existing Route
membphis commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799067440 @batman-ezio you can make a try to merge the `master` branch This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1490: feat: support yaml to config plugin in plugin config page
juzhiyuan merged pull request #1490: URL: https://github.com/apache/apisix-dashboard/pull/1490 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (07e55f2 -> e22de29)
This is an automated email from the ASF dual-hosted git repository. juzhiyuan pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 07e55f2 fix: fe e2e error for pr 1538 (#1590) add e22de29 feat: support yaml to config plugin in plugin config page (#1490) No new revisions were added by this update. Summary of changes: web/package.json | 5 +- web/src/components/Plugin/PluginDetail.tsx | 74 ++ web/src/components/Plugin/typing.d.ts | 2 + web/src/global.less| 4 ++ web/src/helpers.tsx| 42 + 5 files changed, 115 insertions(+), 12 deletions(-)
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1512: Plugin template configuration
juzhiyuan closed issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1584: feat: save list page's meta status
juzhiyuan commented on pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-799066671 @guoqqqi You should mark this PR ready for review. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r594028620 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component": "umi test ./src/components", "tsc": "tsc", -"cypress:open": "CYPRESS_SERVE_ENV=test cypress open", -"cypress:open-dev": "CYPRESS_SERVE_ENV=dev cypress open", -"cypress:run-ci": "CYPRESS_SERVE_ENV=test cypress run" +"cypress:open": "cross-env CYPRESS_SERVE_ENV=test cypress open", Review comment: fail on windows, right? does this work on Linux? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1590: fix: fe e2e error for pr 1538
juzhiyuan merged pull request #1590: URL: https://github.com/apache/apisix-dashboard/pull/1590 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: fe e2e error for pr 1538 (#1590)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 07e55f2 fix: fe e2e error for pr 1538 (#1590)
07e55f2 is described below
commit 07e55f20be0e177797333a89e8ffcec47047c821
Author: liuxiran
AuthorDate: Mon Mar 15 10:54:00 2021 +0800
fix: fe e2e error for pr 1538 (#1590)
---
web/cypress/integration/route/import_export_route.spec.js | 1 -
web/cypress/integration/route/online-debug.spec.js| 6 +++---
2 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/web/cypress/integration/route/import_export_route.spec.js
b/web/cypress/integration/route/import_export_route.spec.js
index 1786b40..188ec2e 100644
--- a/web/cypress/integration/route/import_export_route.spec.js
+++ b/web/cypress/integration/route/import_export_route.spec.js
@@ -159,7 +159,6 @@ context('import and export routes', () => {
cy.get(this.domSelector.notification).should(
'contain', 'Success'
);
-cy.get(this.domSelector.fileSelectorClose).click();
cy.get(this.domSelector.notificationCloseIcon).click().should('not.exist');
// delete route just imported
cy.reload();
diff --git a/web/cypress/integration/route/online-debug.spec.js
b/web/cypress/integration/route/online-debug.spec.js
index f491a1c..487a320 100644
--- a/web/cypress/integration/route/online-debug.spec.js
+++ b/web/cypress/integration/route/online-debug.spec.js
@@ -44,7 +44,6 @@ context('Online debug', () => {
postUrl:
`${defaultSettings.serveUrlMap[SERVE_ENV].split('//')[1]}/apisix/admin/import/routes`,
uploadFile: '../../../api/test/testdata/import/default.json',
headerAuthorizationKey: 'Authorization',
-token: localStorage.getItem('token'),
routeName: 'hello',
};
@@ -112,6 +111,7 @@ context('Online debug', () => {
it('should debug POST request with file successfully', function() {
cy.visit('/');
cy.contains(menuLocaleUS['menu.routes']).click();
+const currentToken = localStorage.getItem('token');
// show online debug draw
cy.contains(routeLocaleUS['page.route.onlineDebug']).click();
@@ -146,8 +146,8 @@ context('Online debug', () => {
// set header Authorization
cy.contains('Header Params').should('be.visible').click();
-cy.get(domSelector.headerDataKey0).type(data.headerAuthorizationKey),
-cy.get(domSelector.headerDataValue0).type(data.token);
+cy.get(domSelector.headerDataKey0).type(data.headerAuthorizationKey);
+cy.get(domSelector.headerDataValue0).type(currentToken);
cy.contains(routeLocaleUS['page.route.button.send']).click();
// assert: send request return
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1584: feat: save list page's meta status
LiteSun commented on pull request #1584: URL: https://github.com/apache/apisix-dashboard/pull/1584#issuecomment-799053245 > @LiteSun When you have time, please help me check this PR. ok, you mean review? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
LiteSun commented on a change in pull request #1576:
URL: https://github.com/apache/apisix-dashboard/pull/1576#discussion_r594013700
##
File path: web/src/pages/Route/components/Step1/ProxyRewrite.tsx
##
@@ -0,0 +1,291 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React, { useEffect } from 'react';
+import Form from 'antd/es/form';
+import { Button, Input, Radio, Row, Col } from 'antd';
+import { PlusOutlined, MinusCircleOutlined } from '@ant-design/icons';
+import { useIntl } from 'umi';
+import { PanelSection } from '@api7-dashboard/ui';
+
+import {
+ FORM_ITEM_LAYOUT,
+ FORM_ITEM_WITHOUT_LABEL,
+ ShcemeRewrite,
+ URIRewriteType,
+ HostRewriteType
+} from '@/pages/Route/constants';
+
+const ProxyRewrite: React.FC = ({ form, disabled
}) => {
+ const { formatMessage } = useIntl();
+
+ const getUriRewriteItems = () => {
+switch (form.getFieldValue('URIRewriteType')) {
+ case URIRewriteType.STATIC:
+return (
+
+
+
+);
+ case URIRewriteType.REGEXP:
+return (
+
+{(fields) =>
+ fields.map((field, index) => {
+switch (index) {
+ case 0:
+return (
+ http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React, { useEffect } from 'react';
+import Form from 'antd/es/form';
+import { Button, Input, Radio, Row, Col } from 'antd';
+import { PlusOutlined, MinusCircleOutlined } from '@ant-design/icons';
+import { useIntl } from 'umi';
+import { PanelSection } from '@api7-dashboard/ui';
+
+import {
+ FORM_ITEM_LAYOUT,
+ FORM_ITEM_WITHOUT_LABEL,
+ ShcemeRewrite,
+ URIRewriteType,
+ HostRewriteType
+} from '@/pages/Route/constants';
+
+const ProxyRewrite: React.FC = ({ form, disabled
}) => {
+ const { formatMessage } = useIntl();
+
+ const getUriRewriteItems = () => {
+switch (form.getFieldValue('URIRewriteType')) {
+ case URIRewriteType.STATIC:
+return (
+
+
+
+);
+ case URIRewriteType.REGEXP:
+return (
+
+{(fields) =>
+ fields.map((field, index) => {
+switch (index) {
+ case 0:
+return (
+
+
+
+);
+ case 1:
+return (
+
+
+
+);
+ default:
+return null;
+}
+ })
+}
+
+);
+ case URIRewriteType.KEEP:
+ default:
+return null;
+}
+ };
+
+ const getHostRewriteItems = () => {
+switch (form.getFieldValue('hostRewriteType')) {
+ case HostRewriteType.REWRITE:
+return (
+
+
+
+);
+ case HostRewriteType.KEEP:
+ default:
+return null;
+}
+ };
+
+ useEffect(() => {}, []);
Review comment:
useless line? 樂
##
File path:
web/cypress/integration/route/create-route-with-proxy-rewrite-plugin.spec.js
##
@@ -0,0 +1,139 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT
[GitHub] [apisix] Miss-you opened a new pull request #3824: typo: fix table format in plugin limit-count-redis-cluster.lua and limit-count-redis.lua
Miss-you opened a new pull request #3824: URL: https://github.com/apache/apisix/pull/3824 typo: fix table format in plugin limit-count-redis-cluster.lua and limit-count-redis.lua ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1582: feat: rewrite e2e test(rewrite-e2e-test-route-with-priority-test) with ginkgo
codecov-io edited a comment on pull request #1582: URL: https://github.com/apache/apisix-dashboard/pull/1582#issuecomment-799045704 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=h1) Report > Merging [#1582](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=desc) (df804ce) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7?el=desc) (9cb4b43) will **decrease** coverage by `5.29%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1582 +/- ## == - Coverage 71.64% 66.34% -5.30% == Files 132 46 -86 Lines5339 3019-2320 Branches 5840 -584 == - Hits 3825 2003-1822 + Misses 1269 768 -501 - Partials 245 248 +3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `46.27% <ø> (-0.14%)` | :arrow_down: | | backend-unit-test | `51.54% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `77.14% <0.00%> (-8.58%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `43.63% <0.00%> (-3.64%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | ... and [86 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=footer). Last update [9cb4b43...df804ce](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please
[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1593: feat: rewrite e2e test(rewrite-e2e-test-route-with-proxy-test) with ginkgo
Jaycean opened a new pull request #1593: URL: https://github.com/apache/apisix-dashboard/pull/1593 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #1500 ___ ### New feature or improvement - Rewrite e2e test(rewrite-e2e-test-route-with-proxy-test) with ginkgo This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-io edited a comment on pull request #275: updated technical architecture of apisix-ingress-controller
codecov-io edited a comment on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-787224463 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr=h1) Report > Merging [#275](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr=desc) (312f16f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/0c8f306cac9911ababb3c23700ac7ca1efc21833?el=desc) (0c8f306) will **decrease** coverage by `1.56%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr=tree) ```diff @@Coverage Diff @@ ## master #275 +/- ## == - Coverage 53.85% 52.28% -1.57% == Files 33 32 -1 Lines2245 2320 +75 == + Hits 1209 1213 +4 - Misses879 950 +71 Partials 157 157 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr=tree) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `53.03% <0.00%> (ø)` | | | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr=tree#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr=tree#diff-dGVzdC9lMmUvZTJlLmdv) | | | | [cmd/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr=tree#diff-Y21kL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `74.32% <0.00%> (+0.35%)` | :arrow_up: | | [pkg/apisix/ssl.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr=tree#diff-cGtnL2FwaXNpeC9zc2wuZ28=) | `39.86% <0.00%> (+0.40%)` | :arrow_up: | | [pkg/config/config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr=tree#diff-cGtnL2NvbmZpZy9jb25maWcuZ28=) | `80.48% <0.00%> (+0.48%)` | :arrow_up: | | [pkg/seven/state/solver.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275/diff?src=pr=tree#diff-cGtnL3NldmVuL3N0YXRlL3NvbHZlci5nbw==) | `4.00% <0.00%> (+2.00%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr=footer). Last update [0c8f306...312f16f](https://codecov.io/gh/apache/apisix-ingress-controller/pull/275?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] iamayushdas edited a comment on pull request #275: updated technical architecture of apisix-ingress-controller
iamayushdas edited a comment on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-799046244 @gxthrj i have done the change according to helm repo ,can i have a review please? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] iamayushdas commented on pull request #275: updated technical architecture of apisix-ingress-controller
iamayushdas commented on pull request #275: URL: https://github.com/apache/apisix-ingress-controller/pull/275#issuecomment-799046244 @gxthrj can i have a review on this? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration
LiteSun commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-799045795 > @LiteSun can we close this issue now? Sure. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1512: Plugin template configuration
LiteSun commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-799045638 closed by #1540 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1582: feat: rewrite e2e test(rewrite-e2e-test-route-with-priority-test) with ginkgo
codecov-io commented on pull request #1582: URL: https://github.com/apache/apisix-dashboard/pull/1582#issuecomment-799045704 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=h1) Report > Merging [#1582](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=desc) (df804ce) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7?el=desc) (9cb4b43) will **decrease** coverage by `20.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1582 +/- ## === - Coverage 71.64% 51.54% -20.10% === Files 132 37 -95 Lines5339 2555 -2784 Branches 5840 -584 === - Hits 3825 1317 -2508 + Misses 1269 1057 -212 + Partials 245 181 -64 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.54% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [118 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1582/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=footer). Last update [9cb4b43...df804ce](https://codecov.io/gh/apache/apisix-dashboard/pull/1582?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1592: feat: expose JSON Schema through API
codecov-io edited a comment on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-798933657 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=h1) Report > Merging [#1592](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=desc) (314eead) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7?el=desc) (9cb4b43) will **increase** coverage by `1.63%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1592 +/- ## == + Coverage 71.64% 73.27% +1.63% == Files 132 86 -46 Lines5339 2320-3019 Branches 584 584 == - Hits 3825 1700-2125 + Misses 1269 620 -649 + Partials 2450 -245 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.27% <ø> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=tree) | Coverage Δ | | |---|---|---| | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `75.38% <0.00%> (-1.54%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | | | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | | | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | | | | ... and [35 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=footer). Last update [9cb4b43...314eead](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3823: test: don't crash when dubbo upstream returns integer status code
spacewander opened a new pull request #3823: URL: https://github.com/apache/apisix/pull/3823 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton opened a new pull request #3822: chore: sort imports in the Markdown examples
jbampton opened a new pull request #3822: URL: https://github.com/apache/apisix/pull/3822 ### What this PR does / why we need it: Standardizes the codebase ### Pre-submission checklist: * [X] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3809: feat: upgrade lua-resty-expr/radixtree to support logical expression
spacewander merged pull request #3809: URL: https://github.com/apache/apisix/pull/3809 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: feat: upgrade lua-resty-expr/radixtree to support logical expression (#3809)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 7047932 feat: upgrade lua-resty-expr/radixtree to support logical
expression (#3809)
7047932 is described below
commit 7047932548a06f3f644c1d1c7fac4995ad32377a
Author: 罗泽轩
AuthorDate: Mon Mar 15 09:51:15 2021 +0800
feat: upgrade lua-resty-expr/radixtree to support logical expression (#3809)
Signed-off-by: spacewander
---
apisix/plugins/fault-injection.lua | 10 +++-
apisix/plugins/response-rewrite.lua | 6 ---
apisix/plugins/traffic-split.lua| 55 +--
apisix/schema_def.lua | 6 ---
rockspec/apisix-master-0.rockspec | 4 +-
t/plugin/fault-injection.t | 4 +-
t/plugin/fault-injection2.t | 97 +
t/plugin/response-rewrite.t | 2 +-
t/plugin/traffic-split.t| 2 +-
t/plugin/traffic-split2.t | 105
t/router/radixtree-uri-vars.t | 63 ++
11 files changed, 292 insertions(+), 62 deletions(-)
diff --git a/apisix/plugins/fault-injection.lua
b/apisix/plugins/fault-injection.lua
index ac2846d..eb699c3 100644
--- a/apisix/plugins/fault-injection.lua
+++ b/apisix/plugins/fault-injection.lua
@@ -35,7 +35,10 @@ local schema = {
percentage = {type = "integer", minimum = 0, maximum = 100},
vars = {
type = "array",
-maxItems = 20
+maxItems = 20,
+item = {
+type = "array",
+},
}
},
required = {"http_status"},
@@ -47,7 +50,10 @@ local schema = {
percentage = {type = "integer", minimum = 0, maximum = 100},
vars = {
type = "array",
-maxItems = 20
+maxItems = 20,
+item = {
+type = "array",
+},
}
},
required = {"duration"},
diff --git a/apisix/plugins/response-rewrite.lua
b/apisix/plugins/response-rewrite.lua
index 82ab120..4959111 100644
--- a/apisix/plugins/response-rewrite.lua
+++ b/apisix/plugins/response-rewrite.lua
@@ -47,12 +47,6 @@ local schema = {
},
vars = {
type = "array",
-items = {
-description = "Nginx builtin variable name and value",
-type = "array",
-maxItems = 4,
-minItems = 2,
-},
},
},
minProperties = 1,
diff --git a/apisix/plugins/traffic-split.lua b/apisix/plugins/traffic-split.lua
index c2e54c0..2a7138e 100644
--- a/apisix/plugins/traffic-split.lua
+++ b/apisix/plugins/traffic-split.lua
@@ -33,48 +33,6 @@ local lrucache = core.lrucache.new({
local vars_schema = {
type = "array",
-items = {
-type = "array",
-items = {
-{
-type = "string",
-minLength = 1,
-maxLength = 100
-},
-{
-type = "string",
-minLength = 1,
-maxLength = 2
-}
-},
-additionalItems = {
-anyOf = {
-{type = "string"},
-{type = "number"},
-{type = "boolean"},
-{
-type = "array",
-items = {
-anyOf = {
-{
-type = "string",
-minLength = 1, maxLength = 100
-},
-{
-type = "number"
-},
-{
-type = "boolean"
-}
-}
-},
-uniqueItems = true
-}
-}
-},
-minItems = 0,
-maxItems = 10
-}
}
@@ -154,6 +112,19 @@ function _M.check_schema(conf)
return false, err
end
+if conf.rules then
+for _, rule in ipairs(conf.rules) do
+if rule.match then
+for _, m in ipairs(rule.match) do
+local ok, err = expr.new(m.vars)
+if not ok then
+return false, "failed to validate the 'vars'
expression: " .. err
+end
+end
+end
+end
+end
+
return true
end
diff --git a/apisix/schema_def.lua b/apisix/schema_def.lua
index 57f9915..1357c7a 100644
--- a/apisix/schema_def.lua
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1592: feat: expose JSON Schema through API
starsz commented on a change in pull request #1592:
URL: https://github.com/apache/apisix-dashboard/pull/1592#discussion_r594002376
##
File path: api/internal/handler/schema/schema.go
##
@@ -0,0 +1,76 @@
+/*
Review comment:
I think you can merge `plugin.go` to `schema.go`.
##
File path: api/test/e2enew/schema/schema_suite_test.go
##
@@ -23,5 +23,5 @@ import (
)
func TestPlugin(t *testing.T) {
Review comment:
Rename to TestSchema?
##
File path: api/internal/handler/schema/plugin_test.go
##
@@ -60,84 +58,9 @@ func TestPlugin(t *testing.T) {
basicAuthConsumerSchema = string(consumerSchemaByte)
assert.Nil(t, err)
}
-
- assert.Contains(t, conf.Plugins, plugin["name"])
}
-
- assert.Contains(t, conf.Plugins, "server-info")
- assert.Contains(t, conf.Plugins, "traffic-split")
- assert.NotContains(t, conf.Plugins, "dubbo-proxy")
-
// plugin type
assert.ElementsMatch(t, []string{"basic-auth", "jwt-auth", "hmac-auth",
"key-auth", "wolf-rbac"}, authPlugins)
// consumer schema
assert.Equal(t,
`{"additionalProperties":false,"properties":{"password":{"type":"string"},"username":{"type":"string"}},"required":["password","username"],"title":"work
with consumer object","type":"object"}`, basicAuthConsumerSchema)
-
Review comment:
Why delete those tests?
##
File path: api/internal/handler/schema/plugin.go
##
@@ -90,11 +65,9 @@ func (h *Handler) Plugins(c droplet.Context) (interface{},
error) {
var ret []string
list := plugins.Map()
for pluginName := range list {
- if res, ok := conf.Plugins[pluginName]; !ok || !res {
- continue
+ if pluginName != "serverless-post-function" && pluginName !=
"serverless-pre-function" {
+ ret = append(ret, pluginName)
Review comment:
The logic had changed？
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo
nic-chen commented on pull request #1583: URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-799033939 > Thank you @membphis :) > > It seems few recently added tests are failing. I am going to push the changes really soon after rechecking the code. > > Btw, I have a small query. Here I have used [`gomega`](https://onsi.github.io/gomega/) with ginkgo as a matcher library (as they are widely used as a combo for being more bdd style), will that be okay, or I should stick with the assert package that is currently being used? I know this lib, but I don't know its details very well. Could you share us the benefits of using this lib? @bisakhmondal Thanks. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1592: feat: expose JSON Schema through API
nic-chen commented on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-799033033 > why this PR will decrease coverage by 12.25%？ Because the coverage of the last PR merged into the master only counts the coverage of `frontend-e2e-test`, see: https://github.com/apache/apisix-dashboard/pull/1587#issuecomment-798343221 And in this PR it’s calculated The coverage of `frontend-e2e-test` and `backend-e2e-test`, so the statistical result is decreased. We have contacted codecov to see if we can solve this unstable problem. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo
membphis commented on pull request #1583: URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-799030114 > Here I have used [`gomega`](https://onsi.github.io/gomega/) with ginkgo as a matcher library (as they are widely used as a combo for being more bdd style), will that be okay, or I should stick with the assert package that is currently being used? need @nic-chen or @gxthrj help This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio commented on pull request #1558: feat:Support duplicate one existing Route
batman-ezio commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799028747 > ping @LiteSun I see he fire the PR for fix, https://github.com/apache/apisix-dashboard/pull/1590/files This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3766: docs: add --server option for the use of luarocks
spacewander commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r593997301 ## File path: Makefile ## @@ -60,6 +60,7 @@ help: default ### deps: Installation dependencies .PHONY: deps deps: default +luarocks install apisix --server https://luarocks.cn Review comment: @stu01509 I have already told you **many times**. > See my first comment. "We should wrap the server option in `make deps` ...". We need to introduce something like `LUAROCKS_SERVER=https://luarocks.cn make deps`. https://github.com/apache/apisix/pull/3766#discussion_r589118059 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3809: feat: upgrade lua-resty-expr/radixtree to support logical expression
spacewander commented on pull request #3809: URL: https://github.com/apache/apisix/pull/3809#issuecomment-799026854 > > > > do we need to add doc for this PR？ > > We may add a link to refer to the lua-resty-expr. We have already done it in the doc. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3817: test: make control/discovery.t stable
spacewander merged pull request #3817: URL: https://github.com/apache/apisix/pull/3817 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: test: make control/discovery.t stable (#3817)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new ecb04f3 test: make control/discovery.t stable (#3817)
ecb04f3 is described below
commit ecb04f380f9a1ff23bd7831e9470a5cedb96fc93
Author: 罗泽轩
AuthorDate: Mon Mar 15 09:13:20 2021 +0800
test: make control/discovery.t stable (#3817)
---
t/control/discovery.t | 25 +
1 file changed, 21 insertions(+), 4 deletions(-)
diff --git a/t/control/discovery.t b/t/control/discovery.t
index c9a4ed2..e16db43 100644
--- a/t/control/discovery.t
+++ b/t/control/discovery.t
@@ -88,16 +88,33 @@ GET /t
local t = require("lib.test_admin")
local code, body, res = t.test('/v1/discovery/eureka/dump',
-ngx.HTTP_GET)
-local entity = json.decode(res)
-ngx.say(json.encode(entity))
+ngx.HTTP_GET, nil,
+[[{
+"config": {
+"fetch_interval": 10,
+"host": [
+"http://127.0.0.1:8761;
+],
+"prefix": "/eureka/",
+"timeout": {
+"connect": 1500,
+"read": 1500,
+"send": 1500
+},
+"weight": 80
+},
+"services": {}
+}]]
+)
+ngx.satus = code
+ngx.say(body)
}
}
--- request
GET /t
--- error_code: 200
--- response_body
-{"config":{"fetch_interval":10,"host":["http://127.0.0.1:8761"],"prefix":"/eureka/","timeout":{"connect":1500,"read":1500,"send":1500},"weight":80},"services":{}}
+passed
[GitHub] [apisix] tokers merged pull request #3821: chore: fix spelling, grammar and JSON example
tokers merged pull request #3821: URL: https://github.com/apache/apisix/pull/3821 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: chore: fix spelling, grammar and JSON example (#3821)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 9fafa43 chore: fix spelling, grammar and JSON example (#3821)
9fafa43 is described below
commit 9fafa43b3758a026db1c992a71e80e1a38ce5c96
Author: John Bampton
AuthorDate: Mon Mar 15 10:56:43 2021 +1000
chore: fix spelling, grammar and JSON example (#3821)
---
apisix/discovery/consul_kv.lua | 2 +-
apisix/init.lua| 4 ++--
apisix/plugin.lua | 4 ++--
apisix/plugins/api-breaker.lua | 2 +-
apisix/plugins/error-log-logger.lua| 2 +-
apisix/plugins/example-plugin.lua | 2 +-
apisix/plugins/log-rotate.lua | 2 +-
apisix/plugins/node-status.lua | 4 ++--
apisix/plugins/prometheus/exporter.lua | 4 ++--
apisix/plugins/response-rewrite.lua| 6 +++---
apisix/plugins/server-info.lua | 2 +-
docs/en/latest/admin-api.md| 2 +-
docs/en/latest/discovery/consul_kv.md | 1 -
docs/en/latest/discovery/dns.md| 2 +-
t/control/discovery.t | 2 +-
t/node/grpc-proxy.t| 2 +-
t/node/remote-addr-ipv6.t | 2 +-
t/node/upstream-ipv6.t | 2 +-
t/plugin/prometheus2.t | 6 +++---
t/plugin/response-rewrite.t| 4 ++--
20 files changed, 28 insertions(+), 29 deletions(-)
diff --git a/apisix/discovery/consul_kv.lua b/apisix/discovery/consul_kv.lua
index 5f53231..e94f043 100644
--- a/apisix/discovery/consul_kv.lua
+++ b/apisix/discovery/consul_kv.lua
@@ -319,7 +319,7 @@ local function format_consul_params(consul_conf)
if scheme ~= "http" then
return nil, "only support consul http schema address, eg:
http://address:port;
elseif path ~= "/" or core.string.has_suffix(v, '/') then
-return nil, "invald consul server address, the valid format:
http://address:port;
+return nil, "invalid consul server address, the valid format:
http://address:port;
end
core.table.insert(consul_server_list, {
diff --git a/apisix/init.lua b/apisix/init.lua
index beec7e6..0b29257 100644
--- a/apisix/init.lua
+++ b/apisix/init.lua
@@ -548,7 +548,7 @@ function _M.http_body_filter_phase()
end
-local function healcheck_passive(api_ctx)
+local function healthcheck_passive(api_ctx)
local checker = api_ctx.up_checker
if not checker then
return
@@ -605,7 +605,7 @@ end
function _M.http_log_phase()
local api_ctx = common_phase("log")
-healcheck_passive(api_ctx)
+healthcheck_passive(api_ctx)
if api_ctx.server_picker and api_ctx.server_picker.after_balance then
api_ctx.server_picker.after_balance(api_ctx, false)
diff --git a/apisix/plugin.lua b/apisix/plugin.lua
index 4cbf722..8c9534a 100644
--- a/apisix/plugin.lua
+++ b/apisix/plugin.lua
@@ -71,8 +71,8 @@ local function unload_plugin(name, is_stream_plugin)
end
local old_plugin = pkg_loaded[pkg_name]
-if old_plugin and type(old_plugin.destory) == "function" then
-old_plugin.destory()
+if old_plugin and type(old_plugin.destroy) == "function" then
+old_plugin.destroy()
end
pkg_loaded[pkg_name] = nil
diff --git a/apisix/plugins/api-breaker.lua b/apisix/plugins/api-breaker.lua
index af3856b..7856373 100644
--- a/apisix/plugins/api-breaker.lua
+++ b/apisix/plugins/api-breaker.lua
@@ -174,7 +174,7 @@ function _M.log(conf, ctx)
return
end
--- unhealth process
+-- unhealthy process
if core.table.array_find(conf.unhealthy.http_statuses,
upstream_status)
then
diff --git a/apisix/plugins/error-log-logger.lua
b/apisix/plugins/error-log-logger.lua
index 9e5c746..c2d6d74 100644
--- a/apisix/plugins/error-log-logger.lua
+++ b/apisix/plugins/error-log-logger.lua
@@ -202,7 +202,7 @@ function _M.init()
end
-function _M.destory()
+function _M.destroy()
timers.unregister_timer("plugin#error-log-logger", true)
end
diff --git a/apisix/plugins/example-plugin.lua
b/apisix/plugins/example-plugin.lua
index 5d281ef..abe149e 100644
--- a/apisix/plugins/example-plugin.lua
+++ b/apisix/plugins/example-plugin.lua
@@ -66,7 +66,7 @@ function _M.init()
end
-function _M.destory()
+function _M.destroy()
-- call this function when plugin is unloaded
end
diff --git a/apisix/plugins/log-rotate.lua b/apisix/plugins/log-rotate.lua
index 22709c2..4a03a80 100644
--- a/apisix/plugins/log-rotate.lua
+++ b/apisix/plugins/log-rotate.lua
@@ -210,7 +210,7 @@ function _M.init()
end
-function _M.destory()
+function _M.destroy()
timers.unregister_timer("plugin#log-rotate", true)
end
diff --git a/apisix/plugins/node-status.lua b/apisix/plugins/node-status.lua
index 15c65bb..ceb574b 100644
--- a/apisix/plugins/node-status.lua
+++
[GitHub] [apisix] tokers merged pull request #3758: fix: the traffic-split plugin is invalid to bind upstream via upstream_id
tokers merged pull request #3758: URL: https://github.com/apache/apisix/pull/3758 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers closed issue #3740: bug: the traffic-split plugin is invalid to bind upstream via upstream_id
tokers closed issue #3740: URL: https://github.com/apache/apisix/issues/3740 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (4ebccaf -> 210ca46)
This is an automated email from the ASF dual-hosted git repository. tokers pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 4ebccaf chore: fix spelling (#3253) add 210ca46 fix: the traffic-split plugin is invalid to bind upstream via upstream_id (#3758) No new revisions were added by this update. Summary of changes: apisix/plugins/traffic-split.lua | 15 ++-- t/plugin/traffic-split.t | 143 --- 2 files changed, 143 insertions(+), 15 deletions(-)
[GitHub] [apisix] tokers commented on pull request #3809: feat: upgrade lua-resty-expr/radixtree to support logical expression
tokers commented on pull request #3809: URL: https://github.com/apache/apisix/pull/3809#issuecomment-799020165 > do we need to add doc for this PR？ We may add a link to refer to the lua-resty-expr. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio edited a comment on pull request #1558: feat:Support duplicate one existing Route
batman-ezio edited a comment on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799015546 after rebase from latest master, the frontend test case is still failed. `should import route(s) from be test files` failed because click from multi routes. maybe import in foreach look needs to ensure the route is deleted. add async? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] batman-ezio commented on pull request #1558: feat:Support duplicate one existing Route
batman-ezio commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-799015546 after rebase from latest master, the frontend test case is still failed. `should import route(s) from be test files` failed because from click multi routes. maybe import in foreach look needs to ensure the route is deleted. add async? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on pull request #3809: feat: upgrade lua-resty-expr/radixtree to support logical expression
moonming commented on pull request #3809: URL: https://github.com/apache/apisix/pull/3809#issuecomment-799014965 do we need to add doc for this PR？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on issue #1554: bug: 通过API创建的upstream和route，在dashboard的route详情页面中显示不完整
guoqqqi commented on issue #1554: URL: https://github.com/apache/apisix-dashboard/issues/1554#issuecomment-799014895 Hi @miaoyb @membphis , sorry for the late reply. Do you mean you tried this guide: https://apisix.apache.org/docs/apisix/getting-started#create-an-upstream ? if yes, then the dashboard will not show those fields, for we don't have those fields indeed when creating that upstream and route. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] stu01509 commented on a change in pull request #3766: docs: add --server option for the use of luarocks
stu01509 commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r593988469 ## File path: Makefile ## @@ -60,6 +60,7 @@ help: default ### deps: Installation dependencies .PHONY: deps deps: default +luarocks install apisix --server https://luarocks.cn Review comment: Hi @membphis Ok, so what should I change? I am not familiar with `Makefile` cc @spacewander This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] stu01509 commented on a change in pull request #3766: docs: add --server option for the use of luarocks
stu01509 commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r593988469 ## File path: Makefile ## @@ -60,6 +60,7 @@ help: default ### deps: Installation dependencies .PHONY: deps deps: default +luarocks install apisix --server https://luarocks.cn Review comment: Hi @membphis Ok, so what should I change? cc @spacewander This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] moonming commented on pull request #1592: feat: expose JSON Schema through API
moonming commented on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-799013592 why this PR will decrease coverage by 12.25%？ This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error
stu01509 commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r593988141 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component": "umi test ./src/components", "tsc": "tsc", -"cypress:open": "CYPRESS_SERVE_ENV=test cypress open", -"cypress:open-dev": "CYPRESS_SERVE_ENV=dev cypress open", -"cypress:run-ci": "CYPRESS_SERVE_ENV=test cypress run" +"cypress:open": "cross-env CYPRESS_SERVE_ENV=test cypress open", Review comment: But If we don't use the `cross-env` to set the env variables, the cypress definitely will fail to start. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1580: fix: fix the upstream timeout unit
nic-chen commented on pull request #1580: URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-799003391 thanks @liuxiran This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1590: fix: fe e2e error for pr 1538
codecov-io edited a comment on pull request #1590: URL: https://github.com/apache/apisix-dashboard/pull/1590#issuecomment-798638590 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=h1) Report > Merging [#1590](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=desc) (9a5a9a3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9a92ff95ddbe43432247a8b49ba63a9de115e726?el=desc) (9a92ff9) will **decrease** coverage by `0.56%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1590 +/- ## == - Coverage 70.88% 70.32% -0.57% == Files 135 46 -89 Lines5485 3019-2466 Branches 5830 -583 == - Hits 3888 2123-1765 + Misses 1349 651 -698 + Partials 248 245 -3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `60.88% <ø> (+5.16%)` | :arrow_up: | | backend-e2e-test-ginkgo | `46.17% <ø> (+6.09%)` | :arrow_up: | | backend-unit-test | `51.54% <ø> (-0.14%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `69.01% <0.00%> (-2.87%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (ø)` | | | [web/src/components/HeaderDropdown/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0hlYWRlckRyb3Bkb3duL2luZGV4LnRzeA==) | | | | [...components/PluginOrchestration/components/Page.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vY29tcG9uZW50cy9QYWdlLnRzeA==) | | | | [web/src/pages/Upstream/components/Step1.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9jb21wb25lbnRzL1N0ZXAxLnRzeA==) | | | | [.../components/PluginOrchestration/DrawPluginStyle.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbk9yY2hlc3RyYXRpb24vRHJhd1BsdWdpblN0eWxlLnRz) | | | | [web/src/components/Footer/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0Zvb3Rlci9pbmRleC50c3g=) | | | | [web/src/services/tool.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-d2ViL3NyYy9zZXJ2aWNlcy90b29sLnRz) | | | | [web/src/pages/Upstream/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9MaXN0LnRzeA==) | | | | [...b/src/pages/User/components/LoginMethodExample.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL2NvbXBvbmVudHMvTG9naW5NZXRob2RFeGFtcGxlLnRzeA==) | | | | ... and [85 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=footer). Last update [9a92ff9...9a5a9a3](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1590: fix: fe e2e error for pr 1538
codecov-io edited a comment on pull request #1590: URL: https://github.com/apache/apisix-dashboard/pull/1590#issuecomment-798638590 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=h1) Report > Merging [#1590](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=desc) (9a5a9a3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9a92ff95ddbe43432247a8b49ba63a9de115e726?el=desc) (9a92ff9) will **decrease** coverage by `4.63%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1590 +/- ## == - Coverage 70.88% 66.24% -4.64% == Files 135 46 -89 Lines5485 3019-2466 Branches 5830 -583 == - Hits 3888 2000-1888 + Misses 1349 771 -578 Partials 248 248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `46.17% <ø> (+6.09%)` | :arrow_up: | | backend-unit-test | `51.54% <ø> (-0.14%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `32.25% <0.00%> (-32.67%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `77.14% <0.00%> (-8.58%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `69.01% <0.00%> (-2.87%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | ... and [94 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=footer). Last update [9a92ff9...9a5a9a3](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please
[GitHub] [apisix-dashboard] liuxiran commented on pull request #1580: fix: fix the upstream timeout unit
liuxiran commented on pull request #1580: URL: https://github.com/apache/apisix-dashboard/pull/1580#issuecomment-798992193 > Hi @liuxiran and @nic-chen > > Thanks for point out, so should I fix the E2E test error or waiting for @nic-chen to solve it? you can try to fix the e2e error in `route/import_export_route.spec.js` first @stu01509 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
codecov-io edited a comment on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=h1) Report > Merging [#1576](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=desc) (0c6bc6b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9a92ff95ddbe43432247a8b49ba63a9de115e726?el=desc) (9a92ff9) will **decrease** coverage by `0.56%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1576 +/- ## == - Coverage 70.88% 70.32% -0.57% == Files 135 46 -89 Lines5485 3019-2466 Branches 5830 -583 == - Hits 3888 2123-1765 + Misses 1349 651 -698 + Partials 248 245 -3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `60.88% <ø> (+5.16%)` | :arrow_up: | | backend-e2e-test-ginkgo | `46.40% <ø> (+6.33%)` | :arrow_up: | | backend-unit-test | `51.54% <ø> (-0.14%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `69.01% <0.00%> (-2.87%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (ø)` | | | [web/src/pages/Route/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9MaXN0LnRzeA==) | | | | [web/src/components/HeaderDropdown/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0hlYWRlckRyb3Bkb3duL2luZGV4LnRzeA==) | | | | [web/src/services/tool.ts](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-d2ViL3NyYy9zZXJ2aWNlcy90b29sLnRz) | | | | [api/internal/core/store/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvcXVlcnkuZ28=) | | | | [...Route/components/DebugViews/AuthenticationView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvQXV0aGVudGljYXRpb25WaWV3LnRzeA==) | | | | [api/internal/core/entity/query.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L3F1ZXJ5Lmdv) | | | | [web/src/components/Footer/index.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0Zvb3Rlci9pbmRleC50c3g=) | | | | [web/src/components/LabelsfDrawer/LabelsDrawer.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL0xhYmVsc2ZEcmF3ZXIvTGFiZWxzRHJhd2VyLnRzeA==) | | | | ... and [81 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=footer). Last update [9a92ff9...0c6bc6b](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1590: fix: fe e2e error for pr 1538
codecov-io edited a comment on pull request #1590: URL: https://github.com/apache/apisix-dashboard/pull/1590#issuecomment-798638590 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=h1) Report > Merging [#1590](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=desc) (9a5a9a3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9a92ff95ddbe43432247a8b49ba63a9de115e726?el=desc) (9a92ff9) will **decrease** coverage by `19.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1590 +/- ## === - Coverage 70.88% 51.54% -19.34% === Files 135 37 -98 Lines5485 2555 -2930 Branches 5830 -583 === - Hits 3888 1317 -2571 + Misses 1349 1057 -292 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.54% <ø> (-0.14%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [120 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1590/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=footer). Last update [9a92ff9...9a5a9a3](https://codecov.io/gh/apache/apisix-dashboard/pull/1590?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
codecov-io edited a comment on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=h1) Report > Merging [#1576](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=desc) (0c6bc6b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9a92ff95ddbe43432247a8b49ba63a9de115e726?el=desc) (9a92ff9) will **decrease** coverage by `4.40%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1576 +/- ## == - Coverage 70.88% 66.47% -4.41% == Files 135 46 -89 Lines5485 3019-2466 Branches 5830 -583 == - Hits 3888 2007-1881 + Misses 1349 764 -585 Partials 248 248 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `46.40% <ø> (+6.33%)` | :arrow_up: | | backend-unit-test | `51.54% <ø> (-0.14%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `77.14% <0.00%> (-8.58%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | `69.01% <0.00%> (-2.87%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | ... and [90 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=footer). Last update [9a92ff9...0c6bc6b](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1590: fix: fe e2e error for pr 1538
liuxiran commented on a change in pull request #1590:
URL: https://github.com/apache/apisix-dashboard/pull/1590#discussion_r593971033
##
File path: web/cypress/integration/route/import_export_route.spec.js
##
@@ -159,7 +159,7 @@ context('import and export routes', () => {
cy.get(this.domSelector.notification).should(
'contain', 'Success'
);
-cy.get(this.domSelector.fileSelectorClose).click();
+//cy.get(this.domSelector.fileSelectorClose).click();
Review comment:
removed, thanks
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1576: fix: config proxy-rewrite out of the plugin market in route module
codecov-io edited a comment on pull request #1576: URL: https://github.com/apache/apisix-dashboard/pull/1576#issuecomment-795836615 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=h1) Report > Merging [#1576](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=desc) (0c6bc6b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9a92ff95ddbe43432247a8b49ba63a9de115e726?el=desc) (9a92ff9) will **decrease** coverage by `19.33%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1576 +/- ## === - Coverage 70.88% 51.54% -19.34% === Files 135 37 -98 Lines5485 2555 -2930 Branches 5830 -583 === - Hits 3888 1317 -2571 + Misses 1349 1057 -292 + Partials 248 181 -67 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.54% <ø> (-0.14%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `57.14% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `0.00% <0.00%> (-33.34%)` | :arrow_down: | | ... and [116 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1576/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=footer). Last update [9a92ff9...0c6bc6b](https://codecov.io/gh/apache/apisix-dashboard/pull/1576?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1592: feat: expose JSON Schema through API
bisakhmondal commented on a change in pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#discussion_r593944343 ## File path: api/test/e2enew/schema/plugin_test.go ## @@ -0,0 +1,53 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package schema + +import ( + "net/http" + + "github.com/onsi/ginkgo" + "github.com/onsi/ginkgo/extensions/table" + + "e2enew/base" Review comment: e2enew module path has been updated in #1578 ```suggestion "github.com/apisix/manager-api/test/e2enew/base" ``` ## File path: api/test/e2enew/schema/schema_test.go ## @@ -14,47 +14,22 @@ * See the License for the specific language governing permissions and * limitations under the License. */ -package plugin +package schema import ( "net/http" "github.com/onsi/ginkgo" "github.com/onsi/ginkgo/extensions/table" - "github.com/apisix/manager-api/test/e2enew/base" + "e2enew/base" Review comment: same here ```suggestion "github.com/apisix/manager-api/test/e2enew/base" ``` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo
bisakhmondal commented on pull request #1583: URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-798957791 Thank you @membphis :) It seems few recently added tests are failing. I am going to push the changes really soon after rechecking the code. Btw, I have a small query. Here I have used [`gomega`](https://onsi.github.io/gomega/) with ginkgo as a matcher library (as they are widely used as a combo for being more bdd style), will that be okay, or I should stick with the assert package that is currently being used? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1592: feat: expose JSON Schema through API
codecov-io edited a comment on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-798933657 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=h1) Report > Merging [#1592](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=desc) (dd1740b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7?el=desc) (9cb4b43) will **decrease** coverage by `12.25%`. > The diff coverage is `31.81%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1592 +/- ## === - Coverage 71.64% 59.38% -12.26% === Files 132 133+1 Lines5339 5343+4 Branches 584 584 === - Hits 3825 3173 -652 - Misses 1269 1927 +658 + Partials 245 243-2 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `48.72% <31.81%> (-12.16%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.27% <ø> (-0.09%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | `15.78% <0.00%> (ø)` | | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `29.41% <29.41%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `86.11% <100.00%> (+0.39%)` | :arrow_up: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.88% <0.00%> (-68.63%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `12.04% <0.00%> (-61.26%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `33.64% <0.00%> (-55.15%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | ... and [26 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=footer). Last update [9cb4b43...dd1740b](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1592: feat: expose JSON Schema through API
codecov-io commented on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-798933657 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=h1) Report > Merging [#1592](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=desc) (dd1740b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/9cb4b430e4337a9a1b6a4b3eea4763a76c2feeb7?el=desc) (9cb4b43) will **decrease** coverage by `22.91%`. > The diff coverage is `31.81%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1592 +/- ## === - Coverage 71.64% 48.72% -22.92% === Files 132 47 -85 Lines5339 3023 -2316 Branches 5840 -584 === - Hits 3825 1473 -2352 - Misses 1269 1307 +38 + Partials 245 243-2 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `48.72% <31.81%> (-12.16%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | `15.78% <0.00%> (ø)` | | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `29.41% <29.41%> (ø)` | | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `86.11% <100.00%> (+0.39%)` | :arrow_up: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.88% <0.00%> (-68.63%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `12.04% <0.00%> (-61.26%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `33.64% <0.00%> (-55.15%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | ... and [111 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1592/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=footer). Last update [9cb4b43...dd1740b](https://codecov.io/gh/apache/apisix-dashboard/pull/1592?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to
[GitHub] [apisix] membphis commented on a change in pull request #3766: docs: add --server option for the use of luarocks
membphis commented on a change in pull request #3766: URL: https://github.com/apache/apisix/pull/3766#discussion_r593922682 ## File path: Makefile ## @@ -60,6 +60,7 @@ help: default ### deps: Installation dependencies .PHONY: deps deps: default +luarocks install apisix --server https://luarocks.cn Review comment: this is wrong, we can not call install apisix when call `make deps` This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1592: feat: expose JSON Schema through API
juzhiyuan commented on pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592#issuecomment-798932681 also cc @guoqqqi to review This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1592: feat: expose JSON Schema through API
nic-chen opened a new pull request #1592: URL: https://github.com/apache/apisix-dashboard/pull/1592 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues close #1450 ___ ### New feature or improvement - Describe the details and related test reports. The APISIX ingress controller needs to use the json schema (dashboard FE or other projects may also need it), and it still use the admin api interface. At present, the manager api only supports to expose the json schema of plugins. so we now support exposing JSON Schema of all resources and plugins through API ___ ### Please add the corresponding test cases if necessary. added. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1512: Plugin template configuration
juzhiyuan commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-798932003 @LiteSun Do remember to use `close/resolve/fix #xxx` to link issue in PR. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3787: [discuss]: does the traffic-split plugin has a way to implement the original capabilities without corrupting the data?
membphis commented on issue #3787: URL: https://github.com/apache/apisix/issues/3787#issuecomment-798931154 ping @Firstsawyou This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r593920864 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component": "umi test ./src/components", "tsc": "tsc", -"cypress:open": "CYPRESS_SERVE_ENV=test cypress open", -"cypress:open-dev": "CYPRESS_SERVE_ENV=dev cypress open", -"cypress:run-ci": "CYPRESS_SERVE_ENV=test cypress run" +"cypress:open": "cross-env CYPRESS_SERVE_ENV=test cypress open", Review comment: Maybe a FAQ or some tips would be better? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1591: fix: fix CYPRESS cross platform env error
juzhiyuan commented on a change in pull request #1591: URL: https://github.com/apache/apisix-dashboard/pull/1591#discussion_r593920843 ## File path: web/package.json ## @@ -29,9 +29,9 @@ "start:test": "cross-env REACT_APP_ENV=test MOCK=none umi dev", "test:component": "umi test ./src/components", "tsc": "tsc", -"cypress:open": "CYPRESS_SERVE_ENV=test cypress open", -"cypress:open-dev": "CYPRESS_SERVE_ENV=dev cypress open", -"cypress:run-ci": "CYPRESS_SERVE_ENV=test cypress run" +"cypress:open": "cross-env CYPRESS_SERVE_ENV=test cypress open", Review comment: `cross-env` is used in Windows IMO 樂 we can't set it here directly. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3732: bug: plugin ip-restriction cannot work on HTTPS
membphis commented on issue #3732: URL: https://github.com/apache/apisix/issues/3732#issuecomment-798930218 ping @chenyicai This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1554: bug: 通过API创建的upstream和route，在dashboard的route详情页面中显示不完整
juzhiyuan commented on issue #1554: URL: https://github.com/apache/apisix-dashboard/issues/1554#issuecomment-798930164 I remember @guoqqqi has been checking on this issue, what's your feedback? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3673: request help: A node in the K8S environment ETCD cluster died, causing Apisix to fail
membphis commented on issue #3673: URL: https://github.com/apache/apisix/issues/3673#issuecomment-798930161 ping @Yiyiyimu This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1583: fest: rewrite e2e test(route_import_test) with ginkgo
membphis commented on pull request #1583: URL: https://github.com/apache/apisix-dashboard/pull/1583#issuecomment-798928940 @bisakhmondal ci failed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1558: feat:Support duplicate one existing Route
membphis commented on pull request #1558: URL: https://github.com/apache/apisix-dashboard/pull/1558#issuecomment-798928415 ping @LiteSun This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on pull request #1490: feat: support yaml to config plugin in plugin config page
membphis commented on pull request #1490: URL: https://github.com/apache/apisix-dashboard/pull/1490#issuecomment-798928256 ping @LiteSun This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1554: bug: 通过API创建的upstream和route，在dashboard的route详情页面中显示不完整
membphis commented on issue #1554: URL: https://github.com/apache/apisix-dashboard/issues/1554#issuecomment-798928119 any news? @juzhiyuan @guoqqqi This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1512: Plugin template configuration
membphis commented on issue #1512: URL: https://github.com/apache/apisix-dashboard/issues/1512#issuecomment-798928006 @litesun can we close this issue now? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton opened a new pull request #3821: chore: fix spelling, grammar and JSON example
jbampton opened a new pull request #3821: URL: https://github.com/apache/apisix/pull/3821 ### What this PR does / why we need it: Fixes spelling and an example ### Pre-submission checklist: * [X] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis merged pull request #299: docs: fix website broken links
membphis merged pull request #299: URL: https://github.com/apache/apisix-ingress-controller/pull/299 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] membphis closed issue #256: brokens links in installation docs about apisix-ingress-controller
membphis closed issue #256: URL: https://github.com/apache/apisix-website/issues/256 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: docs: fix website broken links (#299)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git The following commit(s) were added to refs/heads/master by this push: new 8d539a0 docs: fix website broken links (#299) 8d539a0 is described below commit 8d539a096036a93c34dffbc352242a872f5d4c6e Author: Cliff Su AuthorDate: Sun Mar 14 23:18:21 2021 +0800 docs: fix website broken links (#299) --- docs/en/latest/getting-started.md | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/docs/en/latest/getting-started.md b/docs/en/latest/getting-started.md index 7ec9960..1db11dc 100644 --- a/docs/en/latest/getting-started.md +++ b/docs/en/latest/getting-started.md @@ -52,13 +52,13 @@ See [Design](./design.md) for more details. apisix-ingress-controller supports to be installed on some clouds such as AWS, GCP. -* [Install Ingress APISIX on Azure AKS](./docs/en/latest/deployments/azure.md) -* [Install Ingress APISIX on AWS EKS](./docs/en/latest/deployments/aws.md) -* [Install Ingress APISIX on ACK](./docs/en/latest/deployments/ack.md) -* [Install Ingress APISIX on Google Cloud GKE](./docs/en/latest/deployments/gke.md) -* [Install Ingress APISIX on Minikube](./docs/en/latest/deployments/minikube.md) -* [Install Ingress APISIX on KubeSphere](./docs/en/latest/deployments/kubesphere.md) -* [Install Ingress APISIX on K3S and RKE](./docs/en/latest/deployments/k3s-rke.md) +* [Install Ingress APISIX on Azure AKS](https://apisix.apache.org/docs/ingress-controller/deployments/azure) +* [Install Ingress APISIX on AWS EKS](https://apisix.apache.org/docs/ingress-controller/deployments/aws) +* [Install Ingress APISIX on ACK](https://apisix.apache.org/docs/ingress-controller/deployments/ack) +* [Install Ingress APISIX on Google Cloud GKE](https://apisix.apache.org/docs/ingress-controller/deployments/gke) +* [Install Ingress APISIX on Minikube](https://apisix.apache.org/docs/ingress-controller/deployments/minikube) +* [Install Ingress APISIX on KubeSphere](https://apisix.apache.org/docs/ingress-controller/deployments/kubesphere) +* [Install Ingress APISIX on K3S and RKE](https://apisix.apache.org/docs/ingress-controller/deployments/k3s-rke) ## Installation on Prem
[GitHub] [apisix-ingress-controller] membphis commented on pull request #299: docs: fix website broken links
membphis commented on pull request #299: URL: https://github.com/apache/apisix-ingress-controller/pull/299#issuecomment-798925414 @stu01509 many thx This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis edited a comment on pull request #296: fix: use networking informer instead of extensions
membphis edited a comment on pull request #296: URL: https://github.com/apache/apisix-ingress-controller/pull/296#issuecomment-798925093 ping @gxthrj This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on pull request #296: fix: use networking informer instead of extensions
membphis commented on pull request #296: URL: https://github.com/apache/apisix-ingress-controller/pull/296#issuecomment-798925093 ping @Junnplus This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on pull request #300: add chinese version of decument
membphis commented on pull request #300: URL: https://github.com/apache/apisix-ingress-controller/pull/300#issuecomment-798924749 @soulsoul pls take a look at the output of CI  This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] membphis commented on pull request #283: docs: update deployments repository url
membphis commented on pull request #283: URL: https://github.com/apache/apisix-ingress-controller/pull/283#issuecomment-798924573 ping @gxthrj This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
