[GitHub] [apisix] Firstsawyou edited a comment on issue #3888: request help: Can I set timeout for each route?
Firstsawyou edited a comment on issue #3888: URL: https://github.com/apache/apisix/issues/3888#issuecomment-804627206 You can refer to the setting of the `timeout` field in upstream: https://github.com/apache/apisix/blob/2.4/docs/en/latest/admin-api.md#upstream In the route, you can configure upstream. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1650: feat: added github link to header #1632
codecov-io edited a comment on pull request #1650: URL: https://github.com/apache/apisix-dashboard/pull/1650#issuecomment-804602279 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=h1) Report > Merging [#1650](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=desc) (0d226c3) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/85efb37b0c5fe76c94a85f9fc0dc13312083181d?el=desc) (85efb37) will **increase** coverage by `1.51%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1650 +/- ## == + Coverage 72.38% 73.90% +1.51% == Files 134 87 -47 Lines5737 2621-3116 Branches 665 665 == - Hits 4153 1937-2216 + Misses 1341 684 -657 + Partials 2430 -243 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.90% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/pages/User/Login.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9Vc2VyL0xvZ2luLnRzeA==) | `72.00% <ø> (ø)` | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | | | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | | | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | | | | [api/internal/conf/conf.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvbmYvY29uZi5nbw==) | | | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | | | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | | | | ... and [42 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=footer). Last update [85efb37...0d226c3](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] qian0817 commented on issue #1150: plugin compose support Edge browser
qian0817 commented on issue #1150: URL: https://github.com/apache/apisix-dashboard/issues/1150#issuecomment-804627715 Hi @juzhiyuan I found plugin orchestration works well with Edge (Chromium) browser,so consider modifying the judgment condition to allow Edge to use this feature -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3888: request help: Can I set timeout for each route?
Firstsawyou commented on issue #3888: URL: https://github.com/apache/apisix/issues/3888#issuecomment-804627206 You can refer to the setting of the `timeout` field in upstream: https://github.com/apache/apisix/blob/2.4/docs/en/latest/admin-api.md#upstream -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on pull request #1650: feat: added github link to header #1632
iamayushdas edited a comment on pull request #1650: URL: https://github.com/apache/apisix-dashboard/pull/1650#issuecomment-804626773 > https://github.com/apache/apisix-dashboard/pull/1649 > > > > This PR will resolve backend CI I added the google cloud container registry to the repo as stated in #1649. I hope that won't be a issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1650: feat: added github link to header #1632
iamayushdas commented on pull request #1650: URL: https://github.com/apache/apisix-dashboard/pull/1650#issuecomment-804626773 > https://github.com/apache/apisix-dashboard/pull/1649 > > > > This PR will resolve backend CI I added the google cloud container registry to the repo. I hope that won't be a issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1651: feat: update menuicon
codecov-io edited a comment on pull request #1651: URL: https://github.com/apache/apisix-dashboard/pull/1651#issuecomment-804621787 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=h1) Report > Merging [#1651](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=desc) (ff218eb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/eecadb8c03d06a7edd5a730ee2a19ba070f7acb6?el=desc) (eecadb8) will **decrease** coverage by `8.55%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1651 +/- ## == - Coverage 70.33% 61.77% -8.56% == Files 134 47 -87 Lines5737 3116-2621 Branches 6650 -665 == - Hits 4035 1925-2110 + Misses 1450 878 -572 - Partials 252 313 +61 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `61.77% <ø> (+13.15%)` | :arrow_up: | | backend-e2e-test-ginkgo | `47.84% <ø> (?)` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `58.43% <0.00%> (-29.52%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-26.09%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `47.22% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/filter/ip\_filter.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9pcF9maWx0ZXIuZ28=) | `48.71% <0.00%> (-23.08%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `64.51% <0.00%> (-19.36%)` | :arrow_down: | | [...pi/internal/handler/plugin\_config/plugin\_config.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcGx1Z2luX2NvbmZpZy9wbHVnaW5fY29uZmlnLmdv) | `59.57% <0.00%> (-18.09%)` | :arrow_down: | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | `44.82% <0.00%> (-13.80%)` | :arrow_down: | | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | `88.23% <0.00%> (-11.77%)` | :arrow_down: | | ... and [105 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=footer). Last update [eecadb8...ff218eb](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1651: feat: update menuicon
codecov-io commented on pull request #1651: URL: https://github.com/apache/apisix-dashboard/pull/1651#issuecomment-804621787 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=h1) Report > Merging [#1651](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=desc) (ff218eb) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/eecadb8c03d06a7edd5a730ee2a19ba070f7acb6?el=desc) (eecadb8) will **decrease** coverage by `22.48%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1651 +/- ## === - Coverage 70.33% 47.84% -22.49% === Files 134 47 -87 Lines5737 3116 -2621 Branches 6650 -665 === - Hits 4035 1491 -2544 + Misses 1450 1340 -110 - Partials 252 285 +33 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `47.84% <ø> (?)` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-36.12%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `56.02% <0.00%> (-31.93%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-26.09%)` | :arrow_down: | | [api/internal/handler/consumer/consumer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvY29uc3VtZXIvY29uc3VtZXIuZ28=) | `65.95% <0.00%> (-25.54%)` | :arrow_down: | | ... and [106 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1651/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=footer). Last update [eecadb8...ff218eb](https://codecov.io/gh/apache/apisix-dashboard/pull/1651?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go
[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1651: feat: update menuicon
LiteSun opened a new pull request #1651: URL: https://github.com/apache/apisix-dashboard/pull/1651 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - [ ] Backport patches **What changes will this PR take into?** Please update this section with detailed description. update meunicon  **Related issues** fix/resolve #0001 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1648: feat: reset etcd before every test run.
LiteSun commented on pull request #1648: URL: https://github.com/apache/apisix-dashboard/pull/1648#issuecomment-804611185 > @LiteSun failed BE OK -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3886: bug: Execute "make deps" prompt "Could not find header file for OPENSSL"
spacewander commented on issue #3886: URL: https://github.com/apache/apisix/issues/3886#issuecomment-804608695 > Error: Please provide a flag for querying configuration values. See '/usr/bin/luarocks help config'. I guess you are using luarocks 2.x? If it is, please upgrade it to 3.x. You can take advantage of this script: https://github.com/apache/apisix/blob/master/utils/linux-install-luarocks.sh -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1647: chore(BE): Change route name feild required
codecov-io edited a comment on pull request #1647: URL: https://github.com/apache/apisix-dashboard/pull/1647#issuecomment-804328077 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=h1) Report > Merging [#1647](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=desc) (2530989) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/548bbe38f66ff18a6de6567bf13dc5b81a995a46?el=desc) (548bbe3) will **decrease** coverage by `12.47%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1647 +/- ## === - Coverage 72.29% 59.82% -12.48% === Files 134 134 Lines5736 5737+1 Branches 665 665 === - Hits 4147 3432 -715 - Misses 1345 2020 +675 - Partials 244 285 +41 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `47.97% <ø> (+0.06%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `73.90% <ø> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <ø> (-25.00%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-41.67%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `56.02% <0.00%> (-31.93%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: | | ... and [29 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=footer). Last update [548bbe3...2530989](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to
[GitHub] [apisix] Caelebs commented on issue #3886: bug: Execute "make deps" prompt "Could not find header file for OPENSSL"
Caelebs commented on issue #3886: URL: https://github.com/apache/apisix/issues/3886#issuecomment-804605385 I run the command `luarocks config variables` directly, it will prompt error and did not get your output ``` [root@TEST3 /0322/23/apisix] -> luarocks config variables Error: Please provide a flag for querying configuration values. See '/usr/bin/luarocks help config'. ``` I have compiled and installed apisix2.2 version before on this machine, These errors did not appear at the time. The document requires `openresty-openssl-devel` to be installed instead of ` openresty-openssl111-devel`, so I have uninstalled `openresty-openssl111-devel`, but the error still persists ``` [root@TEST3 /0322/23/apisix] -> rpm -qa | grep -i openssl openssl-libs-1.0.2k-16.el7.x86_64 openresty-openssl111-1.1.1i-1.el7.x86_64 openresty-openssl-1.1.0l-2.el7.x86_64 openresty-openssl-devel-1.1.0l-2.el7.x86_64 openssl-1.0.2k-16.el7.x86_64 ``` @spacewander @Firstsawyou -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1647: chore(BE): Change route name feild required
codecov-io edited a comment on pull request #1647: URL: https://github.com/apache/apisix-dashboard/pull/1647#issuecomment-804328077 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=h1) Report > Merging [#1647](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=desc) (2530989) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/548bbe38f66ff18a6de6567bf13dc5b81a995a46?el=desc) (548bbe3) will **increase** coverage by `1.60%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1647 +/- ## == + Coverage 72.29% 73.90% +1.60% == Files 134 87 -47 Lines5736 2621-3115 Branches 665 665 == - Hits 4147 1937-2210 + Misses 1345 684 -661 + Partials 2440 -244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.90% <ø> (+0.12%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | `61.53% <0.00%> (-0.48%)` | :arrow_down: | | [web/src/pages/Upstream/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9MaXN0LnRzeA==) | `90.00% <0.00%> (ø)` | | | [web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4) | `81.25% <0.00%> (ø)` | | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | | | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | | | [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | | | | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | | | | ... and [46 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=footer). Last update [548bbe3...2530989](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1650: feat: added github link to header #1632
codecov-io commented on pull request #1650: URL: https://github.com/apache/apisix-dashboard/pull/1650#issuecomment-804602279 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=h1) Report > Merging [#1650](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=desc) (8615aa9) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/85efb37b0c5fe76c94a85f9fc0dc13312083181d?el=desc) (85efb37) will **decrease** coverage by `24.63%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1650 +/- ## === - Coverage 72.38% 47.75% -24.64% === Files 134 47 -87 Lines5737 3116 -2621 Branches 6650 -665 === - Hits 4153 1488 -2665 - Misses 1341 1345+4 - Partials 243 283 +40 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `47.75% <ø> (+0.03%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-41.67%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `56.02% <0.00%> (-33.14%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `51.83% <0.00%> (-26.94%)` | :arrow_down: | | ... and [105 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1650/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=footer). Last update [85efb37...8615aa9](https://codecov.io/gh/apache/apisix-dashboard/pull/1650?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1632: improve some minor issues
juzhiyuan commented on issue #1632: URL: https://github.com/apache/apisix-dashboard/issues/1632#issuecomment-804602254 good good -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1650: feat: added github link to header #1632
juzhiyuan commented on pull request #1650: URL: https://github.com/apache/apisix-dashboard/pull/1650#issuecomment-804602203 https://github.com/apache/apisix-dashboard/pull/1649 This PR will resolve backend CI -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] diaosj opened a new issue #3888: request help: Can I set timeout for each route?
diaosj opened a new issue #3888: URL: https://github.com/apache/apisix/issues/3888 ### Issue description Nginx has a series of timeout settings, such as `proxy_connect_timeout`、`proxy_read_timeout`. These settings are valid for all the connections. Can I set these params to a large value (say 3600s), and then control timeout (say 60s) for each route? ### Environment * apisix version (cmd: `apisix version`): 2.3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou edited a comment on issue #3886: bug: Execute "make deps" prompt "Could not find header file for OPENSSL"
Firstsawyou edited a comment on issue #3886: URL: https://github.com/apache/apisix/issues/3886#issuecomment-804599821 This seems to be caused by incorrect openssl development kit of openresty. https://github.com/apache/apisix/blob/master/docs/en/latest/FAQ.md#why-does-the-make-deps-command-fail-in-source-installation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3886: bug: Execute "make deps" prompt "Could not find header file for OPENSSL"
Firstsawyou commented on issue #3886: URL: https://github.com/apache/apisix/issues/3886#issuecomment-804599821 This seems to be caused by the lack of the openssl development kit of openresty. https://github.com/apache/apisix/blob/master/docs/en/latest/FAQ.md#why-does-the-make-deps-command-fail-in-source-installation -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas edited a comment on issue #1632: improve some minor issues
iamayushdas edited a comment on issue #1632: URL: https://github.com/apache/apisix-dashboard/issues/1632#issuecomment-804596214 ## TODO * [ ] Left icon replacement. @LiteSun * [ ] Extracting Table as a separate component for reuse in various modules. * [ ] APISIX plugin type change. * [x] GitHub hyperlink (icon) added to Header section.  PR: #1650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1650: feat: added github link to header #1632
iamayushdas commented on pull request #1650: URL: https://github.com/apache/apisix-dashboard/pull/1650#issuecomment-804596821 CI not responding @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on issue #1632: improve some minor issues
iamayushdas commented on issue #1632: URL: https://github.com/apache/apisix-dashboard/issues/1632#issuecomment-804596214 ## TODO * [ ] Left icon replacement. @LiteSun * [ ] Extracting Table as a separate component for reuse in various modules. * [ ] APISIX plugin type change. * [x] GitHub hyperlink (icon) added to Header section.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3886: bug: Execute "make deps" prompt "Could not find header file for OPENSSL"
spacewander commented on issue #3886:
URL: https://github.com/apache/apisix/issues/3886#issuecomment-804595859
>
>
> Sorry, I don't know the usage of this command. According to the -h prompt,
I executed the following commands, I don't know if it's right
>
> ```
> [root@TEST3 /0322/23/apisix] -> luarocks config --lua-ver
> 5.1
> [root@TEST3 /0322/23/apisix] -> luarocks config --system-config
> /etc/luarocks/config-5.1.lua
> [root@TEST3 /0322/23/apisix] -> luarocks config --lua-incdir
> /usr/include
> [root@TEST3 /0322/23/apisix] -> luarocks config --lua-libdir
> /usr/lib64/lua
> [root@TEST3 /0322/23/apisix] -> luarocks config --rock-trees
> /root/.luarocksuser
> /usr system
> [root@TEST3 /0322/23/apisix] -> luarocks config --user-config
> /root/.luarocks/config-5.1.lua
>
> Error: file not found
> ```
>
> @spacewander
Run it like this:
```
incubator-apisix (bdt) 0
￥ luarocks config variables
{
AR = "ar",
BUNZIP2 = "bunzip2",
CC = "gcc",
CFLAGS = "-O2 -fPIC",
CHMOD = "chmod",
CMAKE = "cmake",
CP = "cp",
CURL = "curl",
CURLNOCERTFLAG = "-k",
CVS = "cvs",
FIND = "find",
GIT = "git",
GPG = "gpg",
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #1666: add test cases in `t/` for admin api https access
spacewander commented on issue #1666: URL: https://github.com/apache/apisix/issues/1666#issuecomment-804595727 Consider solved -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #1666: add test cases in `t/` for admin api https access
spacewander closed issue #1666: URL: https://github.com/apache/apisix/issues/1666 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1650: feat: added github link to header #1632
iamayushdas opened a new pull request #1650: URL: https://github.com/apache/apisix-dashboard/pull/1650 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** Please update this section with detailed description. #1632 fix/resolve #1632 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first screenshot of changes done @LiteSun @juzhiyuan  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3887: test: break down cli test_main.sh
spacewander opened a new pull request #3887: URL: https://github.com/apache/apisix/pull/3887 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] stu01509 closed pull request #3766: docs: add --server option for the use of luarocks
stu01509 closed pull request #3766: URL: https://github.com/apache/apisix/pull/3766 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Caelebs edited a comment on issue #3886: bug: Execute "make deps" prompt "Could not find header file for OPENSSL"
Caelebs edited a comment on issue #3886: URL: https://github.com/apache/apisix/issues/3886#issuecomment-804594227 Before that, according to the commands in the install-dependencies.md document, I installed `openresty-openssl111-devel`, But I just found out that the document says "If you are using OpenResty which is older than `1.17.8`, please installing `openresty-openssl-devel` instead of `openresty-openssl111-devel`", but in the following example , The command given is to install `openresty-openssl111-devel`? Is the document description wrong? But after I installed `openresty-openssl-devel`, executing `make deps` still prompted "Could not find header file for OPENSSL" ``` [root@TEST3 /0322/23/apisix] -> rpm -qa | grep openssl openresty-openssl111-devel-1.1.1i-1.el7.x86_64 openssl-libs-1.0.2k-16.el7.x86_64 openresty-openssl111-1.1.1i-1.el7.x86_64 openresty-openssl-1.1.0l-2.el7.x86_64 openresty-openssl-devel-1.1.0l-2.el7.x86_64 openssl-1.0.2k-16.el7.x86_64 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Caelebs commented on issue #3886: bug: Execute "make deps" prompt "Could not find header file for OPENSSL"
Caelebs commented on issue #3886: URL: https://github.com/apache/apisix/issues/3886#issuecomment-804594227 Before that, according to the commands in the install-dependencies.md document, I installed `openresty-openssl111-devel`, But I just found out that the document says "If you are using OpenResty which is older than `1.17.8`, please installing `openresty-openss-devel` instead of `openresty-openssl111-devel`", but in the following example , The command given is to install `openresty-openssl111-devel`? Is the document description wrong? But after I installed `openresty-openssl-devel`, executing `make deps` still prompted "Could not find header file for OPENSSL" ``` [root@TEST3 /0322/23/apisix] -> rpm -qa | grep openssl openresty-openssl111-devel-1.1.1i-1.el7.x86_64 openssl-libs-1.0.2k-16.el7.x86_64 openresty-openssl111-1.1.1i-1.el7.x86_64 openresty-openssl-1.1.0l-2.el7.x86_64 openresty-openssl-devel-1.1.0l-2.el7.x86_64 openssl-1.0.2k-16.el7.x86_64 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Caelebs commented on issue #3886: bug: Execute "make deps" prompt "Could not find header file for OPENSSL"
Caelebs commented on issue #3886: URL: https://github.com/apache/apisix/issues/3886#issuecomment-804594045 Sorry, I don't know the usage of this command. According to the -h prompt, I executed the following commands, I don't know if it's right ``` [root@TEST3 /0322/23/apisix] -> luarocks config --lua-ver 5.1 [root@TEST3 /0322/23/apisix] -> luarocks config --system-config /etc/luarocks/config-5.1.lua [root@TEST3 /0322/23/apisix] -> luarocks config --lua-incdir /usr/include [root@TEST3 /0322/23/apisix] -> luarocks config --lua-libdir /usr/lib64/lua [root@TEST3 /0322/23/apisix] -> luarocks config --rock-trees /root/.luarocks user /usr system [root@TEST3 /0322/23/apisix] -> luarocks config --user-config /root/.luarocks/config-5.1.lua Error: file not found ``` @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3880: request help: I see proxy_cache.disk_path: "/tmp/disk_cache_one" in the config.yaml, this is the path to store the cache data, but why I can't f
Firstsawyou commented on issue #3880: URL: https://github.com/apache/apisix/issues/3880#issuecomment-80459 > What is the etcd data cache interval, or it's real-time watching? It is monitored in real time, you can refer to here: https://github.com/apache/apisix/blob/master/docs/en/latest/FAQ.md#how-does-apisix-use-etcd-to-achieve-millisecond-level-configuration-synchronization -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1649: fix: ETCD container registry
nic-chen opened a new pull request #1649: URL: https://github.com/apache/apisix-dashboard/pull/1649 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** `quay.io/coreos/etcd` is down uses `gcr.io/etcd-development/etcd` as ETCD container registry, instead of `quay.io/coreos/etcd` **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3861: Proposition ldap-auth plugin
spacewander commented on issue #3861: URL: https://github.com/apache/apisix/issues/3861#issuecomment-804575841 @jp-gouin Would you submit a PR? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3803: request help:
spacewander closed issue #3803: URL: https://github.com/apache/apisix/issues/3803 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3803: request help:
spacewander commented on issue #3803: URL: https://github.com/apache/apisix/issues/3803#issuecomment-804573421 Closed as lack of response. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1645: test: enhanced test stability
LiteSun commented on a change in pull request #1645:
URL: https://github.com/apache/apisix-dashboard/pull/1645#discussion_r599243319
##
File path: web/cypress/integration/consumer/create_and_delete_consumer.spec.js
##
@@ -25,10 +25,9 @@ context('Create and Delete Consumer', () => {
});
it('creates consumer with key-auth', function () {
-cy.visit('/');
-cy.contains('Consumer').click();
+cy.visit('/consumer/list');
Review comment:
This will not cover whether the left menu button can jump to the
corresponding page.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3886: bug: Execute "make deps" prompt "Could not find header file for OPENSSL"
spacewander commented on issue #3886: URL: https://github.com/apache/apisix/issues/3886#issuecomment-804570986 Could you show us the output of `luarocks config variables`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1648: feat: reset etcd before every test run.
codecov-io edited a comment on pull request #1648: URL: https://github.com/apache/apisix-dashboard/pull/1648#issuecomment-804549796 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=h1) Report > Merging [#1648](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=desc) (0697cd4) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/eecadb8c03d06a7edd5a730ee2a19ba070f7acb6?el=desc) (eecadb8) will **increase** coverage by `3.49%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1648 +/- ## == + Coverage 70.33% 73.82% +3.49% == Files 134 87 -47 Lines5737 2621-3116 Branches 665 665 == - Hits 4035 1935-2100 + Misses 1450 686 -764 + Partials 2520 -252 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.82% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/pid.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3BpZC5nbw==) | | | | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | | | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | | | [api/cmd/manager/main.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyL21haW4uZ28=) | | | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | | | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | | | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | | | | ... and [37 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=footer). Last update [eecadb8...0697cd4](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1648: feat: reset etcd before every test run.
codecov-io commented on pull request #1648: URL: https://github.com/apache/apisix-dashboard/pull/1648#issuecomment-804549796 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=h1) Report > Merging [#1648](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=desc) (14aa234) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/eecadb8c03d06a7edd5a730ee2a19ba070f7acb6?el=desc) (eecadb8) will **increase** coverage by `3.49%`. > The diff coverage is `n/a`. > :exclamation: Current head 14aa234 differs from pull request most recent head 0697cd4. Consider uploading reports for the commit 0697cd4 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1648 +/- ## == + Coverage 70.33% 73.82% +3.49% == Files 134 87 -47 Lines5737 2621-3116 Branches 665 665 == - Hits 4035 1935-2100 + Misses 1450 686 -764 + Partials 2520 -252 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.82% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/log/zap.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy96YXAuZ28=) | | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | | | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | | | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | | | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | | | | [api/internal/utils/json\_patch.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2pzb25fcGF0Y2guZ28=) | | | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | | | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | | | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | | | | ... and [37 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1648/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=footer). Last update [eecadb8...0697cd4](https://codecov.io/gh/apache/apisix-dashboard/pull/1648?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Caelebs opened a new issue #3886: bug: Execute "make deps" prompt "Could not find header file for OPENSSL"
Caelebs opened a new issue #3886: URL: https://github.com/apache/apisix/issues/3886 ### Issue description When I compiled and installed apisix2.4, I executed `make deps` and prompted "Could not find header file for OPENSSL" The complete error message is as follows ``` Error: Failed installing dependency: https://luarocks.org/luasec-0.9-1.src.rock - Could not find header file for OPENSSL No file openssl/ssl.h in /usr/local/include No file openssl/ssl.h in /usr/include You may have to install OPENSSL in your system and/or pass OPENSSL_DIR or OPENSSL_INCDIR to the luarocks command. Example: luarocks install luasec OPENSSL_DIR=/usr/local make: *** [deps] ``` I checked that openssl is installed, Including openresty-openssl111 ``` [root@TEST3 /0322/23/apisix] -> rpm -qa | grep -i openresty openresty-openssl111-devel-1.1.1i-1.el7.x86_64 openresty-zlib-1.2.11-3.el7.centos.x86_64 openresty-pcre-8.44-1.el7.x86_64 openresty-openssl111-1.1.1i-1.el7.x86_64 openresty-1.17.8.2-1.el7.x86_64 ``` ``` [root@TEST3 /0322/23/apisix] -> find / -name ssl.h /root/.cache/node-gyp/12.16.1/include/node/openssl/ssl.h /usr/local/openresty/openssl111/include/openssl/ssl.h /opt/node-v12.16.1-linux-x64/include/node/openssl/ssl. ``` According to the error, I executed `luarocks install luasec OPENSSL_DIR=/usr/local`, and modified OPENSSL_DIR to `/usr/local/openresty/openssl111/`, this step can be successful, But subsequent execution of `make deps` will still prompt the same error, So what should I do now? ``` [root@TEST3 /0322/23/apisix] -> luarocks install luasec OPENSSL_DIR=/usr/local/openresty/openssl111/ Installing https://luarocks.org/luasec-1.0-1.src.rock... Using https://luarocks.org/luasec-1.0-1.src.rock... switching to 'build' mode gcc -O2 -fPIC -I/usr/include -c src/options.c -o src/options.o -DWITH_LUASOCKET -DLUASOCKET_DEBUG -I/usr/local/openresty/openssl111/include -Isrc/ -Isrc/luasocket gcc -O2 -fPIC -I/usr/include -c src/config.c -o src/config.o -DWITH_LUASOCKET -DLUASOCKET_DEBUG -I/usr/local/openresty/openssl111/include -Isrc/ -Isrc/luasocket gcc -O2 -fPIC -I/usr/include -c src/ec.c -o src/ec.o -DWITH_LUASOCKET -DLUASOCKET_DEBUG -I/usr/local/openresty/openssl111/include -Isrc/ -Isrc/luasocket gcc -O2 -fPIC -I/usr/include -c src/x509.c -o src/x509.o -DWITH_LUASOCKET -DLUASOCKET_DEBUG -I/usr/local/openresty/openssl111/include -Isrc/ -Isrc/luasocket gcc -O2 -fPIC -I/usr/include -c src/context.c -o src/context.o -DWITH_LUASOCKET -DLUASOCKET_DEBUG -I/usr/local/openresty/openssl111/include -Isrc/ -Isrc/luasocket gcc -O2 -fPIC -I/usr/include -c src/ssl.c -o src/ssl.o -DWITH_LUASOCKET -DLUASOCKET_DEBUG -I/usr/local/openresty/openssl111/include -Isrc/ -Isrc/luasocket gcc -O2 -fPIC -I/usr/include -c src/luasocket/buffer.c -o src/luasocket/buffer.o -DWITH_LUASOCKET -DLUASOCKET_DEBUG -I/usr/local/openresty/openssl111/include -Isrc/ -Isrc/luasocket gcc -O2 -fPIC -I/usr/include -c src/luasocket/io.c -o src/luasocket/io.o -DWITH_LUASOCKET -DLUASOCKET_DEBUG -I/usr/local/openresty/openssl111/include -Isrc/ -Isrc/luasocket gcc -O2 -fPIC -I/usr/include -c src/luasocket/timeout.c -o src/luasocket/timeout.o -DWITH_LUASOCKET -DLUASOCKET_DEBUG -I/usr/local/openresty/openssl111/include -Isrc/ -Isrc/luasocket gcc -O2 -fPIC -I/usr/include -c src/luasocket/usocket.c -o src/luasocket/usocket.o -DWITH_LUASOCKET -DLUASOCKET_DEBUG -I/usr/local/openresty/openssl111/include -Isrc/ -Isrc/luasocket gcc -shared -o ssl.so -L/usr/lib64/lua src/options.o src/config.o src/ec.o src/x509.o src/context.o src/ssl.o src/luasocket/buffer.o src/luasocket/io.o src/luasocket/timeout.o src/luasocket/usocket.o -L/usr/local/openresty/openssl111/lib -Wl,-rpath,/usr/local/openresty/openssl111/lib: -lssl -lcrypto Updating manifest for /usr/lib64/luarocks/rocks luasec 1.0-1 is now built and installed in /usr (license: MIT) ``` ### Environment * apisix version (cmd: `apisix version`): `2.4` * OS (cmd: `uname -a`): `CentOS Linux release 7.6.1810 (Core)` * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): `openresty/1.17.8.2` * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): * apisix-dashboard version, if have: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz closed issue #1627: improve Metrics module
starsz closed issue #1627: URL: https://github.com/apache/apisix-dashboard/issues/1627 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz merged pull request #1641: feat: change the metrics to dashboard
starsz merged pull request #1641: URL: https://github.com/apache/apisix-dashboard/pull/1641 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat: change the metrics to dashboard (#1641)
This is an automated email from the ASF dual-hosted git repository.
starsz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 2f5d27c feat: change the metrics to dashboard (#1641)
2f5d27c is described below
commit 2f5d27cfba3a6e925ca9265e38de25763321d2e6
Author: Cliff Su
AuthorDate: Tue Mar 23 11:08:43 2021 +0800
feat: change the metrics to dashboard (#1641)
---
web/config/routes.ts | 6 +++---
.../dashboard-smoketest.spec.js} | 10 +-
.../integration/settings/settings-smoketest.spec.js| 2 +-
web/src/helpers.tsx| 4 ++--
web/src/locales/en-US/menu.ts | 1 -
web/src/locales/zh-CN/menu.ts | 1 -
.../pages/{Metrics/Metrics.tsx => Dashboard/Dashboard.tsx} | 14 +++---
web/src/pages/{Metrics => Dashboard}/index.ts | 2 +-
web/src/pages/{Metrics => Dashboard}/locales/en-US.ts | 6 +++---
web/src/pages/{Metrics => Dashboard}/locales/zh-CN.ts | 6 +++---
web/src/pages/{Metrics => Dashboard}/service.ts| 0
web/src/pages/Setting/Setting.tsx | 2 +-
12 files changed, 26 insertions(+), 28 deletions(-)
diff --git a/web/config/routes.ts b/web/config/routes.ts
index b47c7cd..7f01bc3 100644
--- a/web/config/routes.ts
+++ b/web/config/routes.ts
@@ -17,11 +17,11 @@
const routes = [
{
path: '/',
-component: './Metrics',
+component: './Dashboard',
},
{
-path: '/metrics',
-component: './Metrics',
+path: '/dashboard',
+component: './Dashboard',
},
{
path: '/serverinfo',
diff --git a/web/cypress/integration/metrics/metrics-smoketest.spec.js
b/web/cypress/integration/dashboard/dashboard-smoketest.spec.js
similarity index 83%
rename from web/cypress/integration/metrics/metrics-smoketest.spec.js
rename to web/cypress/integration/dashboard/dashboard-smoketest.spec.js
index 2e8a43d..595aa4e 100644
--- a/web/cypress/integration/metrics/metrics-smoketest.spec.js
+++ b/web/cypress/integration/dashboard/dashboard-smoketest.spec.js
@@ -16,20 +16,20 @@
*/
/* eslint-disable no-undef */
-context('metrics page smoke test', () => {
+context('dashboard page smoke test', () => {
beforeEach(() => {
cy.login();
cy.fixture('selector.json').as('domSelector');
});
- it('should visit metrics page', function () {
+ it('should visit dashboard page', function () {
cy.visit('/');
-cy.contains('Metrics').click();
-cy.url().should('contains', '/metrics');
+cy.contains('Dashboard').click();
+cy.url().should('contains', '/dashboard');
cy.get(this.domSelector.pageContent)
.children()
- .should('contain', 'Metrics')
+ .should('contain', 'Dashboard')
.and('contain', 'You have not configured Grafana')
.and('contain', 'Configure');
});
diff --git a/web/cypress/integration/settings/settings-smoketest.spec.js
b/web/cypress/integration/settings/settings-smoketest.spec.js
index 64804d8..1c0b8ef 100644
--- a/web/cypress/integration/settings/settings-smoketest.spec.js
+++ b/web/cypress/integration/settings/settings-smoketest.spec.js
@@ -63,6 +63,6 @@ context('settings page smoke test', () => {
cy.get(this.domSelector.notificationMessage).should('contain',
this.data.updateSuccessfully);
cy.intercept(data.validURL).as(data.fetchURL);
cy.wait(data.fetch);
-cy.get(this.domSelector.pageContainer).children().should('contain',
'Metrics');
+cy.get(this.domSelector.pageContainer).children().should('contain',
'Dashboard');
});
});
diff --git a/web/src/helpers.tsx b/web/src/helpers.tsx
index 44fb0d8..c5743d8 100644
--- a/web/src/helpers.tsx
+++ b/web/src/helpers.tsx
@@ -28,8 +28,8 @@ import IconFont from './components/IconFont';
export const getMenuData = (): MenuDataItem[] => {
return [
{
- name: 'metrics',
- path: '/metrics',
+ name: 'dashboard',
+ path: '/dashboard',
icon: ,
},
{
diff --git a/web/src/locales/en-US/menu.ts b/web/src/locales/en-US/menu.ts
index e84a578..a577330 100644
--- a/web/src/locales/en-US/menu.ts
+++ b/web/src/locales/en-US/menu.ts
@@ -63,7 +63,6 @@ export default {
'menu.editor.flow': 'Flow Editor',
'menu.editor.mind': 'Mind Editor',
'menu.editor.koni': 'Koni Editor',
- 'menu.metrics': 'Metrics',
'menu.routes': 'Route',
'menu.pluginTemplate': 'Plugin Template',
'menu.ssl': 'SSL',
diff --git a/web/src/locales/zh-CN/menu.ts b/web/src/locales/zh-CN/menu.ts
index 19b4c6e..bb3b69c 100644
--- a/web/src/locales/zh-CN/menu.ts
+++ b/web/src/locales/zh-CN/menu.ts
@@ -60,7 +60,6 @@ export default {
'menu.editor.flow': '流程编辑器',
'menu.editor.mind': '脑图编辑器',
'menu.editor.koni': '拓扑编辑器',
- 'menu.metrics': '监控',
'menu.routes': '路由',
[GitHub] [apisix-dashboard] starsz merged pull request #1636: chore: update PULL_REQUEST_TEMPLATE
starsz merged pull request #1636: URL: https://github.com/apache/apisix-dashboard/pull/1636 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore: update PULL_REQUEST_TEMPLATE (#1636)
This is an automated email from the ASF dual-hosted git repository. starsz pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git The following commit(s) were added to refs/heads/master by this push: new 3087c57 chore: update PULL_REQUEST_TEMPLATE (#1636) 3087c57 is described below commit 3087c576c31c0872e206696dcefc172ada816651 Author: 琚致远 AuthorDate: Tue Mar 23 11:06:31 2021 +0800 chore: update PULL_REQUEST_TEMPLATE (#1636) --- .github/PULL_REQUEST_TEMPLATE | 33 - 1 file changed, 12 insertions(+), 21 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE b/.github/PULL_REQUEST_TEMPLATE index 8576011..b5d09b0 100644 --- a/.github/PULL_REQUEST_TEMPLATE +++ b/.github/PULL_REQUEST_TEMPLATE @@ -1,32 +1,23 @@ -Please answer these questions before submitting a pull request +Please answer these questions before submitting a pull request, **or your PR will get closed**. + +**Why submit this pull request?** -- Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches -- Related issues - -___ -### Bugfix -- Description - -- How to fix? - -___ -### New feature or improvement -- Describe the details and related test reports. +**What changes will this PR take into?** -___ -### Please add the corresponding test cases if necessary. +Please update this section with detailed description. -___ -### Backport patches -- Why need to backport? +**Related issues** -- Source branch +fix/resolve #0001 -- Related commits and pull requests +**Checklist:** -- Target branch +- [ ] Did you explain what problem does this PR solve? Or what new features have been added? +- [ ] Have you added corresponding test cases? +- [ ] Have you modified the corresponding document? +- [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first
[GitHub] [apisix] Firstsawyou commented on pull request #3884: feat: show how to specify --server when installing the dependency
Firstsawyou commented on pull request #3884: URL: https://github.com/apache/apisix/pull/3884#issuecomment-804546973 LGTM. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] stu01509 commented on issue #3882: add a proper link to README item
stu01509 commented on issue #3882: URL: https://github.com/apache/apisix/issues/3882#issuecomment-804542354 Let me fix it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1648: feat: reset etcd before every test run.
juzhiyuan commented on pull request #1648: URL: https://github.com/apache/apisix-dashboard/pull/1648#issuecomment-804541451 @LiteSun failed BE -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3885: request help: Modify the ctx.var.upstream_uri does not work in access phase when i use proxy-rewrite plugin
spacewander commented on issue #3885: URL: https://github.com/apache/apisix/issues/3885#issuecomment-804539995 We don't answer questions caused by modifying APISIX. You need to debug your change by yourself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3885: request help: Modify the ctx.var.upstream_uri does not work in access phase when i use proxy-rewrite plugin
spacewander closed issue #3885: URL: https://github.com/apache/apisix/issues/3885 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] comedown opened a new issue #3885: request help: Modify the ctx.var.upstream_uri does not work in access phase when i use proxy-rewrite plugin
comedown opened a new issue #3885: URL: https://github.com/apache/apisix/issues/3885 ### Issue description After proxy-rewrite plugin is executed, i add the following line of code to modify the request parameters, but it does not work. api_ctx.var.upstream_uri = "/test/urlencoded" ### Environment * apisix version (cmd: `apisix version`): 2.0 * OS (cmd: `uname -a`): MacOS * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): V3 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun opened a new pull request #1648: feat: reset etcd before every test run.
LiteSun opened a new pull request #1648: URL: https://github.com/apache/apisix-dashboard/pull/1648 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches ___ ### New feature or improvement - Describe the details and related test reports. Failure of one test case may leave dirty data behind and cause other cases to fail. ___ ### Please add the corresponding test cases if necessary. Empty the etcd data before each test case to ensure a clean environment ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1647: chore(BE): Change route name feild required
codecov-io edited a comment on pull request #1647: URL: https://github.com/apache/apisix-dashboard/pull/1647#issuecomment-804328077 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=h1) Report > Merging [#1647](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=desc) (9631d70) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/548bbe38f66ff18a6de6567bf13dc5b81a995a46?el=desc) (548bbe3) will **decrease** coverage by `20.52%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1647 +/- ## === - Coverage 72.29% 51.77% -20.53% === Files 134 38 -96 Lines5736 2650 -3086 Branches 6650 -665 === - Hits 4147 1372 -2775 + Misses 1345 1090 -255 + Partials 244 188 -56 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.77% <ø> (-0.04%)` | :arrow_down: | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <ø> (-100.00%)` | :arrow_down: | | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | ... and [121 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=footer). Last update [548bbe3...9631d70](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3848: feat: add dump for consul_kv
spacewander merged pull request #3848: URL: https://github.com/apache/apisix/pull/3848 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: feat: add dump for consul_kv (#3848)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 1896cb1 feat: add dump for consul_kv (#3848)
1896cb1 is described below
commit 1896cb1826255aefebe989c54a6dfd7e6feef53d
Author: yongboy
AuthorDate: Tue Mar 23 10:07:32 2021 +0800
feat: add dump for consul_kv (#3848)
Co-authored-by: nieyong
---
apisix/control/router.lua | 41 +++-
apisix/discovery/consul_kv.lua| 105 -
docs/en/latest/discovery/consul_kv.md | 64 +-
t/discovery/consul_kv_dump.t | 386 ++
4 files changed, 591 insertions(+), 5 deletions(-)
diff --git a/apisix/control/router.lua b/apisix/control/router.lua
index 49fdc23..43fb7e2 100644
--- a/apisix/control/router.lua
+++ b/apisix/control/router.lua
@@ -31,6 +31,41 @@ local get_method = ngx.req.get_method
local _M = {}
+local function format_dismod_uri(mod_name, uri)
+if core.string.has_prefix(uri, "/v1/") then
+return uri
+end
+
+local tmp = {"/v1/discovery/", mod_name}
+if not core.string.has_prefix(uri, "/") then
+core.table.insert(tmp, "/")
+end
+core.table.insert(tmp, uri)
+
+return core.table.concat(tmp, "")
+end
+
+-- we do not hardcode the discovery module's control api uri
+local function format_dismod_control_api_uris(mod_name, api_route)
+if not api_route or #api_route == 0 then
+return api_route
+end
+
+local clone_route = core.table.clone(api_route)
+for _, v in ipairs(clone_route) do
+local uris = v.uris
+local target_uris = core.table.new(#uris, 0)
+for _, uri in ipairs(uris) do
+local target_uri = format_dismod_uri(mod_name, uri)
+core.table.insert(target_uris, target_uri)
+end
+v.uris = target_uris
+end
+
+return clone_route
+end
+
+
local fetch_control_api_router
do
local function register_api_routes(routes, api_routes)
@@ -78,14 +113,16 @@ function fetch_control_api_router()
local api_fun = dis_mod.control_api
if api_fun then
local api_route = api_fun()
-register_api_routes(routes, api_route)
+local format_route = format_dismod_control_api_uris(key,
api_route)
+register_api_routes(routes, format_route)
end
local dump_data = dis_mod.dump_data
if dump_data then
+local target_uri = format_dismod_uri(key, "/dump")
local item = {
methods = {"GET"},
-uris = {"/v1/discovery/" .. key .. "/dump"},
+uris = {target_uri},
handler = function()
return 200, dump_data()
end
diff --git a/apisix/discovery/consul_kv.lua b/apisix/discovery/consul_kv.lua
index e94f043..bd61e17 100644
--- a/apisix/discovery/consul_kv.lua
+++ b/apisix/discovery/consul_kv.lua
@@ -20,11 +20,12 @@ local core = require("apisix.core")
local resty_consul = require('resty.consul')
local cjson = require('cjson')
local http = require('resty.http')
+local util = require("apisix.cli.util")
local ipairs = ipairs
local error = error
local ngx= ngx
local unpack = unpack
-local ngx_re_match = ngx.re.match
+local ngx_re_match = ngx.re.match
local tonumber = tonumber
local pairs = pairs
local ipairs = ipairs
@@ -33,13 +34,14 @@ local ngx_timer_every= ngx.timer.every
local log= core.log
local ngx_decode_base64 = ngx.decode_base64
local json_delay_encode = core.json.delay_encode
-local cjson_null = cjson.null
+local cjson_null = cjson.null
local applications = core.table.new(0, 5)
local default_service
local default_weight
local default_prefix_rule
local skip_keys_map = core.table.new(0, 1)
+local dump_params
local events
local events_list
@@ -82,6 +84,15 @@ local schema = {
type = "string",
}
},
+dump = {
+type = "object",
+properties = {
+path = {type = "string", minLength = 1},
+load_on_init = {type = "boolean", default = true},
+expire = {type = "integer", default = 0},
+},
+required = {"path"},
+},
default_service = {
type = "object",
properties = {
@@ -230,6 +241,72 @@ local function update_application(server_name_prefix, data)
end
+local function read_dump_srvs()
+local data, err = util.read_file(dump_params.path)
+if not data then
+log.notice("read dump file get error: ",
[GitHub] [apisix] spacewander commented on pull request #3766: docs: add --server option for the use of luarocks
spacewander commented on pull request #3766: URL: https://github.com/apache/apisix/pull/3766#issuecomment-804527402 Surpassed by https://github.com/apache/apisix/pull/3884 I need this feature now so I write it by myself. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3884: feat: show how to specify --server when installing the dependency
spacewander opened a new pull request #3884: URL: https://github.com/apache/apisix/pull/3884 Fix #3671 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas closed pull request #1646: feat: added github link to header #1632
iamayushdas closed pull request #1646: URL: https://github.com/apache/apisix-dashboard/pull/1646 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on issue #1639: feat: Improve the regexp, reference some standard projects
LiteSun commented on issue #1639: URL: https://github.com/apache/apisix-dashboard/issues/1639#issuecomment-804523341 > ya, here have some examples: https://projects.lukehaas.me/regexhub/ > > and @LiteSun, could you help to provide some rules from antd? ANTD uses the [async-validator](https://github.com/yiminghe/async-validator) library for field checking, if you want to see the regular rules you need to look through the source code, which is not very convenient -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aiyiyi121 commented on issue #3880: request help: I see proxy_cache.disk_path: "/tmp/disk_cache_one" in the config.yaml, this is the path to store the cache data, but why I can't fin
aiyiyi121 commented on issue #3880: URL: https://github.com/apache/apisix/issues/3880#issuecomment-804522459 > ETCD data caching is in memory, not in filesystem. What is the etcd data cache interval, or it's real-time watching? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated (85efb37 -> eecadb8)
This is an automated email from the ASF dual-hosted git repository. sunyi pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git. from 85efb37 test: add the create and delete plugin in drawer (#1597) add eecadb8 chore: add ignore cypress screenshots and videos (#1640) No new revisions were added by this update. Summary of changes: .gitignore | 2 ++ 1 file changed, 2 insertions(+)
[GitHub] [apisix-dashboard] LiteSun merged pull request #1640: chore: add ignore cypress screenshots and videos
LiteSun merged pull request #1640: URL: https://github.com/apache/apisix-dashboard/pull/1640 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on pull request #1646: feat: added github link to header #1632
LiteSun commented on pull request #1646: URL: https://github.com/apache/apisix-dashboard/pull/1646#issuecomment-804518463 It would be great if you could post a screenshot of the page -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1646: feat: added github link to header #1632
juzhiyuan commented on a change in pull request #1646:
URL: https://github.com/apache/apisix-dashboard/pull/1646#discussion_r599180281
##
File path: web/src/pages/User/Login.tsx
##
@@ -14,17 +14,18 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
+import logo from '@/assets/logo.svg';
Review comment:
no no no, I mean `import { GithubOutlined } from '@ant-design/icons';`
this line, because it's importing a file from inner module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1642: Whether to consider adding scheme configuration items in the upstream configuration
juzhiyuan commented on issue #1642: URL: https://github.com/apache/apisix-dashboard/issues/1642#issuecomment-804513066 ok, if we choose `grcp` or `grcps`, what should we do on UI view? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3880: request help: I see proxy_cache.disk_path: "/tmp/disk_cache_one" in the config.yaml, this is the path to store the cache data, but why I can't find a
tokers commented on issue #3880: URL: https://github.com/apache/apisix/issues/3880#issuecomment-804511366 > > This is the path used by the proxy-cache plugin to store cached data. Only after you enable the proxy-cache plug-in can you see the existence of data. You can refer to it here: https://github.com/apache/apisix/blob/master/docs/en/latest/plugins/proxy-cache.md > > Thx, I mistook this for the config of caching etcd data，so，where can I find sonmething abouting caching etcd data？ ETCD data caching is in memory, not in filesystem. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3873: docs: add more example about how to use the router `radixtree-uri`
Firstsawyou commented on issue #3873: URL: https://github.com/apache/apisix/issues/3873#issuecomment-804510733 Assigned to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3879: is it optional to enable TLS when installing APISIX on MacOS?
tokers commented on issue #3879: URL: https://github.com/apache/apisix/issues/3879#issuecomment-804510460 @juzhiyuan This issue could be a "good first issue". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen edited a comment on issue #1642: Whether to consider adding scheme configuration items in the upstream configuration
nic-chen edited a comment on issue #1642: URL: https://github.com/apache/apisix-dashboard/issues/1642#issuecomment-804509122 @juzhiyuan we have support `scheme` for upstream, see: https://github.com/apache/apisix-dashboard/blob/master/api/internal/core/entity/entity.go#L167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on issue #1642: Whether to consider adding scheme configuration items in the upstream configuration
nic-chen commented on issue #1642: URL: https://github.com/apache/apisix-dashboard/issues/1642#issuecomment-804509122 @juzhiyuan we have support `schema` for upstream, see: https://github.com/apache/apisix-dashboard/blob/master/api/internal/core/entity/entity.go#L167 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3867: docs: add route uri regular matching in the FAQ doc
spacewander closed issue #3867: URL: https://github.com/apache/apisix/issues/3867 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #3881: docs: add route uri regular matching in the FAQ doc
spacewander merged pull request #3881: URL: https://github.com/apache/apisix/pull/3881 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: add route uri regular matching in the FAQ doc (#3881)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 2744a99 docs: add route uri regular matching in the FAQ doc (#3881)
2744a99 is described below
commit 2744a9947250b83c5dab8ca7925ab6947f735c82
Author: Yuelin Zheng <2226815...@qq.com>
AuthorDate: Tue Mar 23 09:08:08 2021 +0800
docs: add route uri regular matching in the FAQ doc (#3881)
---
docs/en/latest/FAQ.md | 36
docs/zh/latest/FAQ.md | 36
2 files changed, 72 insertions(+)
diff --git a/docs/en/latest/FAQ.md b/docs/en/latest/FAQ.md
index eb5e917..1ab0b3b 100644
--- a/docs/en/latest/FAQ.md
+++ b/docs/en/latest/FAQ.md
@@ -404,3 +404,39 @@ curl -i http://127.0.0.1:9180/apisix/admin/routes/1 -H
'X-API-KEY: edd1c9f03433
}
}'
```
+
+## How to use route `uri` for regular matching
+
+The regular matching of uri is achieved through the `vars` field of route.
+
+```shell
+curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/*",
+"vars": [
+["uri", "~~", "^/[a-z]+$"]
+],
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:1980": 1
+}
+}
+}'
+```
+
+Test request:
+
+```shell
+# The uri matched successfully
+$ curl http://127.0.0.1:9080/hello -i
+HTTP/1.1 200 OK
+...
+
+# The uri match failed
+curl http://127.0.0.1:9080/12ab -i
+HTTP/1.1 404 Not Found
+...
+```
+
+In route, we can achieve more condition matching by combining `uri` with
`vars` field. For more details of using `vars`, please refer to
[lua-resty-expr](https://github.com/api7/lua-resty-expr).
diff --git a/docs/zh/latest/FAQ.md b/docs/zh/latest/FAQ.md
index 54ec6a1..98af1b5 100644
--- a/docs/zh/latest/FAQ.md
+++ b/docs/zh/latest/FAQ.md
@@ -352,3 +352,39 @@ curl -i http://127.0.0.1:9180/apisix/admin/routes/1 -H
'X-API-KEY: edd1c9f03433
}
}'
```
+
+## route 的 `uri` 如何进行正则匹配
+
+这里通过 route 的 `vars` 字段来实现 uri 的正则匹配。
+
+```shell
+curl -i http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
+{
+"uri": "/*",
+"vars": [
+["uri", "~~", "^/[a-z]+$"]
+],
+"upstream": {
+"type": "roundrobin",
+"nodes": {
+"127.0.0.1:1980": 1
+}
+}
+}'
+```
+
+测试请求：
+
+```shell
+# uri 匹配成功
+$ curl http://127.0.0.1:9080/hello -i
+HTTP/1.1 200 OK
+...
+
+# uri 匹配失败
+curl http://127.0.0.1:9080/12ab -i
+HTTP/1.1 404 Not Found
+...
+```
+
+在 route 中，我们可以通过 `uri` 结合 `vars` 字段来实现更多的条件匹配，`vars` 的更多使用细节请参考
[lua-resty-expr](https://github.com/api7/lua-resty-expr)。
[GitHub] [apisix] starsz opened a new pull request #3883: feat: add 5xx error page
starsz opened a new pull request #3883: URL: https://github.com/apache/apisix/pull/3883 ### What this PR does / why we need it: Show our own HTML page, when the apisix self returns 5xx. fix #3251 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solves? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #3766: docs: add --server option for the use of luarocks
spacewander commented on pull request #3766: URL: https://github.com/apache/apisix/pull/3766#issuecomment-804507983 @membphis It is my suggestion to update the Makefile because we don't have a wrapper. https://github.com/apache/apisix/pull/3766#discussion_r589118059 However, my intention is to update both the Makefile and the doc. It looks like I didn't explain it clearly. @stu01509 The current solution is incorrect. > LUAROCKS_SERVER=https://luarocks.cn make deps You should handle the server as an argument, instead of hardcoding one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (bb95f7a -> 1ced2c3)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from bb95f7a feat: add allow_origins_by_regex to cors plugin (#3839) add 1ced2c3 docs: remove duplicated section from discovery.md (#3869) No new revisions were added by this update. Summary of changes: docs/en/latest/discovery.md | 6 -- 1 file changed, 6 deletions(-)
[GitHub] [apisix] spacewander merged pull request #3869: docs: remove duplicated section from discovery.md
spacewander merged pull request #3869: URL: https://github.com/apache/apisix/pull/3869 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj closed issue #219: types should have yaml tag
gxthrj closed issue #219: URL: https://github.com/apache/apisix-ingress-controller/issues/219 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj merged pull request #307: chore: add yaml tags for types
gxthrj merged pull request #307: URL: https://github.com/apache/apisix-ingress-controller/pull/307 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: chore: add yaml tags for types (#307)
This is an automated email from the ASF dual-hosted git repository.
kvn pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new b5cba04 chore: add yaml tags for types (#307)
b5cba04 is described below
commit b5cba04a9039ba47cb4991102ba80cbcf653db8b
Author: Hoshea Jiang
AuthorDate: Tue Mar 23 08:54:41 2021 +0800
chore: add yaml tags for types (#307)
* Add yaml tags
* resolve conflicts
---
pkg/kube/apisix/apis/config/v1/types.go | 52 +-
pkg/kube/apisix/apis/config/v2alpha1/types.go | 54 +--
2 files changed, 53 insertions(+), 53 deletions(-)
diff --git a/pkg/kube/apisix/apis/config/v1/types.go
b/pkg/kube/apisix/apis/config/v1/types.go
index fe665ab..9e014c2 100644
--- a/pkg/kube/apisix/apis/config/v1/types.go
+++ b/pkg/kube/apisix/apis/config/v1/types.go
@@ -35,40 +35,40 @@ type ApisixRoute struct {
// ApisixRouteSpec is the spec definition for ApisixRouteSpec.
type ApisixRouteSpec struct {
- Rules []Rule `json:"rules,omitempty"`
+ Rules []Rule `json:"rules,omitempty" yaml:"rules,omitempty"`
}
// Rule represents a single route rule in ApisixRoute.
type Rule struct {
- Host string `json:"host,omitempty"`
- Http Http `json:"http,omitempty"`
+ Host string `json:"host,omitempty" yaml:"host,omitempty"`
+ Http Http `json:"http,omitempty" yaml:"http,omitempty"`
}
// Http represents all route rules in HTTP scope.
type Http struct {
- Paths []Path `json:"paths,omitempty"`
+ Paths []Path `json:"paths,omitempty" yaml:"paths,omitempty"`
}
// Path defines an URI based route rule.
type Path struct {
- Pathstring `json:"path,omitempty"`
- Backend Backend `json:"backend,omitempty"`
- Plugins []Plugin `json:"plugins,omitempty"`
+ Pathstring `json:"path,omitempty" yaml:"path,omitempty"`
+ Backend Backend `json:"backend,omitempty" yaml:"backend,omitempty"`
+ Plugins []Plugin `json:"plugins,omitempty" yaml:"plugins,omitempty"`
}
// Backend defines an upstream, it should be an existing Kubernetes Service.
// Note the Service should be in the same namespace with ApisixRoute resource,
// i.e. cross namespacing is not allowed.
type Backend struct {
- ServiceName string `json:"serviceName,omitempty"`
- ServicePort int`json:"servicePort,omitempty"`
+ ServiceName string `json:"serviceName,omitempty"
yaml:"serviceName,omitempty"`
+ ServicePort int`json:"servicePort,omitempty"
yaml:"servicePort,omitempty"`
}
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
type ApisixRouteList struct {
- metav1.TypeMeta `json:",inline"`
- metav1.ListMeta `json:"metadata"`
- Items []ApisixRoute `json:"items,omitempty"`
+ metav1.TypeMeta `json:",inline" yaml:",inline"`
+ metav1.ListMeta `json:"metadata" yaml:"metadata"`
+ Items []ApisixRoute `json:"items,omitempty"
yaml:"items,omitempty"`
}
// +genclient
@@ -208,16 +208,16 @@ type PassiveHealthCheckUnhealthy struct {
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
type ApisixUpstreamList struct {
- metav1.TypeMeta `json:",inline"`
- metav1.ListMeta `json:"metadata"`
- Items []ApisixUpstream `json:"items,omitempty"`
+ metav1.TypeMeta `json:",inline" yaml:",inline"`
+ metav1.ListMeta `json:"metadata" yaml:"metadata"`
+ Items []ApisixUpstream `json:"items,omitempty"
yaml:"items,omitempty"`
}
type Plugin struct {
- Name string`json:"name,omitempty"`
- Enablebool `json:"enable,omitempty"`
- ConfigConfig`json:"config,omitempty"`
- ConfigSet ConfigSet `json:"config_set,omitempty"`
+ Name string`json:"name,omitempty" yaml:"name,omitempty"`
+ Enablebool `json:"enable,omitempty" yaml:"enable,omitempty"`
+ ConfigConfig`json:"config,omitempty" yaml:"config,omitempty"`
+ ConfigSet ConfigSet `json:"config_set,omitempty"
yaml:"config_set,omitempty"`
}
type ConfigSet []interface{}
@@ -265,19 +265,19 @@ type ApisixTls struct {
// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
type ApisixTlsList struct {
- metav1.TypeMeta `json:",inline"`
- metav1.ListMeta `json:"metadata"`
- Items []ApisixTls `json:"items,omitempty"`
+ metav1.TypeMeta `json:",inline" yaml:",inline"`
+ metav1.ListMeta `json:"metadata" yaml:"metadata"`
+ Items []ApisixTls `json:"items,omitempty"
yaml:"items,omitempty"`
}
// ApisixTlsSpec is the specification of ApisixSSL.
type ApisixTlsSpec struct {
- Hosts []string `json:"hosts,omitempty"`
- Secret ApisixSecret `json:"secret,omitempty"`
+ Hosts
[GitHub] [apisix-dashboard] gxthrj commented on issue #1624: Discussion: Is the name field required or not when BE create a route
gxthrj commented on issue #1624: URL: https://github.com/apache/apisix-dashboard/issues/1624#issuecomment-804501407 Agree +1 , Let `name` to be required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1646: feat: added github link to header #1632
iamayushdas commented on a change in pull request #1646:
URL: https://github.com/apache/apisix-dashboard/pull/1646#discussion_r599167812
##
File path: web/src/pages/User/Login.tsx
##
@@ -25,6 +25,7 @@ import logo from '@/assets/logo.svg';
import { getUrlQuery } from '@/helpers';
import Footer from '@/components/Footer';
import styles from './Login.less';
+import { GithubOutlined } from '@ant-design/icons';
Review comment:
Done!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] juzhiyuan opened a new issue #3882: add a proper link to README item
juzhiyuan opened a new issue #3882: URL: https://github.com/apache/apisix/issues/3882 # Improve Docs ## Please describe which part of docs should be improved or typo fixed I noticed that there has one item without a proper link[1], anyone would like to fix it?  [1] https://github.com/apache/apisix/blob/master/README.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1646: feat: added github link to header #1632
juzhiyuan commented on a change in pull request #1646:
URL: https://github.com/apache/apisix-dashboard/pull/1646#discussion_r599144163
##
File path: web/src/pages/User/Login.tsx
##
@@ -25,6 +25,7 @@ import logo from '@/assets/logo.svg';
import { getUrlQuery } from '@/helpers';
import Footer from '@/components/Footer';
import styles from './Login.less';
+import { GithubOutlined } from '@ant-design/icons';
Review comment:
Hi, would better move this line to the top :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1647: chore(BE): Change route name feild required
codecov-io edited a comment on pull request #1647: URL: https://github.com/apache/apisix-dashboard/pull/1647#issuecomment-804328077 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=h1) Report > Merging [#1647](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=desc) (d3b97fc) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/548bbe38f66ff18a6de6567bf13dc5b81a995a46?el=desc) (548bbe3) will **increase** coverage by `1.52%`. > The diff coverage is `n/a`. > :exclamation: Current head d3b97fc differs from pull request most recent head 21b6877. Consider uploading reports for the commit 21b6877 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1647 +/- ## == + Coverage 72.29% 73.82% +1.52% == Files 134 87 -47 Lines5736 2621-3115 Branches 665 665 == - Hits 4147 1935-2212 + Misses 1345 686 -659 + Partials 2440 -244 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `73.82% <ø> (+0.04%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=tree) | Coverage Δ | | |---|---|---| | [web/src/helpers.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-d2ViL3NyYy9oZWxwZXJzLnRzeA==) | `77.04% <0.00%> (-3.28%)` | :arrow_down: | | [web/src/components/Upstream/UpstreamForm.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-d2ViL3NyYy9jb21wb25lbnRzL1Vwc3RyZWFtL1Vwc3RyZWFtRm9ybS50c3g=) | `61.53% <0.00%> (-0.48%)` | :arrow_down: | | [web/src/pages/Upstream/List.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9MaXN0LnRzeA==) | `90.00% <0.00%> (ø)` | | | [web/src/pages/Upstream/Create.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-d2ViL3NyYy9wYWdlcy9VcHN0cmVhbS9DcmVhdGUudHN4) | `81.25% <0.00%> (ø)` | | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | | | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | | | [.../internal/handler/authentication/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvYXV0aGVudGljYXRpb24vYXV0aGVudGljYXRpb24uZ28=) | | | | [api/internal/core/storage/storage\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9zdG9yYWdlX21vY2suZ28=) | | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | | | | ... and [43 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=footer). Last update [548bbe3...21b6877](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1647: chore(BE): Change route name feild required
codecov-io commented on pull request #1647: URL: https://github.com/apache/apisix-dashboard/pull/1647#issuecomment-804328077 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=h1) Report > Merging [#1647](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=desc) (21b6877) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/548bbe38f66ff18a6de6567bf13dc5b81a995a46?el=desc) (548bbe3) will **decrease** coverage by `23.93%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1647 +/- ## === - Coverage 72.29% 48.36% -23.94% === Files 134 47 -87 Lines5736 3116 -2620 Branches 6650 -665 === - Hits 4147 1507 -2640 - Misses 1345 1348+3 - Partials 244 261 +17 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `48.36% <ø> (-13.42%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <ø> (-18.75%)` | :arrow_down: | | [api/internal/handler/schema/plugin.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3BsdWdpbi5nbw==) | `15.00% <0.00%> (-85.00%)` | :arrow_down: | | [api/internal/handler/tool/tool.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdG9vbC90b29sLmdv) | `13.88% <0.00%> (-80.56%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `23.80% <0.00%> (-76.20%)` | :arrow_down: | | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.55% <0.00%> (-70.38%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/ssl/ssl.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc3NsL3NzbC5nbw==) | `12.04% <0.00%> (-61.26%)` | :arrow_down: | | [api/internal/handler/upstream/upstream.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvdXBzdHJlYW0vdXBzdHJlYW0uZ28=) | `31.42% <0.00%> (-59.29%)` | :arrow_down: | | [api/internal/handler/server\_info/server\_info.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmVyX2luZm8vc2VydmVyX2luZm8uZ28=) | `33.33% <0.00%> (-57.15%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `41.73% <0.00%> (-50.44%)` | :arrow_down: | | ... and [110 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1647/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=footer). Last update [548bbe3...21b6877](https://codecov.io/gh/apache/apisix-dashboard/pull/1647?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1645: test: enhanced test stability
codecov-io edited a comment on pull request #1645: URL: https://github.com/apache/apisix-dashboard/pull/1645#issuecomment-804283336 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=h1) Report > Merging [#1645](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=desc) (13970e8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/85efb37b0c5fe76c94a85f9fc0dc13312083181d?el=desc) (85efb37) will **decrease** coverage by `4.93%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=tree) ```diff @@Coverage Diff @@ ## master#1645 +/- ## == - Coverage 72.38% 67.45% -4.94% == Files 134 47 -87 Lines5737 3116-2621 Branches 6650 -665 == - Hits 4153 2102-2051 + Misses 1341 767 -574 - Partials 243 247 +4 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `48.04% <ø> (+0.32%)` | :arrow_up: | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `35.08% <0.00%> (-29.84%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `75.00% <0.00%> (-25.00%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `66.12% <0.00%> (-17.75%)` | :arrow_down: | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | `54.11% <0.00%> (-11.77%)` | :arrow_down: | | [api/internal/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3JvdXRlLmdv) | `76.47% <0.00%> (-8.83%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `67.28% <0.00%> (-3.74%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `52.10% <0.00%> (-3.37%)` | :arrow_down: | | [api/internal/core/store/validate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGUuZ28=) | `67.03% <0.00%> (-2.24%)` | :arrow_down: | | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `80.18% <0.00%> (-1.89%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (-1.21%)` | :arrow_down: | | ... and [88 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=footer). Last update [85efb37...13970e8](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1645: test: enhanced test stability
codecov-io commented on pull request #1645: URL: https://github.com/apache/apisix-dashboard/pull/1645#issuecomment-804283336 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=h1) Report > Merging [#1645](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=desc) (13970e8) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/85efb37b0c5fe76c94a85f9fc0dc13312083181d?el=desc) (85efb37) will **decrease** coverage by `24.34%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1645 +/- ## === - Coverage 72.38% 48.04% -24.35% === Files 134 47 -87 Lines5737 3116 -2621 Branches 6650 -665 === - Hits 4153 1497 -2656 + Misses 1341 1334-7 - Partials 243 285 +42 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `48.04% <ø> (+0.32%)` | :arrow_up: | | backend-unit-test | `?` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/handler/label/label.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbGFiZWwvbGFiZWwuZ28=) | `9.43% <0.00%> (-72.65%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_export.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfZXhwb3J0Lmdv) | `3.38% <0.00%> (-65.79%)` | :arrow_down: | | [api/internal/utils/runtime/runtime.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3J1bnRpbWUvcnVudGltZS5nbw==) | `0.00% <0.00%> (-64.29%)` | :arrow_down: | | [api/internal/handler/global\_rule/global\_rule.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZ2xvYmFsX3J1bGUvZ2xvYmFsX3J1bGUuZ28=) | `27.41% <0.00%> (-56.46%)` | :arrow_down: | | [api/internal/core/store/validate\_mock.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvdmFsaWRhdGVfbW9jay5nbw==) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/filter/authentication.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9hdXRoZW50aWNhdGlvbi5nbw==) | `36.11% <0.00%> (-41.67%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `57.22% <0.00%> (-31.93%)` | :arrow_down: | | [api/internal/handler/service/service.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2VydmljZS9zZXJ2aWNlLmdv) | `62.60% <0.00%> (-29.57%)` | :arrow_down: | | [api/internal/handler/route/route.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGUvcm91dGUuZ28=) | `51.83% <0.00%> (-26.94%)` | :arrow_down: | | ... and [105 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1645/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=footer). Last update [85efb37...13970e8](https://codecov.io/gh/apache/apisix-dashboard/pull/1645?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1645: test: enhanced test stability
guoqqqi commented on a change in pull request #1645:
URL: https://github.com/apache/apisix-dashboard/pull/1645#discussion_r598927311
##
File path: web/cypress/integration/service/edit-service-with-upstream.spec.js
##
@@ -25,8 +25,7 @@ context('Edit Service with Upstream', () => {
});
it('should create a test upstream', function () {
-cy.visit('/');
-cy.contains('Upstream').click();
+cy.visit('/upstream/list');
Review comment:
Agree with you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1647: Chore(BE): Change route name feild required
Jaycean opened a new pull request #1647: URL: https://github.com/apache/apisix-dashboard/pull/1647 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #1624 ___ ### New feature or improvement - Change route name feild required. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1646: feat: added github link to header #1632
iamayushdas commented on pull request #1646: URL: https://github.com/apache/apisix-dashboard/pull/1646#issuecomment-804211748 @juzhiyuan please review this -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1646: feat: added github link to header #1632
iamayushdas opened a new pull request #1646: URL: https://github.com/apache/apisix-dashboard/pull/1646 issue resolved from #1632 Here are some minor issues on the Login page we could resolve. ## TODO * [ ] Left icon replacement. @LiteSun * [ ] Extracting Table as a separate component for reuse in various modules. * [ ] APISIX plugin type change. * [x] GitHub hyperlink (icon) added to Header section. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1641: feat: change the metrics to dashboard
liuxiran commented on a change in pull request #1641:
URL: https://github.com/apache/apisix-dashboard/pull/1641#discussion_r598866736
##
File path: web/src/locales/zh-CN/menu.ts
##
@@ -22,7 +22,7 @@ export default {
'menu.login': '登录',
'menu.register': '注册',
'menu.register.result': '注册结果',
- 'menu.dashboard': 'Dashboard',
+ 'menu.dashboard': '仪表板',
Review comment:
may I ask why we keep `Dashboard` in zh-CN? @juzhiyuan
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1645: test: enhanced test stability
liuxiran commented on a change in pull request #1645:
URL: https://github.com/apache/apisix-dashboard/pull/1645#discussion_r598843463
##
File path: web/cypress/integration/service/edit-service-with-upstream.spec.js
##
@@ -25,8 +25,7 @@ context('Edit Service with Upstream', () => {
});
it('should create a test upstream', function () {
-cy.visit('/');
-cy.contains('Upstream').click();
+cy.visit('/upstream/list');
Review comment:
Is it necessary to add
`cy.get(this.domSelector.empty).should('be.visible');` to make sure the
upstream list rendered well just like
https://github.com/apache/apisix-dashboard/pull/1645/files#diff-e5538d6ea581a815051ee7ba013803f5b5c795e4979f908e3aa8c51844521a36R34
?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis edited a comment on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
membphis edited a comment on issue #1468: URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-804156876 > Why the duplicate also needs to be updated? IMO, if the duplicate route is not updated, they are two different routes. that is why I think it'll cause a bug. because there are two different routes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
membphis commented on issue #1468: URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-804156876 > Why the duplicate also needs to be updated? IMO, if the duplicate route is not updated, they are two different routes. that is why I think it'll cause a but. because there are two different routes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3766: docs: add --server option for the use of luarocks
membphis commented on pull request #3766: URL: https://github.com/apache/apisix/pull/3766#issuecomment-804153853 @stu01509 you should update the doc: https://github.com/apache/apisix/blob/master/docs/en/latest/FAQ.md#why-is-it-that-installing-apisix-dependencies-with-luarocks-causes-timeout-slow-or-unsuccessful-installation we do not need to update the file `Makefile` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1643: When creating a route, the upstream cannot select ‘none’
juzhiyuan commented on issue #1643: URL: https://github.com/apache/apisix-dashboard/issues/1643#issuecomment-804141246 ya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
