[GitHub] [apisix-dashboard] Jaycean commented on issue #1664: feat: use gomega match assertion
Jaycean commented on issue #1664: URL: https://github.com/apache/apisix-dashboard/issues/1664#issuecomment-807955741 > @Jaycean feel free to ask me if I could be of any help :) > I'd be happy to write some. Thank you very much. Let me finish the issue. If you have time, you can help to finish the issue: #1500 . There are still many E2E tests to rewrite. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on issue #1664: feat: use gomega match assertion
bisakhmondal commented on issue #1664: URL: https://github.com/apache/apisix-dashboard/issues/1664#issuecomment-807952994 @Jaycean feel free to ask me if I could be of any help :) I'd be happy to write some. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3903: request help: Accessing ctx.var.upstream_uri in global rule causes failure of proxy-rewrite
Firstsawyou commented on issue #3903: URL: https://github.com/apache/apisix/issues/3903#issuecomment-807952132 > It is because `ctx.var` caches the result: > https://github.com/apache/apisix/blob/83931ba0a5c95e04ec867a4ffd0821d426ca0d27/apisix/core/ctx.lua#L186 Got it, thank you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3913: request help: How to transfer parameters to the next plugin?
Firstsawyou commented on issue #3913: URL: https://github.com/apache/apisix/issues/3913#issuecomment-807951412 I think you can try to use the `ctx` variable in the plugin to cache the value that needs to be transferred. such as: `ctx.ignore` Then we can get it in the next plugin. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yangzcy423911 opened a new issue #3916: request help: upstream healthy check with http upstream server no access log
Yangzcy423911 opened a new issue #3916:
URL: https://github.com/apache/apisix/issues/3916
### Issue description
### Environment
* apisix version (cmd: `apisix version`):2.2
* OS (cmd: `uname -a`):
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
* apisix-dashboard version, if have:
upstream info
{
"node": {
"value": {
"update_time": 1616730666,
"id": "340800355065398158",
"name": "test",
"checks": {
"active": {
"host": "www.host.com",
"port": 80,
"http_path": "/api/actuator/health",
"healthy": {
"interval": 2,
"successes": 1
},
"unhealthy": {
"http_failures": 3,
"interval": 2
},
"timeout": 3
}
},
"nodes": [
{
"host": "192.168.1.100",
"port": 8080,
"weight": 0
},
{
"host": "192.168.1.200",
"port": 8080,
"weight": 1
}
],
"timeout": {
"connect": 6000,
"send": 6000,
"read": 6000
},
"type": "roundrobin",
"create_time": 1612662441,
"desc": "test",
"pass_host": "pass"
},
"key": "/apisix/upstreams/340800355065398158"
},
"count": "1",
"action": "get"
}
use curl cmd
curl http://www.host.com:80/api/actuator/health
{"status":"UP"}
upstream server log
2021-03-26 13:06:12.310 INFO com.host.com.check -/actuator/health
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] juzhiyuan commented on a change in pull request #47: docs: create docs folder and move README.md
juzhiyuan commented on a change in pull request #47:
URL: https://github.com/apache/apisix-helm-chart/pull/47#discussion_r602019375
##
File path: docs/en/latest/config.json
##
@@ -0,0 +1,10 @@
+{
+"version": 0.4,
+"sidebar": [
+ {
+"type": "category",
+"label": "Installation",
+"items": ["apisix", "apisix-dashboard", "apisix-ingress-controller"]
Review comment:
don't forget to add meta infomation.
##
File path: docs/en/latest/config.json
##
@@ -0,0 +1,10 @@
+{
+"version": 0.4,
+"sidebar": [
+ {
+"type": "category",
+"label": "Installation",
+"items": ["apisix", "apisix-dashboard", "apisix-ingress-controller"]
+ }
+]
+ }
Review comment:
new line
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] juzhiyuan merged pull request #310: feat: add CHANGELOG.md in sidebar
juzhiyuan merged pull request #310: URL: https://github.com/apache/apisix-ingress-controller/pull/310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: docs: support CHANGELOG (#310)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new f963319 docs: support CHANGELOG (#310)
f963319 is described below
commit f963319e38a1206f7eb7f75fd540c9a6acb5be28
Author: Kishani Kandasamy <53715187+kishanikandas...@users.noreply.github.com>
AuthorDate: Fri Mar 26 10:36:33 2021 +0530
docs: support CHANGELOG (#310)
---
docs/en/latest/config.json | 5 +
1 file changed, 5 insertions(+)
diff --git a/docs/en/latest/config.json b/docs/en/latest/config.json
index abb8bb6..64c7b09 100644
--- a/docs/en/latest/config.json
+++ b/docs/en/latest/config.json
@@ -60,6 +60,11 @@
{
"type": "doc",
"id": "FAQ"
+},
+{
+ "type": "link",
+ "label": "CHANGELOG",
+ "href":
"https://github.com/apache/apisix-ingress-controller/blob/master/CHANGELOG.md;
}
]
}
[GitHub] [apisix-docker] juzhiyuan commented on a change in pull request #153: docs: move the md files to /docs/en/latest foleder
juzhiyuan commented on a change in pull request #153:
URL: https://github.com/apache/apisix-docker/pull/153#discussion_r602018586
##
File path: docs/en/latest/config.json
##
@@ -0,0 +1,10 @@
+{
+"version": 1.0,
+"sidebar": [
+ {
+"type": "category",
+"label": "Installation",
+"items": ["build", "manual", "example"]
+ }
+]
+ }
Review comment:
new line, please
##
File path: docs/en/latest/config.json
##
@@ -0,0 +1,10 @@
+{
+"version": 1.0,
+"sidebar": [
+ {
+"type": "category",
+"label": "Installation",
+"items": ["build", "manual", "example"]
Review comment:
Hi, those items should contain necessary meta information, please refer
to `apisix`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-docker] tokers edited a comment on pull request #153: docs: move the md files to /docs/en/latest foleder
tokers edited a comment on pull request #153: URL: https://github.com/apache/apisix-docker/pull/153#issuecomment-807936414 @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on pull request #153: docs: move the md files to /docs/en/latest foleder
tokers commented on pull request #153: URL: https://github.com/apache/apisix-docker/pull/153#issuecomment-807936414 @juzhiyuan ju -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3903: request help: Accessing ctx.var.upstream_uri in global rule causes failure of proxy-rewrite
spacewander commented on issue #3903: URL: https://github.com/apache/apisix/issues/3903#issuecomment-807927812 Another solution is to use a new way to cache `ctx.var`: https://github.com/apache/apisix/pull/3915 This way has performance slow down, CC @membphis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3915: feat: new way to cache ctx.var
spacewander opened a new pull request #3915: URL: https://github.com/apache/apisix/pull/3915 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3903: request help: Accessing ctx.var.upstream_uri in global rule causes failure of proxy-rewrite
spacewander commented on issue #3903: URL: https://github.com/apache/apisix/issues/3903#issuecomment-807926957 One solution is to use ngx.var instead: https://github.com/apache/apisix/pull/3914 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3914: test: show how to bypass the ctx.var cache
spacewander opened a new pull request #3914: URL: https://github.com/apache/apisix/pull/3914 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3903: request help: Accessing ctx.var.upstream_uri in global rule causes failure of proxy-rewrite
spacewander commented on issue #3903: URL: https://github.com/apache/apisix/issues/3903#issuecomment-807926060 It is because `ctx.var` caches the result: https://github.com/apache/apisix/blob/83931ba0a5c95e04ec867a4ffd0821d426ca0d27/apisix/core/ctx.lua#L186 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 edited a comment on pull request #1633: feat: add the service page upstream select option
stu01509 edited a comment on pull request #1633: URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-807875220 Hi @liuxiran Thanks for your detailed explanation, I update the commit please review it again.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] han6565 commented on a change in pull request #3910: fix: limit-count plugin connect error
han6565 commented on a change in pull request #3910:
URL: https://github.com/apache/apisix/pull/3910#discussion_r601996195
##
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##
@@ -32,7 +32,7 @@ local mt = {
local function new_redis_cluster(conf)
local config = {
-name = "apisix-redis-cluster",
+name = "apisix-redis-cluster-" .. conf.name,
Review comment:
one name Mapping one routes，if all redis_cluster config the same name.
When concurrent lrucache can not find the correct redis_cluster in pool.
This is my personal opinion ，maybe it is wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Caelebs opened a new issue #3913: request help: How to transfer parameters to the next plugin?
Caelebs opened a new issue #3913:
URL: https://github.com/apache/apisix/issues/3913
### Issue description
I have a custom plug-in to determine whether the requested URI exists in the
whitelist api list. In addition, there is another plugin to request the
internal authentication service to verify whether there is permission. Now my
approach is to enter in the request When it comes to the first plugin, I use
`core.response.set_header("Ignore", var)` to set a header, and then determine
the value of the header in subsequent plugins. I am not sure if there are other
ways to do it? The method I use now doesn't seem to be very good.
I have used `spring cloud gateway` before, and the practice was similar to
now, using `serverWebExchange.getAttributes().put("ignore_access", "true");`,
maybe apisix can have a better way? Because I always feel that it is not very
good to transfer variables by setting the header
### Environment
* apisix version (cmd: `apisix version`): `2.4`
* OS (cmd: `uname -a`): `CentOS Linux release 7.6.1810 (Core)`
* OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
`openresty/1.17.8.2`
* etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
`{"up_time":1869,"boot_time":1616727683,"last_report_time":1616729544,"id":"408bcb78-10dd-4958-902c-f399bc60e0fc","etcd_version":"3.4.0","hostname":"TEST3","version":"2.4"}`
* apisix-dashboard version, if have: `2.5`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas closed pull request #1671: feat: improved plugin #1631
iamayushdas closed pull request #1671: URL: https://github.com/apache/apisix-dashboard/pull/1671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] stu01509 commented on pull request #47: docs: create docs folder and move README.md
stu01509 commented on pull request #47: URL: https://github.com/apache/apisix-helm-chart/pull/47#issuecomment-807909632 > Once this PR gets merged, @stu01509 please update apisix-website's sync codes. Sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] juzhiyuan commented on pull request #47: docs: create docs folder and move README.md
juzhiyuan commented on pull request #47: URL: https://github.com/apache/apisix-helm-chart/pull/47#issuecomment-807909271 Once this PR gets merged, @stu01509 please update apisix-website's sync codes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] stu01509 opened a new pull request #153: docs: move the md files to /docs/en/latest foleder
stu01509 opened a new pull request #153: URL: https://github.com/apache/apisix-docker/pull/153 According to this apache/apisix-website#216, so I created the folder /docs/en/latest to save the current README.md file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new issue #313: bug: ingress resources in extensions/v1beta1 is not dealt reasonablely
tokers opened a new issue #313: URL: https://github.com/apache/apisix-ingress-controller/issues/313 ### Issue description For Kubernetes prior to `1.14`, the API version group for [Ingress](https://kubernetes.io/docs/concepts/services-networking/ingress/) is `extensions/v1beta1`, which is deprecated in newer versions and will be unavailable in `1.22`. Currently, apisix-ingress-controller works well with `ingress.networking/v1beta1` and `ingress.networking/v1`, but if there are some `ingress.extensions/v1beta1` resources in the Kuberentes cluster, the apisix-ingress-controller program might panic since it's not compatible with `ingress.extensions/v1beta1`. We'd better to be compatible with `ingress.extensions/v1beta1`. Some problems we have to solve: * The differences between `ingress.extensions/v1beta1` and `ingress.networking/v1beta1`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] han6565 commented on pull request #3910: fix: limit-count plugin connect error
han6565 commented on pull request #3910:
URL: https://github.com/apache/apisix/pull/3910#issuecomment-807906115
> Could you please add some test cases to cover the scene that you said?
ok,I can paste some of my test configuration and test results
in etcd one route like this:
{
"id": "347382218030582023",
"create_time": 1616585537,
"update_time": 1616590678,
"uris": [
"/test"
],
"name": "limit",
"methods": [
"GET",
"HEAD",
"POST",
"PUT",
"DELETE",
"OPTIONS",
"PATCH"
],
"plugins": {
"limit-count": {
"count": 1000,
"time_window": 1,
"rejected_code": 503,
"policy": "redis-cluster",
"redis_cluster_nodes": [
"cluster1-node1:6379",
"cluster1-node2:6379",
"cluster1-node3:6379"
],
"redis_password": "cluster1-password"
}
},
"upstream": {
"nodes": [
{
"host": "myip",
"port": ,
"weight": 1
}
],
"timeout": {
"connect": 6000,
"read": 6000,
"send": 6000
},
"type": "roundrobin",
"pass_host": "pass"
},
"status": 1
}
other route like this:
{
"id": "347382218030582024",
"create_time": 1616585538,
"update_time": 1616590679,
"uris": [
"/test2"
],
"name": "limit2",
"methods": [
"GET",
"HEAD",
"POST",
"PUT",
"DELETE",
"OPTIONS",
"PATCH"
],
"plugins": {
"limit-count": {
"count": 1000,
"time_window": 1,
"rejected_code": 503,
"policy": "redis-cluster",
"redis_cluster_nodes": [
"cluster2-node1:6379",
"cluster2-node2:6379",
"cluster2-node3:6379"
],
"redis_password": "cluster2-password"
}
},
"upstream": {
"nodes": [
{
"host": "myip",
"port": ,
"weight": 1
}
],
"timeout": {
"connect": 6000,
"read": 6000,
"send": 6000
},
"type": "roundrobin",
"pass_host": "pass"
},
"status": 1
}
then I stress test two routes at the same time，i use the go-stress-testing
test the url like this:
./go-stress-testing-mac -c 20 -n 10 -u http://apisix_ip:9080/test
./go-stress-testing-mac -c 20 -n 10 -u http://apisix_ip:9080/test2
you can see my error.log it output errror like this:
2021/03/26 11:07:03 [error] 28109#28109: *6443 [lua] limit-count.lua:174:
phase_func(): failed to limit req: failed to get redis
`plugin-limit-count10.73.42.1route122` ttl: ERR invalid password, client:
10.73.42.1, server: , request: "GET /test HTTP/1.1", host: "172.20.4.213:9080"
but the password is correct。
I will upload the error log
[error.log](https://github.com/apache/apisix/files/6209169/error.log)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1671: feat: improved plugin #1631
codecov-io commented on pull request #1671: URL: https://github.com/apache/apisix-dashboard/pull/1671#issuecomment-807906043 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1671?src=pr=h1) Report > Merging [#1671](https://codecov.io/gh/apache/apisix-dashboard/pull/1671?src=pr=desc) (91da575) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/88f323285f2bdbafca027da9aef357b2e3eb4008?el=desc) (88f3232) will **decrease** coverage by `20.60%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1671?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1671 +/- ## === - Coverage 72.41% 51.81% -20.61% === Files 133 38 -95 Lines5728 2650 -3078 Branches 6660 -666 === - Hits 4148 1373 -2775 + Misses 1337 1089 -248 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1671?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [117 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1671/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1671?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1671?src=pr=footer). Last update [88f3232...91da575](https://codecov.io/gh/apache/apisix-dashboard/pull/1671?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean opened a new pull request #1673: fix: unable to export route with nil methods field
Jaycean opened a new pull request #1673: URL: https://github.com/apache/apisix-dashboard/pull/1673 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** 1. Fixed the bug that when creating route, the methods field is nil or [] and the data cannot be exported. 2. When there is no plugin data in the route, the empty field is not exported. **Related issues** fix/resolve #1668 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1671: feat: improved plugin #1631
iamayushdas commented on pull request #1671: URL: https://github.com/apache/apisix-dashboard/pull/1671#issuecomment-807903021 @juzhiyuan can you retrigger CI and review this now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1671: feat: improved plugin #1631
iamayushdas commented on a change in pull request #1671:
URL: https://github.com/apache/apisix-dashboard/pull/1671#discussion_r601981679
##
File path: web/src/pages/Plugin/locales/zh-CN.ts
##
@@ -16,5 +16,5 @@
*/
export default {
'page.plugin.drawer.popconfirm.title.delete': '确定删除该插件吗？',
- 'page.plugin.list': '插件列表'
+ 'page.plugin.list': '插件列表：已启用插件的列表'
Review comment:
is it cool now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] stu01509 commented on pull request #47: docs: create docs folder and move README.md
stu01509 commented on pull request #47: URL: https://github.com/apache/apisix-helm-chart/pull/47#issuecomment-807897825 Hi @juzhiyuan I following the https://github.com/apache/apisix-dashboard/blob/master/docs/en/latest/config.json to create the `config.json` file, please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] riskgod closed issue #46: [request help]: 404 not found
riskgod closed issue #46: URL: https://github.com/apache/apisix-helm-chart/issues/46 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] riskgod commented on issue #46: [request help]: 404 not found
riskgod commented on issue #46: URL: https://github.com/apache/apisix-helm-chart/issues/46#issuecomment-807897808 get it thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #3910: fix: limit-count plugin connect error
spacewander commented on a change in pull request #3910:
URL: https://github.com/apache/apisix/pull/3910#discussion_r601979901
##
File path: apisix/plugins/limit-count/limit-count-redis-cluster.lua
##
@@ -32,7 +32,7 @@ local mt = {
local function new_redis_cluster(conf)
local config = {
-name = "apisix-redis-cluster",
+name = "apisix-redis-cluster-" .. conf.name,
Review comment:
I am confused by the solution. What is the relation between the password
and name?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1549: feat: support `discovery_type` in Dashboard
juzhiyuan commented on issue #1549: URL: https://github.com/apache/apisix-dashboard/issues/1549#issuecomment-807893461 AFAIK, @stu01509 is working on other issues, let's wait for other contributors to take this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1633: feat: add the service page upstream select option
stu01509 commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r601976697
##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -661,15 +661,14 @@ const UpstreamForm: React.FC = forwardRef(
item?.children.toLowerCase().includes(input.toLowerCase())
}
>
- {Boolean(!required) && None}
+ {Boolean(!required) && {
Review comment:
Hi @juzhiyuan
Update the commit :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] starsz merged pull request #3457: fix: refine example grafana dashboard
starsz merged pull request #3457: URL: https://github.com/apache/apisix/pull/3457 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (83ab543 -> 83931ba)
This is an automated email from the ASF dual-hosted git repository. starsz pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 83ab543 fix: use the builtin server by default (#3907) add 83931ba fix: refine example grafana dashboard (#3457) No new revisions were added by this update. Summary of changes: apisix/plugins/prometheus/exporter.lua | 5 +- docs/assets/images/plugin/grafana-1.png| Bin 0 -> 260106 bytes docs/assets/images/plugin/grafana-2.png| Bin 0 -> 211404 bytes docs/assets/images/plugin/grafana-3.png| Bin 0 -> 38360 bytes docs/assets/images/plugin/grafana_1.png| Bin 104999 -> 0 bytes docs/assets/images/plugin/grafana_2.png| Bin 115465 -> 0 bytes docs/assets/images/plugin/grafana_3.png| Bin 44326 -> 0 bytes .../other/json/apisix-grafana-dashboard.json | 702 ++--- docs/en/latest/plugins/prometheus.md | 14 +- docs/zh/latest/plugins/prometheus.md | 14 +- rockspec/apisix-master-0.rockspec | 2 +- t/plugin/prometheus.t | 2 +- 12 files changed, 504 insertions(+), 235 deletions(-) create mode 100644 docs/assets/images/plugin/grafana-1.png create mode 100644 docs/assets/images/plugin/grafana-2.png create mode 100644 docs/assets/images/plugin/grafana-3.png delete mode 100644 docs/assets/images/plugin/grafana_1.png delete mode 100644 docs/assets/images/plugin/grafana_2.png delete mode 100644 docs/assets/images/plugin/grafana_3.png
[GitHub] [apisix-dashboard] iamayushdas commented on a change in pull request #1671: feat: improved plugin #1631
iamayushdas commented on a change in pull request #1671:
URL: https://github.com/apache/apisix-dashboard/pull/1671#discussion_r601974772
##
File path: web/src/pages/Plugin/locales/zh-CN.ts
##
@@ -16,5 +16,5 @@
*/
export default {
'page.plugin.drawer.popconfirm.title.delete': '确定删除该插件吗？',
- 'page.plugin.list': '插件列表'
+ 'page.plugin.list': '插件列表：已启用插件的列表'
Review comment:
okay i have closed this and will try to fix this in next PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] stu01509 commented on pull request #47: docs: create docs folder and move README.md
stu01509 commented on pull request #47: URL: https://github.com/apache/apisix-helm-chart/pull/47#issuecomment-807888670 Hi @juzhiyuan Update the commit :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on pull request #3910: fix: limit-count plugin connect error
tokers commented on pull request #3910: URL: https://github.com/apache/apisix/pull/3910#issuecomment-807884606 Could you please add some test cases to cover the scene that you said? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on issue #46: [request help]: 404 not found
tokers commented on issue #46: URL: https://github.com/apache/apisix-helm-chart/issues/46#issuecomment-807883897 @riskgod As per your diagrams, 30957 is the node port for apisix admin, not the gateway, try 30103 instead. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #230: docs: tell users where they are
iamayushdas commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-807883977 > @iamayushdas Hi, please refer to https://v2.docusaurus.io/ first :) Okay -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #230: docs: tell users where they are
juzhiyuan commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-807883334 @iamayushdas Hi, please refer to https://v2.docusaurus.io/ first :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on a change in pull request #311: fix: workqueue need to retry when failed
tokers commented on a change in pull request #311:
URL:
https://github.com/apache/apisix-ingress-controller/pull/311#discussion_r601967157
##
File path: pkg/ingress/controller/apisix_route.go
##
@@ -188,15 +188,11 @@ func (c *apisixRouteController) handleSyncErr(obj
interface{}, err error) {
c.workqueue.Forget(obj)
return
}
- if c.workqueue.NumRequeues(obj) < _maxRetries {
Review comment:
I cannot claim a distinct point about this now. Just merge it if it
makes some trouble at present.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1633: feat: add the service page upstream select option
juzhiyuan commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r601966905
##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -661,15 +661,14 @@ const UpstreamForm: React.FC = forwardRef(
item?.children.toLowerCase().includes(input.toLowerCase())
}
>
- {Boolean(!required) && None}
+ {Boolean(!required) && {
Review comment:
```suggestion
{Boolean(!required) && {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #3864: bug: Upstream SNI should also be rewritten when the upstream host is rewritten
tokers commented on issue #3864: URL: https://github.com/apache/apisix/issues/3864#issuecomment-807878251 Yep. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #3912: fix(error-log-logger): the logger should be run in each process
spacewander opened a new pull request #3912: URL: https://github.com/apache/apisix/pull/3912 Fix #3911 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on pull request #1633: feat: add the service page upstream select option
stu01509 commented on pull request #1633: URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-807875220 Hi @LiteSun Thanks for your detailed explanation, I update the commit please review it again.  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] stu01509 commented on issue #230: docs: tell users where they are
stu01509 commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-807868069 Hi @iamayushdas Actually, I'm not get in-depth about this issue, What problem do you encounter? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1549: feat: support `discovery_type` in Dashboard
juzhiyuan commented on issue #1549: URL: https://github.com/apache/apisix-dashboard/issues/1549#issuecomment-807866436 oh got it, @stu01509 just to make sure, would you have time to resolve this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] caukie commented on issue #1549: feat: support `discovery_type` in Dashboard
caukie commented on issue #1549: URL: https://github.com/apache/apisix-dashboard/issues/1549#issuecomment-807866005 @juzhiyuan sorry，i'm not working with nodejs, so still waiting for help. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas removed a comment on pull request #1666: feat: improved plugin #1631
iamayushdas removed a comment on pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-807860167 >  > > How about here? #1671 @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas closed pull request #1671: feat: improved plugin #1631
iamayushdas closed pull request #1671: URL: https://github.com/apache/apisix-dashboard/pull/1671 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1549: feat: support `discovery_type` in Dashboard
juzhiyuan commented on issue #1549: URL: https://github.com/apache/apisix-dashboard/issues/1549#issuecomment-807863484 @caukie Hi, would you like to have a try? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] caukie commented on issue #1549: feat: support `discovery_type` in Dashboard
caukie commented on issue #1549: URL: https://github.com/apache/apisix-dashboard/issues/1549#issuecomment-807861836 > Hi, please resolve other issues first can this issue be assigned to @stu01509 now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1671: feat: improved plugin #1631
juzhiyuan commented on a change in pull request #1671:
URL: https://github.com/apache/apisix-dashboard/pull/1671#discussion_r601945854
##
File path: web/src/locales/zh-CN/component.ts
##
@@ -21,19 +21,24 @@ export default {
'component.global.search': '查询',
'component.global.reset': '重置',
'component.global.confirm': '确认',
+ 'component.global.format': '格式',
+ 'component.global.document': '文档',
+ 'component.global.enable': '使能够',
Review comment:
```suggestion
'component.global.enable': '启用',
```
##
File path: web/src/pages/Plugin/locales/zh-CN.ts
##
@@ -16,5 +16,5 @@
*/
export default {
'page.plugin.drawer.popconfirm.title.delete': '确定删除该插件吗？',
- 'page.plugin.list': '插件列表'
+ 'page.plugin.list': '插件列表：已启用插件的列表'
Review comment:
Hi, as for the subtitle, how about using the `extra` prop like here[1]?
[1] https://procomponents.ant.design/en-US/components/page-container
##
File path: web/src/locales/zh-CN/component.ts
##
@@ -21,19 +21,24 @@ export default {
'component.global.search': '查询',
'component.global.reset': '重置',
'component.global.confirm': '确认',
+ 'component.global.format': '格式',
+ 'component.global.document': '文档',
+ 'component.global.enable': '使能够',
+ 'component.global.scope': '范围',
+ 'component.global.data.editor': '资料编辑器',
Review comment:
```suggestion
'component.global.data.editor': '原始内容编辑器',
```
##
File path: web/src/locales/zh-CN/component.ts
##
@@ -21,19 +21,24 @@ export default {
'component.global.search': '查询',
'component.global.reset': '重置',
'component.global.confirm': '确认',
+ 'component.global.format': '格式',
+ 'component.global.document': '文档',
+ 'component.global.enable': '使能够',
+ 'component.global.scope': '范围',
Review comment:
```suggestion
'component.global.scope': '作用域',
```
##
File path: web/src/locales/zh-CN/component.ts
##
@@ -21,19 +21,24 @@ export default {
'component.global.search': '查询',
'component.global.reset': '重置',
'component.global.confirm': '确认',
+ 'component.global.format': '格式',
Review comment:
```suggestion
'component.global.format': '格式化',
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] iamayushdas commented on pull request #1666: feat: improved plugin #1631
iamayushdas commented on pull request #1666: URL: https://github.com/apache/apisix-dashboard/pull/1666#issuecomment-807860167 >  > > How about here? #1671 @juzhiyuan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1672: doc: add more details and examples to import openapi guide
codecov-io edited a comment on pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#issuecomment-807310922 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=h1) Report > Merging [#1672](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=desc) (512053c) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **decrease** coverage by `20.77%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1672 +/- ## === - Coverage 72.59% 51.81% -20.78% === Files 133 38 -95 Lines5728 2650 -3078 Branches 6660 -666 === - Hits 4158 1373 -2785 + Misses 1327 1089 -238 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.77%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [119 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=footer). Last update [c6c5d14...512053c](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Jaycean commented on issue #1664: feat: use gomega match assertion
Jaycean commented on issue #1664: URL: https://github.com/apache/apisix-dashboard/issues/1664#issuecomment-807856964 > ok fine, anyone would like to take this issue? I will finish it when I have time. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on issue #1664: feat: use gomega match assertion
juzhiyuan commented on issue #1664: URL: https://github.com/apache/apisix-dashboard/issues/1664#issuecomment-807856400 ok fine, anyone would like to take this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran commented on a change in pull request #1633: feat: add the service page upstream select option
liuxiran commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r601934240
##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -667,6 +667,9 @@ const UpstreamForm: React.FC = forwardRef(
name: formatMessage({ id:
'page.upstream.step.select.upstream.select.option' }),
id: '',
},
+{
Review comment:
Hi @stu01509
1. turn to this line
https://github.com/apache/apisix-dashboard/pull/1633/files#diff-0029901a283985aea1e8e47cfb2d45c9c8eef8cb392e12ed31720390a22ec269R664,
you will see
this is the `None` option item, and you will find that it is controlled by
`required` parameter
3. for the `upstreamForm` component, `required` is a props item, see
4. our create service page used `upstreamForm` component, see
you can try to change the `required` param to `required={false}`, that will
solve your problem.
just try it ^_^, looking forward to your reply, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1672: doc: add more details and examples to import openapi guide
codecov-io commented on pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672#issuecomment-807310922 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=h1) Report > Merging [#1672](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=desc) (7d412b2) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/c6c5d147ef3e63a87a5f238aac8597357d2589d4?el=desc) (c6c5d14) will **decrease** coverage by `20.77%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=tree) ```diff @@ Coverage Diff @@ ## master#1672 +/- ## === - Coverage 72.59% 51.81% -20.78% === Files 133 38 -95 Lines5728 2650 -3078 Branches 6660 -666 === - Hits 4158 1373 -2785 + Misses 1327 1089 -238 + Partials 243 188 -55 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `51.81% <ø> (ø)` | | | frontend-e2e-test | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=tree) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-74.77%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | | [api/internal/handler/data\_loader/route\_import.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvZGF0YV9sb2FkZXIvcm91dGVfaW1wb3J0Lmdv) | `27.41% <0.00%> (-37.50%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `42.59% <0.00%> (-35.19%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | ... and [119 more](https://codecov.io/gh/apache/apisix-dashboard/pull/1672/diff?src=pr=tree-more) | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=footer). Last update [c6c5d14...7d412b2](https://codecov.io/gh/apache/apisix-dashboard/pull/1672?src=pr=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran opened a new pull request #1672: doc: add more details and examples to import openapi guide
liuxiran opened a new pull request #1672: URL: https://github.com/apache/apisix-dashboard/pull/1672 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** improve `IMPORT_OPENAPI_USER_GUIDE.md`, add more details and examples to help users to import route from the correct OAS3.0 file. **Related issues** update import doc for #1464 #1660 **Checklist:** - [ ] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] liuxiran edited a comment on issue #1660: doc: Improve docs about route import and export
liuxiran edited a comment on issue #1660: URL: https://github.com/apache/apisix-dashboard/issues/1660#issuecomment-806378650 > > ~~duplicate with #1646~~ > > @nic-chen sorry for late response for this issue, and pr is on the way > > thanks for remind. but the issue id seems wrong… it should be https://github.com/apache/apisix-dashboard/issues/1464 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] whl739 opened a new issue #3911: bug: error-log-logger call ngx.worker.id() in privileged agent
whl739 opened a new issue #3911:
URL: https://github.com/apache/apisix/issues/3911
In plugin `error-log-logger`:
```
function _M.init()
timers.register_timer("plugin#error-log-logger", process, true)
end
```
this timer will run on privileged agent, but in function `process`, it will
call `ngx.worker.id()`, whtich will return `nil`.
```
local function process()
local id = ngx.worker.id()
buffers[id] = log_buffer
end
```
it seems a bug, did i miss something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] membphis commented on pull request #26: chore: fix the template of deployment.yaml and add hints for affinity setting in values.yaml
membphis commented on pull request #26: URL: https://github.com/apache/apisix-helm-chart/pull/26#issuecomment-807054519 > Hi all > > Is this solve? If not, I would like to follow the @TkClark this PR to sent the pull request. welcome to submit new PR ^_^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #3824: fix: fix table format in plugin limit-count-redis-cluster.lua and limit-count-redis.lua
membphis commented on pull request #3824: URL: https://github.com/apache/apisix/pull/3824#issuecomment-807052835 bad code style, please take a look at the output of CI: https://github.com/apache/apisix/pull/3824/checks?check_run_id=2192618793#step:15:674 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3864: bug: Upstream SNI should also be rewritten when the upstream host is rewritten
membphis commented on issue #3864: URL: https://github.com/apache/apisix/issues/3864#issuecomment-807046953 I think this issue can be a `good first issue`, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou edited a comment on issue #3903: request help: Accessing ctx.var.upstream_uri in global rule causes failure of proxy-rewrite
Firstsawyou edited a comment on issue #3903:
URL: https://github.com/apache/apisix/issues/3903#issuecomment-807035124
Hi, @Gary-Airwallex Sorry, my previous test method was incorrect. I checked
the latest version again, and there seems to be such a problem. @spacewander
Please take a look at this question when you are free.
Here are the steps to reproduce:
1. Add the log of `ctx.var.upstream_uri` in the rewrite phase of the `cors`
plugin, and print the rewritten uri in the `proxy-rewrite` plugin.
```shell
diff --git a/apisix/plugins/cors.lua b/apisix/plugins/cors.lua
index 4b0b7c4..98beecc 100644
--- a/apisix/plugins/cors.lua
+++ b/apisix/plugins/cors.lua
@@ -225,6 +225,7 @@ end
function _M.rewrite(conf, ctx)
+core.log.warn("Access upstream uri: ", ctx.var.upstream_uri)
if ctx.var.request_method == "OPTIONS" then
return 200
end
diff --git a/apisix/plugins/proxy-rewrite.lua
b/apisix/plugins/proxy-rewrite.lua
index c678b59..e0c3d58 100644
--- a/apisix/plugins/proxy-rewrite.lua
+++ b/apisix/plugins/proxy-rewrite.lua
@@ -179,6 +179,7 @@ function _M.rewrite(conf, ctx)
end
if not conf.headers then
+core.log.warn("upstream_uri: ", ctx.var.upstream_uri)
return
end
```
2. Add the global plugin `cors`
```shell
curl -X PUT http://127.0.0.1:9080/apisix/admin/global_rules/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -d '{
"plugins": {
"cors": {}
}
}'
```
3. Add a route and bind the `proxy-rewrite` plugin
```shell
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"methods": ["GET"],
"uri": "/hello",
"plugins": {
"proxy-rewrite": {
"uri": "/route01"
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:1990": 1
}
}
}'
```
4. Test route (upstream default response data is the requested uri)
```shell
curl http://127.0.0.1:9080/hello -i
HTTP/1.1 200 OK
Content-Type: application/octet-stream
Transfer-Encoding: chunked
Connection: keep-alive
Date: Thu, 25 Mar 2021 16:05:58 GMT
Server: APISIX/2.4
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: *
Access-Control-Max-Age: 5
Access-Control-Expose-Headers: *
Access-Control-Allow-Headers: *
request_uri: /hello
```
The `proxy-rewrite` plugin rewriting uri is not effective.
`access.log` information:
```
[warn] 2707#2707: *62368 [lua] proxy-rewrite.lua:182: phase_func():
upstream_uri: /route01, client: 127.0.0.1,
```
5. Remove the log of `ctx.var.upstream_uri` in the global plugin `cors`
```shell
diff --git a/apisix/plugins/proxy-rewrite.lua
b/apisix/plugins/proxy-rewrite.lua
index c678b59..e0c3d58 100644
--- a/apisix/plugins/proxy-rewrite.lua
+++ b/apisix/plugins/proxy-rewrite.lua
@@ -179,6 +179,7 @@ function _M.rewrite(conf, ctx)
end
if not conf.headers then
+core.log.warn("upstream_uri: ", ctx.var.upstream_uri)
return
end
```
6. Test the route again (the upstream default response data is the requested
uri)
```shell
$ curl http://127.0.0.1:9080/hello -i
HTTP/1.1 200 OK
Content-Type: application/octet-stream
Transfer-Encoding: chunked
Connection: keep-alive
Date: Thu, 25 Mar 2021 16:13:31 GMT
Server: APISIX/2.4
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: *
Access-Control-Max-Age: 5
Access-Control-Expose-Headers: *
Access-Control-Allow-Headers: *
request_uri: /route01
```
The `proxy-rewrite` plugin rewrites the uri to take effect.
`access.log` information:
```
[warn] 2707#2707: *62368 [lua] proxy-rewrite.lua:182: phase_func():
upstream_uri: /route01, client: 127.0.0.1,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #3903: request help: Accessing ctx.var.upstream_uri in global rule causes failure of proxy-rewrite
Firstsawyou commented on issue #3903:
URL: https://github.com/apache/apisix/issues/3903#issuecomment-807035124
Hi, @Gary-Airwallex Sorry, my previous test method was incorrect. I checked
the latest version again, and there seems to be such a problem. @spacewander
Please take a look at this question when you are free.
Here are the steps to reproduce:
1. Add the log of `ctx.var.upstream_uri` in the rewrite phase of the `cors`
plugin, and print the rewritten uri in the `proxy-rewrite` plugin.
```shell
diff --git a/apisix/plugins/cors.lua b/apisix/plugins/cors.lua
index 4b0b7c4..98beecc 100644
--- a/apisix/plugins/cors.lua
+++ b/apisix/plugins/cors.lua
@@ -225,6 +225,7 @@ end
function _M.rewrite(conf, ctx)
+core.log.warn("Access upstream uri: ", ctx.var.upstream_uri)
if ctx.var.request_method == "OPTIONS" then
return 200
end
diff --git a/apisix/plugins/proxy-rewrite.lua
b/apisix/plugins/proxy-rewrite.lua
index c678b59..e0c3d58 100644
--- a/apisix/plugins/proxy-rewrite.lua
+++ b/apisix/plugins/proxy-rewrite.lua
@@ -179,6 +179,7 @@ function _M.rewrite(conf, ctx)
end
if not conf.headers then
+core.log.warn("upstream_uri: ", ctx.var.upstream_uri)
return
end
```
2. Add the global plugin `cors`
```shell
curl -X PUT http://127.0.0.1:9080/apisix/admin/global_rules/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -d '{
"plugins": {
"cors": {}
}
}'
```
3. Add a route and bind the `proxy-rewrite` plugin
```shell
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"methods": ["GET"],
"uri": "/hello",
"plugins": {
"proxy-rewrite": {
"uri": "/route01"
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:1990": 1
}
}
}'
```
4. Test route (upstream default response data is the requested uri)
```shell
curl http://127.0.0.1:9080/hello -i
HTTP/1.1 200 OK
Content-Type: application/octet-stream
Transfer-Encoding: chunked
Connection: keep-alive
Date: Thu, 25 Mar 2021 16:05:58 GMT
Server: APISIX/2.4
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: *
Access-Control-Max-Age: 5
Access-Control-Expose-Headers: *
Access-Control-Allow-Headers: *
request_uri: /hello
```
The `proxy-rewrite` plug-in rewriting uri is not effective.
`access.log` information:
```
[warn] 2707#2707: *62368 [lua] proxy-rewrite.lua:182: phase_func():
upstream_uri: /route01, client: 127.0.0.1,
```
5. Remove the log of `ctx.var.upstream_uri` in the global plugin `cors`
```shell
diff --git a/apisix/plugins/proxy-rewrite.lua
b/apisix/plugins/proxy-rewrite.lua
index c678b59..e0c3d58 100644
--- a/apisix/plugins/proxy-rewrite.lua
+++ b/apisix/plugins/proxy-rewrite.lua
@@ -179,6 +179,7 @@ function _M.rewrite(conf, ctx)
end
if not conf.headers then
+core.log.warn("upstream_uri: ", ctx.var.upstream_uri)
return
end
```
6. Test the route again (the upstream default response data is the requested
uri)
```shell
$ curl http://127.0.0.1:9080/hello -i
HTTP/1.1 200 OK
Content-Type: application/octet-stream
Transfer-Encoding: chunked
Connection: keep-alive
Date: Thu, 25 Mar 2021 16:13:31 GMT
Server: APISIX/2.4
Access-Control-Allow-Origin: *
Access-Control-Allow-Methods: *
Access-Control-Max-Age: 5
Access-Control-Expose-Headers: *
Access-Control-Allow-Headers: *
request_uri: /route01
```
The `proxy-rewrite` plug-in rewrites the uri to take effect.
`access.log` information:
```
[warn] 2707#2707: *62368 [lua] proxy-rewrite.lua:182: phase_func():
upstream_uri: /route01, client: 127.0.0.1,
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] membphis commented on issue #1468: discuss: When import routes, whether duplicate routes should be allowed to be imported
membphis commented on issue #1468: URL: https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-807012310 I think everyone is right, sorry for causing you trouble. https://github.com/apache/apisix-dashboard/issues/1468#issuecomment-781184877 is a good way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on issue #1664: feat: use gomega match assertion
starsz commented on issue #1664: URL: https://github.com/apache/apisix-dashboard/issues/1664#issuecomment-806984719 +1 Gomega -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis merged pull request #3907: fix: use the builtin server by default
membphis merged pull request #3907: URL: https://github.com/apache/apisix/pull/3907 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #3906: Why do I limit the server_name value, but still go to the snippet server block
membphis closed issue #3906: URL: https://github.com/apache/apisix/issues/3906 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix: use the builtin server by default (#3907)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 83ab543 fix: use the builtin server by default (#3907)
83ab543 is described below
commit 83ab5439a03ebff133a36045b8e9cc3003b8baf0
Author: 罗泽轩
AuthorDate: Thu Mar 25 23:49:38 2021 +0800
fix: use the builtin server by default (#3907)
Fix #3906
---
apisix/cli/ngx_tpl.lua | 14 +++---
t/cli/test_main.sh | 69 ---
t/cli/test_snippet.sh | 123 +
3 files changed, 131 insertions(+), 75 deletions(-)
diff --git a/apisix/cli/ngx_tpl.lua b/apisix/cli/ngx_tpl.lua
index 2bfa582..00cda09 100644
--- a/apisix/cli/ngx_tpl.lua
+++ b/apisix/cli/ngx_tpl.lua
@@ -345,31 +345,33 @@ http {
server {
{% for _, item in ipairs(node_listen) do %}
-listen {* item.port *} {% if enable_reuseport then %} reuseport {% end
%} {% if item.enable_http2 then %} http2 {% end %};
+listen {* item.port *} default_server {% if enable_reuseport then %}
reuseport {% end %} {% if item.enable_http2 then %} http2 {% end %};
{% end %}
{% if ssl.enable then %}
{% for _, port in ipairs(ssl.listen_port) do %}
-listen {* port *} ssl {% if ssl.enable_http2 then %} http2 {% end %}
{% if enable_reuseport then %} reuseport {% end %};
+listen {* port *} ssl default_server {% if ssl.enable_http2 then %}
http2 {% end %} {% if enable_reuseport then %} reuseport {% end %};
{% end %}
{% end %}
{% if proxy_protocol and proxy_protocol.listen_http_port then %}
-listen {* proxy_protocol.listen_http_port *} proxy_protocol;
+listen {* proxy_protocol.listen_http_port *} default_server
proxy_protocol;
{% end %}
{% if proxy_protocol and proxy_protocol.listen_https_port then %}
-listen {* proxy_protocol.listen_https_port *} ssl {% if
ssl.enable_http2 then %} http2 {% end %} proxy_protocol;
+listen {* proxy_protocol.listen_https_port *} ssl default_server {% if
ssl.enable_http2 then %} http2 {% end %} proxy_protocol;
{% end %}
{% if enable_ipv6 then %}
{% for _, item in ipairs(node_listen) do %}
-listen [::]:{* item.port *} {% if enable_reuseport then %} reuseport
{% end %} {% if item.enable_http2 then %} http2 {% end %};
+listen [::]:{* item.port *} default_server {% if enable_reuseport then
%} reuseport {% end %} {% if item.enable_http2 then %} http2 {% end %};
{% end %}
{% if ssl.enable then %}
{% for _, port in ipairs(ssl.listen_port) do %}
-listen [::]:{* port *} ssl {% if ssl.enable_http2 then %} http2 {% end
%} {% if enable_reuseport then %} reuseport {% end %};
+listen [::]:{* port *} ssl default_server {% if ssl.enable_http2 then
%} http2 {% end %} {% if enable_reuseport then %} reuseport {% end %};
{% end %}
{% end %}
{% end %} {% -- if enable_ipv6 %}
+server_name _;
+
{% if ssl.ssl_trusted_certificate ~= nil then %}
lua_ssl_trusted_certificate {* ssl.ssl_trusted_certificate *};
{% end %}
diff --git a/t/cli/test_main.sh b/t/cli/test_main.sh
index ca287bb..e2dc488 100755
--- a/t/cli/test_main.sh
+++ b/t/cli/test_main.sh
@@ -481,75 +481,6 @@ fi
echo "passed: found 'my_dict' in nginx.conf"
-# allow injecting configuration snippets
-
-echo '
-apisix:
-node_listen: 9080
-enable_admin: true
-port_admin: 9180
-stream_proxy:
-tcp:
-- 9100
-nginx_config:
-main_configuration_snippet: |
-daemon on;
-http_configuration_snippet: |
-chunked_transfer_encoding on;
-http_server_configuration_snippet: |
-set $my "var";
-http_admin_configuration_snippet: |
-log_format admin "$request_time $pipe";
-http_end_configuration_snippet: |
-server_names_hash_bucket_size 128;
-stream_configuration_snippet: |
-tcp_nodelay off;
-' > conf/config.yaml
-
-make init
-
-grep "daemon on;" -A 2 conf/nginx.conf | grep "configuration snippet ends" >
/dev/null
-if [ ! $? -eq 0 ]; then
-echo "failed: can't inject main configuration"
-exit 1
-fi
-
-grep "chunked_transfer_encoding on;" -A 2 conf/nginx.conf | grep
"configuration snippet ends" > /dev/null
-if [ ! $? -eq 0 ]; then
-echo "failed: can't inject http configuration"
-exit 1
-fi
-
-grep 'set $my "var";' -A 2 conf/nginx.conf | grep "configuration snippet ends"
> /dev/null
-if [ ! $? -eq 0 ]; then
-echo "failed: can't inject http server configuration"
-exit 1
-fi
-
-grep 'log_format admin "$request_time $pipe";' -A 2 conf/nginx.conf | grep
"configuration snippet ends" > /dev/null
-if [ ! $? -eq 0 ]; then
-echo "failed: can't inject admin server configuration"
-
[GitHub] [apisix] membphis merged pull request #3905: feat: support mTLS with etcd
membphis merged pull request #3905: URL: https://github.com/apache/apisix/pull/3905 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: feat: support mTLS with etcd (#3905)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 92b3528 feat: support mTLS with etcd (#3905)
92b3528 is described below
commit 92b352862a7770daa0b1ac50893c4c68d84af877
Author: 罗泽轩
AuthorDate: Thu Mar 25 23:40:40 2021 +0800
feat: support mTLS with etcd (#3905)
---
apisix/core/config_etcd.lua | 11 +-
apisix/core/etcd.lua | 13 +-
apisix/patch.lua | 39 +-
rockspec/apisix-master-0.rockspec | 2 +-
t/APISIX.pm | 9 +-
t/core/etcd-mtls.t| 273 ++
6 files changed, 339 insertions(+), 8 deletions(-)
diff --git a/apisix/core/config_etcd.lua b/apisix/core/config_etcd.lua
index 10d54f3..a9888a3 100644
--- a/apisix/core/config_etcd.lua
+++ b/apisix/core/config_etcd.lua
@@ -506,8 +506,15 @@ do
-- default to verify etcd cluster certificate
etcd_conf.ssl_verify = true
-if etcd_conf.tls and etcd_conf.tls.verify == false then
-etcd_conf.ssl_verify = false
+if etcd_conf.tls then
+if etcd_conf.tls.verify == false then
+etcd_conf.ssl_verify = false
+end
+
+if etcd_conf.tls.cert then
+etcd_conf.ssl_cert_path = etcd_conf.tls.cert
+etcd_conf.ssl_key_path = etcd_conf.tls.key
+end
end
local err
diff --git a/apisix/core/etcd.lua b/apisix/core/etcd.lua
index 6a30728..6ce2742 100644
--- a/apisix/core/etcd.lua
+++ b/apisix/core/etcd.lua
@@ -24,6 +24,7 @@ local tonumber = tonumber
local _M = {}
+-- this function create the etcd client instance used in the Admin API
local function new()
local local_conf, err = fetch_local_conf()
if not local_conf then
@@ -40,8 +41,16 @@ local function new()
etcd_conf.ssl_verify = true
-- default to verify etcd cluster certificate
-if etcd_conf.tls and etcd_conf.tls.verify == false then
-etcd_conf.ssl_verify = false
+etcd_conf.ssl_verify = true
+if etcd_conf.tls then
+if etcd_conf.tls.verify == false then
+etcd_conf.ssl_verify = false
+end
+
+if etcd_conf.tls.cert then
+etcd_conf.ssl_cert_path = etcd_conf.tls.cert
+etcd_conf.ssl_key_path = etcd_conf.tls.key
+end
end
local etcd_cli
diff --git a/apisix/patch.lua b/apisix/patch.lua
index e310bca..850c6b1 100644
--- a/apisix/patch.lua
+++ b/apisix/patch.lua
@@ -14,6 +14,7 @@
-- See the License for the specific language governing permissions and
-- limitations under the License.
--
+local require = require
local socket = require("socket")
local unix_socket = require("socket.unix")
local ssl = require("ssl")
@@ -30,9 +31,19 @@ local setmetatable = setmetatable
local type = type
+local config_local
local _M = {}
+local function get_local_conf()
+if not config_local then
+config_local = require("apisix.core.config_local")
+end
+
+return config_local.local_conf()
+end
+
+
local function flatten(args)
local buf = new_tab(#args, 0)
for i, v in ipairs(args) do
@@ -119,7 +130,12 @@ local luasocket_wrapper = {
return self.sock:settimeout(time)
end,
-sslhandshake = function (self, reused_session, server_name, verify,
send_status_req)
+tlshandshake = function (self, options)
+local reused_session = options.reused_session
+local server_name = options.server_name
+local verify = options.verify
+local send_status_req = options.ocsp_status_req
+
if reused_session then
log(WARN, "reused_session is not supported yet")
end
@@ -132,6 +148,8 @@ local luasocket_wrapper = {
mode = "client",
protocol = "any",
verify = verify and "peer" or "none",
+certificate = options.client_cert_path,
+key = options.client_priv_key_path,
options = {
"all",
"no_sslv2",
@@ -140,6 +158,16 @@ local luasocket_wrapper = {
}
}
+local local_conf, err = get_local_conf()
+if not local_conf then
+return nil, err
+end
+
+local apisix_ssl = local_conf.apisix.ssl
+if apisix_ssl and apisix_ssl.ssl_trusted_certificate then
+params.cafile = apisix_ssl.ssl_trusted_certificate
+end
+
local sec_sock, err = ssl.wrap(self.sock, params)
if not sec_sock then
return false, err
@@ -157,6 +185,15 @@ local luasocket_wrapper = {
self.sock = sec_sock
return true
+end,
+
+sslhandshake = function (self, reused_session, server_name, verify,
send_status_req)
+return self:tlshandshake({
+
[GitHub] [apisix-dashboard] iamayushdas opened a new pull request #1671: feat: improved plugin #1631
iamayushdas opened a new pull request #1671: URL: https://github.com/apache/apisix-dashboard/pull/1671 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** ## Plugin TODO * [ ] Search area, using Table's own, using fuzzy search. * [x] page title not internationalized: configure global plugins/Configure Global Plugin. * [ ] Add icon for Plugin Marketplace plugins. * [x] list page top title, add description: list of enabled plugins. * [x] list page, edit button in action area modified to: `配置/Configure`. ## Plugin Editor * [ ] Some Auth plugins do not need to be configured, in the Data Editor, to disable the input of content. * [x] The button is not internationalized. * [ ] Document button fits too close to JSON button. * [ ] JSONSchema checks for error messages, which can be divided into: error message + view details. * [ ] CodeMirror code error highlighting. ## Meta Raw data editor (Route List page) * [ ] Button not internationalized. * [ ] layout needs to be adjusted, with additional scrolling axes. Extras: Dashboard title also internationalised **Related issues** fix/resolve #1631 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [ ] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] juzhiyuan commented on pull request #47: docs: create docs folder and move README.md
juzhiyuan commented on pull request #47: URL: https://github.com/apache/apisix-helm-chart/pull/47#issuecomment-806926764 Hi, yes, you could follow this step: 1. **Move** all `.md` files under the `chart` folder to `/en/latest/xxx`; 2. No need to update README, just keep it under the root folder, for our website doesn't show README. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #230: docs: tell users where they are
iamayushdas commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-806842327 @stu01509 can you help me in this please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] stu01509 commented on pull request #26: chore: fix the template of deployment.yaml and add hints for affinity setting in values.yaml
stu01509 commented on pull request #26: URL: https://github.com/apache/apisix-helm-chart/pull/26#issuecomment-806818241 Hi all Is this solve? If not, I would like to follow the @TkClark this PR to sent the pull request. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] stu01509 commented on pull request #47: docs: create docs folder and move README.md
stu01509 commented on pull request #47: URL: https://github.com/apache/apisix-helm-chart/pull/47#issuecomment-806810370 Hi @juzhiyuan I created the PR, please take a look is correct? and Should I copy all of `xxx.md` files under the `/charts`? to `/docs/en/latest` ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] stu01509 opened a new pull request #47: docs: create docs folder and move README.md
stu01509 opened a new pull request #47: URL: https://github.com/apache/apisix-helm-chart/pull/47 According to this https://github.com/apache/apisix-website/issues/216, so I created the folder `/docs/en/latest` to save the current `README.md` file. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj commented on a change in pull request #311: fix: workqueue need to retry when failed
gxthrj commented on a change in pull request #311:
URL:
https://github.com/apache/apisix-ingress-controller/pull/311#discussion_r601510097
##
File path: pkg/ingress/controller/apisix_route.go
##
@@ -188,15 +188,11 @@ func (c *apisixRouteController) handleSyncErr(obj
interface{}, err error) {
c.workqueue.Forget(obj)
return
}
- if c.workqueue.NumRequeues(obj) < _maxRetries {
Review comment:
I suggest to cancel the maximum number of times limit first, and add it
when our admission and crd status are improved. Now we need real-time error
reporting to quickly solve the problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] stu01509 commented on issue #230: docs: tell users where they are
stu01509 commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-806783268 Hi @juzhiyuan If @iamayushdas not able to solve it, I would like to try it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on issue #230: docs: tell users where they are
iamayushdas edited a comment on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-806768550 Can you give me last two hours to solve this? If i won't be able to do i will tell you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #230: docs: tell users where they are
iamayushdas commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-806768550 Can you give me last two hours to solve this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #230: docs: tell users where they are
juzhiyuan commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-806764944 ok, anyone would like to take this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #230: docs: tell users where they are
iamayushdas commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-806739982 i am not working on this right now. i am working on plugin from dashboard -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #230: docs: tell users where they are
juzhiyuan commented on issue #230: URL: https://github.com/apache/apisix-website/issues/230#issuecomment-806736332 Hello~ any update about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #216: add more projects to /docs
juzhiyuan commented on issue #216: URL: https://github.com/apache/apisix-website/issues/216#issuecomment-806734994 yep! you are right! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] stu01509 commented on issue #216: add more projects to /docs
stu01509 commented on issue #216: URL: https://github.com/apache/apisix-website/issues/216#issuecomment-806718110 Hi @juzhiyuan Should I use `sync-docs.js` to sync the apisix-helm-chart and apisix-docker project documents? If yes, I think we need to move those projects's `xxx.md` files to `/docs` folder right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] riskgod commented on issue #46: [request help]: 404 not found
riskgod commented on issue #46: URL: https://github.com/apache/apisix-helm-chart/issues/46#issuecomment-806709046 https://user-images.githubusercontent.com/3436287/112477428-f7bab880-8dad-11eb-88ff-e7aafe534f56.png;> This still not work -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] StretchV closed issue #3908: request help: When I execute a test case, I report an error:you may need to install the Test::Base module
StretchV closed issue #3908: URL: https://github.com/apache/apisix/issues/3908 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] han6565 opened a new pull request #3910: fix the problem of multiple different redis-cluster data sources, str…
han6565 opened a new pull request #3910: URL: https://github.com/apache/apisix/pull/3910 …ess test prompting ' ttl: ERR invalid passwor' ### What this PR does / why we need it: during the stress test, I found that if the limit-count plugin configures multiple different redis-cluster data sources, the following error will appear failed to get redis `plugin-limit-countxx.xx.xx.xxroute122` ttl: ERR invalid password so I Fixed it ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] riskgod commented on issue #46: [request help]: 404 not found
riskgod commented on issue #46: URL: https://github.com/apache/apisix-helm-chart/issues/46#issuecomment-806655546 https://user-images.githubusercontent.com/3436287/112473399-49ad0f80-8da9-11eb-85b8-0e5f369e5ebf.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on a change in pull request #1633: feat: add the service page upstream select option
stu01509 commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r601430927
##
File path: web/src/components/Upstream/UpstreamForm.tsx
##
@@ -667,6 +667,9 @@ const UpstreamForm: React.FC = forwardRef(
name: formatMessage({ id:
'page.upstream.step.select.upstream.select.option' }),
id: '',
},
+{
Review comment:
Hi @liuxiran
I'm not sure your mean, and I didn't found the `None` option in the current
codebase,
could you guide me how to approach it?
Thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] StretchV commented on issue #3908: request help: When I execute a test case, I report an error:you may need to install the Test::Base module
StretchV commented on issue #3908: URL: https://github.com/apache/apisix/issues/3908#issuecomment-806628195  我执行了一下 ，然后提示“you may need to install the t::APISIX module” ，但是./t/目录下是有APISIX.pm文件的额，这是怎么回事呢 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] riskgod commented on issue #46: [request help]: 404 not found
riskgod commented on issue #46: URL: https://github.com/apache/apisix-helm-chart/issues/46#issuecomment-806625034 Is this problem? https://user-images.githubusercontent.com/3436287/11247-74e22f80-8da6-11eb-8543-5190a70a3088.png;> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] riskgod closed pull request #45: add allow_admin rest support
riskgod closed pull request #45: URL: https://github.com/apache/apisix-helm-chart/pull/45 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
