[GitHub] [apisix-helm-chart] KishaniKandasamy commented on issue #56: Duplicate titles appear in the website
KishaniKandasamy commented on issue #56: URL: https://github.com/apache/apisix-helm-chart/issues/56#issuecomment-818459343 > Hi, does this title removed from original markdown file content? #57 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1733: feat: added cors plugin form
netlify[bot] edited a comment on pull request #1733: URL: https://github.com/apache/apisix-dashboard/pull/1733#issuecomment-817283838 Deploy preview for *apisix-dashboard* processing. Building with commit f16001d32a5266d8e0112ccace094add4bed5d9d https://app.netlify.com/sites/apisix-dashboard/deploys/607531e67b68ce0007d9564f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] juzhiyuan commented on issue #56: Duplicate titles appear in the website
juzhiyuan commented on issue #56: URL: https://github.com/apache/apisix-helm-chart/issues/56#issuecomment-818457758 Hi, does this title removed from original markdown file content? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on pull request #4029: ci: more retry on fetching lua rocks
Yiyiyimu commented on pull request #4029: URL: https://github.com/apache/apisix/pull/4029#issuecomment-818456531 Add retry for all places, re-run for three times and all passed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] KishaniKandasamy commented on issue #56: Duplicate titles appear in the website
KishaniKandasamy commented on issue #56: URL: https://github.com/apache/apisix-helm-chart/issues/56#issuecomment-818455660 Hi , even the commit was merged it still shows the same(like Duplicate titles ) as before樂 @juzhiyuan @tokers @membphis  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] stu01509 commented on pull request #1633: feat: add the service page upstream select option
stu01509 commented on pull request #1633: URL: https://github.com/apache/apisix-dashboard/pull/1633#issuecomment-818450332 Ok, I will solve it later. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4034: feat: support client certificate verification
Firstsawyou commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612141003 ## File path: docs/en/latest/admin-api.md ## @@ -784,6 +784,8 @@ Return response from etcd currently. | key | True | Private key | https private key | | | certs | False| An array of certificate | when you need to configure multiple certificate for the same domain, you can pass extra https certificates (excluding the one given as cert) in this field | | | keys| False| An array of private key | https private keys. The keys should be paired with certs above | | +| client.ca | False | Certificate| set the CA certificate which will use to verify client. This feature requires OpenResty 1.19+. | | +| client.depth | False | Certificate| set the verification depth in the client certificates chain, default to 1. This feature requires OpenResty 1.19+. | | Review comment: Got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3260: request help: how support cas?
spacewander commented on issue #3260: URL: https://github.com/apache/apisix/issues/3260#issuecomment-818442795 The CAS seems to use standard protocols like JWT and OpenID-Connect Maybe we can integrate with it via plugins: https://github.com/apache/apisix/blob/master/doc/plugins/jwt-auth.md https://github.com/apache/apisix/blob/master/doc/plugins/openid-connect.md -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4034: feat: support client certificate verification
spacewander commented on a change in pull request #4034:
URL: https://github.com/apache/apisix/pull/4034#discussion_r612134869
##
File path: t/node/client-mtls.t
##
@@ -0,0 +1,310 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX;
+
+my $nginx_binary = $ENV{'TEST_NGINX_BINARY'} || 'nginx';
+my $version = eval { `$nginx_binary -V 2>&1` };
+
+if ($version !~ m/\/apisix-nginx-module/) {
+plan(skip_all => "apisix-nginx-module not installed");
+} else {
+plan('no_plan');
+}
+
+repeat_each(1);
+log_level('info');
+no_root_location();
+no_shuffle();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+$block->set_value("no_error_log", "[error]");
+}
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: bad client certificate
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin")
+local json = require("toolkit.json")
+local ssl_cert = t.read_file("t/certs/mtls_client.crt")
+local ssl_key = t.read_file("t/certs/mtls_client.key")
+local data = {
+cert = ssl_cert,
+key = ssl_key,
+sni = "test.com",
+client = {
+ca = ("test.com"):rep(128),
+}
+}
+local code, body = t.test('/apisix/admin/ssl/1',
+ngx.HTTP_PUT,
+json.encode(data)
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.print(body)
+}
+}
+--- request
+GET /t
+--- error_code: 400
+--- response_body
+{"error_msg":"failed to validate client_cert: failed to parse cert:
PEM_read_bio_X509_AUX() failed"}
+
+
+
+=== TEST 2: missing client certificate
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin")
+local json = require("toolkit.json")
+local ssl_cert = t.read_file("t/certs/mtls_client.crt")
+local ssl_key = t.read_file("t/certs/mtls_client.key")
+local data = {
+cert = ssl_cert,
+key = ssl_key,
+sni = "test.com",
+client = {
+}
+}
+local code, body = t.test('/apisix/admin/ssl/1',
+ngx.HTTP_PUT,
+json.encode(data)
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.print(body)
+}
+}
+--- request
+GET /t
+--- error_code: 400
+--- response_body
+{"error_msg":"invalid configuration: property \"client\" validation failed:
property \"ca\" is required"}
+
+
+
+=== TEST 3: set verification
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin")
+local json = require("toolkit.json")
+local ssl_ca_cert = t.read_file("t/certs/mtls_ca.crt")
+local ssl_cert = t.read_file("t/certs/mtls_client.crt")
+local ssl_key = t.read_file("t/certs/mtls_client.key")
+local data = {
+upstream = {
+scheme = "https",
+type = "roundrobin",
+nodes = {
+["127.0.0.1:1994"] = 1,
+},
+tls = {
+client_cert = ssl_cert,
+client_key = ssl_key,
+}
+},
+plugins = {
+["proxy-rewrite"] = {
+uri = "/hello"
+}
+},
+uri = "/mtls"
+}
+local code, body = t.test('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+json.encode(data)
+)
+
+if code >= 300 then
+ngx.status = code
+ngx.say(body)
+return
+end
+
+local data = {
+upstream = {
+type = "roundrobin",
+
[GitHub] [apisix] spacewander commented on a change in pull request #4034: feat: support client certificate verification
spacewander commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612134431 ## File path: docs/en/latest/admin-api.md ## @@ -784,6 +784,8 @@ Return response from etcd currently. | key | True | Private key | https private key | | | certs | False| An array of certificate | when you need to configure multiple certificate for the same domain, you can pass extra https certificates (excluding the one given as cert) in this field | | | keys| False| An array of private key | https private keys. The keys should be paired with certs above | | +| client.ca | False | Certificate| set the CA certificate which will use to verify client. This feature requires OpenResty 1.19+. | | +| client.depth | False | Certificate| set the verification depth in the client certificates chain, default to 1. This feature requires OpenResty 1.19+. | | Review comment: None of the description in this table start with uppercase letter. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers edited a comment on issue #356: request help: KubeSphere setup
tokers edited a comment on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818440741 I found these routes were created by apisix-dashboard, just do not mix the use of apisix-ingress-controller and manual configurations from apisix-dashboard. Also, the route you pasted doesn't contain the one in the YAML configuration: ```yaml # httpbin-route.yaml apiVersion: apisix.apache.org/v2alpha1 kind: ApisixRoute metadata: name: httpserver-route spec: http: - name: rule1 match: hosts: - local.httpbin.org paths: - /* backend: serviceName: httpbin-85d57ddd75-wtmwh servicePort: 80 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #356: request help: KubeSphere setup
tokers commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818440741 I found these routes were created by apisix-dashboard, just do not mix the use of apisix-ingress-controller and manual dashboard confiugration. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #356: request help: KubeSphere setup
tokers commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818440525 It seems that there are some other routes in your APISIX cluster? How are they created? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers commented on pull request #60: feat: add namespace support for apisix-dashboard when using helm
tokers commented on pull request #60: URL: https://github.com/apache/apisix-helm-chart/pull/60#issuecomment-818437903 @totemofwolf Please also update the chart version in `Chart.yaml`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4034: feat: support client certificate verification
tokers commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612131312 ## File path: apisix/admin/ssl.lua ## @@ -70,6 +70,17 @@ local function check_conf(id, conf, need_id) end end +if conf.client then +if not apisix_ssl.support_client_verification() then Review comment: Got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on a change in pull request #4034: feat: support client certificate verification
tokers commented on a change in pull request #4034:
URL: https://github.com/apache/apisix/pull/4034#discussion_r612131210
##
File path: apisix/schema_def.lua
##
@@ -642,6 +642,18 @@ _M.ssl = {
type = "array",
items = private_key_schema,
},
+client = {
+type = "object",
+properties = {
+ca = certificate_scheme,
Review comment:
OK, just an advice and won't block this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers opened a new pull request #61: doc: update readme
tokers opened a new pull request #61: URL: https://github.com/apache/apisix-helm-chart/pull/61 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers merged pull request #59: feat: add new configs for ingress
tokers merged pull request #59: URL: https://github.com/apache/apisix-helm-chart/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: feat: add new configs for ingress (#59)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git
The following commit(s) were added to refs/heads/master by this push:
new 6a27910 feat: add new configs for ingress (#59)
6a27910 is described below
commit 6a27910dc51bbf21dcd5d2073eb8257f092a768d
Author: Alex Zhang
AuthorDate: Tue Apr 13 12:55:27 2021 +0800
feat: add new configs for ingress (#59)
---
.../templates/configmap.yaml | 3 ++
charts/apisix-ingress-controller/values.yaml | 37 ++
2 files changed, 40 insertions(+)
diff --git a/charts/apisix-ingress-controller/templates/configmap.yaml
b/charts/apisix-ingress-controller/templates/configmap.yaml
index f80988d..86fd021 100644
--- a/charts/apisix-ingress-controller/templates/configmap.yaml
+++ b/charts/apisix-ingress-controller/templates/configmap.yaml
@@ -31,6 +31,9 @@ data:
- {{ . | quote }}
{{- end }}
{{- end }}
+ ingress_class: {{ .Values.config.kubernetes.ingressClass | quote }}
+ ingress_version: {{ .Values.config.kubernetes.ingressVersion | quote }}
+ apisix_route_version: {{ .Values.config.kubernetes.apisixRouteVersion |
quote }}
apisix:
base_url: {{ .Values.config.apisix.baseURL | quote }}
admin_key: {{ .Values.config.apisix.adminKey | quote }}
diff --git a/charts/apisix-ingress-controller/values.yaml
b/charts/apisix-ingress-controller/values.yaml
index c6aa429..e9727bf 100644
--- a/charts/apisix-ingress-controller/values.yaml
+++ b/charts/apisix-ingress-controller/values.yaml
@@ -47,14 +47,51 @@ service:
port: 80
config:
+ # the error log level, default is info, optional values are:
+ # debug
+ # info
+ # warn
+ # error
+ # panic
+ # fatal
logLevel: "info"
+ # the output file path of error log, default is stderr, when
+ # the file path is "stderr" or "stdout", logs are marshalled
+ # plainly, which is more readable for human; otherwise logs
+ # are marshalled in JSON format, which can be parsed by
+ # programs easily.
logOutput: "stderr"
+ # the HTTP Server listen address, default is ":8080"
httpListen: ":8080"
+ # enable profiling via web interfaces host:port/debug/pprof, default is true.
enableProfiling: true
+ # Kubernetes related configurations.
kubernetes:
+# the Kubernetes configuration file path, default is "", so the in-cluster
+# configuration will be used.
kubeconfig: ""
+# how long should apisix-ingress-controller re-synchronizes with
Kubernetes,
+# default is 6h,
resyncInterval: "60s"
+# namespace list that controller will watch for resources,
+# by default all namespaces (represented by "*") are watched.
appNamespaces: ["*"]
+# the election id for the controller leader campaign,
+# only the leader will watch and delivery resource changes,
+# other instances (as candidates) stand by.
+electionId: "ingress-apisix-leader"
+# The class of an Ingress object is set using the field IngressClassName in
+# Kubernetes clusters version v1.18.0 or higher or the annotation
+# "kubernetes.io/ingress.class" (deprecated).
+ingressClass: "apisix"
+# the supported ingress api group version, can be "networking/v1beta1",
+# "networking/v1" (for Kubernetes version v1.19.0 or higher), and
+# "extensions/v1beta1", default is "networking/v1".
+ingressVersion: "networking/v1"
+# the supported apisixroute api group version, can be
"apisix.apache.org/v1"
+# or "apisix.apache.org/v2alpha1",
+apisixRouteVersion: "apisix.apache.org/v2alpha1"
+ # APISIX related configurations.
apisix:
baseURL: "http://apisix-admin:9180/apisix/admin;
adminKey: "edd1c9f034335f136f87ad84b625c8f1"
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1730: feat: add api-breaker plugin form
juzhiyuan commented on a change in pull request #1730:
URL: https://github.com/apache/apisix-dashboard/pull/1730#discussion_r612123162
##
File path: web/src/components/Plugin/locales/zh-CN.ts
##
@@ -29,6 +29,12 @@ export default {
'component.pluginForm.api-breaker.unhealthy.failures.tooltip':
'触发不健康状态的连续错误请求次数。',
'component.pluginForm.api-breaker.healthy.http_statuses.tooltip':
'健康时候的状态码。',
'component.pluginForm.api-breaker.healthy.successes.tooltip':
'触发健康状态的连续正常请求次数。',
+ // limit-conn
+ 'component.pluginForm.limit-conn.conn.tooltip': '允许的最大并发请求数。超过 conn 的限制、但是低于
conn + burst 的请求，将被延迟处理。',
+ 'component.pluginForm.limit-conn.burst.tooltip': '允许被延迟处理的并发请求数。',
+ 'component.pluginForm.limit-conn.default_conn_delay.tooltip':
'默认的典型连接（或请求）的处理延迟时间。',
Review comment:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1730: feat: add api-breaker plugin form
nic-chen commented on a change in pull request #1730:
URL: https://github.com/apache/apisix-dashboard/pull/1730#discussion_r612122819
##
File path: web/src/components/Plugin/locales/zh-CN.ts
##
@@ -29,6 +29,12 @@ export default {
'component.pluginForm.api-breaker.unhealthy.failures.tooltip':
'触发不健康状态的连续错误请求次数。',
'component.pluginForm.api-breaker.healthy.http_statuses.tooltip':
'健康时候的状态码。',
'component.pluginForm.api-breaker.healthy.successes.tooltip':
'触发健康状态的连续正常请求次数。',
+ // limit-conn
+ 'component.pluginForm.limit-conn.conn.tooltip': '允许的最大并发请求数。超过 conn 的限制、但是低于
conn + burst 的请求，将被延迟处理。',
+ 'component.pluginForm.limit-conn.burst.tooltip': '允许被延迟处理的并发请求数。',
+ 'component.pluginForm.limit-conn.default_conn_delay.tooltip':
'默认的典型连接（或请求）的处理延迟时间。',
Review comment:
I have never seen such a statement either
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1761: fix: online debug test case
codecov-io commented on pull request #1761: URL: https://github.com/apache/apisix-dashboard/pull/1761#issuecomment-818427037 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1761?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1761](https://codecov.io/gh/apache/apisix-dashboard/pull/1761?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (c5a746b) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1fa467a3ffc627e37cc7057b6c1887eb4eba2c31?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1fa467a) will **decrease** coverage by `19.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1761?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1761 +/- ## === - Coverage 71.35% 52.25% -19.10% === Files 47 38-9 Lines3128 2660 -468 === - Hits 2232 1390 -842 - Misses656 1082 +426 + Partials 240 188 -52 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.25% <ø> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1761?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1761/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1761/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1761/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1761/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1761/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1761/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1761/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] nic-chen commented on issue #1706: security: support HTTPS for dashboard
nic-chen commented on issue #1706: URL: https://github.com/apache/apisix-dashboard/issues/1706#issuecomment-818426644 sure. here is the discussion thread: https://lists.apache.org/thread.html/r082c75e50b3c2445a4e15c012a267ea1f4844f2dac5ab02fa6508a41%40%3Cdev.apisix.apache.org%3E -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on a change in pull request #4034: feat: support client certificate verification
Firstsawyou commented on a change in pull request #4034:
URL: https://github.com/apache/apisix/pull/4034#discussion_r612110910
##
File path: docs/en/latest/admin-api.md
##
@@ -784,6 +784,8 @@ Return response from etcd currently.
| key | True | Private key | https private key
|
|
| certs | False| An array of certificate | when you need to
configure multiple certificate for the same domain, you can pass extra https
certificates (excluding the one given as cert) in this field |
|
| keys| False| An array of private key | https private keys. The
keys should be paired with certs above
|
|
+| client.ca | False | Certificate| set the CA certificate which will use to
verify client. This feature requires OpenResty 1.19+.
|
|
+| client.depth | False | Certificate| set the verification depth in the client
certificates chain, default to 1. This feature requires OpenResty 1.19+.
|
|
Review comment:
The first letter should be capitalized. set --> Set
```
set the CA certificate which will use to verify client.
```
##
File path: t/node/client-mtls.t
##
@@ -0,0 +1,310 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX;
+
+my $nginx_binary = $ENV{'TEST_NGINX_BINARY'} || 'nginx';
+my $version = eval { `$nginx_binary -V 2>&1` };
+
+if ($version !~ m/\/apisix-nginx-module/) {
+plan(skip_all => "apisix-nginx-module not installed");
+} else {
+plan('no_plan');
+}
+
+repeat_each(1);
+log_level('info');
+no_root_location();
+no_shuffle();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+$block->set_value("no_error_log", "[error]");
+}
+});
+
+run_tests();
+
+__DATA__
+
+=== TEST 1: bad client certificate
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin")
+local json = require("toolkit.json")
+local ssl_cert = t.read_file("t/certs/mtls_client.crt")
+local ssl_key = t.read_file("t/certs/mtls_client.key")
+local data = {
+cert = ssl_cert,
+key = ssl_key,
+sni = "test.com",
+client = {
+ca = ("test.com"):rep(128),
+}
+}
+local code, body = t.test('/apisix/admin/ssl/1',
+ngx.HTTP_PUT,
+json.encode(data)
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.print(body)
+}
+}
+--- request
+GET /t
+--- error_code: 400
+--- response_body
+{"error_msg":"failed to validate client_cert: failed to parse cert:
PEM_read_bio_X509_AUX() failed"}
+
+
+
+=== TEST 2: missing client certificate
+--- config
+location /t {
+content_by_lua_block {
+local t = require("lib.test_admin")
+local json = require("toolkit.json")
+local ssl_cert = t.read_file("t/certs/mtls_client.crt")
+local ssl_key = t.read_file("t/certs/mtls_client.key")
+local data = {
+cert = ssl_cert,
+key = ssl_key,
+sni = "test.com",
+client = {
+}
+}
+local code, body = t.test('/apisix/admin/ssl/1',
+ngx.HTTP_PUT,
+json.encode(data)
+)
+
+if code >= 300 then
+ngx.status = code
+end
+ngx.print(body)
+}
+}
+--- request
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 Deploy preview for *apisix-dashboard* ready! Built with commit c8cdac674ba05e5108abd6ff499b280d5092d6fd https://deploy-preview-1732--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bfcx opened a new issue #4037: [discuss]: keep backward compatibility of apisix admin api or manager api
bfcx opened a new issue #4037:
URL: https://github.com/apache/apisix/issues/4037
When upgrading APISIX form v1.5 to v2.4, I find that the response body of
admin api in APISIX2.4 are not keep compatibility with that in v1.5.
In APISIX 1.5, config restored by etcd v2, response body returned by admin
api both contains the field:
"modifiedIndex("mod_revision" in etcd v3)" and "prevNode("prev_kv" in etcd
v3)".
BUT, in APISIX 2.4, response body of admin api and manager api are not
contains these fields.
We've developed series of apis base on APISIX1.5 admin api which can perform
batch operations of CURDs for apisix config, so, in our apis we used field
"modifiedIndex" and "prevNode" for atomicity guarantee and failed rollback.
**DISCUSS**:
Wish to add these fields in response body of admin api and manager api in
APISIX2.4, to keep compatibility with that in v1.5.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 Deploy preview for *apisix-dashboard* processing. Building with commit c8cdac674ba05e5108abd6ff499b280d5092d6fd https://app.netlify.com/sites/apisix-dashboard/deploys/607516b044a16700089b71c4 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 Deploy preview for *apisix-dashboard* ready! Built with commit b722526f5f005ab40b1a025abbf9b86401056743 https://deploy-preview-1732--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 Deploy preview for *apisix-dashboard* processing. Building with commit 9461c24242ca8102a20a6e15c323798b5c55616b https://app.netlify.com/sites/apisix-dashboard/deploys/607512b59d290c0009b38901 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1748: chore: update Consumer
netlify[bot] edited a comment on pull request #1748: URL: https://github.com/apache/apisix-dashboard/pull/1748#issuecomment-817897362 Deploy preview for *apisix-dashboard* ready! Built with commit 180aae7e2c1fcb9266ffa862c1d7df3957db15ef https://deploy-preview-1748--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1730: feat: add api-breaker plugin form
netlify[bot] edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817653772 Deploy preview for *apisix-dashboard* ready! Built with commit 40724664d2b55e5f6a61d8340707e2c99c6e6a45 https://deploy-preview-1730--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1727: feat: add referer-restriction plugin form
codecov-io edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817269980 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1727](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d0d70a6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1fa467a3ffc627e37cc7057b6c1887eb4eba2c31?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1fa467a) will **increase** coverage by `0.03%`. > The diff coverage is `n/a`. > :exclamation: Current head d0d70a6 differs from pull request most recent head 308d4d6. Consider uploading reports for the commit 308d4d6 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1727 +/- ## == + Coverage 71.35% 71.38% +0.03% == Files 47 47 Lines3128 3128 == + Hits 2232 2233 +1 + Misses656 652 -4 - Partials 240 243 +3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.14% <ø> (+0.03%)` | :arrow_up: | | backend-e2e-test-ginkgo | `48.91% <ø> (-0.07%)` | :arrow_down: | | backend-unit-test | `52.29% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1727/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `86.74% <0.00%> (-1.21%)` | :arrow_down: | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1727/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1727/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `58.10% <0.00%> (+4.05%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [1fa467a...308d4d6](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: fix: null value instead of empty slice during JSON marshalling for GET labels (#1741)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 537b4ff fix: null value instead of empty slice during JSON
marshalling for GET labels (#1741)
537b4ff is described below
commit 537b4ffdd5898879cbc611809e503f5e2b943254
Author: Bisakh Mondal
AuthorDate: Tue Apr 13 08:58:55 2021 +0530
fix: null value instead of empty slice during JSON marshalling for GET
labels (#1741)
---
api/internal/core/store/store.go| 5 +
api/internal/handler/label/label.go | 2 +-
api/test/e2e/label_test.go | 10 ++
3 files changed, 16 insertions(+), 1 deletion(-)
diff --git a/api/internal/core/store/store.go b/api/internal/core/store/store.go
index 9f13f62..d529dd5 100644
--- a/api/internal/core/store/store.go
+++ b/api/internal/core/store/store.go
@@ -163,6 +163,11 @@ type ListOutput struct {
TotalSize int `json:"total_size"`
}
+// NewListOutput returns JSON marshalling safe struct pointer for empty slice
+func NewListOutput() *ListOutput {
+ return {Rows: make([]interface{}, 0)}
+}
+
var defLessFunc = func(i, j interface{}) bool {
iBase := i.(entity.BaseInfoGetter).GetBaseInfo()
jBase := j.(entity.BaseInfoGetter).GetBaseInfo()
diff --git a/api/internal/handler/label/label.go
b/api/internal/handler/label/label.go
index 791b034..fc76725 100644
--- a/api/internal/handler/label/label.go
+++ b/api/internal/handler/label/label.go
@@ -197,7 +197,7 @@ func (h *Handler) List(c droplet.Context) (interface{},
error) {
return subsetOf(reqLabels, ls)
}
- var totalRet = new(store.ListOutput)
+ var totalRet = store.NewListOutput()
var existMap = make(map[string]struct{})
for _, item := range items {
ret, err := item.(store.Interface).List(c.Context(),
diff --git a/api/test/e2e/label_test.go b/api/test/e2e/label_test.go
index 3b69577..ab43777 100644
--- a/api/test/e2e/label_test.go
+++ b/api/test/e2e/label_test.go
@@ -373,6 +373,16 @@ func TestLabel(t *testing.T) {
Headers: map[string]string{"Authorization": token},
ExpectStatus: http.StatusOK,
},
+ {
+ Desc: "get route label(check empty response)",
+ Object: ManagerApiExpect(t),
+ Method: http.MethodGet,
+ Headers: map[string]string{"Authorization": token},
+ Path: "/apisix/admin/labels/route",
+ ExpectStatus: http.StatusOK,
+ ExpectBody: "{\"rows\":[],\"total_size\":0}",
+ Sleep:sleepTime,
+ },
}
for _, tc := range tests {
[GitHub] [apisix-dashboard] juzhiyuan closed issue #1737: Bug: the row field is nil when request to get the label list
juzhiyuan closed issue #1737: URL: https://github.com/apache/apisix-dashboard/issues/1737 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #1741: fix: null value instead of empty slice during JSON marshalling for GET labels
juzhiyuan merged pull request #1741: URL: https://github.com/apache/apisix-dashboard/pull/1741 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1610: feat: improve the config plugin button enable disable status
juzhiyuan commented on pull request #1610: URL: https://github.com/apache/apisix-dashboard/pull/1610#issuecomment-818404052 ping @liuxiran @bzp2010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] riskgod commented on issue #4036: request help: hmac sha256 "Invalid signature"
riskgod commented on issue #4036: URL: https://github.com/apache/apisix/issues/4036#issuecomment-818403800 > > -H "Tue Apr 13 2021 09:56:35 GMT+0800 (China Standard Time)" \ > > In the plug-in test, the format of your GMT time request header seems to be incorrect, it needs to be like this: > > ``` > -H "Date: Tue Apr 13 2021 09:56:35 GMT+0800 (China Standard Time)" \ > ``` Thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] riskgod closed issue #4036: request help: hmac sha256 "Invalid signature"
riskgod closed issue #4036: URL: https://github.com/apache/apisix/issues/4036 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1748: chore: update Consumer
juzhiyuan commented on a change in pull request #1748:
URL: https://github.com/apache/apisix-dashboard/pull/1748#discussion_r612100751
##
File path: web/src/pages/Consumer/locales/zh-CN.ts
##
@@ -20,6 +20,10 @@ export default {
'page.consumer.form.itemExtraMessage.username': '名称需唯一',
'page.consumer.notification.warning.enableAuthenticationPlugin':
'请启用一种身份认证类插件',
'page.consumer.username': '名称',
+ 'page.consumer.username.required': '请输入消费者名称',
'page.consumer.updateTime': '更新时间',
- 'page.consumer.list': '消费者列表'
+ 'page.consumer.list': '消费者列表',
+ 'page.consumer.description': '消费者是路由的消费方，形式包扩开发者、最终用户、API
调用等。创建消费者时，需绑定至少一个认证类插件。',
Review comment:
updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1748: chore: update Consumer
netlify[bot] edited a comment on pull request #1748: URL: https://github.com/apache/apisix-dashboard/pull/1748#issuecomment-817897362 Deploy preview for *apisix-dashboard* processing. Building with commit 180aae7e2c1fcb9266ffa862c1d7df3957db15ef https://app.netlify.com/sites/apisix-dashboard/deploys/60750f659d290c0009b36358 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1730: feat: add api-breaker plugin form
netlify[bot] edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817653772 Deploy preview for *apisix-dashboard* processing. Building with commit 40724664d2b55e5f6a61d8340707e2c99c6e6a45 https://app.netlify.com/sites/apisix-dashboard/deploys/60750ecfd2883b00072b30db -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on a change in pull request #1748: chore: update Consumer
starsz commented on a change in pull request #1748:
URL: https://github.com/apache/apisix-dashboard/pull/1748#discussion_r612099802
##
File path: web/src/pages/Consumer/locales/zh-CN.ts
##
@@ -20,6 +20,10 @@ export default {
'page.consumer.form.itemExtraMessage.username': '名称需唯一',
'page.consumer.notification.warning.enableAuthenticationPlugin':
'请启用一种身份认证类插件',
'page.consumer.username': '名称',
+ 'page.consumer.username.required': '请输入消费者名称',
'page.consumer.updateTime': '更新时间',
- 'page.consumer.list': '消费者列表'
+ 'page.consumer.list': '消费者列表',
+ 'page.consumer.description': '消费者是路由的消费方，形式包扩开发者、最终用户、API
调用等。创建消费者时，需绑定至少一个认证类插件。',
Review comment:
typo？
"包扩" => "包括"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1727: feat: add referer-restriction plugin form
codecov-io edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817269980 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1727](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (d0d70a6) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1fa467a3ffc627e37cc7057b6c1887eb4eba2c31?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1fa467a) will **decrease** coverage by `19.06%`. > The diff coverage is `n/a`. > :exclamation: Current head d0d70a6 differs from pull request most recent head 308d4d6. Consider uploading reports for the commit 308d4d6 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1727 +/- ## === - Coverage 71.35% 52.29% -19.07% === Files 47 38-9 Lines3128 2660 -468 === - Hits 2232 1391 -841 - Misses656 1081 +425 + Partials 240 188 -52 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.29% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1727?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1727/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1727/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1727/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1727/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1727/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1727/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1727/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #363: test: add e2e test cases for request-validation plugin
codecov-io commented on pull request #363: URL: https://github.com/apache/apisix-ingress-controller/pull/363#issuecomment-818401478 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/363?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#363](https://codecov.io/gh/apache/apisix-ingress-controller/pull/363?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (e36aa71) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/ff3ca2e99dae47fb28c1031c586fb4a07ff3b524?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ff3ca2e) will **decrease** coverage by `0.01%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/363?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #363 +/- ## == - Coverage 43.49% 43.47% -0.02% == Files 40 39 -1 Lines3458 3457 -1 == - Hits 1504 1503 -1 Misses 1783 1783 Partials 171 171 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/363?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/363/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/363?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/363?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [ff3ca2e...e36aa71](https://codecov.io/gh/apache/apisix-ingress-controller/pull/363?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: chore: added fields for SSL (#1751)
This is an automated email from the ASF dual-hosted git repository.
starsz pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 62e94af chore: added fields for SSL (#1751)
62e94af is described below
commit 62e94afe9e953568d687f9a1212a2685d4c24327
Author: 琚致远
AuthorDate: Tue Apr 13 11:19:28 2021 +0800
chore: added fields for SSL (#1751)
---
web/src/pages/SSL/List.tsx | 2 +-
web/src/pages/SSL/components/CertificateForm/index.tsx | 4 ++--
web/src/pages/SSL/components/Step1/index.tsx | 5 -
web/src/pages/SSL/locales/en-US.ts | 6 --
web/src/pages/SSL/locales/zh-CN.ts | 5 -
5 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/web/src/pages/SSL/List.tsx b/web/src/pages/SSL/List.tsx
index 56e5737..26452f1 100644
--- a/web/src/pages/SSL/List.tsx
+++ b/web/src/pages/SSL/List.tsx
@@ -108,7 +108,7 @@ const Page: React.FC = () => {
];
return (
-
+
rowKey="id"
columns={columns}
diff --git a/web/src/pages/SSL/components/CertificateForm/index.tsx
b/web/src/pages/SSL/components/CertificateForm/index.tsx
index 89a178d..73dcf6f 100644
--- a/web/src/pages/SSL/components/CertificateForm/index.tsx
+++ b/web/src/pages/SSL/components/CertificateForm/index.tsx
@@ -75,7 +75,7 @@ const CertificateForm: React.FC = ({
mode, form }) => {
},
]}
>
-
+
= ({
mode, form }) => {
},
]}
>
-
+
{renderExpireTime()}
diff --git a/web/src/pages/SSL/components/Step1/index.tsx
b/web/src/pages/SSL/components/Step1/index.tsx
index c66f3f1..5d10103 100644
--- a/web/src/pages/SSL/components/Step1/index.tsx
+++ b/web/src/pages/SSL/components/Step1/index.tsx
@@ -70,11 +70,6 @@ const Step: React.FC = ({ form }) => {
[GitHub] [apisix-dashboard] starsz merged pull request #1751: chore: added fields for SSL
starsz merged pull request #1751: URL: https://github.com/apache/apisix-dashboard/pull/1751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] totemofwolf opened a new pull request #60: feat: add namespace support for apisix-dashboard when using helm
totemofwolf opened a new pull request #60: URL: https://github.com/apache/apisix-helm-chart/pull/60 ``` # debug $ helm install --debug --name apisix-dashboard . --namespace edge --dry-run > /tmp/apisix-dashboard.sh ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] starsz commented on pull request #1758: chore: remove service worker
starsz commented on pull request #1758: URL: https://github.com/apache/apisix-dashboard/pull/1758#issuecomment-818400468 Fix: https://github.com/apache/apisix-dashboard/security/code-scanning/5?query=ref%3Arefs%2Fheads%2Fmaster https://github.com/apache/apisix-dashboard/security/code-scanning/4?query=ref%3Arefs%2Fheads%2Fmaster -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #361: chore: controller tree
tokers merged pull request #361: URL: https://github.com/apache/apisix-ingress-controller/pull/361 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: chore: controller tree (#361)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 2dd7f14 chore: controller tree (#361)
2dd7f14 is described below
commit 2dd7f143343410a610d7dd2fcf1cdd08f0131611
Author: Alex Zhang
AuthorDate: Tue Apr 13 11:16:23 2021 +0800
chore: controller tree (#361)
---
.github/workflows/e2e-test-ci.yml | 2 +-
cmd/ingress/ingress.go | 2 +-
pkg/apisix/ssl.go | 1 +
pkg/ingress/apisix/tls.go | 66 --
pkg/ingress/apisix/tls_test.go | 133 -
pkg/ingress/{controller => }/apisix_route.go| 2 +-
pkg/ingress/apisix_tls.go | 240 ++
pkg/ingress/{controller => }/apisix_upstream.go | 2 +-
pkg/ingress/{controller => }/controller.go | 82
pkg/ingress/controller/apisix_tls.go| 254
pkg/ingress/{controller => }/endpoint.go| 2 +-
pkg/ingress/{controller => }/ingress.go | 2 +-
pkg/ingress/{controller => }/ingress_test.go| 2 +-
pkg/ingress/{controller => }/manifest.go| 2 +-
pkg/ingress/{controller => }/manifest_test.go | 2 +-
pkg/ingress/{controller => }/secret.go | 116 ++-
pkg/ingress/{controller => }/types.go | 2 +-
pkg/kube/translation/apisix_ssl.go | 58 ++
pkg/kube/translation/translator.go | 3 +
pkg/seven/apisix/event.go | 23 ---
pkg/seven/conf/conf.go | 50 -
pkg/seven/conf/conf_test.go | 24 ---
pkg/seven/state/event.go| 21 --
pkg/seven/state/solver.go | 46 -
pkg/seven/utils/diff.go | 59 --
pkg/seven/utils/http.go | 88
pkg/seven/utils/types.go| 20 --
test/e2e/ingress/secret.go | 4 +-
28 files changed, 423 insertions(+), 885 deletions(-)
diff --git a/.github/workflows/e2e-test-ci.yml
b/.github/workflows/e2e-test-ci.yml
index d6f093e..6faafea 100644
--- a/.github/workflows/e2e-test-ci.yml
+++ b/.github/workflows/e2e-test-ci.yml
@@ -28,7 +28,7 @@ jobs:
- name: Run e2e test cases
working-directory: ./
run: |
- make e2e-test E2E_CONCURRENCY=2
+ make e2e-test E2E_CONCURRENCY=1
- name: upload coverage profile
working-directory: ./test/e2e
run: |
diff --git a/cmd/ingress/ingress.go b/cmd/ingress/ingress.go
index c2a4b3a..f90b50f 100644
--- a/cmd/ingress/ingress.go
+++ b/cmd/ingress/ingress.go
@@ -26,7 +26,7 @@ import (
"github.com/spf13/cobra"
"github.com/apache/apisix-ingress-controller/pkg/config"
- "github.com/apache/apisix-ingress-controller/pkg/ingress/controller"
+ controller "github.com/apache/apisix-ingress-controller/pkg/ingress"
"github.com/apache/apisix-ingress-controller/pkg/log"
"github.com/apache/apisix-ingress-controller/pkg/version"
)
diff --git a/pkg/apisix/ssl.go b/pkg/apisix/ssl.go
index 684479a..7069c48 100644
--- a/pkg/apisix/ssl.go
+++ b/pkg/apisix/ssl.go
@@ -144,6 +144,7 @@ func (s *sslClient) Create(ctx context.Context, obj
*v1.Ssl) (*v1.Ssl, error) {
return nil, err
}
data, err := json.Marshal(v1.Ssl{
+ ID: obj.ID,
Snis: obj.Snis,
Cert: obj.Cert,
Key:obj.Key,
diff --git a/pkg/ingress/apisix/tls.go b/pkg/ingress/apisix/tls.go
deleted file mode 100644
index 7ef31fa..000
--- a/pkg/ingress/apisix/tls.go
+++ /dev/null
@@ -1,66 +0,0 @@
-// Licensed to the Apache Software Foundation (ASF) under one or more
-// contributor license agreements. See the NOTICE file distributed with
-// this work for additional information regarding copyright ownership.
-// The ASF licenses this file to You under the Apache License, Version 2.0
-// (the "License"); you may not use this file except in compliance with
-// the License. You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-package apisix
-
-import (
- "context"
-
- v1 "k8s.io/api/core/v1"
- metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
-
- ingressConf "github.com/apache/apisix-ingress-controller/pkg/kube"
- configv1
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #363: test: add e2e test cases for request-validation plugin
tokers opened a new pull request #363: URL: https://github.com/apache/apisix-ingress-controller/pull/363 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Firstsawyou commented on issue #4036: request help: hmac sha256 "Invalid signature"
Firstsawyou commented on issue #4036: URL: https://github.com/apache/apisix/issues/4036#issuecomment-818399987 > -H "Tue Apr 13 2021 09:56:35 GMT+0800 (China Standard Time)" \ In the plug-in test, the format of your GMT time request header seems to be incorrect, it needs to be like this: ``` -H "Date: Tue Apr 13 2021 09:56:35 GMT+0800 (China Standard Time)" \ ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jbampton commented on issue #3587: docs: add Spanish translations
jbampton commented on issue #3587: URL: https://github.com/apache/apisix/issues/3587#issuecomment-818397330 Hello everyone. A very sad day has come and our dear friend Jorge @summerhill5 has died of COVID-19 in Venezuela. Jorge died in hospital and was sick for over 3 weeks. The Crisis in Venezuela during the Bolivarian Revolution is an ongoing socioeconomic and political crisis that began in Venezuela on 2 June 2010 during the presidency of Hugo Chávez and has continued since. I believe the hospital facilities in Venezuela are bad too. Jorge translated the README and FAQ to Spanish and he was a really good worker and will be badly missed. I have some other friends that translate to Spanish but I am not sure if they will help us or whether they can do complex technical translations but I will ask them. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1730: feat: add api-breaker plugin form
juzhiyuan commented on a change in pull request #1730:
URL: https://github.com/apache/apisix-dashboard/pull/1730#discussion_r612095039
##
File path: web/src/components/Plugin/locales/zh-CN.ts
##
@@ -29,6 +29,12 @@ export default {
'component.pluginForm.api-breaker.unhealthy.failures.tooltip':
'触发不健康状态的连续错误请求次数。',
'component.pluginForm.api-breaker.healthy.http_statuses.tooltip':
'健康时候的状态码。',
'component.pluginForm.api-breaker.healthy.successes.tooltip':
'触发健康状态的连续正常请求次数。',
+ // limit-conn
+ 'component.pluginForm.limit-conn.conn.tooltip': '允许的最大并发请求数。超过 conn 的限制、但是低于
conn + burst 的请求，将被延迟处理。',
+ 'component.pluginForm.limit-conn.burst.tooltip': '允许被延迟处理的并发请求数。',
+ 'component.pluginForm.limit-conn.default_conn_delay.tooltip':
'默认的典型连接（或请求）的处理延迟时间。',
Review comment:
`典型`?
for those fields, need @membphis @starsz @nic-chen to take a look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on issue #156: https for website
juzhiyuan commented on issue #156: URL: https://github.com/apache/apisix-website/issues/156#issuecomment-818396905 Apache Infra uses asf-site branch as HTML branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] tokers opened a new pull request #59: feat: add new configs for ingress
tokers opened a new pull request #59: URL: https://github.com/apache/apisix-helm-chart/pull/59 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1762: chore: reduce CI time
netlify[bot] edited a comment on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818367527 Deploy preview for *apisix-dashboard* ready! Built with commit cea8de0381f0645ba2625496e003dafdb84946c2 https://deploy-preview-1762--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1730: feat: add api-breaker plugin form
netlify[bot] edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817653772 Deploy preview for *apisix-dashboard* ready! Built with commit c542e14bf0cec175b2c894d6941ffc354931cbb4 https://deploy-preview-1730--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1761: fix: online debug test case
netlify[bot] edited a comment on pull request #1761: URL: https://github.com/apache/apisix-dashboard/pull/1761#issuecomment-818361132 Deploy preview for *apisix-dashboard* ready! Built with commit c5a746bd6b63e61f61f6142d2f714b7206ff4c54 https://deploy-preview-1761--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup
wjx8382 commented on issue #356:
URL:
https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818391921
> > @tokers Why does `kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 --
curl http://127.0.0.1:9080/headers -H 'Host: local.httpbin.org'` returns
`{"error_msg":"404 Route Not Found"}`
> > ```
> > # httpbin-route.yaml
> > apiVersion: apisix.apache.org/v2alpha1
> > kind: ApisixRoute
> > metadata:
> > name: httpserver-route
> > spec:
> > http:
> > - name: rule1
> > match:
> > hosts:
> > - local.httpbin.org
> > paths:
> > - /*
> > backend:
> > serviceName: httpbin-85d57ddd75-wtmwh
> > servicePort: 80
> > ```
>
> Could you access the apisix admin API by
>
> ```
> kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 -- curl
http://127.0.0.1:9180/apisix/admin/routes
> ```
>
> To see the routes?
`kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 -- curl
http://127.0.0.1:9180/apisix/admin/routes -H 'X-API-Key:
edd1c9f034335f136f87ad84b625c8f1'` returns
```
{"node":{"key":"\/apisix\/routes","nodes":[{"value":{"update_time":1615967207,"uris":["\/hello"],"id":"1","status":1,"create_time":1615797004,"name":"hello","upstream_id":"346344795876098996","plugins":{"fault-injection":{"disable":true,"delay":{"duration":3}},"proxy-rewrite":{"disable":false,"scheme":"https","regex_uri":["^\/samplePrefix\/get(.*)","\/hello$1"]}},"vars":{}},"key":"\/apisix\/routes\/1","modifiedIndex":1902,"createdIndex":39},{"value":{"priority":0,"uri":"\/grpctest","methods":["GET"],"status":1,"create_time":1615878242,"update_time":1615878242,"upstream":{"pass_host":"pass","nodes":{"127.0.0.1:50051":1},"hash_on":"vars","type":"roundrobin"},"plugins":{"grpc-transcode":{"deadline":0,"service":"helloworld.Greeter","proto_id":"1","method":"SayHello"}},"id":"111"},"key":"\/apisix\/routes\/111","modifiedIndex":1350,"createdIndex":1350},{"value":{"update_time":1618212271,"uris":["\/httpbin"],"id":"350111307409654788","methods":["GET","HEAD","POST","PUT","DELETE","OPTIONS
","PATCH"],"status":1,"hosts":["local.httpbin.org"],"create_time":1618212201,"name":"httpbin","upstream_id":"350111087426798596","vars":{}},"key":"\/apisix\/routes\/350111307409654788","modifiedIndex":18185,"createdIndex":18182},{"value":{"update_time":1618210980,"uris":["\/get"],"id":"5","status":1,"create_time":1615789201,"name":"test","upstream_id":"50","plugins":{"http-logger":{"uri":"http:\/\/127.0.0.1:80\/postendpoint?param=1","disable":false},"limit-conn":{"rejected_code":503,"conn":1,"burst":0,"disable":true,"key":"remote_addr","default_conn_delay":0.1},"basic-auth":{"disable":true},"fault-injection":{"disable":true,"abort":{"http_status":403,"body":"Fault
Injection!\n","vars":[[["arg_name","==","jack"]]]}},"proxy-rewrite":{"scheme":"https","disable":false},"authz-keycloak":{"token_endpoint":"http:\/\/127.0.0.1:8090\/auth\/realms\/{client_id}\/protocol\/openid-connect\/token","disable":true,"audience":"Client
ID","permissions":["resource name#scope name"]},"ip-restriction":{
"whitelist":["172.16.110.186","127.0.0.1"],"disable":false},"serverless-pre-function":{"phase":"rewrite","functions":["return
function() ngx.log(ngx.ERR, \"serverless pre function\");
end"],"disable":false},"limit-count":{"rejected_code":503,"key":"remote_addr","count":2,"disable":true,"time_window":60},"batch-requests":{"disable":false},"cors":{"disable":false},"uri-blocker":{"block_rules":["get"],"disable":true},"key-auth":{"disable":true},"serverless-post-function":{"phase":"rewrite","functions":["return
function() ngx.log(ngx.ERR, \"serverless post function\");
end"],"disable":false},"request-id":{"include_in_response":true,"disable":false},"prometheus":{"disable":false},"limit-req":{"rate":1,"key":"remote_addr","burst":2,"disable":true,"rejected_code":503},"request-validation":{"disable":true,"body_schema":{"required":["required_payload"],"type":"object","properties":{"required_payload":{"type":"string"},"boolean_payload":{"type":"boolean","jwt-auth":{"disable":true}},"vars
":{}},"key":"\/apisix\/routes\/5","modifiedIndex":18159,"createdIndex":16}],"dir":true},"action":"get","count":"5"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1762: chore: reduce CI time
netlify[bot] edited a comment on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818367527 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1730: feat: add api-breaker plugin form
netlify[bot] edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817653772 Deploy preview for *apisix-dashboard* processing. Building with commit c542e14bf0cec175b2c894d6941ffc354931cbb4 https://app.netlify.com/sites/apisix-dashboard/deploys/6075052974edee00086841ae -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1727: feat: add referer-restriction plugin form
netlify[bot] edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817649660 Deploy preview for *apisix-dashboard* ready! Built with commit 308d4d67b97deff5c348599cc73ebf00dbca9d3a https://deploy-preview-1727--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1762: chore: reduce CI time
juzhiyuan commented on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818389575 wait for #1761 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] riskgod opened a new issue #4036: request help: hmac sha256 "Invalid signature"
riskgod opened a new issue #4036:
URL: https://github.com/apache/apisix/issues/4036
### Issue description
hey, I am using node to create the X-HMAC-SIGNATURE, but it always return
"Invalid signature"
create one consumer
```
curl http://127.0.0.1:9080/apisix/admin/consumers -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -i -d '
{
"username": "kelly",
"plugins": {
"hmac-auth": {
"access_key": "user-key-kelly",
"secret_key": "my-secret-key—kelly",
"clock_skew": 0,
"signed_headers": ["User-Agent", "x-custom-a"]
}
}
}'
```
enable the plugin global
```
curl http://127.0.0.1:9080/apisix/admin/global_rules/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"plugins": {
"request-id": {
"include_in_response": true
},
"hmac-auth":{},
"limit-req": {
"rate": 1,
"burst": 0,
"rejected_code": 503,
"key": "remote_addr"
},
"tcp-logger": {
"host": "127.0.0.1",
"port": 5000,
"tls": false,
"batch_max_size": 1,
"name": "tcp logger"
}
}
}'
```
set upstream
```
curl http://127.0.0.1:9080/apisix/admin/upstreams/100 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -i -X PUT -d '
{
"type":"roundrobin",
"scheme": "grpc",
"nodes":{
"127.0.0.1:8081": 1
}
}'
```
set router
```
curl http://127.0.0.1:9080/apisix/admin/routes/120 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"methods": ["GET"],
"uri": "/testgrpc",
"plugins": {
"grpc-transcode": {
"proto_id": "1",
"service": "helloworld.Greeter",
"method": "SayHello"
},
"consumer-restriction": {
"whitelist": [
"candy"
]
}
},
"upstream_id": "100"
}'
```
Use node.js to create the signature
```
const crypto = require('crypto');
const signing_string = `
GET
/testgrpc
name=world
user-key-kelly
Tue Apr 13 2021 09:56:35 GMT+0800 (China Standard Time)
User-Agent:curl/7.29.0
x-custom-a:test
`
const test = crypto.createHmac('sha256',
"my-secret-key—kelly").update(signing_string).digest("base64");
console.log(test)
```
Test the plugin
```
curl -i "http://127.0.0.1:9080/testgrpc?name=world; \
-H "X-HMAC-SIGNATURE: hoQVG90Af6OwQs19gVqmsmqfw0QGVrurNIV3/bkFicg=" \
-H "X-HMAC-ALGORITHM: hmac-sha256" \
-H "X-HMAC-ACCESS-KEY: user-key-kelly" \
-H "Tue Apr 13 2021 09:56:35 GMT+0800 (China Standard Time)" \
-H "X-HMAC-SIGNED-HEADERS: User-Agent;x-custom-a" \
-H "x-custom-a: test" \
-H "User-Agent: curl/7.29.0"
```
Result
```
HTTP/1.1 401 Unauthorized
Date: Tue, 13 Apr 2021 02:21:20 GMT
Content-Type: text/plain; charset=utf-8
Transfer-Encoding: chunked
Connection: keep-alive
Server: APISIX/2.5
X-Request-Id: a112df5e-76c3-46bc-a000-fdabc99bb0c8
{"message":"Invalid signature"}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1761: fix: online debug test case
netlify[bot] edited a comment on pull request #1761: URL: https://github.com/apache/apisix-dashboard/pull/1761#issuecomment-818361132 Deploy preview for *apisix-dashboard* processing. Building with commit c5a746bd6b63e61f61f6142d2f714b7206ff4c54 https://app.netlify.com/sites/apisix-dashboard/deploys/6075048813dfe70008a0f088 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1762: chore: reduce CI time
netlify[bot] edited a comment on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818367527 Deploy preview for *apisix-dashboard* processing. Building with commit a858d33361277c83f12571fe6ffbee4f54128a34 https://app.netlify.com/sites/apisix-dashboard/deploys/607503d08c1ab90008372aa1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1727: feat: add referer-restriction plugin form
netlify[bot] edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817649660 Deploy preview for *apisix-dashboard* processing. Building with commit 308d4d67b97deff5c348599cc73ebf00dbca9d3a https://app.netlify.com/sites/apisix-dashboard/deploys/60750348bb2dce0007af9a2f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io commented on pull request #1762: chore: reduce CI time
codecov-io commented on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818385237 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1762?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1762](https://codecov.io/gh/apache/apisix-dashboard/pull/1762?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (56c4d3d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1fa467a3ffc627e37cc7057b6c1887eb4eba2c31?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1fa467a) will **decrease** coverage by `19.09%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1762?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1762 +/- ## === - Coverage 71.35% 52.25% -19.10% === Files 47 38-9 Lines3128 2660 -468 === - Hits 2232 1390 -842 - Misses656 1082 +426 + Partials 240 188 -52 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.25% <ø> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1762?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1762/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1762/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1762/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1762/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1762/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1762/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1762/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup
wjx8382 commented on issue #356:
URL:
https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818384772
> > @tokers Why does `kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 --
curl http://127.0.0.1:9080/headers -H 'Host: local.httpbin.org'` returns
`{"error_msg":"404 Route Not Found"}`
> > ```
> > # httpbin-route.yaml
> > apiVersion: apisix.apache.org/v2alpha1
> > kind: ApisixRoute
> > metadata:
> > name: httpserver-route
> > spec:
> > http:
> > - name: rule1
> > match:
> > hosts:
> > - local.httpbin.org
> > paths:
> > - /*
> > backend:
> > serviceName: httpbin-85d57ddd75-wtmwh
> > servicePort: 80
> > ```
>
> Could you access the apisix admin API by
>
> ```
> kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 -- curl
http://127.0.0.1:9180/apisix/admin/routes
> ```
>
> To see the routes?
It returns
```
401 Authorization Required
401 Authorization Required
openresty
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1661: feat: add scheme field test case
codecov-io edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-805419276 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1661](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (26afa8d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1fa467a3ffc627e37cc7057b6c1887eb4eba2c31?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1fa467a) will **increase** coverage by `0.44%`. > The diff coverage is `n/a`. > :exclamation: Current head 26afa8d differs from pull request most recent head ec569b1. Consider uploading reports for the commit ec569b1 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1661 +/- ## == + Coverage 71.35% 71.80% +0.44% == Files 47 47 Lines3128 3128 == + Hits 2232 2246 +14 + Misses656 639 -17 - Partials 240 243 +3 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `62.65% <ø> (+0.54%)` | :arrow_up: | | backend-e2e-test-ginkgo | `49.16% <ø> (+0.19%)` | :arrow_up: | | backend-unit-test | `52.29% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | `33.33% <0.00%> (ø)` | | | [api/internal/core/store/store.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmUuZ28=) | `87.95% <0.00%> (ø)` | | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `74.76% <0.00%> (+3.73%)` | :arrow_up: | | [api/cmd/managerapi.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2NtZC9tYW5hZ2VyYXBpLmdv) | `59.45% <0.00%> (+5.40%)` | :arrow_up: | | [api/internal/core/storage/etcd.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmFnZS9ldGNkLmdv) | `50.90% <0.00%> (+5.45%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update
[GitHub] [apisix-ingress-controller] tokers commented on issue #356: request help: KubeSphere setup
tokers commented on issue #356:
URL:
https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818383744
> @tokers Why does `kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 -- curl
http://127.0.0.1:9080/headers -H 'Host: local.httpbin.org'` returns
`{"error_msg":"404 Route Not Found"}`
>
> ```
> # httpbin-route.yaml
> apiVersion: apisix.apache.org/v2alpha1
> kind: ApisixRoute
> metadata:
> name: httpserver-route
> spec:
> http:
> - name: rule1
> match:
> hosts:
> - local.httpbin.org
> paths:
> - /*
> backend:
> serviceName: httpbin-85d57ddd75-wtmwh
> servicePort: 80
> ```
Could you access the apisix admin API by
```
kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 -- curl
http://127.0.0.1:9180/apisix/admin/routes
```
To see the routes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1661: feat: add scheme field test case
codecov-io edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-805419276 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1661](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (26afa8d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1fa467a3ffc627e37cc7057b6c1887eb4eba2c31?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1fa467a) will **decrease** coverage by `3.96%`. > The diff coverage is `n/a`. > :exclamation: Current head 26afa8d differs from pull request most recent head ec569b1. Consider uploading reports for the commit ec569b1 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1661 +/- ## == - Coverage 71.35% 67.39% -3.97% == Files 47 47 Lines3128 3128 == - Hits 2232 2108 -124 - Misses656 765 +109 - Partials 240 255 +15 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `47.37% <ø> (-14.74%)` | :arrow_down: | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.29% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [...l/handler/route\_online\_debug/route\_online\_debug.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvcm91dGVfb25saW5lX2RlYnVnL3JvdXRlX29ubGluZV9kZWJ1Zy5nbw==) | `5.35% <0.00%> (-71.43%)` | :arrow_down: | | [api/internal/handler/healthz/healthz.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGVhbHRoei9oZWFsdGh6Lmdv) | `66.66% <0.00%> (-33.34%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `31.93% <0.00%> (-23.53%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `81.25% <0.00%> (-18.75%)` | :arrow_down: | | [api/internal/log/log.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2xvZy9sb2cuZ28=) | `40.00% <0.00%> (-10.00%)` | :arrow_down: | | [api/internal/handler/schema/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvc2NoZW1hL3NjaGVtYS5nbw==) | `90.47% <0.00%> (-9.53%)` | :arrow_down: | | [api/internal/handler/handler.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvaGFuZGxlci5nbw==) | `68.51% <0.00%> (-9.26%)` | :arrow_down: | |
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1661: feat: add scheme field test case
codecov-io edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-805419276 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1661](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (26afa8d) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/1fa467a3ffc627e37cc7057b6c1887eb4eba2c31?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1fa467a) will **decrease** coverage by `19.06%`. > The diff coverage is `n/a`. > :exclamation: Current head 26afa8d differs from pull request most recent head ec569b1. Consider uploading reports for the commit ec569b1 to get more accurate results [](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@ Coverage Diff @@ ## master#1661 +/- ## === - Coverage 71.35% 52.29% -19.07% === Files 47 38-9 Lines3128 2660 -468 === - Hits 2232 1391 -841 - Misses656 1081 +425 + Partials 240 188 -52 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `52.29% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1661?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/utils/version.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3ZlcnNpb24uZ28=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/filter/request\_id.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9yZXF1ZXN0X2lkLmdv) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: | | [api/internal/core/store/storehub.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvc3RvcmUvc3RvcmVodWIuZ28=) | `0.00% <0.00%> (-71.03%)` | :arrow_down: | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | `0.00% <0.00%> (-66.67%)` | :arrow_down: | | [api/internal/filter/schema.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9zY2hlbWEuZ28=) | `0.00% <0.00%> (-55.47%)` | :arrow_down: | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/1661/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | `0.00% <0.00%> (-50.00%)` | :arrow_down: | |
[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup
wjx8382 commented on issue #356:
URL:
https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-818383007
@tokers Why does `kubectl exec -it -n tools apisix-7987b5b7f-tmrk7 -- curl
http://127.0.0.1:9080/headers -H 'Host: local.httpbin.org'` returns
`{"error_msg":"404 Route Not Found"}`
```
# httpbin-route.yaml
apiVersion: apisix.apache.org/v2alpha1
kind: ApisixRoute
metadata:
name: httpserver-route
spec:
http:
- name: rule1
match:
hosts:
- local.httpbin.org
paths:
- /*
backend:
serviceName: httpbin-85d57ddd75-wtmwh
servicePort: 80
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #324: bug: secret controller doesn't update ApisixTls but just re-push the old one
tokers commented on issue #324: URL: https://github.com/apache/apisix-ingress-controller/issues/324#issuecomment-818377821 Fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers closed issue #324: bug: secret controller doesn't update ApisixTls but just re-push the old one
tokers closed issue #324: URL: https://github.com/apache/apisix-ingress-controller/issues/324 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4034: feat: support client certificate verification
spacewander commented on a change in pull request #4034: URL: https://github.com/apache/apisix/pull/4034#discussion_r612076873 ## File path: apisix/admin/ssl.lua ## @@ -70,6 +70,17 @@ local function check_conf(id, conf, need_id) end end +if conf.client then +if not apisix_ssl.support_client_verification() then Review comment: There is an additional check in the DP side. The `conf.client` will be ignored if the DP doesn't support it. The check here is not critical as the DP may be different with the Admin API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on issue #156: https for website
Yiyiyimu commented on issue #156: URL: https://github.com/apache/apisix-website/issues/156#issuecomment-818376580 My bad.. I noticed Github Page on the front page of the repo, but it seems two years ago when it got deployed last time 藍  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #4034: feat: support client certificate verification
spacewander commented on a change in pull request #4034:
URL: https://github.com/apache/apisix/pull/4034#discussion_r612075931
##
File path: apisix/schema_def.lua
##
@@ -642,6 +642,18 @@ _M.ssl = {
type = "array",
items = private_key_schema,
},
+client = {
+type = "object",
+properties = {
+ca = certificate_scheme,
Review comment:
Currently, OpenResty only supports a single CA cert chain. We can use
`ca_list` or anything else if multiple chains are supported. However, using
such a name now is confusing as we only support one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1727: feat: add referer-restriction plugin form
netlify[bot] edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817649660 Deploy preview for *apisix-dashboard* ready! Built with commit d0d70a6806731d70721a8f6893a50607ad3918c8 https://deploy-preview-1727--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1661: feat: add scheme field test case
netlify[bot] edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-818307502 Deploy preview for *apisix-dashboard* ready! Built with commit ec569b19fb0e6b8ddc0cabc357202fe3a6c88973 https://deploy-preview-1661--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1727: feat: add referer-restriction plugin form
netlify[bot] edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817649660 Deploy preview for *apisix-dashboard* processing. Building with commit d0d70a6806731d70721a8f6893a50607ad3918c8 https://app.netlify.com/sites/apisix-dashboard/deploys/6074f80fa58b7f00071efa7a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1762: chore: reduce CI time
netlify[bot] edited a comment on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818367527 Deploy preview for *apisix-dashboard* ready! Built with commit 56c4d3d69abfa8a664eb5f830596ae6413c5de38 https://deploy-preview-1762--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1710: feat: duplicate upstream service consumer
netlify[bot] edited a comment on pull request #1710: URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-818368730 Deploy preview for *apisix-dashboard* ready! Built with commit 5bde2d483d7d7c183cf99c26471615066511e440 https://deploy-preview-1710--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1661: feat: add scheme field test case
netlify[bot] edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-818307502 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1762: chore: reduce CI time
juzhiyuan commented on a change in pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#discussion_r612069815 ## File path: .github/workflows/markdown-link-checker.yml ## @@ -1,14 +0,0 @@ -name: Check markdown links Review comment: See this one: https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status#GitHubActionsstatus-Security -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1762: chore: reduce CI time
juzhiyuan commented on a change in pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#discussion_r612069617 ## File path: .github/workflows/markdown-link-checker.yml ## @@ -1,14 +0,0 @@ -name: Check markdown links Review comment: yes, because Apache Infra doen't allow this one -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1762: chore: reduce CI time
nic-chen commented on a change in pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#discussion_r612069390 ## File path: .github/workflows/markdown-link-checker.yml ## @@ -1,14 +0,0 @@ -name: Check markdown links Review comment: we don't need this CI now ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1710: feat: duplicate upstream service consumer
netlify[bot] commented on pull request #1710: URL: https://github.com/apache/apisix-dashboard/pull/1710#issuecomment-818368730 Deploy preview for *apisix-dashboard* processing. Building with commit 5bde2d483d7d7c183cf99c26471615066511e440 https://app.netlify.com/sites/apisix-dashboard/deploys/6074f6c6bd48450008bb8ba1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1762: chore: reduce CI time
netlify[bot] commented on pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762#issuecomment-818367527 Deploy preview for *apisix-dashboard* processing. Building with commit 56c4d3d69abfa8a664eb5f830596ae6413c5de38 https://app.netlify.com/sites/apisix-dashboard/deploys/6074f5fad29c8600073ca910 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1661: feat: add scheme field test case
netlify[bot] edited a comment on pull request #1661: URL: https://github.com/apache/apisix-dashboard/pull/1661#issuecomment-818307502 Deploy preview for *apisix-dashboard* processing. Building with commit 26afa8dba021aeddac8782af44884c87f200d0ff https://app.netlify.com/sites/apisix-dashboard/deploys/6074f5e3f96b5b00082b5d91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan opened a new pull request #1762: chore: reduce CI time
juzhiyuan opened a new pull request #1762: URL: https://github.com/apache/apisix-dashboard/pull/1762 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [x] Improve performance - [ ] Backport patches **What changes will this PR take into?** - [x] Update CI Trigger policy that run CI conditionally **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #4026: ci: cache deps
spacewander commented on pull request #4026: URL: https://github.com/apache/apisix/pull/4026#issuecomment-818366833 Look like something wrong is cached? https://github.com/apache/apisix/pull/4026/checks?check_run_id=2329191183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1725: feat: add proxy-mirror plugin form
LiteSun commented on a change in pull request #1725:
URL: https://github.com/apache/apisix-dashboard/pull/1725#discussion_r612067202
##
File path: web/src/components/Plugin/locales/zh-CN.ts
##
@@ -21,4 +21,7 @@ export default {
'component.step.select.pluginTemplate.select.option': '手动配置',
'component.plugin.pluginTemplate.tip1': '1. 若路由已配置插件，则插件模板数据将与已配置的插件数据合并。',
'component.plugin.pluginTemplate.tip2': '2. 插件模板相同的插件会覆盖掉原有的插件。',
+
+ // proxxy-mirror
+ 'component.pluginForm.proxy-mirror.host.tooltip':
'指定镜像服务地址，例如：http://127.0.0.1:9797（地址中需要包含 schema ：http或https，不能包含 URI 部分）',
Review comment:
IMO, we should keep the documentation consistent, otherwise, it can
confuse users when explanations are inconsistent. I've this in this issue
https://github.com/apache/apisix-dashboard/issues/1724.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1740: feat: Added fault-injection plugin form
netlify[bot] edited a comment on pull request #1740: URL: https://github.com/apache/apisix-dashboard/pull/1740#issuecomment-817315630 Deploy preview for *apisix-dashboard* ready! Built with commit 1bb8b879b44362f5a351dabe78255830d3fa6c17 https://deploy-preview-1740--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1761: fix: online debug test case
netlify[bot] edited a comment on pull request #1761: URL: https://github.com/apache/apisix-dashboard/pull/1761#issuecomment-818361132 Deploy preview for *apisix-dashboard* ready! Built with commit 66d21c8fa2c75fabd6d6bde78cac1d91534d6f8c https://deploy-preview-1761--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Firstsawyou edited a comment on issue #1759: default login page return 404 when using APISIX for http/https proxy
Firstsawyou edited a comment on issue #1759: URL: https://github.com/apache/apisix-dashboard/issues/1759#issuecomment-818361900 > It works. I am wondering why should this happen...? Port conflict or? Because Dashboard access needs to occupy the port of `/apisix/admin/xxx`, and on the data side, the default APISIX and `Admin API` listening ports are the same. When using APISIX proxy to access Dashboard, it will conflict with APISIX's `Admin API` listening interface. Therefore, we need to customize the Admin API port to avoid conflicts, or disable the Admin API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] guoqqqi commented on a change in pull request #1733: feat: added cors plugin form
guoqqqi commented on a change in pull request #1733:
URL: https://github.com/apache/apisix-dashboard/pull/1733#discussion_r612054702
##
File path: web/src/components/Plugin/locales/en-US.ts
##
@@ -21,6 +21,19 @@ export default {
'component.step.select.pluginTemplate.select.option': 'Custom',
'component.plugin.pluginTemplate.tip1': '1. When a route already have
plugins field configured, the plugins in the plugin template will be merged
into it.',
'component.plugin.pluginTemplate.tip2': '2. The same plugin in the plugin
template will override one in the plugins',
+ // cors
'component.pluginForm.cors.allow_credential.tooltip': 'If you set this
option to true, you can not use \'*\' for other options.',
'component.pluginForm.cors.max_age.tooltip': 'Maximum number of seconds the
results can be cached.. Within this time range, the browser will reuse the last
check result. -1 means no cache.',
+
+ // limit-conn
+ 'component.pluginForm.limit-conn.conn.tooltip': 'the maximum number of
concurrent requests allowed. Requests exceeding this ratio (and below conn +
burst) will get delayed(the latency seconds is configured by
default_conn_delay) to conform to this threshold.',
+ 'component.pluginForm.limit-conn.burst.tooltip': 'the number of excessive
concurrent requests (or connections) allowed to be delayed.',
+ 'component.pluginForm.limit-conn.default_conn_delay.tooltip': 'the latency
seconds of request when concurrent requests exceeding conn but below (conn +
burst).',
+ 'component.pluginForm.limit-conn.key.tooltip': 'to limit the concurrency
level.For example, one can use the host name (or server zone) as the key so
that we limit concurrency per host name. Otherwise, we can also use the client
address as the key so that we can avoid a single client from flooding our
service with too many parallel connections or requests.Now accept those as key:
"remote_addr"(client\'s IP), "server_addr"(server\'s IP),
"X-Forwarded-For/X-Real-IP" in request header, "consumer_name"(consumer\'s
username).',
+ 'component.pluginForm.limit-conn.rejected_code.tooltip': 'returned when the
request exceeds conn + burst will be rejected.',
+
+ 'component.plugin.form': 'Form',
+ 'component.plugin.format-codes.disable': 'Format JSON or YAML data',
Review comment:
These files are conflicting files, generated after conflict resolution.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
