[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 Deploy preview for *apisix-dashboard* processing. Building with commit 38c64210defabc7e6ade86398bdf19a117bca291 https://app.netlify.com/sites/apisix-dashboard/deploys/607680524ba00c00092fde6b -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #306: fix: broken link in release guide
netlify[bot] edited a comment on pull request #306: URL: https://github.com/apache/apisix-website/pull/306#issuecomment-819020192 Deploy preview for *apisix* ready! Built with commit f21579af71f3d85a8597ffe32fdaa8199b44a7ff https://deploy-preview-306--apisix.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #306: fix: broken link in release guide
netlify[bot] edited a comment on pull request #306: URL: https://github.com/apache/apisix-website/pull/306#issuecomment-819020192 Deploy preview for *apisix* processing. Building with commit f21579af71f3d85a8597ffe32fdaa8199b44a7ff https://app.netlify.com/sites/apisix/deploys/607677f7057d610007e9d1f2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers closed issue #348: bug: failed to sync route configuration to apisix
tokers closed issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #348: bug: failed to sync route configuration to apisix
tokers commented on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819227096 > I tested successfully. The manual created routes need add description. if not, the error above will be raised. We will add some labels for resources created by apisix-ingress-controller, and only theses resources will be synced to apisix-ingress-controller (when it starts). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #348: bug: failed to sync route configuration to apisix
tokers commented on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819226923 > @tokers It's resovled, thanks very much. How can I add the external routes configuration in apisix which not from apisix-ingress-controller? I hope the apisix can proxy the k8s svc and other services of not in k8s? We don't recommend this way. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #369: chore: remove apisix service related codes
tokers merged pull request #369: URL: https://github.com/apache/apisix-ingress-controller/pull/369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: chore: remove apisix service related codes (#369)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 207f059 chore: remove apisix service related codes (#369)
207f059 is described below
commit 207f05999045025df5484c79c8afd3db4dea1d14
Author: Alex Zhang
AuthorDate: Wed Apr 14 12:54:05 2021 +0800
chore: remove apisix service related codes (#369)
---
pkg/apisix/apisix.go | 12 --
pkg/apisix/cache/cache.go| 10 +-
pkg/apisix/cache/memdb.go| 58 +--
pkg/apisix/cache/memdb_test.go | 66 +---
pkg/apisix/cache/schema.go | 21 ---
pkg/apisix/cluster.go| 22 ---
pkg/apisix/cluster_test.go | 9 -
pkg/apisix/nonexistentclient.go | 32
pkg/apisix/resource.go | 31
pkg/apisix/resource_test.go | 2 -
pkg/apisix/route.go | 3 -
pkg/apisix/route_test.go | 4 -
pkg/apisix/service.go| 244 ---
pkg/apisix/service_test.go | 207 ---
pkg/ingress/endpoint.go | 1 -
pkg/types/apisix/v1/types.go | 44 ++---
pkg/types/apisix/v1/zz_generated.deepcopy.go | 82 +++--
17 files changed, 84 insertions(+), 764 deletions(-)
diff --git a/pkg/apisix/apisix.go b/pkg/apisix/apisix.go
index d16641b..bec4d25 100644
--- a/pkg/apisix/apisix.go
+++ b/pkg/apisix/apisix.go
@@ -37,8 +37,6 @@ type Cluster interface {
Route() Route
// Upstream returns a Upstream interface that can operate Upstream
resources.
Upstream() Upstream
- // Service returns a Service interface that can operate Service
resources.
- Service() Service
// SSL returns a SSL interface that can operate SSL resources.
SSL() SSL
// String exposes the client information in human readable format.
@@ -78,16 +76,6 @@ type Upstream interface {
Update(context.Context, *v1.Upstream) (*v1.Upstream, error)
}
-// Service is the specific client interface to take over the create, update,
-// list and delete for APISIX's Service resource.
-type Service interface {
- Get(context.Context, string) (*v1.Service, error)
- List(context.Context) ([]*v1.Service, error)
- Create(context.Context, *v1.Service) (*v1.Service, error)
- Delete(context.Context, *v1.Service) error
- Update(context.Context, *v1.Service) (*v1.Service, error)
-}
-
type apisix struct {
nonExistentCluster Cluster
clusters map[string]Cluster
diff --git a/pkg/apisix/cache/cache.go b/pkg/apisix/cache/cache.go
index 6df8335..7cc9031 100644
--- a/pkg/apisix/cache/cache.go
+++ b/pkg/apisix/cache/cache.go
@@ -19,14 +19,12 @@ import v1
"github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1"
// Cache defines the necessary behaviors that the cache object should have.
// Note this interface is for APISIX, not for generic purpose, it supports
-// standard APISIX resources, i.e. Route, Upstream, Service and SSL.
+// standard APISIX resources, i.e. Route, Upstream, and SSL.
// Cache implementations should copy the target objects before/after read/write
// operations for the sake of avoiding data corrupted by other writers.
type Cache interface {
// InsertRoute adds or updates route to cache.
InsertRoute(*v1.Route) error
- // InsertService adds or updates service to cache.
- InsertService(*v1.Service) error
// InsertSSL adds or updates ssl to cache.
InsertSSL(*v1.Ssl) error
// InsertUpstream adds or updates upstream to cache.
@@ -34,8 +32,6 @@ type Cache interface {
// GetRoute finds the route from cache according to the primary index.
GetRoute(string) (*v1.Route, error)
- // GetService finds the service from cache according to the primary
index.
- GetService(string) (*v1.Service, error)
// GetSSL finds the ssl from cache according to the primary index.
GetSSL(string) (*v1.Ssl, error)
// GetUpstream finds the upstream from cache according to the primary
index.
@@ -43,8 +39,6 @@ type Cache interface {
// ListRoutes lists all routes in cache.
ListRoutes() ([]*v1.Route, error)
- // ListServices lists all services in cache.
- ListServices() ([]*v1.Service, error)
// ListSSL lists all ssl objects in cache.
ListSSL() ([]*v1.Ssl, error)
// ListUpstreams lists all upstreams in cache.
@@ -52,8 +46,6 @@ type Cache interface {
// DeleteRoute deletes the specified route in cache.
DeleteRoute(*v1.Route) error
- // DeleteService deletes the specified service in cache.
-
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1705: fix: detailed error for store init failure and deferred execution of closers
netlify[bot] edited a comment on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-818713534 Deploy preview for *apisix-dashboard* ready! Built with commit a9da7c127653d53c49ddfb32c8782cbd1aa83fb0 https://deploy-preview-1705--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1705: fix: detailed error for store init failure and deferred execution of closers
netlify[bot] edited a comment on pull request #1705: URL: https://github.com/apache/apisix-dashboard/pull/1705#issuecomment-818713534 Deploy preview for *apisix-dashboard* processing. Building with commit a9da7c127653d53c49ddfb32c8782cbd1aa83fb0 https://app.netlify.com/sites/apisix-dashboard/deploys/607670dd1470cb00074aaf22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1739: feat: add limit-count plugin
codecov-io edited a comment on pull request #1739: URL: https://github.com/apache/apisix-dashboard/pull/1739#issuecomment-817236136 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1739?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1739](https://codecov.io/gh/apache/apisix-dashboard/pull/1739?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4325300) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/419128df29cde091554c469a3b4d20a9e1e1e929?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (419128d) will **increase** coverage by `0.21%`. > The diff coverage is `84.84%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1739?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1739 +/- ## == + Coverage 72.57% 72.79% +0.21% == Files 113 114 +1 Lines2695 2727 +32 Branches 650 655 +5 == + Hits 1956 1985 +29 - Misses739 742 +3 ``` | Flag | Coverage Δ | | |---|---|---| | frontend-e2e-test | `72.79% <84.84%> (+0.21%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1739?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/Plugin/UI/limit-count.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1739/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9saW1pdC1jb3VudC50c3g=) | `83.33% <83.33%> (ø)` | | | [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1739/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `69.23% <100.00%> (+5.59%)` | :arrow_up: | | [...ages/Route/components/DebugViews/DebugDrawView.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1739/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9wYWdlcy9Sb3V0ZS9jb21wb25lbnRzL0RlYnVnVmlld3MvRGVidWdEcmF3Vmlldy50c3g=) | `79.86% <0.00%> (+1.34%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1739?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1739?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [419128d...4325300](https://codecov.io/gh/apache/apisix-dashboard/pull/1739?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] nic-chen commented on issue #4037: [discuss]: keep backward compatibility of apisix admin api or manager api
nic-chen commented on issue #4037: URL: https://github.com/apache/apisix/issues/4037#issuecomment-819219259 > Those fields are removed intentionally because we have plan to support non-etcd storage. Yes, so we only return generic values, not the data unique to etcd. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] bisakhmondal commented on a change in pull request #1705: fix: detailed error for store init failure and deferred execution of closers
bisakhmondal commented on a change in pull request #1705:
URL: https://github.com/apache/apisix-dashboard/pull/1705#discussion_r612927994
##
File path: api/cmd/managerapi.go
##
@@ -93,13 +102,16 @@ func NewManagerAPICommand() *cobra.Command {
return newMws
}
+ fmt.Printf("DEBUG-ETCDCONFIG: %+v\n\n",
*conf.ETCDConfig)
Review comment:
yes yes. Just 1 min.
Actually, it was the root cause. The endpoint was different, haha.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #1420: feat: added support for -c to set the config file path
nic-chen commented on pull request #1420: URL: https://github.com/apache/apisix-dashboard/pull/1420#issuecomment-819218416 ping @vinayaksh42 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on a change in pull request #1705: fix: detailed error for store init failure and deferred execution of closers
nic-chen commented on a change in pull request #1705:
URL: https://github.com/apache/apisix-dashboard/pull/1705#discussion_r612926934
##
File path: api/cmd/managerapi.go
##
@@ -93,13 +102,16 @@ func NewManagerAPICommand() *cobra.Command {
return newMws
}
+ fmt.Printf("DEBUG-ETCDCONFIG: %+v\n\n",
*conf.ETCDConfig)
Review comment:
please remove debug code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1745: change: remove ID of consumer
netlify[bot] edited a comment on pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#issuecomment-817293771 Deploy preview for *apisix-dashboard* ready! Built with commit 4fc721eff8e7b268b5dc77f99f81c8bd32ac7d57 https://deploy-preview-1745--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1745: change: remove ID of consumer
netlify[bot] edited a comment on pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#issuecomment-817293771 Deploy preview for *apisix-dashboard* processing. Building with commit 4fc721eff8e7b268b5dc77f99f81c8bd32ac7d57 https://app.netlify.com/sites/apisix-dashboard/deploys/607668f86507370007897c26 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 Deploy preview for *apisix-dashboard* ready! Built with commit d49319f8c7bf8c1897d7909ceeb6ef5942162cd6 https://deploy-preview-1764--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] Firstsawyou opened a new issue #1768: the `Regex` in the routing configuration cannot be displayed normally
Firstsawyou opened a new issue #1768: URL: https://github.com/apache/apisix-dashboard/issues/1768 ## Issue description After configuring the `Regex` in the `URI Override` of the `Request Override`, when editing the route again, the configured `Regex` information cannot be displayed. 1. Create a route and configure the `Regex` information in `URI Override`. https://user-images.githubusercontent.com/52862365/114651585-d7c84600-9d16-11eb-97dd-78e36d8a2e36.png;> 2. Edit the route again, the `Regex` configuration information cannot be displayed, but the `Stay The Same` option is defaulted. https://user-images.githubusercontent.com/52862365/114651614-e9115280-9d16-11eb-9546-006159ec3607.png;> ## Expected behavior After configuring the `Regex` information in the `URI Override`, when editing the route again, the `Regex` configuration information should be displayed. ## Environment * apisix version (cmd: `apisix version`): 2.4 * OS (cmd: `uname -a`): * OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): * etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): * apisix-dashboard version, if have: 2.5 * Browser version, if have: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] sniper-xx commented on issue #348: bug: failed to sync route configuration to apisix
sniper-xx commented on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819206848 I tested successfully. The manual created routes need add description. if not, the error above will be raised. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1764: chore: added Fields to Upstream module
juzhiyuan commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r612915488
##
File path:
web/src/components/Upstream/components/active-check/Healthy/HttpStatuses.tsx
##
@@ -0,0 +1,75 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Button, InputNumber } from 'antd'
+import { useIntl } from 'umi'
+import { MinusCircleOutlined, PlusOutlined } from '@ant-design/icons'
+
+import { removeBtnStyle } from '@/components/Upstream'
+
+type Props = {
+ readonly?: boolean
+}
+
+const Component: React.FC = ({ readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+
+ {(fields, { add, remove }) => (
+<>
+ https://user-images.githubusercontent.com/2106987/114651435-8a4bd900-9d16-11eb-845d-26b54358f3cc.png)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1764: chore: added Fields to Upstream module
juzhiyuan commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r612914396
##
File path: web/src/components/Upstream/components/active-check/Host.tsx
##
@@ -26,30 +26,30 @@ const Component: React.FC = ({ readonly }) => {
const { formatMessage } = useIntl()
return (
= ({ readonly }) => {
const { formatMessage } = useIntl()
return (
https://github.com/apache/apisix/blob/master/apisix/schema_def.lua#L40
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-io edited a comment on pull request #1730: feat: add api-breaker plugin form
codecov-io edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817070583 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1730?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#1730](https://codecov.io/gh/apache/apisix-dashboard/pull/1730?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (897fa98) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/419128df29cde091554c469a3b4d20a9e1e1e929?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (419128d) will **decrease** coverage by `0.12%`. > The diff coverage is `62.50%`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/1730?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#1730 +/- ## == - Coverage 72.57% 72.45% -0.13% == Files 113 114 +1 Lines2695 2726 +31 Branches 650 660 +10 == + Hits 1956 1975 +19 - Misses739 751 +12 ``` | Flag | Coverage Δ | | |---|---|---| | frontend-e2e-test | `72.45% <62.50%> (-0.13%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/1730?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [web/src/components/Plugin/UI/plugin.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1730/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9wbHVnaW4udHN4) | `60.00% <60.00%> (-3.64%)` | :arrow_down: | | [web/src/components/Plugin/UI/api-breaker.tsx](https://codecov.io/gh/apache/apisix-dashboard/pull/1730/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-d2ViL3NyYy9jb21wb25lbnRzL1BsdWdpbi9VSS9hcGktYnJlYWtlci50c3g=) | `62.96% <62.96%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1730?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/1730?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [419128d...897fa98](https://codecov.io/gh/apache/apisix-dashboard/pull/1730?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] sniper-xx commented on issue #348: bug: failed to sync route configuration to apisix
sniper-xx commented on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819201707 @tokers It's resovled, thanks very much. How can I add the external routes configuration in apisix which not from apisix-ingress-controller? I hope the apisix can proxy the k8s svc and other services of not in k8s? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 Deploy preview for *apisix-dashboard* processing. Building with commit 098bb212df3b5956a15ef465fc7d060f96829a49 https://app.netlify.com/sites/apisix-dashboard/deploys/607660dc3822f800073e0701 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] gxthrj merged pull request #62: chore: update ingress tag to 0.5.0
gxthrj merged pull request #62: URL: https://github.com/apache/apisix-helm-chart/pull/62 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-helm-chart] branch master updated: chore: update ingress tag to 0.5.0 (#62)
This is an automated email from the ASF dual-hosted git repository. kvn pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix-helm-chart.git The following commit(s) were added to refs/heads/master by this push: new d9e462c chore: update ingress tag to 0.5.0 (#62) d9e462c is described below commit d9e462cbc487ab340323dc4fb01f1719ddb4273a Author: kv AuthorDate: Wed Apr 14 11:22:03 2021 +0800 chore: update ingress tag to 0.5.0 (#62) * chore: update dashboard tag to 2.5 * change ingress version to 0.5.0 * fix: modify version in charts --- charts/apisix-ingress-controller/Chart.yaml | 4 ++-- charts/apisix-ingress-controller/values.yaml | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/charts/apisix-ingress-controller/Chart.yaml b/charts/apisix-ingress-controller/Chart.yaml index c491dd2..8e5289b 100644 --- a/charts/apisix-ingress-controller/Chart.yaml +++ b/charts/apisix-ingress-controller/Chart.yaml @@ -24,5 +24,5 @@ keywords: - nginx - crd type: application -version: 0.3.0 -appVersion: 0.4.0 +version: 0.4.0 +appVersion: 0.5.0 diff --git a/charts/apisix-ingress-controller/values.yaml b/charts/apisix-ingress-controller/values.yaml index e9727bf..56400bd 100644 --- a/charts/apisix-ingress-controller/values.yaml +++ b/charts/apisix-ingress-controller/values.yaml @@ -39,7 +39,7 @@ replicaCount: 1 image: repository: apache/apisix-ingress-controller pullPolicy: IfNotPresent - tag: "0.4.0" + tag: "0.5.0" imagePullSecrets: []
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1764: chore: added Fields to Upstream module
LiteSun commented on a change in pull request #1764:
URL: https://github.com/apache/apisix-dashboard/pull/1764#discussion_r612904586
##
File path: web/src/components/Upstream/components/TLS.tsx
##
@@ -0,0 +1,95 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Select, FormInstance, Input } from 'antd'
+import { useIntl } from 'umi'
+
+type Props = {
+ form: FormInstance;
+ readonly?: boolean;
+}
+
+const CUSTOM_FIELD_KEY = "custom__enable_tls"
+
+const TLSComponent: React.FC = ({ form, readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+
+ http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react'
+import { Form, Row, Col, Button, InputNumber } from 'antd'
+import { useIntl } from 'umi'
+import { MinusCircleOutlined, PlusOutlined } from '@ant-design/icons'
+
+import { removeBtnStyle } from '@/components/Upstream'
+
+type Props = {
+ readonly?: boolean
+}
+
+const Component: React.FC = ({ readonly }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+
+ {(fields, { add, remove }) => (
+<>
+ = ({ readonly }) => {
const { formatMessage } = useIntl()
return (
[GitHub] [apisix-ingress-controller] codecov-io commented on pull request #370: fix: zero weight service cannot be configured
codecov-io commented on pull request #370: URL: https://github.com/apache/apisix-ingress-controller/pull/370#issuecomment-819199388 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/370?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#370](https://codecov.io/gh/apache/apisix-ingress-controller/pull/370?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (3f3c902) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/fb5bb33d50f35503f6b7cbc009b75bd5b543478f?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (fb5bb33) will **decrease** coverage by `0.01%`. > The diff coverage is `50.00%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/370?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #370 +/- ## == - Coverage 42.64% 42.63% -0.02% == Files 39 38 -1 Lines3482 3481 -1 == - Hits 1485 1484 -1 Misses 1826 1826 Partials 171 171 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/370?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/370/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3JvdXRlLmdv) | `46.08% <0.00%> (ø)` | | | [pkg/kube/translation/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/370/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vcGx1Z2luLmdv) | `100.00% <100.00%> (ø)` | | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/370/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/370?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/370?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [fb5bb33...3f3c902](https://codecov.io/gh/apache/apisix-ingress-controller/pull/370?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup
wjx8382 commented on issue #356:
URL:
https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-819198021
> Maybe there are some internal bugs, could you paste the error log of
apisix-ingress-controller.
>
> Just paste the result of `kubectl logs -f {apisix-ingress-controller pod
name}`.
```
2021-04-14T11:00:29+08:00error apisix/upstream.go:119 failed to get
upstream from APISIX {"fullname": "tools_httpbin-85d57ddd75-wtmwh_80",
"url": "http://apisix-admin:9180/apisix/admin/upstreams/5e521191;, "cluster":
"", "error": "unexpected status code 403; error message:
\r\n403
Forbidden\r\n\r\n403
Forbidden\r\nopenresty\r\n\r\n\r\n",
"errorCauses": [{"error": "unexpected status code 403"}, {"error": "error
message: \r\n403
Forbidden\r\n\r\n403
Forbidden\r\nopenresty\r\n\r\n\r\n"}]}
2021-04-14T11:00:29+08:00error state/builder.go:174failed to find
upstream tools_httpbin-85d57ddd75-wtmwh_80: unexpected status code 403; error
message:
403 Forbidden
403 Forbidden
openresty
2021-04-14T11:00:29+08:00infocontroller/apisix_route.go:193 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"tools/httpserver-route","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null}}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #372: feat: add jsonschema validate for ApisixTls resource
gxthrj opened a new issue #372: URL: https://github.com/apache/apisix-ingress-controller/issues/372 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] gxthrj opened a new issue #371: feat: add jsonschema validate for ApisixUpstream resource
gxthrj opened a new issue #371: URL: https://github.com/apache/apisix-ingress-controller/issues/371 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #348: bug: failed to sync route configuration to apisix
tokers commented on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819195758 Seems the `desc` field missing (which maps to `full_name` in the internal of apisix-ingress-controller), the in-memory DB checks one of the primary indexes (`full_name`), so the insertion is failed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #348: bug: failed to sync route configuration to apisix
tokers commented on issue #348:
URL:
https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819195373
@sniper-xx It seems your APISIX cluster contains some other routes which
were not created by ingress-controller.
```json
{
"uris": [
"/user/*"
],
"methods": [
"GET",
"HEAD",
"POST",
"PUT",
"DELETE",
"OPTIONS",
"PATCH"
],
"hosts": [
"192.168.2.100"
],
"create_time": 1618294999,
"upstream": {
"pass_host": "pass",
"type": "roundrobin",
"timeout": {
"send": 6,
"connect": 6,
"read": 6
},
"nodes": [
{
"port": 8080,
"host": "192.168.2.1",
"weight": 1
}
]
},
"status": 1,
"id": "350250219385922931",
"update_time": 1618295054,
"name": "openresty-test"
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander opened a new pull request #4045: ci: centos7-ci.sh should be under ci/
spacewander opened a new pull request #4045: URL: https://github.com/apache/apisix/pull/4045 Signed-off-by: spacewander ### What this PR does / why we need it: ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1745: change: remove ID of consumer
netlify[bot] edited a comment on pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#issuecomment-817293771 Deploy preview for *apisix-dashboard* ready! Built with commit da4360718d4ae603ea21b46b3c91a06648be9d0e https://deploy-preview-1745--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 Deploy preview for *apisix-dashboard* ready! Built with commit 41d9e281632102b249f690788493ff55bd0ef4d1 https://deploy-preview-1764--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1745: change: remove ID of consumer
netlify[bot] edited a comment on pull request #1745: URL: https://github.com/apache/apisix-dashboard/pull/1745#issuecomment-817293771 Deploy preview for *apisix-dashboard* processing. Building with commit da4360718d4ae603ea21b46b3c91a06648be9d0e https://app.netlify.com/sites/apisix-dashboard/deploys/607659c55b3d3a000886b532 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] sniper-xx edited a comment on issue #348: bug: failed to sync route configuration to apisix
sniper-xx edited a comment on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819189262 @tokers this is apisix config.yaml ```yaml apisix: admin_key: - name: "admin" # yamllint disable rule:comments-indentation key: "12345678" # using fixed API token has security risk, please update it when you deploy to production environment # yamllint enable rule:comments-indentation role: admin allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow # - 127.0.0.0/24 # If we don't set any IP list, then any IP access is allowed by default. port_admin: 9180 ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] sniper-xx commented on issue #348: bug: failed to sync route configuration to apisix
sniper-xx commented on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819189262 @tokers this is apisix config.yaml apisix: admin_key: - name: "admin" # yamllint disable rule:comments-indentation key: "12345678" # using fixed API token has security risk, please update it when you deploy to production environment # yamllint enable rule:comments-indentation role: admin allow_admin: # http://nginx.org/en/docs/http/ngx_http_access_module.html#allow # - 127.0.0.0/24 # If we don't set any IP list, then any IP access is allowed by default. port_admin: 9180 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1740: feat: Added fault-injection plugin form
netlify[bot] edited a comment on pull request #1740: URL: https://github.com/apache/apisix-dashboard/pull/1740#issuecomment-817315630 Deploy preview for *apisix-dashboard* ready! Built with commit abe03c6b228aa2890e551c6605240a46e305 https://deploy-preview-1740--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1739: feat: add limit-count plugin
netlify[bot] edited a comment on pull request #1739: URL: https://github.com/apache/apisix-dashboard/pull/1739#issuecomment-817287287 Deploy preview for *apisix-dashboard* ready! Built with commit 432530075be58eac60ea5cf06ad9119249f4ed64 https://deploy-preview-1739--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] sniper-xx commented on issue #348: bug: failed to sync route configuration to apisix
sniper-xx commented on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819181389 @tokers this is my ingress controller logs. I changed admin port and token. I can see ingress-controller successfully to read original configuration from apisix,but ingress-controller can't write the config to apisix. this is strange. maybe my apisix configuration is not correct. [apisix-ingress-controller.log](https://github.com/apache/apisix-ingress-controller/files/6307853/apisix-ingress-controller.log) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Fields to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1733: feat: added cors plugin form
netlify[bot] edited a comment on pull request #1733: URL: https://github.com/apache/apisix-dashboard/pull/1733#issuecomment-817283838 Deploy preview for *apisix-dashboard* ready! Built with commit 89a21440c6487f09a43312ab56ba74290b8932f3 https://deploy-preview-1733--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1740: feat: Added fault-injection plugin form
netlify[bot] edited a comment on pull request #1740: URL: https://github.com/apache/apisix-dashboard/pull/1740#issuecomment-817315630 Deploy preview for *apisix-dashboard* processing. Building with commit abe03c6b228aa2890e551c6605240a46e305 https://app.netlify.com/sites/apisix-dashboard/deploys/607653c373c2d40007f62f13 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1739: feat: add limit-count plugin
netlify[bot] edited a comment on pull request #1739: URL: https://github.com/apache/apisix-dashboard/pull/1739#issuecomment-817287287 Deploy preview for *apisix-dashboard* processing. Building with commit 432530075be58eac60ea5cf06ad9119249f4ed64 https://app.netlify.com/sites/apisix-dashboard/deploys/6076538f5aaa0e0007f256e1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 Deploy preview for *apisix-dashboard* ready! Built with commit e27afe46df12a7913db6ea788322479c03240f91 https://deploy-preview-1732--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #356: request help: KubeSphere setup
tokers commented on issue #356: URL: https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-819178628 @wjx8382 You should change the log level, you can set it to `debug` by adding a `--set` option when using helm install. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 Deploy preview for *apisix-dashboard* processing. Building with commit 087848634ad292b2a7b87f96fa2b2b8511cb547b https://app.netlify.com/sites/apisix-dashboard/deploys/607653593ceae10008b23aa2 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1727: feat: add referer-restriction plugin form
netlify[bot] edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817649660 Deploy preview for *apisix-dashboard* ready! Built with commit ec04dbd3765ed8f4a1ade46b71a36b54f3338f29 https://deploy-preview-1727--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on issue #302: feat: add Chinese support for the website
Yiyiyimu commented on issue #302: URL: https://github.com/apache/apisix-website/issues/302#issuecomment-819177358 > Shuyang sir! this is a duplicate issue, i already raised it see #280 Thanks for reminding!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu closed issue #302: feat: add Chinese support for the website
Yiyiyimu closed issue #302: URL: https://github.com/apache/apisix-website/issues/302 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1733: feat: added cors plugin form
netlify[bot] edited a comment on pull request #1733: URL: https://github.com/apache/apisix-dashboard/pull/1733#issuecomment-817283838 Deploy preview for *apisix-dashboard* processing. Building with commit 89a21440c6487f09a43312ab56ba74290b8932f3 https://app.netlify.com/sites/apisix-dashboard/deploys/607653524f2d5700078ff3aa -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1730: feat: add api-breaker plugin form
netlify[bot] edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817653772 Deploy preview for *apisix-dashboard* ready! Built with commit 897fa98b5ad2524f39ae95196bbe62d33949db4b https://deploy-preview-1730--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1725: feat: add proxy-mirror plugin form
netlify[bot] edited a comment on pull request #1725: URL: https://github.com/apache/apisix-dashboard/pull/1725#issuecomment-817850088 Deploy preview for *apisix-dashboard* ready! Built with commit 4b4ff4208f9b15d9d5abc6a42779f294fedfb9f3 https://deploy-preview-1725--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1732: feat: added limit-req plugin form
netlify[bot] edited a comment on pull request #1732: URL: https://github.com/apache/apisix-dashboard/pull/1732#issuecomment-817284488 Deploy preview for *apisix-dashboard* processing. Building with commit e27afe46df12a7913db6ea788322479c03240f91 https://app.netlify.com/sites/apisix-dashboard/deploys/6076530b1362bb0007fe5183 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1730: feat: add api-breaker plugin form
netlify[bot] edited a comment on pull request #1730: URL: https://github.com/apache/apisix-dashboard/pull/1730#issuecomment-817653772 Deploy preview for *apisix-dashboard* processing. Building with commit 897fa98b5ad2524f39ae95196bbe62d33949db4b https://app.netlify.com/sites/apisix-dashboard/deploys/60765290b807b40007d9857f -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1727: feat: add referer-restriction plugin form
netlify[bot] edited a comment on pull request #1727: URL: https://github.com/apache/apisix-dashboard/pull/1727#issuecomment-817649660 Deploy preview for *apisix-dashboard* processing. Building with commit ec04dbd3765ed8f4a1ade46b71a36b54f3338f29 https://app.netlify.com/sites/apisix-dashboard/deploys/6076524a885f12000805f67d -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1725: feat: add proxy-mirror plugin form
netlify[bot] edited a comment on pull request #1725: URL: https://github.com/apache/apisix-dashboard/pull/1725#issuecomment-817850088 Deploy preview for *apisix-dashboard* processing. Building with commit 4b4ff4208f9b15d9d5abc6a42779f294fedfb9f3 https://app.netlify.com/sites/apisix-dashboard/deploys/6076520729f7b200085db59c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #302: feat: add Chinese support for the website
iamayushdas commented on issue #302: URL: https://github.com/apache/apisix-website/issues/302#issuecomment-819173834 Shuyang sir! this is a duplicate issue, i already raised it see #280 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas edited a comment on issue #307: update the architecture diagram
iamayushdas edited a comment on issue #307: URL: https://github.com/apache/apisix-website/issues/307#issuecomment-819172633 okay then i have to again create the darkmode flexi format and will push it today only. > current: > >  > > change to: > >  The image you have suggested to change is of solid background. we could do either from the two things below: 1. we have to remove the alpha from the image 2. we have to recreate it(recommended for sake of pointing arrows) @membphis @juzhiyuan which option to opt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #370: fix: zero weight service cannot be configured
tokers opened a new pull request #370: URL: https://github.com/apache/apisix-ingress-controller/pull/370 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] Yiyiyimu commented on pull request #303: chore: add alpha channel to showcase image for dark mode
Yiyiyimu commented on pull request #303: URL: https://github.com/apache/apisix-website/pull/303#issuecomment-819173058 > Wow, I see so many images got updated, but some images seem broken or too dark? @juzhiyuan On my side, no images got updated 藍 The reason is all images coming from CDN, and it would not got updated when only in PR. That's the same reason those two images got broken. I changed them from svg to png, so we could not use the original source from CDN anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] iamayushdas commented on issue #307: update the architecture diagram
iamayushdas commented on issue #307: URL: https://github.com/apache/apisix-website/issues/307#issuecomment-819172633 okay then i have to again create the darkmode flexi format and will push it today only. > current: > >  > > change to: > >  The image you have suggested to change is of solid background. we could do either from the two things below: 1. we have to remove the alpha from the image 2. we have to recreate it(recommended for sake of pointing arrows) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] wjx8382 commented on issue #356: request help: KubeSphere setup
wjx8382 commented on issue #356:
URL:
https://github.com/apache/apisix-ingress-controller/issues/356#issuecomment-819170124
> Maybe there are some internal bugs, could you paste the error log of
apisix-ingress-controller.
>
> Just paste the result of `kubectl logs -f {apisix-ingress-controller pod
name}`.
No error log,only
```[GIN] 2021/04/14 - 10:06:19 | 200 | 56.195µs | 172.16.110.186 | GET
"/healthz"```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1766: feat: support auto build rpm package for dashboard
juzhiyuan commented on pull request #1766: URL: https://github.com/apache/apisix-dashboard/pull/1766#issuecomment-819169754 please request reviews -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1767: change: remove listen.host from api/conf/conf.yaml
juzhiyuan commented on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819169639 bugfix or feature? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers merged pull request #363: test: add e2e test cases for request-validation plugin
tokers merged pull request #363: URL: https://github.com/apache/apisix-ingress-controller/pull/363 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: test: add e2e test cases for request-validation plugin (#363)
This is an automated email from the ASF dual-hosted git repository.
tokers pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new 91a6f1f test: add e2e test cases for request-validation plugin (#363)
91a6f1f is described below
commit 91a6f1fe85a57882f1b2f388e4286d13ad55c227
Author: Alex Zhang
AuthorDate: Wed Apr 14 10:05:56 2021 +0800
test: add e2e test cases for request-validation plugin (#363)
---
conf/config-default.yaml | 2 +-
test/e2e/plugins/request-validation.go | 196 +
2 files changed, 197 insertions(+), 1 deletion(-)
diff --git a/conf/config-default.yaml b/conf/config-default.yaml
index fd890a5..e255b18 100644
--- a/conf/config-default.yaml
+++ b/conf/config-default.yaml
@@ -57,4 +57,4 @@ kubernetes:
# APISIX related configurations.
apisix:
base_url: "http://127.0.0.1:9080/apisix/admin; # the APISIX admin api /
manager api
- # base url, it's required.
+ # base url, it's required.
diff --git a/test/e2e/plugins/request-validation.go
b/test/e2e/plugins/request-validation.go
new file mode 100644
index 000..12e3758
--- /dev/null
+++ b/test/e2e/plugins/request-validation.go
@@ -0,0 +1,196 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+package plugins
+
+import (
+ "fmt"
+
+ "github.com/apache/apisix-ingress-controller/test/e2e/scaffold"
+ "github.com/onsi/ginkgo"
+ "github.com/stretchr/testify/assert"
+)
+
+var _ = ginkgo.Describe("redirect plugin", func() {
+ opts := {
+ Name:"default",
+ Kubeconfig: scaffold.GetKubeconfig(),
+ APISIXConfigPath:"testdata/apisix-gw-config.yaml",
+ APISIXDefaultConfigPath:
"testdata/apisix-gw-config-default.yaml",
+ IngressAPISIXReplicas: 1,
+ HTTPBinServicePort: 80,
+ APISIXRouteVersion: "apisix.apache.org/v2alpha1",
+ }
+ s := scaffold.NewScaffold(opts)
+ ginkgo.It("sanity", func() {
+ backendSvc, backendPorts := s.DefaultHTTPBackend()
+ ar := fmt.Sprintf(`
+apiVersion: apisix.apache.org/v2alpha1
+kind: ApisixRoute
+metadata:
+ name: httpbin-route
+spec:
+ http:
+ - name: rule1
+ match:
+ hosts:
+ - httpbin.org
+ paths:
+ - /post
+ backends:
+ - serviceName: %s
+ servicePort: %d
+ weight: 10
+ plugins:
+ - name: request-validation
+ enable: true
+ config:
+ body_schema:
+ type: object
+ properties:
+ name:
+ type: string
+ minLength: 5
+ id:
+ type: integer
+ minimum: 20
+ required:
+ - id
+ header_schema:
+ type: object
+ properties:
+ user-agent:
+ type: string
+ pattern: .*Mozilla.*
+`, backendSvc, backendPorts[0])
+
+ assert.Nil(ginkgo.GinkgoT(), s.CreateResourceFromString(ar))
+ err := s.EnsureNumApisixUpstreamsCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of
upstreams")
+ err = s.EnsureNumApisixRoutesCreated(1)
+ assert.Nil(ginkgo.GinkgoT(), err, "Checking number of routes")
+ // header schema check failure.
+ resp := s.NewAPISIXClient().POST("/post").WithHeader("Host",
"httpbin.org").WithHeader("User-Agent", "bad-ua").Expect()
+ resp.Status(400)
+
+ payload := []byte(`
+{
+"name": "bob",
+"id": 33
+}
+ `)
+ // body schema check failure.
+ resp = s.NewAPISIXClient().POST("/post").WithHeader("Host",
"httpbin.org").WithHeader("User-Agent",
"aaaMozillabb").WithBytes(payload).Expect()
+ resp.Status(400)
+
+ payload = []byte(`
+{
+"name": "long-name",
+"id": 11
+}
+ `)
+ // body schema check failure.
+ resp =
[GitHub] [apisix-ingress-controller] tokers opened a new pull request #369: chore: remove apisix service related codes
tokers opened a new pull request #369: URL: https://github.com/apache/apisix-ingress-controller/pull/369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #348: bug: failed to sync route configuration to apisix
tokers commented on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819165093 @sniper-xx You may try to set the log level to debug and paste more and more error log here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] edited a comment on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* ready! Built with commit 06c806496fb8d7e1e3bc08b101129230154b8cf0 https://deploy-preview-1767--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 Deploy preview for *apisix-dashboard* ready! Built with commit 0efb744931c5e776d80cd1ae5ca25fc38e5d90ff https://deploy-preview-1764--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1767: change: remove listen.host from api/conf/conf.yaml
netlify[bot] commented on pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767#issuecomment-819160964 Deploy preview for *apisix-dashboard* processing. Building with commit 06c806496fb8d7e1e3bc08b101129230154b8cf0 https://app.netlify.com/sites/apisix-dashboard/deploys/607648a30423c7000775bb2a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1767: change: remove listen.host from api/conf/conf.yaml
nic-chen opened a new pull request #1767: URL: https://github.com/apache/apisix-dashboard/pull/1767 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches The configuration item `listen.host` in conf.yaml often confuses users, because when the configuration dashboard can be accessed non-locally, two places need to be modified (the other place is allow_list). remove the `listen.host` configuration item from conf.yaml, but retain the feature, and users can add it when they need it. **What changes will this PR take into?** remove listen.host from api/conf/conf.yaml set ServerHost in the code to an empty string **Related issues** fix/resolve #1743 **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers edited a comment on issue #348: bug: failed to sync route configuration to apisix
tokers edited a comment on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819160494 The deployment of apisix-ingress-controller looks very well except for the configuration of `config.apisix.baseURL`. ``` --set config.apisix.baseURL=http://192.168.2.100:9080/apisix/admin \ ``` How did you deploy APISIX? Does the Admin API really listens on `9080`, If you deploy it just by helm, the Admin API should listens on `9180`. The `object missing primary index` is reported when the controller trying to insert data to the in-memory cache but violating the schema. I have tried your YAML file but cannot reproduce this problem on my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #348: bug: failed to sync route configuration to apisix
tokers commented on issue #348: URL: https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819160494 The deployment of apisix-ingress-controller looks very well except for the configuration of `config.apisix.baseURL`. ``` --set config.apisix.baseURL=http://192.168.2.100:9080/apisix/admin \ ``` How did you deploy APISIX? Does the Admin API really listens on `9080`, If you deploy it just by helm, the Admin API should listens on `9180`. The `object missing primary index` is reported when the controller trying to insert data to the in-memory cache but violating the schema. I have tried your YAML file but cannot reproduce this problem in my side. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1766: feat: support auto build rpm package for dashboard
netlify[bot] edited a comment on pull request #1766: URL: https://github.com/apache/apisix-dashboard/pull/1766#issuecomment-819156902 Deploy preview for *apisix-dashboard* ready! Built with commit be5545a2b9888ed624a7f8b335ef0b85c9aab0d8 https://deploy-preview-1766--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 Deploy preview for *apisix-dashboard* processing. Building with commit 0efb744931c5e776d80cd1ae5ca25fc38e5d90ff https://app.netlify.com/sites/apisix-dashboard/deploys/607646e75773f10007f376f5 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1765: docs: Update api documentation
netlify[bot] edited a comment on pull request #1765: URL: https://github.com/apache/apisix-dashboard/pull/1765#issuecomment-819155051 Deploy preview for *apisix-dashboard* ready! Built with commit 56ff275c0c19489f7b91f7d3f23df61b9374a7c8 https://deploy-preview-1765--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1766: feat: support auto build rpm package for dashboard
nic-chen opened a new pull request #1766: URL: https://github.com/apache/apisix-dashboard/pull/1766 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** support auto build rpm package for dashboard **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [x] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1766: feat: support auto build rpm package for dashboard
netlify[bot] commented on pull request #1766: URL: https://github.com/apache/apisix-dashboard/pull/1766#issuecomment-819156902 Deploy preview for *apisix-dashboard* processing. Building with commit be5545a2b9888ed624a7f8b335ef0b85c9aab0d8 https://app.netlify.com/sites/apisix-dashboard/deploys/6076454029f7b200085ccf7c -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 Deploy preview for *apisix-dashboard* ready! Built with commit e16ac2ae97addab37efae1233b012b719edc3a5c https://deploy-preview-1764--apisix-dashboard.netlify.app -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] membphis opened a new issue #307: update the architecture diagram
membphis opened a new issue #307: URL: https://github.com/apache/apisix-website/issues/307 current:  change to:  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #1765: docs: Update api documentation
nic-chen opened a new pull request #1765: URL: https://github.com/apache/apisix-dashboard/pull/1765 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches - [x] Docs **What changes will this PR take into?** Update api documentation **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] commented on pull request #1765: docs: Update api documentation
netlify[bot] commented on pull request #1765: URL: https://github.com/apache/apisix-dashboard/pull/1765#issuecomment-819155051 Deploy preview for *apisix-dashboard* processing. Building with commit 56ff275c0c19489f7b91f7d3f23df61b9374a7c8 https://app.netlify.com/sites/apisix-dashboard/deploys/6076448b3822f800073c3b91 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] netlify[bot] edited a comment on pull request #1764: chore: added Feilds to Upstream module
netlify[bot] edited a comment on pull request #1764: URL: https://github.com/apache/apisix-dashboard/pull/1764#issuecomment-818545343 Deploy preview for *apisix-dashboard* processing. Building with commit e16ac2ae97addab37efae1233b012b719edc3a5c https://app.netlify.com/sites/apisix-dashboard/deploys/607642cce8fdc5000760670a -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1740: feat: Added fault-injection plugin form
LiteSun commented on a change in pull request #1740:
URL: https://github.com/apache/apisix-dashboard/pull/1740#discussion_r612871943
##
File path: web/src/components/Plugin/UI/fault-injection.tsx
##
@@ -0,0 +1,201 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+import React from 'react';
+import type { FormInstance } from 'antd/es/form';
+import { Button, Form, Input, InputNumber, Select } from 'antd';
+import { MinusCircleOutlined, PlusOutlined } from '@ant-design/icons';
+import { useIntl } from 'umi';
+
+type Props = {
+ form: FormInstance;
+};
+
+const FORM_ITEM_LAYOUT = {
+ labelCol: {
+span: 6,
+ },
+ wrapperCol: {
+span: 7,
+ },
+};
+
+const FORM_LIST_LAYOUT = {
+ labelCol: {
+span: 6,
+ },
+ wrapperCol: {
+span: 10,
+ },
+};
+
+const FORM_ITEM_WITHOUT_LABEL = {
+ wrapperCol: {
+sm: { span: 10, offset: 6 },
+ },
+};
+
+const FaultInjection: React.FC = ({ form }) => {
+ const { formatMessage } = useIntl()
+
+ return (
+
+
+
+
+
+
+
+
+
+
+
+
Review comment:
We need to convert the var to the following: ` "vars": [
[
[ "arg_name","==","jack" ]
]
]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] Majalian opened a new pull request #4044: README.md
Majalian opened a new pull request #4044: URL: https://github.com/apache/apisix/pull/4044 Arabic translation of README.md ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #303: chore: add alpha channel to showcase image for dark mode
juzhiyuan commented on pull request #303: URL: https://github.com/apache/apisix-website/pull/303#issuecomment-819149657   Wow, I see so many images got updated, but some images seem broken or too dark? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on a change in pull request #1633: feat: add the service page upstream select option
juzhiyuan commented on a change in pull request #1633:
URL: https://github.com/apache/apisix-dashboard/pull/1633#discussion_r612868817
##
File path: web/src/components/Upstream/components/UpstreamSelector.tsx
##
@@ -61,6 +60,9 @@ const Component: React.FC = ({ shouldUpdate, onChange,
list = [], disable
{item.name}
))}
+{
Review comment:
oh yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-website] tokers commented on a change in pull request #306: fix: broken link in release guide
tokers commented on a change in pull request #306: URL: https://github.com/apache/apisix-website/pull/306#discussion_r612868179 ## File path: website/docs/general/release-guide.md ## @@ -324,7 +324,7 @@ Invite [PMCs](https://apisix.apache.org/team/) to move KEYS and package under th ### Update Download page -The [Download](https://github.com/apache/apisix-website) page contains links for Apache APISIX, Apache APISIX Dashboard, and other sources, and we need to update its contents [here](https://github.com/apache/apisix-website/blob/master/docs/download.md). +The [Download](https://github.com/apache/apisix-website) page contains links for Apache APISIX, Apache APISIX Dashboard, and other sources, and we need to update its contents [here](https://github.com/apache/apisix-website/blob/master/website/src/pages/downloads/index.js). Review comment: I think we should use this [link](https://github.com/apache/apisix-website/blob/master/website/docusaurus.config.js). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-docker] tokers commented on a change in pull request #161: docs: Replace `docker build` command with `make`
tokers commented on a change in pull request #161:
URL: https://github.com/apache/apisix-docker/pull/161#discussion_r612866389
##
File path: README.md
##
@@ -11,27 +11,27 @@
# Assign Apache release version number to variable `APISIX_VERSION`, for
example: 2.4. The latest version can be find at
`https://github.com/apache/apisix/releases`
export APISIX_VERSION=2.4
-docker build -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
+make -t apisix:${APISIX_VERSION}-alpine --build-arg
APISIX_VERSION=${APISIX_VERSION} -f alpine/Dockerfile alpine
Review comment:
```suggestion
# alpine
make build-on-alpine
# centos
make build-on-centos
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] sniper-xx commented on issue #348: bug: failed to sync route configuration to apisix
sniper-xx commented on issue #348:
URL:
https://github.com/apache/apisix-ingress-controller/issues/348#issuecomment-819145461
@tokers I upgrade apisix-ingress-controller to version 0.5.0，but the error
is same.
```bash
2021-04-14T08:51:11+08:00warncontroller/apisix_route.go:205 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"quickstart-system/subscriber-ingress-v2","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null},
"error": "2 errors occurred:\n\t* object missing primary index\n\t* object
missing primary index\n\n"}
2021-04-14T08:51:12+08:00warncontroller/apisix_route.go:205 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"quickstart-system/subscriber-ingress-v2","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null},
"error": "2 errors occurred:\n\t* object missing primary index\n\t* object
missing primary index\n\n"}
2021-04-14T08:51:12+08:00warncontroller/endpoint.go:93 service
kube-system/kube-controller-manager was deleted
2021-04-14T08:51:12+08:00warncontroller/endpoint.go:93 service
kube-system/kube-scheduler was deleted
2021-04-14T08:51:13+08:00warncontroller/apisix_route.go:205 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"quickstart-system/subscriber-ingress-v2","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null},
"error": "2 errors occurred:\n\t* object missing primary index\n\t* object
missing primary index\n\n"}
[GIN] 2021/04/14 - 08:51:14 | 200 | 31.285µs | 172.24.23.132 | GET
"/healthz"
2021-04-14T08:51:14+08:00warncontroller/apisix_route.go:205 sync
ApisixRoute failed, will retry {"object":
{"Type":1,"Object":{"Key":"quickstart-system/subscriber-ingress-v2","OldObject":null,"GroupVersion":"apisix.apache.org/v2alpha1"},"Tombstone":null},
"error": "2 errors occurred:\n\t* object missing primary index\n\t* object
missing primary index\n\n"}
2021-04-14T08:51:14+08:00warncontroller/endpoint.go:93 service
kube-system/kube-controller-manager was deleted
2021-04-14T08:51:14+08:00warncontroller/endpoint.go:93 service
kube-system/kube-scheduler was deleted
2021-04-14T08:51:16+08:00warncontroller/endpoint.go:93 service
kube-system/kube-controller-manager was deleted
2021-04-14T08:51:16+08:00warncontroller/endpoint.go:93 service
kube-system/kube-scheduler was deleted
E0414 08:51:17.323673 1 reflector.go:138]
pkg/mod/k8s.io/client-go@v0.20.2/tools/cache/reflector.go:167: Failed to watch
*v1.Ingress: failed to list *v1.Ingress: the server could not find the
requested resource
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #1749: chore: update Service module
juzhiyuan commented on pull request #1749: URL: https://github.com/apache/apisix-dashboard/pull/1749#issuecomment-819145143 ping @LiteSun @bzp2010 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
