[GitHub] [apisix] MizuhaHimuraki opened a new issue #5608: request help: apisix cannot connect to etcd when etcd auth enabled
MizuhaHimuraki opened a new issue #5608:
URL: https://github.com/apache/apisix/issues/5608
### Issue description
Apisix cannot work when etcd auth is enabled, but apisix-dashboard does.
Did I miss any key configuration items?
STEP 1: create the etcd user and role
```
#etcdctl role get apisix
Role apisix
KV Read:
[/apisix, /apisiy) (prefix /apisix)
KV Write:
[/apisix, /apisiy) (prefix /apisix)
```
STEP 2: enable etcd auth
```
#etcdctl auth enable
Authentication Enabled
```
STEP 3: create apisix ssl pems
```
#cat apisix-csr.json
{
"CN": "apisix",
"hosts": [
],
"key": {
"algo": "rsa",
"size": 2048
},
"names": [
{
"C": "CN",
"ST": "DUMMY",
"L": "DUMMY",
"O": "etcd",
"OU": "DUMMY"
}
]
}
```
STEP 4: make the etcd tls config
```
# cat conf/config.yaml
nginx_config:
http:
lua_shared_dicts:
s_cache: 8m
enable_cpu_affinity: false
apisix:
node_listen: 80
ssl:
listen_port: 443
ssl_trusted_certificate: /etc/pki/tls/certs/ca-bundle.crt
key_encrypt_salt: -
allow_admin: [ 127.0.0.0/24, 0.0.0.0/0 ]
enable_ipv6: false
admin_key:
- name: "admin"
key: -
role: admin
etcd:
host: [
https://prod-k8s0.x.com:2379,https://prod-k8s1.x.com:2379,https://prod-k8s2.x.com:2379
]
prefix: /apisix-7ac5eb62
timeout: 10
health_check_timeout: 60
ssl_trusted_certificate: /tmp/ca.pem
tls:
verify: true
cert: /tmp/apisix.pem
key: /tmp/apisix-key.pem
```
STEP 5 boot apisix
```
# apisix start
/usr/bin/apisix: line 32: which: command not found
lua /usr/local/apisix/apisix/cli/apisix.lua start
lua_shared_dicts is deprecated, use custom_lua_shared_dict instead
nginx: [error] [lua] init.lua:86: http_init(): failed to load the
configuration: failed to read etcd dir
# etcdctl get --prefix /api
```
STEP 6 try use dashboard with same etcd TLS config create a new route
```
# cat
..
etcd:
endpoints:
- https://prod-k8s0.x.com:2379
- https://prod-k8s1.x.com:2379
- https://prod-k8s2.x.com:2379
mtls:
key_file: " /tmp/apisix-key.pem"
cert_file: "/tmp/apisix.pem"
ca_file: "/tmp/ca.pem"
prefix: /apisix-7ac5eb62
..
```
```
# etcdctl get --prefix /api
/apisix-7ac5eb62/routes/383017729642202494
{"id":"383017729642202494","create_time":1637825957,"update_time":1637825957,"uri":"/*","name":"1","methods":["GET","POST","PUT","DELETE","PATCH","HEAD","OPTIONS","CONNECT","TRACE"],"host":"test.x.om","upstream":{"nodes":{"127.0.0.1:9000":1},"timeout":{"connect":6,"send":6,"read":6},"type":"roundrobin","scheme":"http","pass_host":"pass","keepalive_pool":{"idle_timeout":60,"requests":1000,"size":320}},"labels":{"API_VERSION":"1"},"status":1}
```
STEP 7 disable etcd auth and reboot apisix
```
# etcdctl get --prefix /api
/apisix-7ac5eb62/consumers/
init_dir
/apisix-7ac5eb62/global_rules/
init_dir
/apisix-7ac5eb62/plugin_configs/
init_dir
/apisix-7ac5eb62/plugin_metadata/
init_dir
/apisix-7ac5eb62/plugins/
init_dir
/apisix-7ac5eb62/proto/
init_dir
/apisix-7ac5eb62/routes/
init_dir
/apisix-7ac5eb62/services/
init_dir
/apisix-7ac5eb62/ssl/
init_dir
/apisix-7ac5eb62/stream_routes/
init_dir
/apisix-7ac5eb62/upstreams/
init_dir
/apisix-7ac5eb62/routes/383017729642202494
{"id":"383017729642202494","create_time":1637825957,"update_time":1637825957,"uri":"/*","name":"1","methods":["GET","POST","PUT","DELETE","PATCH","HEAD","OPTIONS","CONNECT","TRACE"],"host":"test.x.om","upstream":{"nodes":{"127.0.0.1:9000":1},"timeout":{"connect":6,"send":6,"read":6},"type":"roundrobin","scheme":"http","pass_host":"pass","keepalive_pool":{"idle_timeout":60,"requests":1000,"size":320}},"labels":{"API_VERSION":"1"},"status":1}
```
### Environment
- apisix version : 2.10.1
- OS : docker image: centos:7
- OpenResty / Nginx version : nginx version: openresty/1.19.9.1
- etcd version: etcd Version: 3.4.3
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-helm-chart] tao12345666333 commented on issue #182: feat: add service monitor for main chart
tao12345666333 commented on issue #182: URL: https://github.com/apache/apisix-helm-chart/issues/182#issuecomment-978919499 Sounds good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] webup opened a new issue #182: feat: add service monitor for main chart
webup opened a new issue #182: URL: https://github.com/apache/apisix-helm-chart/issues/182 We already have service monitor for ingress controller (#76), shall we make it available also for main chart? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] wangzhilin90 opened a new issue #181: dashboard report 404
wangzhilin90 opened a new issue #181: URL: https://github.com/apache/apisix-helm-chart/issues/181 1.install apisix success   2.lb's ip is 192.168.8.240  3.when i want to open dashboard,it report 404,why?  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5607: bug: traffic-split err
tzssangglass commented on issue #5607: URL: https://github.com/apache/apisix/issues/5607#issuecomment-978910902 can you test this on master branch? we have solved a bug releated to this:https://github.com/apache/apisix/pull/5414/files -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jagerzhang edited a comment on issue #5604: bug: The latency of request is not stable as expected
jagerzhang edited a comment on issue #5604: URL: https://github.com/apache/apisix/issues/5604#issuecomment-978903474 > Have you tried to observe and analyze by capturing packets? @shuaijinchao 刚抓包分析了下，抓包命令： `tcpdump -iany -nn port 9080 or port 8000 or port 8001 -vvv -w start_test.cap` 找到其中耗时14ms的请求看了下详情，APISIX到Nginx之间耗时仅0.04ms，APISIX 耗时有 14ms：  完整抓包文件： [start_test.cap.zip](https://github.com/apache/apisix/files/7600967/start_test.cap.zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jagerzhang edited a comment on issue #5604: bug: The latency of request is not stable as expected
jagerzhang edited a comment on issue #5604: URL: https://github.com/apache/apisix/issues/5604#issuecomment-978903474 > Have you tried to observe and analyze by capturing packets? @shuaijinchao 刚抓包分析了下，抓包命令： `tcpdump -iany -nn port 9080 or port 8000 or port 8001 -vvv -w start_test.cap` 找到其中耗时14ms的请求看了下详情，APISIX到Nginx之间耗时之后0.04ms，APISIX却耗时14ms：  完整抓包文件： [start_test.cap.zip](https://github.com/apache/apisix/files/7600967/start_test.cap.zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jagerzhang commented on issue #5604: bug: The latency of request is not stable as expected
jagerzhang commented on issue #5604: URL: https://github.com/apache/apisix/issues/5604#issuecomment-978903474 > Have you tried to observe and analyze by capturing packets? @shuaijinchao 刚抓包分析了下，找到其中耗时14ms的请求看了下详情，APISIX到Nginx之间耗时之后0.04ms，APISIX却耗时14ms：  完整抓包文件： [start_test.cap.zip](https://github.com/apache/apisix/files/7600967/start_test.cap.zip) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #61: bug: Can not connect java plugin with apache apisix container
tzssangglass commented on issue #61: URL: https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-978902832 Obviously this is a permissions issue with docker. I would recommend developing under linux. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis merged pull request #5601: ci: improve dns configures override
membphis merged pull request #5601: URL: https://github.com/apache/apisix/pull/5601 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: ci(bug): Improve DNS settings (#5601)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 783b387 ci(bug): Improve DNS settings (#5601) 783b387 is described below commit 783b387f8167a52d5df8fa02c46d72fcab9b506c Author: Zeping Bai AuthorDate: Thu Nov 25 15:20:43 2021 +0800 ci(bug): Improve DNS settings (#5601) CentOS docker: use `--dns` parameter Ubuntu: use `netplan` --- .github/workflows/centos7-ci.yml | 2 +- utils/set-dns.sh | 20 ++-- 2 files changed, 19 insertions(+), 3 deletions(-) diff --git a/.github/workflows/centos7-ci.yml b/.github/workflows/centos7-ci.yml index 5f9f6ec..db5ad0b 100644 --- a/.github/workflows/centos7-ci.yml +++ b/.github/workflows/centos7-ci.yml @@ -57,7 +57,7 @@ jobs: - name: Run centos7 docker and mapping apisix into container run: | -docker run -itd -v /home/runner/work/apisix/apisix:/apisix --name centos7Instance --net="host" docker.io/centos:7 /bin/bash +docker run -itd -v /home/runner/work/apisix/apisix:/apisix --name centos7Instance --net="host" --dns 8.8.8.8 --dns-search apache.org docker.io/centos:7 /bin/bash # docker exec centos7Instance bash -c "cp -r /tmp/apisix ./" - name: Run other docker containers for test diff --git a/utils/set-dns.sh b/utils/set-dns.sh index 53970a7..2c7689d 100755 --- a/utils/set-dns.sh +++ b/utils/set-dns.sh @@ -25,8 +25,24 @@ echo "127.0.0.1 test.com" | sudo tee -a /etc/hosts echo "127.0.0.1 admin.apisix.dev" | sudo tee -a /etc/hosts cat /etc/hosts # check GitHub Action's configuration -echo "nameserver 8.8.8.8" | sudo tee /etc/resolv.conf -echo "search apache.org" | sudo tee -a /etc/resolv.conf +# override DNS configures +if [ -f "/etc/netplan/50-cloud-init.yaml" ]; then +sudo pip3 install yq + +tmp=$(mktemp) +yq -y '.network.ethernets.eth0."dhcp4-overrides"."use-dns"=false' /etc/netplan/50-cloud-init.yaml | \ +yq -y '.network.ethernets.eth0."dhcp4-overrides"."use-domains"=false' | \ +yq -y '.network.ethernets.eth0.nameservers.addresses[0]="8.8.8.8"' | \ +yq -y '.network.ethernets.eth0.nameservers.search[0]="apache.org"' > $tmp +mv $tmp /etc/netplan/50-cloud-init.yaml +cat /etc/netplan/50-cloud-init.yaml +sudo netplan apply +sleep 3 + +sudo mv /etc/resolv.conf /etc/resolv.conf.bak +sudo ln -s /run/systemd/resolve/resolv.conf /etc/ +fi +cat /etc/resolv.conf mkdir -p build-cache
[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #61: bug: Can not connect java plugin with apache apisix container
cws1981 edited a comment on issue #61: URL: https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-978884628 this is my Dockerfile: ``` FROM apache/apisix:2.10.0-alpine RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" /etc/apk/repositories && apk add --no-cache openjdk11-jre-headless ADD apisix-java-plugin-runner.jar /usr/local/apisix-java-plugin-runner.jar ``` i rebuild docker images add apisix-java-plugin-runner.jar,but when i running, it outputs errors in the error.log: ` 2021/11/25 06:33:31 [crit] 44#44: *2280 connect() to unix:/usr/local/apisix/conf/apisix-1.sock failed (13: Permission denied) ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #770: feat: implement apisix healthz check
codecov-commenter edited a comment on pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#issuecomment-978870409 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#770](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1779ece) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b127ff4) will **increase** coverage by `0.04%`. > The diff coverage is `56.25%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #770 +/- ## == + Coverage 32.50% 32.54% +0.04% == Files 66 67 +1 Lines6800 6815 +15 == + Hits 2210 2218 +8 - Misses 4340 4346 +6 - Partials 250 251 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `72.72% <ø> (-2.28%)` | :arrow_down: | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.00% <0.00%> (-0.01%)` | :arrow_down: | | [pkg/api/router/apisix\_healthz.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvYXBpc2l4X2hlYWx0aHouZ28=) | `63.63% <63.63%> (ø)` | | | [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | `82.27% <100.00%> (+0.46%)` | :arrow_up: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [b127ff4...1779ece](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #772: feat: implement pluginconfig clients (#638)
codecov-commenter edited a comment on pull request #772: URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (314d819) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b127ff4) will **decrease** coverage by `0.09%`. > The diff coverage is `42.12%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #772 +/- ## == - Coverage 32.50% 32.40% -0.10% == Files 66 66 Lines6800 6993 +193 == + Hits 2210 2266 +56 - Misses 4340 4452 +112 - Partials 250 275 +25 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | | | [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `62.26% <0.00%> (-2.45%)` | :arrow_down: | | [pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=) | `37.33% <37.33%> (ø)` | | | [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `38.81% <42.50%> (-2.98%)` | :arrow_down: | | [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `60.27% <66.66%> (+0.57%)` | :arrow_up: | | [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `75.12% <76.47%> (+0.12%)` | :arrow_up: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.18% <100.00%> (-3.15%)` | :arrow_down: | | [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `36.91% <0.00%> (-2.02%)` | :arrow_down: | | ... and [1 more](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree-more_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | | --
[GitHub] [apisix-ingress-controller] neverCase commented on pull request #772: feat: implement pluginconfig clients (#638)
neverCase commented on pull request #772: URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978892163 @tao12345666333 hi, i'm ok. I had add the missing license header. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #772: feat: implement pluginconfig clients (#638)
codecov-commenter commented on pull request #772: URL: https://github.com/apache/apisix-ingress-controller/pull/772#issuecomment-978891422 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#772](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0662b5f) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b127ff4) will **increase** coverage by `0.18%`. > The diff coverage is `42.12%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #772 +/- ## == + Coverage 32.50% 32.68% +0.18% == Files 66 66 Lines6800 6993 +193 == + Hits 2210 2286 +76 - Misses 4340 4439 +99 - Partials 250 268 +18 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/apisix/apisix.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9hcGlzaXguZ28=) | `67.50% <ø> (ø)` | | | [pkg/apisix/schema.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9zY2hlbWEuZ28=) | `62.26% <0.00%> (-2.45%)` | :arrow_down: | | [pkg/apisix/pluginconfig.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW5jb25maWcuZ28=) | `37.33% <37.33%> (ø)` | | | [pkg/apisix/nonexistentclient.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9ub25leGlzdGVudGNsaWVudC5nbw==) | `38.81% <42.50%> (-2.98%)` | :arrow_down: | | [pkg/apisix/resource.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yZXNvdXJjZS5nbw==) | `60.27% <66.66%> (+0.57%)` | :arrow_up: | | [pkg/apisix/cache/memdb.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jYWNoZS9tZW1kYi5nbw==) | `75.12% <76.47%> (+0.12%)` | :arrow_up: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `33.49% <100.00%> (+0.15%)` | :arrow_up: | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/772?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by
[GitHub] [apisix-ingress-controller] neverCase opened a new pull request #772: feat: implement pluginconfig clients (#638)
neverCase opened a new pull request #772: URL: https://github.com/apache/apisix-ingress-controller/pull/772 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues #638 ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. ___ ### Backport patches - Why need to backport? - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xianshun163 opened a new issue #5607: bug: traffic-split err
xianshun163 opened a new issue #5607:
URL: https://github.com/apache/apisix/issues/5607
### Issue description
the traffic-split make some error, as the error log show
### Environment
- apisix version (cmd: `apisix version`): 2.10.1
- OS (cmd: `uname -a`): CentOS Linux release 7.6.1810 (Core)
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):nginx
version: openresty/1.19.9.1
- etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info
API):"etcd_version":"3.4.0",
- apisix-dashboard version, if have: 2.10.1
- the plugin runner version, if the issue is about a plugin runner (cmd:
depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
### Steps to reproduce
1、I create a rule like this: the upstream is a simple java app server
curl http://127.0.0.1:9080/apisix/admin/routes/xs-app-r1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/index",
"name": "蓝绿发布",
"host": "local.xsapp.org",
"plugins": {
"traffic-split": {
"rules": [
{
"match": [
{
"vars": [
["http_release","==","new_release"]
]
}
],
"weighted_upstreams": [
{
"upstream_id": "382981255605519758",
"weight": 2
},
{
"weight": 1
}
]
}
]
}
},
"upstream_id": "382981468860712334"
}'
2、I open a global plugin key-auth in the dashboard
3、I test it like this : curl http://127.0.0.1:9080/index -H 'release:
new_release' -H 'Host: local.xsapp.org' -H "apikey: key-of-sam"
4、sometimes it work ， some time it make a error， as the error log show。
5、And then I go to print some error log in the lua file, you can see
it at the error log.
### Actual result
as the error log show
### Error log
2021/11/25 14:03:47 [warn] 24989#24989: *39085296 [lua] lrucache.lua:92:
lrucache(): xs---begin to create_obj_fun---,key:table: 0x7f76788384f8,
client: 127.0.0.1, server: _, request: "GET /index HTTP/1.1", host:
"local.xsapp.org"
2021/11/25 14:03:47 [error] 24989#24989: *39085296 [lua]
traffic-split.lua:202: create_obj_fun(): ---xs--
upstream_obj:{"upstream_id":"382981255605519758","weight":2}, client:
127.0.0.1, server: _, request: "GET /index HTTP/1.1", host: "local.xsapp.org"
2021/11/25 14:03:47 [error] 24989#24989: *39085296 [lua]
traffic-split.lua:205: create_obj_fun(): -xs---
upstream_id:382981255605519758, client: 127.0.0.1, server: _, request: "GET
/index HTTP/1.1", host: "local.xsapp.org"
2021/11/25 14:03:47 [error] 24989#24989: *39085296 [lua]
traffic-split.lua:202: create_obj_fun(): ---xs--
upstream_obj:{"upstream":"plugin#upstream#is#empty","weight":1}, client:
127.0.0.1, server: _, request: "GET /index HTTP/1.1", host: "local.xsapp.org"
2021/11/25 14:03:47 [error] 24989#24989: *39085296 [lua]
traffic-split.lua:209: create_obj_fun(): xs--- upstream is not
null:plugin#upstream#is#empty, client: 127.0.0.1, server: _, request: "GET
/index HTTP/1.1", host: "local.xsapp.org"
2021/11/25 14:03:47 [error] 24989#24989: *39085296 lua entry thread aborted:
runtime error: /data/apisix-2.10.1/apisix/plugins/traffic-split.lua:210:
attempt to index field 'upstream' (a string value)
stack traceback:
coroutine 0:
/data/apisix-2.10.1/apisix/plugins/traffic-split.lua: in function
'create_obj_fun'
/data/apisix-2.10.1/apisix/core/lrucache.lua:93: in function
'lrucache'
/data/apisix-2.10.1/apisix/plugins/traffic-split.lua:268: in
function 'phase_func'
/data/apisix-2.10.1/apisix/plugin.lua:683: in function 'run_plugin'
/data/apisix-2.10.1/apisix/init.lua:465: in function
'http_access_phase'
access_by_lua(nginx.conf:264):2: in main chunk, client: 127.0.0.1,
server: _, request: "GET /index HTTP/1.1", host: "local.xsapp.org"
- this is my traffic-split.lua
198 local function new_rr_obj(weighted_upstreams)
199 local server_list = {}
200 --
core.log.error("---xs--upstream_obj:",core.json.delay_encode(weighted_upstreams,true))
201 for i, upstream_obj in ipairs(weighted_upstreams) do
202core.log.error("---xs--
upstream_obj:",core.json.delay_encode(upstream_obj,true))
203
204if
[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #61: bug: Can not connect java plugin with apache apisix container
cws1981 edited a comment on issue #61: URL: https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-978884628 this is my Dockerfile: ` FROM apache/apisix:2.10.0-alpine RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" /etc/apk/repositories && apk add --no-cache openjdk11-jre-headless ADD apisix-java-plugin-runner.jar /usr/local/apisix-java-plugin-runner.jar ` i rebuild docker images add apisix-java-plugin-runner.jar,but when i running, it outputs errors in the error.log: ` 2021/11/25 06:33:31 [crit] 44#44: *2280 connect() to unix:/usr/local/apisix/conf/apisix-1.sock failed (13: Permission denied) ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] cws1981 edited a comment on issue #61: bug: Can not connect java plugin with apache apisix container
cws1981 edited a comment on issue #61: URL: https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-978884628 this is my Dockerfile: ``` FROM apache/apisix:2.10.0-alpine RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" /etc/apk/repositories && apk add --no-cache openjdk11-jre-headless ADD apisix-java-plugin-runner.jar /usr/local/apisix-java-plugin-runner.jar ``` i rebuild docker images add apisix-java-plugin-runner.jar,but when i running, it outputs errors in the error.log: ` 2021/11/25 06:33:31 [crit] 44#44: *2280 connect() to unix:/usr/local/apisix/conf/apisix-1.sock failed (13: Permission denied) ` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] cws1981 commented on issue #61: bug: Can not connect java plugin with apache apisix container
cws1981 commented on issue #61: URL: https://github.com/apache/apisix-java-plugin-runner/issues/61#issuecomment-978884628 this is my Dockerfile: `FROM apache/apisix:2.10.0-alpine RUN sed -i "s/dl-cdn.alpinelinux.org/mirrors.aliyun.com/g" /etc/apk/repositories && apk add --no-cache openjdk11-jre-headless ADD apisix-java-plugin-runner.jar /usr/local/apisix-java-plugin-runner.jar` i rebuild docker images add apisix-java-plugin-runner.jar,but when i running, it outputs errors in the error.log: `2021/11/25 06:33:31 [crit] 44#44: *2280 connect() to unix:/usr/local/apisix/conf/apisix-1.sock failed (13: Permission denied)` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on issue #5604: bug: The latency of request is not stable as expected
shuaijinchao commented on issue #5604: URL: https://github.com/apache/apisix/issues/5604#issuecomment-978882533 Have you tried to observe and analyze by capturing packets? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] mayocream opened a new pull request #771: chore: Issue & PR template
mayocream opened a new pull request #771: URL: https://github.com/apache/apisix-ingress-controller/pull/771 Please answer these questions before submitting a pull request - Why submit this pull request? - [x] chore - Related issues Fix #748 and #432 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao opened a new pull request #5606: docs: update documents example node ip
shuaijinchao opened a new pull request #5606: URL: https://github.com/apache/apisix/pull/5606 ### What this PR does / why we need it: LINK https://github.com/apache/apisix/pull/5603#issuecomment-978759797 ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #770: feat: implement apisix healthz check
codecov-commenter commented on pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770#issuecomment-978870409 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#770](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (1779ece) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b127ff4) will **increase** coverage by `0.03%`. > The diff coverage is `56.25%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #770 +/- ## == + Coverage 32.50% 32.53% +0.03% == Files 66 66 Lines6800 6814 +14 == + Hits 2210 2217 +7 - Misses 4340 4346 +6 - Partials 250 251 +1 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/api/router/router.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvcm91dGVyLmdv) | `72.72% <ø> (-2.28%)` | :arrow_down: | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.00% <0.00%> (-0.01%)` | :arrow_down: | | [pkg/api/router/apisix\_healthz.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9yb3V0ZXIvYXBpc2l4X2hlYWx0aHouZ28=) | `63.63% <63.63%> (ø)` | | | [pkg/api/server.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaS9zZXJ2ZXIuZ28=) | `82.27% <100.00%> (+0.46%)` | :arrow_up: | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [b127ff4...1779ece](https://codecov.io/gh/apache/apisix-ingress-controller/pull/770?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] bzp2010 commented on pull request #5601: ci: improve dns configures override
bzp2010 commented on pull request #5601: URL: https://github.com/apache/apisix/pull/5601#issuecomment-978869502 ping @spacewander @membphis -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] mayocream opened a new pull request #770: feat: implement apisix healthz check
mayocream opened a new pull request #770: URL: https://github.com/apache/apisix-ingress-controller/pull/770 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [x] New feature provided - [ ] Improve performance - [ ] Backport patches - Related issues Fix #567 ___ ### New feature or improvement - Implement apisix healthz check, sharing health check state with controller, add unit tests. Comment if something is wrong, then I'll change it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] gy09535 edited a comment on issue #2222: support Request Loading status
gy09535 edited a comment on issue #: URL: https://github.com/apache/apisix-dashboard/issues/#issuecomment-978796746 > @gy09535 It seems that you click twice DELETE button, and the first one runs successfully, and then the second request failed. > > This is more like a UX issue, you could set a loading status when Request sent, would like to improve it? @juzhiyuan It seems the api issue, I restart the dashboard service it can work rather then the browser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #772: docs: update topic to avoid displaying issue
juzhiyuan commented on pull request #772: URL: https://github.com/apache/apisix-website/pull/772#issuecomment-978821593 > I would rather call this a human-like thinking logic than a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #726: feat: add externalname support for upstream
codecov-commenter edited a comment on pull request #726: URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-965879979 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#726](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (12563f5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b127ff4) will **decrease** coverage by `0.12%`. > The diff coverage is `67.30%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #726 +/- ## == - Coverage 32.50% 32.37% -0.13% == Files 66 66 Lines6800 6836 +36 == + Hits 2210 2213 +3 - Misses 4340 4362 +22 - Partials 250 261 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `47.32% <55.55%> (+1.24%)` | :arrow_up: | | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | `32.16% <58.82%> (-0.56%)` | :arrow_down: | | [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `83.33% <88.23%> (+0.38%)` | :arrow_up: | | [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.02% <0.00%> (-3.31%)` | :arrow_down: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `36.91% <0.00%> (-2.02%)` | :arrow_down: | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [b127ff4...12563f5](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment
[GitHub] [apisix-website] yzeng25 commented on pull request #772: docs: update topic to avoid displaying issue
yzeng25 commented on pull request #772: URL: https://github.com/apache/apisix-website/pull/772#issuecomment-978815230 > Good catch!! This may be a bug from Docusaurus? Well, not necessarily. It is most people's first instinct to look at file names when the above problem occurs. File name is used to generate urls, thus duplicated file names is prohibited from the very beginning, i.e. creating two files with the same file names in the same directory is not allowed. But if you take a step back and have a look: in what kind of scenario would a person create two or more articles with the same `title`? Basically none except done by accident. With this being said, each article has a unique title is a very common-sense thing. I would rather call this a human-like thinking logic than a bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dmsolr commented on a change in pull request #5550: feat: support to log response body
dmsolr commented on a change in pull request #5550: URL: https://github.com/apache/apisix/pull/5550#discussion_r756558576 ## File path: t/plugin/http-logger.t ## @@ -108,7 +108,43 @@ done -=== TEST 4: add plugin +=== TEST 4: check log schema(include_resp_body_expr) Review comment: updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] juzhiyuan commented on pull request #772: docs: update topic to avoid displaying issue
juzhiyuan commented on pull request #772: URL: https://github.com/apache/apisix-website/pull/772#issuecomment-978811565 Good catch!! This may be a bug from Docusaurus? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] jagerzhang opened a new issue #5604: bug: The latency of request is not stable, not as expected
jagerzhang opened a new issue #5604: URL: https://github.com/apache/apisix/issues/5604 ### Issue description 最近我们开始将生产环境的业务迁移到APISIX，迁移后有业务反馈延迟增大，实测了下，延迟确实存在抖动现象，在我们的生产环境中，接入APISIX的业务正常延时是25ms左右，但是抖动的时候延迟会超过200ms，最高到了800ms，对于延迟比较敏感的业务会受到影响。 不知道该如何定位。为了排除是我们生产环境网络或者APISIX配置的问题，我这边基于官方的example也测试了下，发现在本地网络环境下也存在抖动，正常应该是0ms，但是抖动的时候会达到10ms以上，不太符合APISIX 0.2ms延迟的预期。 具体测试用例和初步结果我已经上传到了github：https://github.com/jagerzhang/apisix-latency-test 辛苦APISIX研发专家帮忙看看这个是APISIX本身的问题还是其他什么因素影响的？ 如果这个测试用例10倍抖动不算问题的话，我们的生产环境抖动该如何定位？ ### Environment - apisix version (cmd: `apisix version`): centos-2.10.2 ### Steps to reproduce 复现用例已整理上传，详见：https://github.com/jagerzhang/apisix-latency-test ### Actual result ``` cost: 13ms cost: 11ms cost: 12ms cost: 15ms cost: 11ms cost: 11ms cost: 11ms cost: 11ms cost: 13ms cost: 14ms cost: 14ms cost: 11ms cost: 13ms cost: 13ms cost: 12ms Latency stats: 0ms: 9726 0~2ms: 191 2~5ms: 32 5~10ms: 28 >10ms: 22 ``` ### Error log None ### Expected result 本地测试延迟应该在1ms左右比较正常，通过直接测试后端Nginx也可以发现延迟稳定很多。 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lemonrains commented on issue #2426: bug：enable openid-connect plugin without redirect_uri got 500 error
lemonrains commented on issue #2426: URL: https://github.com/apache/apisix/issues/2426#issuecomment-978803473 Refer the following link, I solved my problem. https://stackoverflow.com/questions/49338403/openidc-with-keycloak-error-uthenticate-request-to-the-redirect-uri-path-but >Your redirect URI must not be set to "/" but to some arbitrary path that is not supposed to return content (like /redirect_uri). It is a "vanity" URL that is handled by lua-resty-openidc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] xiaokunliu edited a comment on issue #5591: http json params to grpc service have discarded some params when using grpc transcode
xiaokunliu edited a comment on issue #5591:
URL: https://github.com/apache/apisix/issues/5591#issuecomment-978800613
yes, others could pass, but address couldnt recieved, this is my backend
grpc server log:
{"lv":"info","ts":1637747510,"caller":"grpcserver/users.go:63","msg":"UpdateUserById,uid=,user=name:\"uname\"
email:\"uemail\" userProfile: tags:1 tags:2 tags:3 hobbies:\"footboall\"
hobbies:\"basketball\" "}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] xiaokunliu commented on issue #5591: http json params to grpc service have discarded some params when using grpc transcode
xiaokunliu commented on issue #5591:
URL: https://github.com/apache/apisix/issues/5591#issuecomment-978800613
yes, others could pass, but address couldnt recieved, this is my backend
grpc server log:
{"lv":"info","ts":1637747510,"caller":"grpcserver/users.go:63","msg":"UpdateUserById,req=,user=name:\"uname\"
email:\"uemail\" userProfile: tags:1 tags:2 tags:3 hobbies:\"footboall\"
hobbies:\"basketball\" "}
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] aseaday commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
aseaday commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-978797764 Or add randomsed in apisix/patch.lua -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aseaday commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
aseaday commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-978797427 > I prefer patch `math.randomseed` way If we patch the math.randomsee globally as the [kong](https://github.com/Kong/kong/blob/fb7a68d497c1104779d650014ba6521bf129f726/kong/globalpatches.lua?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L241-L342) way, we need to add a module as the global patch. Is it a good choice to put the module in the core? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] gy09535 commented on issue #2222: support Request Loading status
gy09535 commented on issue #: URL: https://github.com/apache/apisix-dashboard/issues/#issuecomment-978796746 > @gy09535 It seems that you click twice DELETE button, and the first one runs successfully, and then the second request failed. > > This is more like a UX issue, you could set a loading status when Request sent, would like to improve it? @juzhiyuan It seems the api issue, I restart the dashboard service it can work rather then restart the browser. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #727: e2e: optimize before_each function in scaffold
tao12345666333 commented on pull request #727: URL: https://github.com/apache/apisix-ingress-controller/pull/727#issuecomment-978790749 CI still failed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #731: feat: Grafana Dashboard Configuration
tao12345666333 commented on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-978785418 Can you add a document describing how to monitor and use this dashboard? Thanks If you need any help please feel free to ping me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #726: feat: add externalname support for upstream
codecov-commenter edited a comment on pull request #726: URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-965879979 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#726](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (12563f5) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/b127ff4eb47c95fa4db3b58020d7005f739d9dbd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (b127ff4) will **decrease** coverage by `0.13%`. > The diff coverage is `67.30%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #726 +/- ## == - Coverage 32.50% 32.36% -0.14% == Files 66 65 -1 Lines6800 6835 +35 == + Hits 2210 2212 +2 - Misses 4340 4362 +22 - Partials 250 261 +11 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/translator.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdHJhbnNsYXRvci5nbw==) | `47.32% <55.55%> (+1.24%)` | :arrow_up: | | [pkg/kube/translation/util.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vdXRpbC5nbw==) | `32.16% <58.82%> (-0.56%)` | :arrow_down: | | [pkg/kube/translation/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYXBpc2l4X3Vwc3RyZWFtLmdv) | `83.33% <88.23%> (+0.38%)` | :arrow_up: | | [pkg/apisix/plugin.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9wbHVnaW4uZ28=) | `80.00% <0.00%> (-20.00%)` | :arrow_down: | | [pkg/apisix/cluster.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9jbHVzdGVyLmdv) | `30.02% <0.00%> (-3.31%)` | :arrow_down: | | [pkg/apisix/route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2FwaXNpeC9yb3V0ZS5nbw==) | `36.91% <0.00%> (-2.02%)` | :arrow_down: | | [test/e2e/e2e.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-dGVzdC9lMmUvZTJlLmdv) | | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/726?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978781841 > #694 has been merged. You can do this job @neverCase > > * [ ] Add client implementation to interact with Apache APISIX. ok, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase removed a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase removed a comment on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978781461 > * chore: consumer data structures by tokers · Pull Request #470 · apache/apisix-ingress-controller ok, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978781461 > * chore: consumer data structures by tokers · Pull Request #470 · apache/apisix-ingress-controller ok, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
membphis commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-978781045 I prefer patch `math.randomseed` way -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
membphis commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-978780822 Which one is the best, then use which one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] lemonrains commented on issue #2426: bug：enable openid-connect plugin without redirect_uri got 500 error
lemonrains commented on issue #2426: URL: https://github.com/apache/apisix/issues/2426#issuecomment-978779938 > I had the same problem. https://github.com/zmartzone/lua-resty-openidc/blob/v1.7.2/lib/resty/openidc.lua Line 1361 `local session, session_error = r_session.start(session_opts)` https://github.com/bungle/lua-resty-session/blob/v2.24/lib/resty/session.lua Line 320 `return self, present` session_error receives the value of present，session is not initialized present I got the same error, how did you solve it finally? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #731: feat: Grafana Dashboard Configuration
codecov-commenter commented on pull request #731: URL: https://github.com/apache/apisix-ingress-controller/pull/731#issuecomment-97877 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#731](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (6628406) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/65f7c88193eb6e83b2bb4ca87a981321a99503e5?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (65f7c88) will **increase** coverage by `0.49%`. > The diff coverage is `52.54%`. [](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master #731 +/- ## == + Coverage 31.70% 32.19% +0.49% == Files 66 65 -1 Lines6640 6799 +159 == + Hits 2105 2189 +84 - Misses 4280 4353 +73 - Partials 255 257 +2 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/ingress/apisix\_cluster\_config.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NsdXN0ZXJfY29uZmlnLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_consumer.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X2NvbnN1bWVyLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_route.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3JvdXRlLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_tls.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Rscy5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/apisix\_upstream.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvYXBpc2l4X3Vwc3RyZWFtLmdv) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/controller.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvY29udHJvbGxlci5nbw==) | `1.00% <0.00%> (-0.01%)` | :arrow_down: | | [pkg/ingress/endpoint.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnQuZ28=) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/endpointslice.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvZW5kcG9pbnRzbGljZS5nbw==) | `0.00% <0.00%> (ø)` | | | [pkg/ingress/ingress.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3MvaW5ncmVzcy5nbw==) | `8.10% <0.00%> (-0.19%)` | :arrow_down: | | [pkg/ingress/secret.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/731/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2luZ3Jlc3Mvc2VjcmV0Lmdv)
[GitHub] [apisix-ingress-controller] neverCase removed a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase removed a comment on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978772547 > #694 has been merged. You can do this job @neverCase > > * [ ] Add client implementation to interact with Apache APISIX. @tao12345666333 Does this task mean that i should implement the webhook and validation? e.g. `github.com/apache/apisix-ingress-controller/pkg/api/validation"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] yzeng25 opened a new pull request #772: docs: update topic to avoid displaying issue
yzeng25 opened a new pull request #772: URL: https://github.com/apache/apisix-website/pull/772 Fixes: #771 Changes: Currently, the website displays two identical articles on the first page of blog. After some researching and testing, I find the cause of this problem. While it is completely fine to post multiple articles in the same date directory, the file names of articles must -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5600: feat(ext-plugin): support to get request body
tzssangglass commented on a change in pull request #5600:
URL: https://github.com/apache/apisix/pull/5600#discussion_r756536490
##
File path: t/plugin/ext-plugin/request-body.t
##
@@ -0,0 +1,177 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+no_shuffle();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+$block->set_value("stream_conf_enable", 1);
+
+if (!defined $block->extra_stream_config) {
+my $stream_config = <<_EOC_;
+server {
+listen unix:\$TEST_NGINX_HTML_DIR/nginx.sock;
+
+content_by_lua_block {
+local ext = require("lib.ext-plugin")
+ext.go({})
+}
+}
+
+_EOC_
+$block->set_value("extra_stream_config", $stream_config);
+}
+
+my $unix_socket_path = $ENV{"TEST_NGINX_HTML_DIR"} . "/nginx.sock";
+my $cmd = $block->ext_plugin_cmd // "['sleep', '5s']";
+my $extra_yaml_config = <<_EOC_;
+ext-plugin:
+path_for_test: $unix_socket_path
+cmd: $cmd
+_EOC_
+
+$block->set_value("extra_yaml_config", $extra_yaml_config);
+
+if (!$block->request) {
+$block->set_value("request", "GET /t");
+}
+
+if (!$block->error_log) {
+$block->set_value("no_error_log", "[error]\n[alert]");
+}
+});
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: add route
+--- config
+location /t {
+content_by_lua_block {
+local json = require("toolkit.json")
+local t = require("lib.test_admin")
+
+local code, message, res = t.test('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+ [[{
+"uri": "/hello",
+"plugins": {
+"ext-plugin-pre-req": {
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+}
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+ngx.say(message)
+return
+end
+
+ngx.say(message)
+}
+}
+--- response_body
+passed
+
+
+
+=== TEST 2: request body(text)
+--- request
+POST /hello
+123
+--- extra_stream_config
+server {
+listen unix:$TEST_NGINX_HTML_DIR/nginx.sock;
+
+content_by_lua_block {
+local ext = require("lib.ext-plugin")
+local actions = {
+{type = "var", name = "request_body", result = "123"},
+}
+ext.go({extra_info = actions, stop = true, get_request_body =
true})
+}
+}
+--- error_code: 405
+--- grep_error_log eval
+qr/send extra info req successfully/
+--- grep_error_log_out
+send extra info req successfully
+
+
+
+=== TEST 3: request body(x-www-form-urlencoded)
+--- request
+POST /hello
+foo=bar
+--- more_headers
+Content-Type: application/x-www-form-urlencoded
+--- extra_stream_config
+server {
+listen unix:$TEST_NGINX_HTML_DIR/nginx.sock;
+
+content_by_lua_block {
+local ext = require("lib.ext-plugin")
+local actions = {
+{type = "var", name = "request_body", result = "foo=bar"},
+}
+ext.go({extra_info = actions, stop = true, get_request_body =
true})
+}
+}
+--- error_code: 405
+--- grep_error_log eval
+qr/send extra info req successfully/
+--- grep_error_log_out
+send extra info req successfully
+
+
+
+=== TEST 4: request body(json)
Review comment:
add a test case of request body is nil
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase edited a comment on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase edited a comment on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978772547 > #694 has been merged. You can do this job @neverCase > > * [ ] Add client implementation to interact with Apache APISIX. @tao12345666333 Does this task mean that i should implement the webhook and validation? e.g. `github.com/apache/apisix-ingress-controller/pkg/api/validation"` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] neverCase commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
neverCase commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978772547 > #694 has been merged. You can do this job @neverCase > > * [ ] Add client implementation to interact with Apache APISIX. @tao12345666333 Does this task mean that i should implement the webhook and validation? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] jikunchong closed issue #750: request help: how to access istio services (demo: Bookinfo)？
jikunchong closed issue #750: URL: https://github.com/apache/apisix-ingress-controller/issues/750 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #85: requst help:how to get request body params
tzssangglass commented on issue #85: URL: https://github.com/apache/apisix-java-plugin-runner/issues/85#issuecomment-978770456 will support soon -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #84: request help: How do I get my Java custom plug-in to take precedence over the VARS feature
tzssangglass commented on issue #84: URL: https://github.com/apache/apisix-java-plugin-runner/issues/84#issuecomment-978770335 1. apisix-java-runner doesn't support to read and rewrite request body yet, just can read and rewrite request args. 2. if you want ro rewrite request args by apisix-java-plugin-runner, an you try to config `ext-plugin-*` plugin on global rule of APISIX? global rule plugins run before route match. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5603: docs: update admin ip example node ip
spacewander commented on pull request #5603: URL: https://github.com/apache/apisix/pull/5603#issuecomment-978759797 There are still many "39.97.63.215" in the docs. I should not merge it so quickly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dmsolr commented on a change in pull request #5550: feat: support to log response body
dmsolr commented on a change in pull request #5550: URL: https://github.com/apache/apisix/pull/5550#discussion_r756529615 ## File path: docs/zh/latest/plugins/kafka-logger.md ## @@ -56,8 +56,10 @@ title: kafka-logger | buffer_duration | integer | 可选 | 60 | [1,...] | 必须先处理批次中最旧条目的最长期限（以秒为单位）。 | | max_retry_count | integer | 可选 | 0 | [0,...] | 从处理管道中移除之前的最大重试次数。 | | retry_delay | integer | 可选 | 1 | [0,...] | 如果执行失败，则应延迟执行流程的秒数。 | -| include_req_body | boolean | 可选 | false | [false, true] | 是否包括请求 body。false： 表示不包含请求的 body ；true： 表示包含请求的 body。注意：如果请求 body 没办法完全放在内存中，由于 Nginx 的限制，我们没有办法把它记录下来。| -| include_req_body_expr | array | 可选| | | 当 `include_req_body` 开启时, 基于 [lua-resty-expr](https://github.com/api7/lua-resty-expr) 表达式的结果进行记录。如果该选项存在，只有在表达式为真的时候才会记录请求 body。 | +| include_req_body | boolean | 可选 | false | [false, true] | 是否包括请求 body。false： 表示不包含请求的 body ； true： 表示包含请求的 body 。| Review comment: Sorry. I think there is the same limitation in the http-logger plugin. Right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] shelltea commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
shelltea commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978756518 @tao12345666333 I am very interested, but I'm not familiar with go and Kubernetes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5603: docs: update admin ip example node ip
spacewander merged pull request #5603: URL: https://github.com/apache/apisix/pull/5603 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: update admin ip example node ip (#5603)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new 12b3fac docs: update admin ip example node ip (#5603)
12b3fac is described below
commit 12b3fac3cef09347aeae1c41baaa7095c8c8ab5c
Author: 帅进超
AuthorDate: Thu Nov 25 10:23:54 2021 +0800
docs: update admin ip example node ip (#5603)
---
docs/en/latest/admin-api.md | 70 ++---
docs/zh/latest/admin-api.md | 70 ++---
2 files changed, 70 insertions(+), 70 deletions(-)
diff --git a/docs/en/latest/admin-api.md b/docs/en/latest/admin-api.md
index b5f4cac..20c0933 100644
--- a/docs/en/latest/admin-api.md
+++ b/docs/en/latest/admin-api.md
@@ -142,7 +142,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1 -H
'X-API-KEY: edd1c9f034335f
"upstream": {
"type": "roundrobin",
"nodes": {
-"39.97.63.215:80": 1
+"127.0.0.1:1980": 1
}
}
}'
@@ -158,7 +158,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/2?ttl=60
-H 'X-API-KEY: edd1c9f
"upstream": {
"type": "roundrobin",
"nodes": {
-"39.97.63.215:80": 1
+"127.0.0.1:1980": 1
}
}
}'
@@ -173,7 +173,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1
-H'X-API-KEY: edd1c9f034335f1
{
"upstream": {
"nodes": {
-"39.97.63.216:80": 1
+"127.0.0.1:1981": 1
}
}
}'
@@ -182,8 +182,8 @@ HTTP/1.1 200 OK
After successful execution, upstream nodes will be updated to:
{
-"39.97.63.215:80": 1,
-"39.97.63.216:80": 1
+"127.0.0.1:1980": 1,
+"127.0.0.1:1981": 1
}
@@ -192,7 +192,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1
-H'X-API-KEY: edd1c9f034335f1
{
"upstream": {
"nodes": {
-"39.97.63.216:80": 10
+"127.0.0.1:1981": 10
}
}
}'
@@ -201,8 +201,8 @@ HTTP/1.1 200 OK
After successful execution, upstream nodes will be updated to:
{
-"39.97.63.215:80": 1,
-"39.97.63.216:80": 10
+"127.0.0.1:1980": 1,
+"127.0.0.1:1981": 10
}
@@ -211,7 +211,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/routes/1
-H'X-API-KEY: edd1c9f034335f1
{
"upstream": {
"nodes": {
-"39.97.63.215:80": null
+"127.0.0.1:1980": null
}
}
}'
@@ -220,7 +220,7 @@ HTTP/1.1 200 OK
After successful execution, upstream nodes will be updated to:
{
-"39.97.63.216:80": 10
+"127.0.0.1:1981": 10
}
@@ -238,14 +238,14 @@ After successful execution, methods will not retain the
original data, and the e
# Replace upstream nodes of the Route -- sub path
$ curl http://127.0.0.1:9080/apisix/admin/routes/1/upstream/nodes
-H'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PATCH -i -d '
{
-"39.97.63.200:80": 1
+"127.0.0.1:1982": 1
}'
HTTP/1.1 200 OK
...
After successful execution, nodes will not retain the original data, and the
entire update is:
{
-"39.97.63.200:80": 1
+"127.0.0.1:1982": 1
}
@@ -359,7 +359,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/services/201 -H
'X-API-KEY: edd1c9f03
"upstream": {
"type": "roundrobin",
"nodes": {
-"39.97.63.215:80": 1
+"127.0.0.1:1980": 1
}
}
}'
@@ -373,7 +373,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/services/201
-H'X-API-KEY: edd1c9f0343
{
"upstream": {
"nodes": {
-"39.97.63.216:80": 1
+"127.0.0.1:1981": 1
}
}
}'
@@ -382,8 +382,8 @@ HTTP/1.1 200 OK
After successful execution, upstream nodes will be updated to:
{
-"39.97.63.215:80": 1,
-"39.97.63.216:80": 1
+"127.0.0.1:1980": 1,
+"127.0.0.1:1981": 1
}
@@ -392,7 +392,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/services/201
-H'X-API-KEY: edd1c9f0343
{
"upstream": {
"nodes": {
-"39.97.63.216:80": 10
+"127.0.0.1:1981": 10
}
}
}'
@@ -401,8 +401,8 @@ HTTP/1.1 200 OK
After successful execution, upstream nodes will be updated to:
{
-"39.97.63.215:80": 1,
-"39.97.63.216:80": 10
+"127.0.0.1:1980": 1,
+"127.0.0.1:1981": 10
}
@@ -411,7 +411,7 @@ $ curl http://127.0.0.1:9080/apisix/admin/services/201
-H'X-API-KEY: edd1c9f0343
{
"upstream": {
"nodes": {
-"39.97.63.215:80": null
+"127.0.0.1:1980": null
}
}
}'
@@ -420,21 +420,21 @@ HTTP/1.1 200 OK
After successful execution, upstream nodes will be updated to:
{
-"39.97.63.216:80": 10
+"127.0.0.1:1981": 10
}
# Replace upstream nodes of the Service
$ curl http://127.0.0.1:9080/apisix/admin/services/201/upstream/nodes
-H'X-API-KEY: edd1c9f034335f136f87ad84b625c8f1' -X PATCH -i -d '
{
-
[GitHub] [apisix-ingress-controller] lxm edited a comment on issue #768: request help: path like /api/*/action
lxm edited a comment on issue #768: URL: https://github.com/apache/apisix-ingress-controller/issues/768#issuecomment-978749574 > We need some discussion, or can rewrite meet your needs? rewrite can't do this. I'm using nginx-ingress now, for example , I'm using this to spec different backends ``` /api/srv-1/.*/action1 => backend1:port /api/srv-1/.*/action2 => backend2:port ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] lxm commented on issue #768: request help: path like /api/*/action
lxm commented on issue #768: URL: https://github.com/apache/apisix-ingress-controller/issues/768#issuecomment-978749574 > We need some discussion, or can rewrite meet your needs? rewrite can do this. I'm using nginx-ingress now, for example , I'm using this to spec different backends ``` /api/srv-1/.*/action1 => backend1:port /api/srv-1/.*/action2 => backend2:port ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] alexchan10241 commented on issue #86: request help: How can I remove unwanted headers or args via java plugin runner?
alexchan10241 commented on issue #86: URL: https://github.com/apache/apisix-java-plugin-runner/issues/86#issuecomment-978728865 OMG!!! I overlooked it.And it did work! Thanks a lot! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] alexchan10241 closed issue #86: request help: How can I remove unwanted headers or args via java plugin runner?
alexchan10241 closed issue #86: URL: https://github.com/apache/apisix-java-plugin-runner/issues/86 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #769: bug: Unable to reconnect to apisix, when all ep are deleted under svc of apisix
tokers commented on issue #769: URL: https://github.com/apache/apisix-ingress-controller/issues/769#issuecomment-978728487 I can give you some clues about this issue. When the controller gets the opportunity to be the new leader, it tries to add the cluster (name is `default`) again, but since the cluster was already there (added in its last term), the new one won't be added, and the controller will still use the old cluster, and in the old cluster, the `cacheSyncErr` was cached and will be used directly when calling `HasSynced`. So the controller won't enter the state for watching Kubernetes resources. A simple solution for this is destroyed the old cluster when it gives up the leader role. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass edited a comment on issue #86: request help: How can I remove unwanted headers or args via java plugin runner?
tzssangglass edited a comment on issue #86: URL: https://github.com/apache/apisix-java-plugin-runner/issues/86#issuecomment-978727796 see: https://github.com/apache/apisix-java-plugin-runner/blob/fa909b851270bb258ee60d1248d3331a3814d139/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java#L183-L184 and https://github.com/apache/apisix-java-plugin-runner/blob/fa909b851270bb258ee60d1248d3331a3814d139/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java#L251-L252 `delete existing header` in Line 251 -> `delete existing arg` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on issue #86: request help: How can I remove unwanted headers or args via java plugin runner?
tzssangglass commented on issue #86: URL: https://github.com/apache/apisix-java-plugin-runner/issues/86#issuecomment-978727796 see: https://github.com/apache/apisix-java-plugin-runner/blob/fa909b851270bb258ee60d1248d3331a3814d139/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java#L183-L184 and https://github.com/apache/apisix-java-plugin-runner/blob/main/runner-plugin-sdk/src/main/java/org/apache/apisix/plugin/runner/HttpRequest.java#L251-L252 `delete existing header` in Line 251 -> `delete existing arg` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5550: feat: support to log response body
spacewander commented on a change in pull request #5550: URL: https://github.com/apache/apisix/pull/5550#discussion_r756517533 ## File path: docs/zh/latest/plugins/kafka-logger.md ## @@ -56,8 +56,10 @@ title: kafka-logger | buffer_duration | integer | 可选 | 60 | [1,...] | 必须先处理批次中最旧条目的最长期限（以秒为单位）。 | | max_retry_count | integer | 可选 | 0 | [0,...] | 从处理管道中移除之前的最大重试次数。 | | retry_delay | integer | 可选 | 1 | [0,...] | 如果执行失败，则应延迟执行流程的秒数。 | -| include_req_body | boolean | 可选 | false | [false, true] | 是否包括请求 body。false： 表示不包含请求的 body ；true： 表示包含请求的 body。注意：如果请求 body 没办法完全放在内存中，由于 Nginx 的限制，我们没有办法把它记录下来。| -| include_req_body_expr | array | 可选| | | 当 `include_req_body` 开启时, 基于 [lua-resty-expr](https://github.com/api7/lua-resty-expr) 表达式的结果进行记录。如果该选项存在，只有在表达式为真的时候才会记录请求 body。 | +| include_req_body | boolean | 可选 | false | [false, true] | 是否包括请求 body。false： 表示不包含请求的 body ； true： 表示包含请求的 body 。| Review comment: `注意：如果请求 body 没办法完全放在内存中，由于 Nginx 的限制，我们没有办法把它记录下来。` This part is overridden. ## File path: t/plugin/http-logger.t ## @@ -108,7 +108,43 @@ done -=== TEST 4: add plugin +=== TEST 4: check log schema(include_resp_body_expr) Review comment: Could we add the test at the end, so the other test numbers won't be changed? We can use `reindex` to fix the number. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5600: feat(ext-plugin): support to get request body
tzssangglass commented on a change in pull request #5600: URL: https://github.com/apache/apisix/pull/5600#discussion_r756516784 ## File path: t/lib/ext-plugin.lua ## @@ -169,6 +169,8 @@ function _M.go(case) local entry = call_req:Args(1) assert(entry:Name() == "x") assert(entry:Value() == "z") +elseif case.get_request_body then +assert(call_req:Method() == a6_method.POST) Review comment: actions.result would check the value in request body? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5600: feat(ext-plugin): support to get request body
tzssangglass commented on a change in pull request #5600: URL: https://github.com/apache/apisix/pull/5600#discussion_r756516435 ## File path: t/lib/ext-plugin.lua ## @@ -169,6 +169,8 @@ function _M.go(case) local entry = call_req:Args(1) assert(entry:Name() == "x") assert(entry:Value() == "z") +elseif case.get_request_body then +assert(call_req:Method() == a6_method.POST) Review comment: I want to validate different content-type, so the value of request body is not fixed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] nic-6443 closed issue #751: bug: e2e test will fail randomly
nic-6443 closed issue #751: URL: https://github.com/apache/apisix-ingress-controller/issues/751 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #746: feat: add v2beta3
tokers commented on pull request #746: URL: https://github.com/apache/apisix-ingress-controller/pull/746#issuecomment-978723205 Can we split this PR to two parts: 1. Add the new version; 2. Delete the old versions; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao opened a new pull request #5603: docs: update admin ip example node ip
shuaijinchao opened a new pull request #5603: URL: https://github.com/apache/apisix/pull/5603 ### What this PR does / why we need it: Private node addresses should not appear in official documents ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on a change in pull request #5600: feat(ext-plugin): support to get request body
tzssangglass commented on a change in pull request #5600:
URL: https://github.com/apache/apisix/pull/5600#discussion_r756513090
##
File path: t/plugin/ext-plugin/request-body.t
##
@@ -0,0 +1,177 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+no_shuffle();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+$block->set_value("stream_conf_enable", 1);
+
+if (!defined $block->extra_stream_config) {
+my $stream_config = <<_EOC_;
+server {
+listen unix:\$TEST_NGINX_HTML_DIR/nginx.sock;
+
+content_by_lua_block {
+local ext = require("lib.ext-plugin")
+ext.go({})
+}
+}
+
+_EOC_
+$block->set_value("extra_stream_config", $stream_config);
+}
+
+my $unix_socket_path = $ENV{"TEST_NGINX_HTML_DIR"} . "/nginx.sock";
+my $cmd = $block->ext_plugin_cmd // "['sleep', '5s']";
+my $extra_yaml_config = <<_EOC_;
+ext-plugin:
+path_for_test: $unix_socket_path
+cmd: $cmd
+_EOC_
+
+$block->set_value("extra_yaml_config", $extra_yaml_config);
+
+if (!$block->request) {
+$block->set_value("request", "GET /t");
+}
+
+if (!$block->error_log) {
+$block->set_value("no_error_log", "[error]\n[alert]");
+}
+});
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: add route
+--- config
+location /t {
+content_by_lua_block {
+local json = require("toolkit.json")
+local t = require("lib.test_admin")
+
+local code, message, res = t.test('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+ [[{
+"uri": "/hello",
+"plugins": {
+"ext-plugin-pre-req": {
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+}
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+ngx.say(message)
+return
+end
+
+ngx.say(message)
+}
+}
+--- response_body
+passed
+
+
+
+=== TEST 2: request body(text)
+--- request
+POST /hello
+123
+--- extra_stream_config
+server {
+listen unix:$TEST_NGINX_HTML_DIR/nginx.sock;
+
+content_by_lua_block {
+local ext = require("lib.ext-plugin")
+local actions = {
+{type = "var", name = "request_body", result = "123"},
+}
+ext.go({extra_info = actions, stop = true, get_request_body =
true})
+}
+}
+--- error_code: 405
+--- grep_error_log eval
+qr/send extra info req successfully/
+--- grep_error_log_out
+send extra info req successfully
+
+
+
+=== TEST 3: request body(x-www-form-urlencoded)
+--- request
+POST /hello
+foo=bar
+--- more_headers
+Content-Type: application/x-www-form-urlencoded
+--- extra_stream_config
+server {
+listen unix:$TEST_NGINX_HTML_DIR/nginx.sock;
+
+content_by_lua_block {
+local ext = require("lib.ext-plugin")
+local actions = {
+{type = "var", name = "request_body", result = "foo=bar"},
+}
+ext.go({extra_info = actions, stop = true, get_request_body =
true})
+}
+}
+--- error_code: 405
+--- grep_error_log eval
+qr/send extra info req successfully/
+--- grep_error_log_out
+send extra info req successfully
+
+
+
+=== TEST 4: request body(json)
Review comment:
I have tried to emulate this test
case：https://github.com/apache/apisix/blob/4b94b84f92d1cb6cb58e52075637a42ed76457d8/t/core/request.t#L414-L439
but failed.
should I send an empty body to test?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on issue #751: bug: e2e test will fail randomly
tokers commented on issue #751: URL: https://github.com/apache/apisix-ingress-controller/issues/751#issuecomment-978721143 @nic-6443 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] alexchan10241 opened a new issue #86: request help: How can I remove unwanted headers or args via java plugin runner?
alexchan10241 opened a new issue #86: URL: https://github.com/apache/apisix-java-plugin-runner/issues/86 ### Issue description request help: How can I remove unwanted headers or args via java plugin runner?I try to remove headers that I want to delete by using 'request.setHeader and request.setArg' in java plugin runner.But,it didn't work .Actually,the headers or args still pass to the upstream.I think maybe there is a merge operation when hiting a router.Is there any solution to handle this case.Thanks a lot! ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 90yangkang closed issue #5585: request help: How to record interface(restful api) request log and return log？
90yangkang closed issue #5585: URL: https://github.com/apache/apisix/issues/5585 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] 90yangkang commented on issue #5585: request help: How to record interface(restful api) request log and return log？
90yangkang commented on issue #5585: URL: https://github.com/apache/apisix/issues/5585#issuecomment-978713873 > not relevant to this issue, see: [#4098 (comment)](https://github.com/apache/apisix/issues/4098#issuecomment-977762062) Ok，thanks~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5600: feat(ext-plugin): support to get request body
spacewander commented on a change in pull request #5600:
URL: https://github.com/apache/apisix/pull/5600#discussion_r756505700
##
File path: t/plugin/ext-plugin/request-body.t
##
@@ -0,0 +1,177 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+use t::APISIX 'no_plan';
+
+repeat_each(1);
+no_long_string();
+no_root_location();
+no_shuffle();
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+$block->set_value("stream_conf_enable", 1);
+
+if (!defined $block->extra_stream_config) {
+my $stream_config = <<_EOC_;
+server {
+listen unix:\$TEST_NGINX_HTML_DIR/nginx.sock;
+
+content_by_lua_block {
+local ext = require("lib.ext-plugin")
+ext.go({})
+}
+}
+
+_EOC_
+$block->set_value("extra_stream_config", $stream_config);
+}
+
+my $unix_socket_path = $ENV{"TEST_NGINX_HTML_DIR"} . "/nginx.sock";
+my $cmd = $block->ext_plugin_cmd // "['sleep', '5s']";
+my $extra_yaml_config = <<_EOC_;
+ext-plugin:
+path_for_test: $unix_socket_path
+cmd: $cmd
+_EOC_
+
+$block->set_value("extra_yaml_config", $extra_yaml_config);
+
+if (!$block->request) {
+$block->set_value("request", "GET /t");
+}
+
+if (!$block->error_log) {
+$block->set_value("no_error_log", "[error]\n[alert]");
+}
+});
+
+run_tests;
+
+__DATA__
+
+=== TEST 1: add route
+--- config
+location /t {
+content_by_lua_block {
+local json = require("toolkit.json")
+local t = require("lib.test_admin")
+
+local code, message, res = t.test('/apisix/admin/routes/1',
+ngx.HTTP_PUT,
+ [[{
+"uri": "/hello",
+"plugins": {
+"ext-plugin-pre-req": {
+}
+},
+"upstream": {
+"nodes": {
+"127.0.0.1:1980": 1
+},
+"type": "roundrobin"
+}
+}]]
+)
+
+if code >= 300 then
+ngx.status = code
+ngx.say(message)
+return
+end
+
+ngx.say(message)
+}
+}
+--- response_body
+passed
+
+
+
+=== TEST 2: request body(text)
+--- request
+POST /hello
+123
+--- extra_stream_config
+server {
+listen unix:$TEST_NGINX_HTML_DIR/nginx.sock;
+
+content_by_lua_block {
+local ext = require("lib.ext-plugin")
+local actions = {
+{type = "var", name = "request_body", result = "123"},
+}
+ext.go({extra_info = actions, stop = true, get_request_body =
true})
+}
+}
+--- error_code: 405
+--- grep_error_log eval
+qr/send extra info req successfully/
+--- grep_error_log_out
+send extra info req successfully
+
+
+
+=== TEST 3: request body(x-www-form-urlencoded)
+--- request
+POST /hello
+foo=bar
+--- more_headers
+Content-Type: application/x-www-form-urlencoded
+--- extra_stream_config
+server {
+listen unix:$TEST_NGINX_HTML_DIR/nginx.sock;
+
+content_by_lua_block {
+local ext = require("lib.ext-plugin")
+local actions = {
+{type = "var", name = "request_body", result = "foo=bar"},
+}
+ext.go({extra_info = actions, stop = true, get_request_body =
true})
+}
+}
+--- error_code: 405
+--- grep_error_log eval
+qr/send extra info req successfully/
+--- grep_error_log_out
+send extra info req successfully
+
+
+
+=== TEST 4: request body(json)
Review comment:
Better to add a test which doesn't have a value
##
File path: t/lib/ext-plugin.lua
##
@@ -169,6 +169,8 @@ function _M.go(case)
local entry = call_req:Args(1)
assert(entry:Name() == "x")
assert(entry:Value() == "z")
+elseif case.get_request_body then
+assert(call_req:Method() == a6_method.POST)
Review comment:
Do we need to check the request_body's value?
--
This is an automated message from the Apache Git Service.
To respond to the message,
[GitHub] [apisix-website] SylviaBABY opened a new issue #771: Bug: display Blog(EN) page has two duplicate articles
SylviaBABY opened a new issue #771: URL: https://github.com/apache/apisix-website/issues/771 **Actual Behaviour** Now the Blog page has two duplicate articles about the CVE-2021-43557 announcement **Expected Behaviour** The page should display the two pieces of content in order： 1. https://apisix.apache.org/blog/2021/11/23/cve-2021-43557-research-report/ 2. https://apisix.apache.org/blog/2021/11/23/cve-2021-43557/ **Steps to reproduce it** **Screenshots of the issue**  **Would you like to work on the issue?** No，need another person help to check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] elvis-cai commented on pull request #726: feat: add externalname support for upstream
elvis-cai commented on pull request #726: URL: https://github.com/apache/apisix-ingress-controller/pull/726#issuecomment-978488784 > Sorry for delay. Can you resolve the conflict? Then we run the test and merge this PR. Thanks! all good, conflict resolved and feel free to rerun the test, thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] alexchan10241 opened a new issue #5602: request help: How can I remove unwanted headers or args via java plugin runner?
alexchan10241 opened a new issue #5602: URL: https://github.com/apache/apisix/issues/5602 ### Issue description request help: How can I remove unwanted headers or args via java plugin runner?I try to remove headers that I want to delete by using 'request.setHeader and request.setArg' in java plugin runner.But,it didn't work .Actually,the headers or args still pass to the upstream.I think maybe there is a merge operation when hiting a router.Is there any solution to handle this case.Thanks a lot! ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on pull request #5600: feat(ext-plugin): support to get request body
tzssangglass commented on pull request #5600: URL: https://github.com/apache/apisix/pull/5600#issuecomment-978033734 I'm thinking that this implementation might not be good enough, because usually the user needs to not only read the request body, but also rewrite it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #638: proposal: Add CRD ApisixPluginConfig support plugin configs
tao12345666333 commented on issue #638: URL: https://github.com/apache/apisix-ingress-controller/issues/638#issuecomment-978006065 > * [ ] Add client implementation to interact with Apache APISIX. > * [ ] Add ApisixPluginConfig translator, it can convert ApisixPluginConfig data structure into APISIX. > * [ ] Add ApisixPluginConfig controller loop, It watches the ApisixPluginConfig resource in the Kubernetes cluster and converts it to the ApisixPluginConfig data structure. > * [ ] Add docs to describe it. @shelltea @fengshunli If you are interested, you can also choose one of the tasks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #710: request help: Apisix ingress controller config.yaml couldn't read os environment variable
tao12345666333 closed issue #710: URL: https://github.com/apache/apisix-ingress-controller/issues/710 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #710: request help: Apisix ingress controller config.yaml couldn't read os environment variable
tao12345666333 commented on issue #710: URL: https://github.com/apache/apisix-ingress-controller/issues/710#issuecomment-977999448 #745 has been merged. This feature has been implemented, I will close this issue. Feel free to reopen it, if you have any questions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #751: bug: e2e test will fail randomly
tao12345666333 commented on issue #751: URL: https://github.com/apache/apisix-ingress-controller/issues/751#issuecomment-977996650 It seems that the recent e2e is running relatively stable, and related PRs have also been merged, can we close this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #732: bug: ApisixRoute backendPoint duplicate
tao12345666333 commented on issue #732: URL: https://github.com/apache/apisix-ingress-controller/issues/732#issuecomment-977995510 #734 has been merged. I will close this one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 closed issue #732: bug: ApisixRoute backendPoint duplicate
tao12345666333 closed issue #732: URL: https://github.com/apache/apisix-ingress-controller/issues/732 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aseaday commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
aseaday commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-977992974 > After a careful look at the two implementations, the core is the same. > > Let's do it. I want to fix this bug as an first step to contribute to apisix. As an newbie, I had one question: 1. Need we to patch the math.randomseed or just fix the id problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
membphis commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-977980006 After a careful look at the two implementations, the core is the same. Let's do it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aseaday commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
aseaday commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-977969074 > how about this way? > > https://github.com/kubernetes/ingress-nginx/blob/30809c066cd027079cbb32dccc8a101d6fbffdcb/rootfs/etc/nginx/lua/lua_ingress.lua#L44 It seems like the same as Kong one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
membphis commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-977955790 how about this way? https://github.com/kubernetes/ingress-nginx/blob/30809c066cd027079cbb32dccc8a101d6fbffdcb/rootfs/etc/nginx/lua/lua_ingress.lua#L44 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-go-plugin-runner] A11enHuang commented on issue #47: bug: key not found
A11enHuang commented on issue #47: URL: https://github.com/apache/apisix-go-plugin-runner/issues/47#issuecomment-977942447 如果是key not found的情况下，不会走过滤器。如果我重新部署APISIX，一切又恢复了正常 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #2962: help~! 如何将 Kong已有业务平滑迁移至 apisix 解决方案？
membphis closed issue #2962: URL: https://github.com/apache/apisix/issues/2962 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #2962: help~! 如何将 Kong已有业务平滑迁移至 apisix 解决方案？
membphis commented on issue #2962: URL: https://github.com/apache/apisix/issues/2962#issuecomment-977936014 so we can close this issue now ^_^ many thx @shuaijinchao 's cool job -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-ingress-controller] branch master updated: feat: init ApisixPluginConfig crd #4 (#638) (#694)
This is an automated email from the ASF dual-hosted git repository.
zhangjintao pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-ingress-controller.git
The following commit(s) were added to refs/heads/master by this push:
new b127ff4 feat: init ApisixPluginConfig crd #4 (#638) (#694)
b127ff4 is described below
commit b127ff4eb47c95fa4db3b58020d7005f739d9dbd
Author: nevercase <1024769...@qq.com>
AuthorDate: Wed Nov 24 22:26:55 2021 +0800
feat: init ApisixPluginConfig crd #4 (#638) (#694)
---
pkg/kube/apisix/apis/config/v2beta2/types.go | 34
.../apis/config/v2beta2/zz_generated.deepcopy.go | 84 +
.../typed/config/v2beta2/apisixpluginconfig.go | 194 +
.../typed/config/v2beta2/config_client.go | 5 +
.../config/v2beta2/fake/fake_apisixpluginconfig.go | 141 +++
.../config/v2beta2/fake/fake_config_client.go | 4 +
.../typed/config/v2beta2/generated_expansion.go| 2 +
.../config/v2beta2/apisixpluginconfig.go | 89 ++
.../externalversions/config/v2beta2/interface.go | 7 +
.../client/informers/externalversions/generic.go | 2 +
.../listers/config/v2beta2/apisixpluginconfig.go | 98 +++
.../listers/config/v2beta2/expansion_generated.go | 8 +
samples/deploy/crd/v1/ApisixPluginConfig.yaml | 83 +
samples/deploy/crd/v1/kustomization.yaml | 1 +
samples/deploy/rbac/apisix_view_clusterrole.yaml | 2 +
test/e2e/scaffold/ingress.go | 2 +
16 files changed, 756 insertions(+)
diff --git a/pkg/kube/apisix/apis/config/v2beta2/types.go
b/pkg/kube/apisix/apis/config/v2beta2/types.go
index 2d0a795..7e276c5 100644
--- a/pkg/kube/apisix/apis/config/v2beta2/types.go
+++ b/pkg/kube/apisix/apis/config/v2beta2/types.go
@@ -195,3 +195,37 @@ type ApisixRouteList struct {
metav1.ListMeta `json:"metadata" yaml:"metadata"`
Items []ApisixRoute `json:"items,omitempty"
yaml:"items,omitempty"`
}
+
+// +genclient
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+// +kubebuilder:subresource:status
+
+// ApisixPluginConfig is the Schema for the ApisixPluginConfig resource.
+// An ApisixPluginConfig is used to support a group of plugin configs
+type ApisixPluginConfig struct {
+ metav1.TypeMeta `json:",inline" yaml:",inline"`
+ metav1.ObjectMeta `json:"metadata" yaml:"metadata"`
+
+ // Spec defines the desired state of ApisixPluginConfigSpec.
+ Spec ApisixPluginConfigSpec `json:"spec" yaml:"spec"`
+ Status ApisixStatus `json:"status,omitempty"
yaml:"status,omitempty"`
+}
+
+// ApisixPluginConfigSpec defines the desired state of ApisixPluginConfigSpec.
+type ApisixPluginConfigSpec struct {
+ // Plugins contains a list of ApisixRouteHTTPPluginConfig
+ // +required
+ // +kubebuilder:validation:Required
+ // +kubebuilder:validation:MinItems=1
+ Plugins []ApisixRouteHTTPPluginConfig `json:"plugins" yaml:"plugins"`
+}
+
+// +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object
+// +kubebuilder:object:generate=true
+
+// ApisixPluginConfigList contains a list of ApisixPluginConfig.
+type ApisixPluginConfigList struct {
+ metav1.TypeMeta `json:",inline" yaml:",inline"`
+ metav1.ListMeta `json:"metadata" yaml:"metadata"`
+ Items []ApisixPluginConfig `json:"items,omitempty"
yaml:"items,omitempty"`
+}
diff --git a/pkg/kube/apisix/apis/config/v2beta2/zz_generated.deepcopy.go
b/pkg/kube/apisix/apis/config/v2beta2/zz_generated.deepcopy.go
index 0c1782f..7172824 100644
--- a/pkg/kube/apisix/apis/config/v2beta2/zz_generated.deepcopy.go
+++ b/pkg/kube/apisix/apis/config/v2beta2/zz_generated.deepcopy.go
@@ -26,6 +26,90 @@ import (
)
// DeepCopyInto is an autogenerated deepcopy function, copying the receiver,
writing into out. in must be non-nil.
+func (in *ApisixPluginConfig) DeepCopyInto(out *ApisixPluginConfig) {
+ *out = *in
+ out.TypeMeta = in.TypeMeta
+ in.ObjectMeta.DeepCopyInto()
+ in.Spec.DeepCopyInto()
+ in.Status.DeepCopyInto()
+ return
+}
+
+// DeepCopy is an autogenerated deepcopy function, copying the receiver,
creating a new ApisixPluginConfig.
+func (in *ApisixPluginConfig) DeepCopy() *ApisixPluginConfig {
+ if in == nil {
+ return nil
+ }
+ out := new(ApisixPluginConfig)
+ in.DeepCopyInto(out)
+ return out
+}
+
+// DeepCopyObject is an autogenerated deepcopy function, copying the receiver,
creating a new runtime.Object.
+func (in *ApisixPluginConfig) DeepCopyObject() runtime.Object {
+ if c := in.DeepCopy(); c != nil {
+ return c
+ }
+ return nil
+}
+
+// DeepCopyInto is an autogenerated deepcopy function, copying the receiver,
writing into out. in must be non-nil.
+func (in *ApisixPluginConfigList) DeepCopyInto(out
