[GitHub] [apisix-dashboard] nimohunter commented on a change in pull request #2247: update the kin-openapi to v0.86.0
nimohunter commented on a change in pull request #2247:
URL: https://github.com/apache/apisix-dashboard/pull/2247#discussion_r771164853
##
File path: api/internal/handler/data_loader/route_import.go
##
@@ -147,7 +147,7 @@ func (h *ImportHandler) Import(c droplet.Context)
(interface{}, error) {
} else {
if _, err := h.routeStore.Create(c.Context(), route);
err != nil {
return handler.SpecCodeResponse(err),
- fmt.Errorf("create route(uris:%v)
failed: %s", route.Uris, err)
+ fmt.Errorf("111create route(uris:%v)
failed: %s", route.Uris, err)
Review comment:
> you could use meaningful worlds to distinguish from the previous message.
sorry about it , i will check it again
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
shuaijinchao commented on a change in pull request #5839: URL: https://github.com/apache/apisix/pull/5839#discussion_r771161510 ## File path: apisix/plugins/google-cloud-logging.lua ## @@ -162,6 +163,7 @@ local function get_auth_config(config) end auth_config_cache = config_data +auth_config_cache.ssl_verify = conf.ssl_verify Review comment: this is a good question and has been updated. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on issue #2252: When will GM SSL be supported
zaunist commented on issue #2252: URL: https://github.com/apache/apisix-dashboard/issues/2252#issuecomment-996490618 Hi, @532810439 Could you please provide more info ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2251: ci: remove push docker image to demo env
zaunist commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996489601 /LGTM -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang opened a new pull request #5848: fix(install-dependencies): the execution of the script should not be interrupted
leslie-tsang opened a new pull request #5848: URL: https://github.com/apache/apisix/pull/5848 ### What this PR does / why we need it: The execution of `install-dependencies.sh` shouldn't be interrupted, add `-y` to fix it. ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [ ] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #2251: ci: remove push docker image to demo env
nic-chen commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996484208 > If we delete the push step, the deploy-with-docker.yaml maybe delete together. Otherwise it doesn't make sense We still need to test Manager API under docker, especially whether there is a problem with the modification of the conf file -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Horus-K commented on issue #5847: request help: proxy_pass cannot use https
Horus-K commented on issue #5847: URL: https://github.com/apache/apisix/issues/5847#issuecomment-996483968 i see this https://github.com/apache/apisix/issues/2257 but ret_code still not work   -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen commented on pull request #2251: ci: remove push docker image to demo env
nic-chen commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996483437 > Hi, may I know visitors how to use the manager-api? They can still use the demo site, but we no longer push to deploy each commit, but use the release image on hub.docker to deploy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: 183bb43d2514b9f82f561f5feae21b65240ffab4 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61bc347dc2b6d600080b1a45](https://app.netlify.com/sites/apache-apisix/deploys/61bc347dc2b6d600080b1a45) Browse the preview: [https://deploy-preview-814--apache-apisix.netlify.app](https://deploy-preview-814--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 Deploy Preview for *apache-apisix* processing. Explore the source changes: 183bb43d2514b9f82f561f5feae21b65240ffab4 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61bc347dc2b6d600080b1a45](https://app.netlify.com/sites/apache-apisix/deploys/61bc347dc2b6d600080b1a45) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
shuaijinchao commented on a change in pull request #5819:
URL: https://github.com/apache/apisix/pull/5819#discussion_r771114819
##
File path: apisix/plugins/splunk-hec-logging.lua
##
@@ -0,0 +1,189 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core= require("apisix.core")
+local ngx = ngx
+local type= type
+local ngx_now = ngx.now
+local ngx_update_time = ngx.update_time
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+
+local DEFAULT_SPLUNK_HEC_ENTRY_SOURCE = "apache-apisix-splunk-hec-logging"
+local DEFAULT_SPLUNK_HEC_ENTRY_TYPE = "_json"
+
+
+local plugin_name = "splunk-hec-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+token = {
+type = "string",
+},
+channel = {
+type = "string",
+},
+timeout = {
+type = "integer",
+minimum = 1,
+default = 60
+}
+},
+required = { "uri", "token" }
+},
+ssl_verify = {
+type = "boolean",
+default = true
+},
+max_retry_count = {
+type = "integer",
+minimum = 0,
+default = 0
+},
+retry_delay = {
+type = "integer",
+minimum = 0,
+default = 1
+},
+buffer_duration = {
+type = "integer",
+minimum = 1,
+default = 60
+},
+inactive_timeout = {
+type = "integer",
+minimum = 1,
+default = 10
+},
+batch_max_size = {
+type = "integer",
+minimum = 1,
+default = 100
+},
+},
+required = { "endpoint" },
+}
+
+
+local function get_logger_entry(conf)
+local entry = log_util.get_full_log(ngx, conf)
+ngx_update_time()
+return {
+time = ngx_now(),
+host = entry.server.hostname,
+source = DEFAULT_SPLUNK_HEC_ENTRY_SOURCE,
+sourcetype = DEFAULT_SPLUNK_HEC_ENTRY_TYPE,
+event = {
+request_url = entry.request.url,
+request_method = entry.request.method,
+request_headers = entry.request.headers,
+request_query = entry.request.querystring,
+request_size = entry.request.size,
+response_headers = entry.response.headers,
+response_status = entry.response.status,
+response_size = entry.response.size,
+latency = entry.latency,
+upstream = entry.upstream,
+}
+}
+end
+
+
+local function send_to_splunk(conf, entries)
+if type(conf.endpoint) ~= "table" then
+return nil, "endpoint config invalid"
+end
+
+if not conf.endpoint.uri then
+return nil, "endpoint url undefined"
+end
+
+if not conf.endpoint.token then
+return nil, "endpoint token undefined"
+end
+
+local request_headers = {}
+request_headers["Content-Type"] = "application/json"
+request_headers["Authorization"] = "Splunk " .. conf.endpoint.token
+if conf.endpoint.channel then
+request_headers["X-Splunk-Request-Channel"] = conf.endpoint.channel
+end
+
+local http_new = http.new()
+local res, err = http_new:request_uri(conf.endpoint.uri, {
+ssl_verify = conf.ssl_verify,
+method = "POST",
+body = core.json.encode(entries),
+headers = request_headers,
+})
+
+if err then
+return nil, "failed to write log to splunk, " .. err
+end
+
+local body
+body, err = core.json.decode(res.body)
+if err then
+return nil, "failed to parse splunk response data, " .. err
+end
+
+if res.status ~= 200 then
Review comment:
If
[GitHub] [apisix-website] SylviaBABY commented on pull request #814: docs: add Istio with APISIX Ingress blog
SylviaBABY commented on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996477588 @juzhiyuan @bzp2010 There is still a picture not put in, please do not merge it right now. I will inform you when it is all done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Horus-K commented on issue #5847: request help: proxy_pass cannot use https
Horus-K commented on issue #5847: URL: https://github.com/apache/apisix/issues/5847#issuecomment-996475958 I used ingress-nginx to start force https, return code 308, proxy_pass can use https On apisix, I used https forwarding and set ret_code 308. In the end, proxy_pass still redirected too many 301 and was not accessible -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] GhangZh commented on issue #5708: request help: go-plugin-runner error after starting in debug mode
GhangZh commented on issue #5708: URL: https://github.com/apache/apisix/issues/5708#issuecomment-996475209 > Bro, I also met the general problem, can you tell me how to solve it? Check that apisix config.yaml is correctly configured, the main reason for this error is that your configuration file does not read the configuration for listening here . You can look at this code apisix/apisix/plugins/ext-plugin/helper.lua -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5839: fix(google-cloud-logging): move ssl_verify to plugin configuration top level
spacewander commented on a change in pull request #5839: URL: https://github.com/apache/apisix/pull/5839#discussion_r771132235 ## File path: apisix/plugins/google-cloud-logging.lua ## @@ -162,6 +163,7 @@ local function get_auth_config(config) end auth_config_cache = config_data +auth_config_cache.ssl_verify = conf.ssl_verify Review comment: It seems the ssl_verify will be cached with the auth configuration. So changing the ssl_verify won't take effect immediately. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Horus-K commented on issue #5847: request help: proxy_pass cannot use https
Horus-K commented on issue #5847: URL: https://github.com/apache/apisix/issues/5847#issuecomment-996469750 If proxy_pass uses http, then the route cannot be enabled to force https, otherwise there will be too many 301 redirects -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: 36f7538391be9830e9ab6fa76078240119627346 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61bc2b45223e540007b1a738](https://app.netlify.com/sites/apache-apisix/deploys/61bc2b45223e540007b1a738) Browse the preview: [https://deploy-preview-814--apache-apisix.netlify.app](https://deploy-preview-814--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 Deploy Preview for *apache-apisix* processing. Explore the source changes: 36f7538391be9830e9ab6fa76078240119627346 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61bc2b45223e540007b1a738](https://app.netlify.com/sites/apache-apisix/deploys/61bc2b45223e540007b1a738) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
shuaijinchao commented on a change in pull request #5819:
URL: https://github.com/apache/apisix/pull/5819#discussion_r771114819
##
File path: apisix/plugins/splunk-hec-logging.lua
##
@@ -0,0 +1,189 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core= require("apisix.core")
+local ngx = ngx
+local type= type
+local ngx_now = ngx.now
+local ngx_update_time = ngx.update_time
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+
+local DEFAULT_SPLUNK_HEC_ENTRY_SOURCE = "apache-apisix-splunk-hec-logging"
+local DEFAULT_SPLUNK_HEC_ENTRY_TYPE = "_json"
+
+
+local plugin_name = "splunk-hec-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+token = {
+type = "string",
+},
+channel = {
+type = "string",
+},
+timeout = {
+type = "integer",
+minimum = 1,
+default = 60
+}
+},
+required = { "uri", "token" }
+},
+ssl_verify = {
+type = "boolean",
+default = true
+},
+max_retry_count = {
+type = "integer",
+minimum = 0,
+default = 0
+},
+retry_delay = {
+type = "integer",
+minimum = 0,
+default = 1
+},
+buffer_duration = {
+type = "integer",
+minimum = 1,
+default = 60
+},
+inactive_timeout = {
+type = "integer",
+minimum = 1,
+default = 10
+},
+batch_max_size = {
+type = "integer",
+minimum = 1,
+default = 100
+},
+},
+required = { "endpoint" },
+}
+
+
+local function get_logger_entry(conf)
+local entry = log_util.get_full_log(ngx, conf)
+ngx_update_time()
+return {
+time = ngx_now(),
+host = entry.server.hostname,
+source = DEFAULT_SPLUNK_HEC_ENTRY_SOURCE,
+sourcetype = DEFAULT_SPLUNK_HEC_ENTRY_TYPE,
+event = {
+request_url = entry.request.url,
+request_method = entry.request.method,
+request_headers = entry.request.headers,
+request_query = entry.request.querystring,
+request_size = entry.request.size,
+response_headers = entry.response.headers,
+response_status = entry.response.status,
+response_size = entry.response.size,
+latency = entry.latency,
+upstream = entry.upstream,
+}
+}
+end
+
+
+local function send_to_splunk(conf, entries)
+if type(conf.endpoint) ~= "table" then
+return nil, "endpoint config invalid"
+end
+
+if not conf.endpoint.uri then
+return nil, "endpoint url undefined"
+end
+
+if not conf.endpoint.token then
+return nil, "endpoint token undefined"
+end
+
+local request_headers = {}
+request_headers["Content-Type"] = "application/json"
+request_headers["Authorization"] = "Splunk " .. conf.endpoint.token
+if conf.endpoint.channel then
+request_headers["X-Splunk-Request-Channel"] = conf.endpoint.channel
+end
+
+local http_new = http.new()
+local res, err = http_new:request_uri(conf.endpoint.uri, {
+ssl_verify = conf.ssl_verify,
+method = "POST",
+body = core.json.encode(entries),
+headers = request_headers,
+})
+
+if err then
+return nil, "failed to write log to splunk, " .. err
+end
+
+local body
+body, err = core.json.decode(res.body)
+if err then
+return nil, "failed to parse splunk response data, " .. err
+end
+
+if res.status ~= 200 then
Review comment:
If
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: 5dc1663ea1d7a1e7accc6c4d141311bd8c0e7d89 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61bc2a4c7fc74f00074d06a2](https://app.netlify.com/sites/apache-apisix/deploys/61bc2a4c7fc74f00074d06a2) Browse the preview: [https://deploy-preview-814--apache-apisix.netlify.app](https://deploy-preview-814--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 Deploy Preview for *apache-apisix* processing. Explore the source changes: 5dc1663ea1d7a1e7accc6c4d141311bd8c0e7d89 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61bc2a4c7fc74f00074d06a2](https://app.netlify.com/sites/apache-apisix/deploys/61bc2a4c7fc74f00074d06a2) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] edited a comment on pull request #814: docs: add Istio with APISIX Ingress blog
netlify[bot] edited a comment on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 ✔️ Deploy Preview for *apache-apisix* ready! Explore the source changes: 7d1670149c3a617d844ad4115b4d87eb07767a14 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61bc2883801f0400072081fc](https://app.netlify.com/sites/apache-apisix/deploys/61bc2883801f0400072081fc) Browse the preview: [https://deploy-preview-814--apache-apisix.netlify.app](https://deploy-preview-814--apache-apisix.netlify.app) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Horus-K opened a new issue #5847: request help: proxy_pass cannot use https
Horus-K opened a new issue #5847: URL: https://github.com/apache/apisix/issues/5847 ### Issue description  nginx returen 502  route use force https  apisix log: 2021/12/17 14:00:15 [error] 51#51: *7848975 [lua] init.lua:157: http_ssl_phase(): failed to fetch ssl config: failed to find SNI: please check if the client requests via IP or uses an outdated protocol. If you need to report an issue, provide a packet capture file of the TLS handshake., context: ssl_certificate_by_lua*, client: xx, server: 0.0.0.0:9443 ### Environment - apisix version 2.10.2: - OS centos7.9: - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, 3.4.0 - apisix-dashboard version, 2.9 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] netlify[bot] commented on pull request #814: docs: add Istio with APISIX Ingress blog
netlify[bot] commented on pull request #814: URL: https://github.com/apache/apisix-website/pull/814#issuecomment-996461821 Deploy Preview for *apache-apisix* processing. Explore the source changes: 7d1670149c3a617d844ad4115b4d87eb07767a14 Inspect the deploy log: [https://app.netlify.com/sites/apache-apisix/deploys/61bc2883801f0400072081fc](https://app.netlify.com/sites/apache-apisix/deploys/61bc2883801f0400072081fc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] SylviaBABY opened a new pull request #814: docs: add Istio with APISIX Ingress blog
SylviaBABY opened a new pull request #814: URL: https://github.com/apache/apisix-website/pull/814 Changes: add Istio with APISIX Ingress blog -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass commented on pull request #100: [WIP]refactor: switch from reactor-netty to netty, and support fetching var and body
tzssangglass commented on pull request #100: URL: https://github.com/apache/apisix-java-plugin-runner/pull/100#issuecomment-996455128 @nic-6443 @dmsolr here -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
shuaijinchao commented on a change in pull request #5819:
URL: https://github.com/apache/apisix/pull/5819#discussion_r771114819
##
File path: apisix/plugins/splunk-hec-logging.lua
##
@@ -0,0 +1,189 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core= require("apisix.core")
+local ngx = ngx
+local type= type
+local ngx_now = ngx.now
+local ngx_update_time = ngx.update_time
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+
+local DEFAULT_SPLUNK_HEC_ENTRY_SOURCE = "apache-apisix-splunk-hec-logging"
+local DEFAULT_SPLUNK_HEC_ENTRY_TYPE = "_json"
+
+
+local plugin_name = "splunk-hec-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+token = {
+type = "string",
+},
+channel = {
+type = "string",
+},
+timeout = {
+type = "integer",
+minimum = 1,
+default = 60
+}
+},
+required = { "uri", "token" }
+},
+ssl_verify = {
+type = "boolean",
+default = true
+},
+max_retry_count = {
+type = "integer",
+minimum = 0,
+default = 0
+},
+retry_delay = {
+type = "integer",
+minimum = 0,
+default = 1
+},
+buffer_duration = {
+type = "integer",
+minimum = 1,
+default = 60
+},
+inactive_timeout = {
+type = "integer",
+minimum = 1,
+default = 10
+},
+batch_max_size = {
+type = "integer",
+minimum = 1,
+default = 100
+},
+},
+required = { "endpoint" },
+}
+
+
+local function get_logger_entry(conf)
+local entry = log_util.get_full_log(ngx, conf)
+ngx_update_time()
+return {
+time = ngx_now(),
+host = entry.server.hostname,
+source = DEFAULT_SPLUNK_HEC_ENTRY_SOURCE,
+sourcetype = DEFAULT_SPLUNK_HEC_ENTRY_TYPE,
+event = {
+request_url = entry.request.url,
+request_method = entry.request.method,
+request_headers = entry.request.headers,
+request_query = entry.request.querystring,
+request_size = entry.request.size,
+response_headers = entry.response.headers,
+response_status = entry.response.status,
+response_size = entry.response.size,
+latency = entry.latency,
+upstream = entry.upstream,
+}
+}
+end
+
+
+local function send_to_splunk(conf, entries)
+if type(conf.endpoint) ~= "table" then
+return nil, "endpoint config invalid"
+end
+
+if not conf.endpoint.uri then
+return nil, "endpoint url undefined"
+end
+
+if not conf.endpoint.token then
+return nil, "endpoint token undefined"
+end
+
+local request_headers = {}
+request_headers["Content-Type"] = "application/json"
+request_headers["Authorization"] = "Splunk " .. conf.endpoint.token
+if conf.endpoint.channel then
+request_headers["X-Splunk-Request-Channel"] = conf.endpoint.channel
+end
+
+local http_new = http.new()
+local res, err = http_new:request_uri(conf.endpoint.uri, {
+ssl_verify = conf.ssl_verify,
+method = "POST",
+body = core.json.encode(entries),
+headers = request_headers,
+})
+
+if err then
+return nil, "failed to write log to splunk, " .. err
+end
+
+local body
+body, err = core.json.decode(res.body)
+if err then
+return nil, "failed to parse splunk response data, " .. err
+end
+
+if res.status ~= 200 then
Review comment:
If
[GitHub] [apisix] tzssangglass commented on a change in pull request #5793: docs: sync stream proxy Chinese version
tzssangglass commented on a change in pull request #5793: URL: https://github.com/apache/apisix/pull/5793#discussion_r771114198 ## File path: docs/zh/latest/stream-proxy.md ## @@ -72,7 +72,11 @@ curl http://127.0.0.1:9080/apisix/admin/stream_routes/1 -H 'X-API-KEY: edd1c9f03 ## 更多 route 匹配选项 -我们可以添加更多的选项来匹配 route。 +我们可以添加更多的选项来匹配 route。目前 stream 路由配置支持 3 个字段进行过滤： + +- server_addr: 接受四层（流式）连接的 APISIX 服务器的地址。 +- server_port: 接受四层（流式）连接的 APISIX 服务器的端口。 Review comment: `Stream Route` +1, because the above is also not translated, it is best to unify. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-java-plugin-runner] tzssangglass opened a new pull request #100: [WIP]refactor: switch from reactor-netty to netty, and support fetching var and body
tzssangglass opened a new pull request #100: URL: https://github.com/apache/apisix-java-plugin-runner/pull/100 Please answer these questions before submitting a pull request - Why submit this pull request? - [ ] Bugfix - [ ] New feature provided - [ ] Improve performance - Related issues ___ ### Bugfix - Description - How to fix? ___ ### New feature or improvement - Describe the details and related test reports. - Source branch - Related commits and pull requests - Target branch -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
shuaijinchao commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r771110588 ## File path: docs/en/latest/plugins/splunk-hec-logging.md ## @@ -0,0 +1,143 @@ +--- +title: splunk-hec-logging +--- + + + +## Summary + +- [**Name**](#name) +- [**Attributes**](#attributes) +- [**How To Enable**](#how-to-enable) +- [**Test Plugin**](#test-plugin) +- [**Disable Plugin**](#disable-plugin) + +## Name + +The `splunk-hec-logging` plugin is used to forward the request log of `Apache APISIX` to `Splunk HTTP Event Collector (HEC)` for analysis and storage. After the plugin is enabled, `Apache APISIX` will obtain request context information in `Log Phase` serialize it into [Splunk Event Data format](https://docs.splunk.com/Documentation/Splunk/latest/Data/FormateventsforHTTPEventCollector#Event_metadata) and submit to the batch queue. When the batch queue is triggered by a capacity or time threshold, the data in the queue will be submitted to `Splunk HEC`. Review comment: I don't feel this way. How do you think it would be more accurate to describe it? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5840: fix(core.log): log level need to be updated in some scenario
leslie-tsang commented on a change in pull request #5840:
URL: https://github.com/apache/apisix/pull/5840#discussion_r771108042
##
File path: apisix/core/log.lua
##
@@ -42,17 +43,27 @@ local log_levels = {
}
-local cur_level = ngx.config.subsystem == "http" and
- require "ngx.errlog" .get_sys_filter_level()
+local cur_level
+
local do_nothing = function() end
+local function log_level_update()
Review comment:
Sure
##
File path: apisix/core/log.lua
##
@@ -74,8 +85,9 @@ end
setmetatable(_M, {__index = function(self, cmd)
local log_level = log_levels[cmd]
-
local method
+log_level_update()
+
Review comment:
Make sense, may be we need a new implement of this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] spacewander edited a comment on issue #953: request help: Any plan for supporting the SM1/SM2/SM3/SM4 cryptographic algorithm?
spacewander edited a comment on issue #953: URL: https://github.com/apache/apisix/issues/953#issuecomment-996442219 For people who are interested in the GMSSL support feature: This task is in the TODO list but doesn't have a deadline. It looks like the modification of GMSSL has been merged into OpenSSL. But we have not tested it yet. If someone is willing to sponsor the development of GMSSL support, please contact us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #953: request help: Any plan for supporting the SM1/SM2/SM3/SM4 cryptographic algorithm?
spacewander commented on issue #953: URL: https://github.com/apache/apisix/issues/953#issuecomment-996442219 For people who are interested in the GMSSL support feature: This task is in the TODO list but doesn't have a plan. It looks like the modification of GMSSL has been merged into OpenSSL. But we have not tested it yet. If someone is willing to sponsor the development of GMSSL support, please contact us. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5844: bug: When will GM SSL be supported
spacewander commented on issue #5844: URL: https://github.com/apache/apisix/issues/5844#issuecomment-996438915 Let's move to https://github.com/apache/apisix/issues/953 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5844: bug: When will GM SSL be supported
spacewander closed issue #5844: URL: https://github.com/apache/apisix/issues/5844 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
spacewander commented on a change in pull request #5819:
URL: https://github.com/apache/apisix/pull/5819#discussion_r771086695
##
File path: apisix/plugins/splunk-hec-logging.lua
##
@@ -0,0 +1,189 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core= require("apisix.core")
+local ngx = ngx
+local type= type
+local ngx_now = ngx.now
+local ngx_update_time = ngx.update_time
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+
+local DEFAULT_SPLUNK_HEC_ENTRY_SOURCE = "apache-apisix-splunk-hec-logging"
+local DEFAULT_SPLUNK_HEC_ENTRY_TYPE = "_json"
+
+
+local plugin_name = "splunk-hec-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+token = {
+type = "string",
+},
+channel = {
+type = "string",
+},
+timeout = {
+type = "integer",
+minimum = 1,
+default = 60
+}
+},
+required = { "uri", "token" }
+},
+ssl_verify = {
+type = "boolean",
+default = true
+},
+max_retry_count = {
+type = "integer",
+minimum = 0,
+default = 0
+},
+retry_delay = {
+type = "integer",
+minimum = 0,
+default = 1
+},
+buffer_duration = {
+type = "integer",
+minimum = 1,
+default = 60
+},
+inactive_timeout = {
+type = "integer",
+minimum = 1,
+default = 10
+},
+batch_max_size = {
+type = "integer",
+minimum = 1,
+default = 100
+},
+},
+required = { "endpoint" },
+}
+
+
+local function get_logger_entry(conf)
+local entry = log_util.get_full_log(ngx, conf)
+ngx_update_time()
Review comment:
The timestamp here is not critical. We don't need to always update the
cache.
##
File path: apisix/plugins/splunk-hec-logging.lua
##
@@ -0,0 +1,189 @@
+--
+-- Licensed to the Apache Software Foundation (ASF) under one or more
+-- contributor license agreements. See the NOTICE file distributed with
+-- this work for additional information regarding copyright ownership.
+-- The ASF licenses this file to You under the Apache License, Version 2.0
+-- (the "License"); you may not use this file except in compliance with
+-- the License. You may obtain a copy of the License at
+--
+-- http://www.apache.org/licenses/LICENSE-2.0
+--
+-- Unless required by applicable law or agreed to in writing, software
+-- distributed under the License is distributed on an "AS IS" BASIS,
+-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+-- See the License for the specific language governing permissions and
+-- limitations under the License.
+--
+
+local core= require("apisix.core")
+local ngx = ngx
+local type= type
+local ngx_now = ngx.now
+local ngx_update_time = ngx.update_time
+local http= require("resty.http")
+local log_util= require("apisix.utils.log-util")
+local bp_manager_mod = require("apisix.utils.batch-processor-manager")
+
+
+local DEFAULT_SPLUNK_HEC_ENTRY_SOURCE = "apache-apisix-splunk-hec-logging"
+local DEFAULT_SPLUNK_HEC_ENTRY_TYPE = "_json"
+
+
+local plugin_name = "splunk-hec-logging"
+local batch_processor_manager = bp_manager_mod.new(plugin_name)
+
+
+local schema = {
+type = "object",
+properties = {
+endpoint = {
+type = "object",
+properties = {
+uri = core.schema.uri_def,
+token = {
+type = "string",
+},
+
[GitHub] [apisix] spacewander edited a comment on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://
spacewander edited a comment on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-996420133 The luarocks 2.x has been broken for a time. This PR just admitted it. In fact, it doesn't handle the new rockspec format and the dependency management which have been reported by the user. That is why the issue template requires people to submit their luarocks version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on a change in pull request #5840: fix(core.log): log level need to be updated in some scenario
spacewander commented on a change in pull request #5840:
URL: https://github.com/apache/apisix/pull/5840#discussion_r771102522
##
File path: apisix/core/log.lua
##
@@ -42,17 +43,27 @@ local log_levels = {
}
-local cur_level = ngx.config.subsystem == "http" and
- require "ngx.errlog" .get_sys_filter_level()
+local cur_level
+
local do_nothing = function() end
+local function log_level_update()
Review comment:
```suggestion
local function update_log_level()
```
would be better?
##
File path: apisix/core/log.lua
##
@@ -74,8 +85,9 @@ end
setmetatable(_M, {__index = function(self, cmd)
local log_level = log_levels[cmd]
-
local method
+log_level_update()
+
Review comment:
There is an issue: if we call the log.xxx in the init phase, we will
always generate the method and affect the later phases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] 532810439 commented on issue #5844: bug: When will GM SSL be supported
532810439 commented on issue #5844: URL: https://github.com/apache/apisix/issues/5844#issuecomment-996433121 http://www.gb688.cn/bzgk/gb/newGbInfo?hcno=778097598DA2761E94A5FF3F77BD66DA -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2251: ci: remove push docker image to demo env
zaunist commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996428789 If we delete the push step, the deploy-with-docker.yaml maybe delete together. Otherwise it doesn't make sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] codecov-commenter commented on pull request #2251: ci: remove push docker image to demo env
codecov-commenter commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996427538 # [Codecov](https://codecov.io/gh/apache/apisix-dashboard/pull/2251?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#2251](https://codecov.io/gh/apache/apisix-dashboard/pull/2251?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (ba1ee5e) into [master](https://codecov.io/gh/apache/apisix-dashboard/commit/0b1abafb0817c1faf428750a3aa2c37b61e417b3?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (0b1abaf) will **decrease** coverage by `1.67%`. > The diff coverage is `n/a`. [](https://codecov.io/gh/apache/apisix-dashboard/pull/2251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) ```diff @@Coverage Diff @@ ## master#2251 +/- ## == - Coverage 69.79% 68.12% -1.68% == Files 184 127 -57 Lines7274 3369-3905 Branches 829 829 == - Hits 5077 2295-2782 + Misses 1902 1074 -828 + Partials 2950 -295 ``` | Flag | Coverage Δ | | |---|---|---| | backend-e2e-test | `?` | | | backend-e2e-test-ginkgo | `?` | | | backend-unit-test | `?` | | | frontend-e2e-test | `68.12% <ø> (+0.05%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/apache/apisix-dashboard/pull/2251?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [api/internal/handler/migrate/migrate.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2251/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2hhbmRsZXIvbWlncmF0ZS9taWdyYXRlLmdv) | | | | [api/internal/utils/consts/api\_error.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2251/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2NvbnN0cy9hcGlfZXJyb3IuZ28=) | | | | [api/internal/utils/utils.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2251/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL3V0aWxzLmdv) | | | | [api/internal/core/entity/format.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2251/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2Zvcm1hdC5nbw==) | | | | [api/internal/filter/cors.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2251/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2ZpbHRlci9jb3JzLmdv) | | | | [api/internal/core/entity/interface.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2251/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2ludGVyZmFjZS5nbw==) | | | | [api/internal/core/entity/entity.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2251/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL2NvcmUvZW50aXR5L2VudGl0eS5nbw==) | | | | [api/internal/utils/closer.go](https://codecov.io/gh/apache/apisix-dashboard/pull/2251/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-YXBpL2ludGVybmFsL3V0aWxzL2Nsb3Nlci5nbw==) | | | |
[apisix] branch master updated (c3ba11f -> 07630c7)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from c3ba11f docs(logging): supplement the supported logging service (#5843) add 07630c7 docs: add offline install to 'how-to-build.md' (#5829) No new revisions were added by this update. Summary of changes: docs/en/latest/how-to-build.md | 17 + docs/zh/latest/how-to-build.md | 17 + 2 files changed, 34 insertions(+)
[GitHub] [apisix] spacewander merged pull request #5829: docs: add offline install to 'how-to-build.md'
spacewander merged pull request #5829: URL: https://github.com/apache/apisix/pull/5829 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #5785: request help: add offline installation for `how-to-build.md`
spacewander closed issue #5785: URL: https://github.com/apache/apisix/issues/5785 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
shuaijinchao commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r771091241 ## File path: docs/en/latest/plugins/splunk-hec-logging.md ## @@ -0,0 +1,143 @@ +--- +title: splunk-hec-logging +--- + + + +## Summary + +- [**Name**](#name) +- [**Attributes**](#attributes) +- [**How To Enable**](#how-to-enable) +- [**Test Plugin**](#test-plugin) +- [**Disable Plugin**](#disable-plugin) + +## Name + +The `splunk-hec-logging` plugin is used to forward the request log of `Apache APISIX` to `Splunk HTTP Event Collector (HEC)` for analysis and storage. After the plugin is enabled, `Apache APISIX` will obtain request context information in `Log Phase` serialize it into [Splunk Event Data format](https://docs.splunk.com/Documentation/Splunk/latest/Data/FormateventsforHTTPEventCollector#Event_metadata) and submit to the batch queue. When the batch queue is triggered by a capacity or time threshold, the data in the queue will be submitted to `Splunk HEC`. + +For more info on Batch-Processor in Apache APISIX please refer to: +[Batch-Processor](../batch-processor.md) + +## Attributes + +| Name| Requirement | Default | Description | +| --- | - | - | | +| endpoint| required | | Splunk HEC endpoint configuration info | +| endpoint.uri| required | | Splunk HEC event collector API | +| endpoint.token | required | | Splunk HEC authentication token | +| endpoint.channel| optional | | Splunk HEC send data channel identifier, refer to: [About HTTP Event Collector Indexer Acknowledgment](https://docs.splunk.com/Documentation/Splunk/8.2.3/Data/AboutHECIDXAck) | +| endpoint.timeout| optional | 60 | Splunk HEC send data timeout | Review comment: time unit is seconds, document updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://
spacewander commented on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-996420133 The luarocks 2.x doesn't be broken because of the git URL. In fact, it doesn't handle the new rockspec format and the dependency management which have been reported by the user. It has been broken for a time. This PR just admitted it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5825: feat: upgrade luarocks to 3.8.0 which converts git:// to https://
spacewander commented on pull request #5825: URL: https://github.com/apache/apisix/pull/5825#issuecomment-996419334 No, as I mentioned in the commit message. The luarocks 2.x is actually broken. We just make sure people won't be trapped in it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tokers commented on issue #5844: bug: When will GM SSL be supported
tokers commented on issue #5844: URL: https://github.com/apache/apisix/issues/5844#issuecomment-996417546 I'm not so familiar with the GM SSL, could you give us the white paper, or the specification link, and some implementations? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated (4855813 -> c3ba11f)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a change to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git. from 4855813 docs(request-id): fix typo in request-id plugin documents. (#5832) add c3ba11f docs(logging): supplement the supported logging service (#5843) No new revisions were added by this update. Summary of changes: README.md| 2 +- docs/zh/latest/README.md | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
[GitHub] [apisix] 532810439 opened a new issue #5844: bug: When will GM SSL be supported
532810439 opened a new issue #5844: URL: https://github.com/apache/apisix/issues/5844 ### Issue description GM/T 0024-2014 SSL VPN specification ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): 2.11 ### Steps to reproduce GM SSL be supported ### Actual result == ### Error log == ### Expected result _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis merged pull request #5843: docs(logging): supplement the supported logging service
membphis merged pull request #5843: URL: https://github.com/apache/apisix/pull/5843 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] 532810439 opened a new issue #2252: When will GM SSL be supported
532810439 opened a new issue #2252: URL: https://github.com/apache/apisix-dashboard/issues/2252 ### Issue description GM/T 0024-2014 SSL VPN specification ### Expected behavior GM SSL be supported ### How to Reproduce 2.8 ### Screenshots apisix dashboard release ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `etcd --version`): - apisix-dashboard version, if have: - Browser version, if have: ### Additional context _No response_ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] zaunist commented on pull request #2251: ci: remove push docker image to demo env
zaunist commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996415535 If we delete the push step, the deploy-with-docker.yaml maybe delete together. Otherwise it doesn't make sense -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao opened a new pull request #5843: docs(logging): supplement the supported logging service
shuaijinchao opened a new pull request #5843: URL: https://github.com/apache/apisix/pull/5843 ### What this PR does / why we need it: ### Pre-submission checklist: * [ ] Did you explain what problem does this PR solve? Or what new features have been added? * [ ] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [x] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #5819: feat(splunk): support splunk hec logging plugin
membphis commented on a change in pull request #5819: URL: https://github.com/apache/apisix/pull/5819#discussion_r771085017 ## File path: docs/en/latest/plugins/splunk-hec-logging.md ## @@ -0,0 +1,143 @@ +--- +title: splunk-hec-logging +--- + + + +## Summary + +- [**Name**](#name) +- [**Attributes**](#attributes) +- [**How To Enable**](#how-to-enable) +- [**Test Plugin**](#test-plugin) +- [**Disable Plugin**](#disable-plugin) + +## Name + +The `splunk-hec-logging` plugin is used to forward the request log of `Apache APISIX` to `Splunk HTTP Event Collector (HEC)` for analysis and storage. After the plugin is enabled, `Apache APISIX` will obtain request context information in `Log Phase` serialize it into [Splunk Event Data format](https://docs.splunk.com/Documentation/Splunk/latest/Data/FormateventsforHTTPEventCollector#Event_metadata) and submit to the batch queue. When the batch queue is triggered by a capacity or time threshold, the data in the queue will be submitted to `Splunk HEC`. + +For more info on Batch-Processor in Apache APISIX please refer to: +[Batch-Processor](../batch-processor.md) + +## Attributes + +| Name| Requirement | Default | Description | +| --- | - | - | | +| endpoint| required | | Splunk HEC endpoint configuration info | +| endpoint.uri| required | | Splunk HEC event collector API | +| endpoint.token | required | | Splunk HEC authentication token | +| endpoint.channel| optional | | Splunk HEC send data channel identifier, refer to: [About HTTP Event Collector Indexer Acknowledgment](https://docs.splunk.com/Documentation/Splunk/8.2.3/Data/AboutHECIDXAck) | +| endpoint.timeout| optional | 60 | Splunk HEC send data timeout | Review comment: What is the time unit? Seconds or milliseconds? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan opened a new issue #5842: docs: fold phrase in Chinese into one line
juzhiyuan opened a new issue #5842: URL: https://github.com/apache/apisix/issues/5842 ### Improved or typo fixed. Hi, In our Chinese Documentations, we have `breaking lines` in original markdowns, e.g ```text `Plugin` 配置可直接绑定在 `Route` 上，也可以被绑定在 `Service` 或 `Consumer`上。而对于同一 个插件的配置，只能有一份是有效的，配置选择优先级总是 `Consumer` > `Route` > `Service`。 在 `conf/config.yaml` 中，可以声明本地 APISIX 节点都支持哪些插件。这是个白名单机制，不在该 白名单的插件配置，都将会被自动忽略。这个特性可用于临时关闭或打开特定插件，应对突发情况非常有效。 如果你想在现有插件的基础上新增插件，注意需要拷贝 `conf/config-default.yaml` 的插件节点内容到 `conf/config.yaml` 的插件节点中。 ``` And it's be rendered differently in different browsers, e.g **Chrome**  **Firfox**  Here has one PR about this: https://github.com/apache/apisix/pull/5823 ### Solution After discussions in PR #5823, @Josh-Cena suggested we could use Prettier[1] to format our Chinese documentations with `"proseWrap": "never"` enabled, and it will collapse all wrapping line breaks. And also, Zexuan Luo suggested[2] we could add a CI to check this case 拾 BTW, for the reason why it will have a different rendered effect, please see this comment[3]. [1] https://prettier.io/ [2] https://github.com/apache/apisix/pull/5823#issuecomment-996346967 [3] https://github.com/apache/apisix/pull/5823#discussion_r770244886 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis merged pull request #5832: docs: Fix typo in request-id plugin documents.
membphis merged pull request #5832: URL: https://github.com/apache/apisix/pull/5832 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs(request-id): fix typo in request-id plugin documents. (#5832)
This is an automated email from the ASF dual-hosted git repository. membphis pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 4855813 docs(request-id): fix typo in request-id plugin documents. (#5832) 4855813 is described below commit 4855813e617f15594e8b2fd47514a424759c8d35 Author: Carl Chen AuthorDate: Fri Dec 17 11:39:16 2021 +0800 docs(request-id): fix typo in request-id plugin documents. (#5832) --- docs/en/latest/plugins/request-id.md | 4 ++-- docs/zh/latest/plugins/request-id.md | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/docs/en/latest/plugins/request-id.md b/docs/en/latest/plugins/request-id.md index 871c542..7a29ade 100644 --- a/docs/en/latest/plugins/request-id.md +++ b/docs/en/latest/plugins/request-id.md @@ -105,7 +105,7 @@ plugin_attr: - `snowflake_epoc` default start time is `2021-01-01T00:00:00Z`, and it can support `69 year` approximately to `2090-09-0715:47:35Z` according to the default configuration - `data_machine_bits` corresponds to the set of workIDs and datacEnteridd in the snowflake definition. The plug-in aslocates a unique ID to each process. Maximum number of supported processes is `pow(2, data_machine_bits)`. The default number of `12 bits` is up to `4096`. -- `sequence_bits` defaults to `10 bits` and each process generates up to `1024` ID per second +- `sequence_bits` defaults to `10 bits` and each process generates up to `1024` ID per millisecond. example @@ -115,7 +115,7 @@ plugin_attr: > - Start time 2014-10-20 T15:00:00.000z, accurate to milliseconds. It can > last about 69 years > - supports up to `1024` processes -> - Up to `4096` ID per second per process +> - Up to `4096` ID per millisecond per process ```yaml plugin_attr: diff --git a/docs/zh/latest/plugins/request-id.md b/docs/zh/latest/plugins/request-id.md index 5cbc42c..87ab863 100644 --- a/docs/zh/latest/plugins/request-id.md +++ b/docs/zh/latest/plugins/request-id.md @@ -104,7 +104,7 @@ plugin_attr: - snowflake_epoc 默认起始时间为 `2021-01-01T00:00:00Z`, 按默认配置可以支持 `69年` 大约可以使用到 `2090-09-07 15:47:35Z` - data_machine_bits 对应的是 snowflake 定义中的 WorkerID 和 DatacenterID 的集合，插件会为每一个进程分配一个唯一ID，最大支持进程数为 `pow(2, data_machine_bits)`。默认占 `12 bits` 最多支持 `4096` 个进程。 -- sequence_bits 默认占 `10 bits`, 每个进程每秒最多生成 `1024` 个ID +- sequence_bits 默认占 `10 bits`, 每个进程每毫秒最多生成 `1024` 个ID 配置示例 @@ -114,7 +114,7 @@ plugin_attr: > - 起始时间 2014-10-20T15:00:00.000Z， 精确到毫秒为单位。大约可以使用 `69年` > - 最多支持 `1024` 个进程 -> - 每个进程每秒最多产生 `4096` 个ID +> - 每个进程每毫秒最多产生 `4096` 个ID ```yaml plugin_attr:
[GitHub] [apisix] gxthrj commented on issue #5780: DISCUSS: Add a plugin that filters specific requests through regular matching
gxthrj commented on issue #5780: URL: https://github.com/apache/apisix/issues/5780#issuecomment-996409398 > I think it's a big thing, so please send this discussion to ML too, thanks. OK, will send to ML today. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] gxthrj commented on issue #5780: DISCUSS: Add a plugin that filters specific requests through regular matching
gxthrj commented on issue #5780: URL: https://github.com/apache/apisix/issues/5780#issuecomment-996409264 > so do you means Apache APISIX needs a WAF plugin? I think APISIX needs WAF plugin，but it is a universal plug-in with regular matching conditions, not enough to solve all WAF problems. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters
juzhiyuan commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996404873 Get it, I will create an issue to track this 拾 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Josh-Cena commented on pull request #5823: docs: remove the redundant space between Chinese characters
Josh-Cena commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996403699 Yeah, that could be helpful 浪 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan edited a comment on pull request #5823: docs: remove the redundant space between Chinese characters
juzhiyuan edited a comment on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996403248 > So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `proseWrap: 'none'` and it will collapse all wrapping line breaks. Just to make sure, do you mean to use Prettier to format all markdown files in this repo? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters
juzhiyuan commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996403248 > So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `proseWrap: 'none'` and it will collapse all wrapping line breaks. Just to make sure, do you mean to use Prettier to format all markdown files in this repo? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Josh-Cena edited a comment on pull request #5823: docs: remove the redundant space between Chinese characters
Josh-Cena edited a comment on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996402605 So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `"proseWrap": "never"` and it will collapse all wrapping line breaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Josh-Cena commented on pull request #5823: docs: remove the redundant space between Chinese characters
Josh-Cena commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996402605 So if you use [Prettier](https://prettier.io/) in the website, you can just configure it to `proseWrap: 'none'` and it will collapse all wrapping line breaks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan merged pull request #2248: feat(plugin): change button desc
juzhiyuan merged pull request #2248: URL: https://github.com/apache/apisix-dashboard/pull/2248 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan closed issue #2245: The `禁用` button on the plugin list page has ambiguity issues
juzhiyuan closed issue #2245: URL: https://github.com/apache/apisix-dashboard/issues/2245 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix-dashboard] branch master updated: feat(plugin): change button desc (#2248)
This is an automated email from the ASF dual-hosted git repository.
juzhiyuan pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix-dashboard.git
The following commit(s) were added to refs/heads/master by this push:
new 40822d7 feat(plugin): change button desc (#2248)
40822d7 is described below
commit 40822d7a803ce3152f90a8b1606a9af9a19b1f8d
Author: Yu.Bozhong
AuthorDate: Fri Dec 17 11:14:16 2021 +0800
feat(plugin): change button desc (#2248)
---
web/src/components/Plugin/locales/en-US.ts | 2 +-
web/src/components/Plugin/locales/zh-CN.ts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/web/src/components/Plugin/locales/en-US.ts
b/web/src/components/Plugin/locales/en-US.ts
index d62764d..1ec4b1b 100644
--- a/web/src/components/Plugin/locales/en-US.ts
+++ b/web/src/components/Plugin/locales/en-US.ts
@@ -24,7 +24,7 @@ export default {
'component.plugin.pluginTemplate.tip2':
'2. The same plugin in the plugin template will override one in the
plugins.',
'component.plugin.enable': 'Enable',
- 'component.plugin.disable': 'Disable',
+ 'component.plugin.disable': 'Edit',
'component.plugin.authentication': 'Authentication',
'component.plugin.security': 'Security',
'component.plugin.traffic': 'Traffic Control',
diff --git a/web/src/components/Plugin/locales/zh-CN.ts
b/web/src/components/Plugin/locales/zh-CN.ts
index c76f2d3..094af63 100644
--- a/web/src/components/Plugin/locales/zh-CN.ts
+++ b/web/src/components/Plugin/locales/zh-CN.ts
@@ -23,7 +23,7 @@ export default {
'1. 若路由已配置插件，则插件模板数据将与已配置的插件数据合并。',
'component.plugin.pluginTemplate.tip2': '2. 插件模板相同的插件会覆盖掉原有的插件。',
'component.plugin.enable': '启用',
- 'component.plugin.disable': '禁用',
+ 'component.plugin.disable': '编辑',
'component.plugin.authentication': '身份验证',
'component.plugin.security': '安全防护',
'component.plugin.traffic': '流量控制',
[GitHub] [apisix] juzhiyuan commented on issue #5834: request help: how to set redirect_uri, when i use openid-connect
juzhiyuan commented on issue #5834: URL: https://github.com/apache/apisix/issues/5834#issuecomment-996401543 Hi @leslie-tsang, would you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters
juzhiyuan commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996398822 > I honestly think this is a legitimate fix and we can just fix this everywhere if needed Hi @Josh-Cena, I can't clearly remember why we have breaking lines in our docs And +1 from me to improve the original docs by folding Chinese phrases into one line. @Nidaozi Would you please have a try?  Hi @spacewander, how about improving those markdown files first, then deciding if we need to implement the CI? Just to make sure, you mean we could use CI to check all coming Chinese documentation changes, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] webup commented on issue #182: feat: add service monitor for main chart
webup commented on issue #182: URL: https://github.com/apache/apisix-helm-chart/issues/182#issuecomment-996397990 Closed with #192. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-helm-chart] webup closed issue #182: feat: add service monitor for main chart
webup closed issue #182: URL: https://github.com/apache/apisix-helm-chart/issues/182 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] juzhiyuan commented on pull request #2251: ci: remove push docker image to demo env
juzhiyuan commented on pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251#issuecomment-996395345 Hi, may I know visitors how to use the manager-api? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang opened a new pull request #5840: fix(core.log): log level need to be updated in some scenario
leslie-tsang opened a new pull request #5840:
URL: https://github.com/apache/apisix/pull/5840
### What this PR does / why we need it:
log level need to be update in some scenario, such as called in init phase.
POC:
> set error_log log level as `error`
```yaml
extra_lua_path: ""# extend lua_package_path to load third
party code
extra_lua_cpath: "" # extend lua_package_cpath to load third
party code
lua_module_hook: "my_project.my_hook" # the hook module which will be
used to inject third party code into APISIX
```
```lua
# code in my_project.my_hook
local core.log = require("apisix.core.log")
core_log.info("test")
# `info` func will be cached in `apisix.core.log`
# which break the expectation of the error_log log level
```
### Pre-submission checklist:
* [x] Did you explain what problem does this PR solve? Or what new features
have been added?
* [ ] Have you added corresponding test cases?
* [ ] Have you modified the corresponding document?
* [x] Is this PR backward compatible? **If it is not backward compatible,
please discuss on the [mailing
list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] dmsolr removed a comment on issue #4301: bug: skywalking not work when upsteam timeout
dmsolr removed a comment on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996393391 I am sorry for pending long time. I am going to release a version before next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dmsolr commented on issue #4301: bug: skywalking not work when upsteam timeout
dmsolr commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996393391 I am sorry for pending long time. I am going to release a version before next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] dmsolr commented on issue #4301: bug: skywalking not work when upsteam timeout
dmsolr commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996392753 I am sorry for pending long time. I am going to release a version before next week. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on issue #3498: apisix access have 500 status code
membphis commented on issue #3498: URL: https://github.com/apache/apisix/issues/3498#issuecomment-996392247 ok, got it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis closed issue #3498: apisix access have 500 status code
membphis closed issue #3498: URL: https://github.com/apache/apisix/issues/3498 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao opened a new pull request #5839: chore(google-cloud-logging): move ssl_verify to plugin configuration top level
shuaijinchao opened a new pull request #5839: URL: https://github.com/apache/apisix/pull/5839 ### What this PR does / why we need it: FIX #5838 ### Pre-submission checklist: * [x] Did you explain what problem does this PR solve? Or what new features have been added? * [x] Have you added corresponding test cases? * [x] Have you modified the corresponding document? * [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first** -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] shuaijinchao opened a new issue #5838: improve: google-cloud-logging unable to set up SSL Verify
shuaijinchao opened a new issue #5838:
URL: https://github.com/apache/apisix/issues/5838
### Issue description
`google-cloud-logging` SSL verification settings currently need to be
configured in the auth_config structure or auth_file configuration file to take
effect. Currently, when using the file key configuration configuration, the key
file downloaded from Google Cloud is usually configured directly into APISIX.
The default file does not contain SSL-related settings. At this time, SSL
Verify cannot be dynamically adjusted through the plug-in configuration.
Solution: Adjust the configuration of SSL Verify to the primary structure of
the plugin configuration.
For example:
```json
{
"google-cloud-logging":{
"auth_file":"/path/to/private_key.json",
"ssl_verify":true,
"...":"..."
}
}
```
### Environment
- apisix version (cmd: `apisix version`):
- OS (cmd: `uname -a`):
- OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`):
- etcd version, if have (cmd: run `curl
http://127.0.0.1:9090/v1/server_info` to get the info from server-info API):
- apisix-dashboard version, if have:
- the plugin runner version, if the issue is about a plugin runner (cmd:
depended on the kind of runner):
- luarocks version, if the issue is about installation (cmd: `luarocks
--version`):
### Steps to reproduce
google-cloud-logging
### Actual result
google-cloud-logging
### Error log
google-cloud-logging
### Expected result
_No response_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] chanjet1213 opened a new issue #5837: 期待监控指标添加对nginx共享内存使用情况的监控
chanjet1213 opened a new issue #5837: URL: https://github.com/apache/apisix/issues/5837 ### Issue description 期待监控指标添加对nginx共享内存使用情况的监控 ### Environment - apisix version (cmd: `apisix version`): - OS (cmd: `uname -a`): - OpenResty / Nginx version (cmd: `nginx -V` or `openresty -V`): - etcd version, if have (cmd: run `curl http://127.0.0.1:9090/v1/server_info` to get the info from server-info API): - apisix-dashboard version, if have: - the plugin runner version, if the issue is about a plugin runner (cmd: depended on the kind of runner): - luarocks version, if the issue is about installation (cmd: `luarocks --version`): -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] wu-sheng commented on issue #4301: bug: skywalking not work when upsteam timeout
wu-sheng commented on issue #4301: URL: https://github.com/apache/apisix/issues/4301#issuecomment-996378124 @dmsolr Any update about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] nic-chen opened a new pull request #2251: ci: remove push docker image to demo env
nic-chen opened a new pull request #2251: URL: https://github.com/apache/apisix-dashboard/pull/2251 Please answer these questions before submitting a pull request, **or your PR will get closed**. **Why submit this pull request?** - [x] Bugfix - [ ] New feature provided - [ ] Improve performance - [ ] Backport patches **What changes will this PR take into?** remove push docker image to demo env in Github Actions **Checklist:** - [x] Did you explain what problem does this PR solve? Or what new features have been added? - [ ] Have you added corresponding test cases? - [ ] Have you modified the corresponding document? - [x] Is this PR backward compatible? If it is not backward compatible, please discuss on the mailing list first -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zjzwjcbj commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua
zjzwjcbj commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-996357675 > @zjzwjcbj we can close this? Ok,thanks. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zjzwjcbj closed issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua
zjzwjcbj closed issue #5817: URL: https://github.com/apache/apisix/issues/5817 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander edited a comment on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy
spacewander edited a comment on issue #5802:
URL: https://github.com/apache/apisix/issues/5802#issuecomment-996355964
Interesting. Here is the result running on my machine:
```
incubator-apisix (master) 0
￥ mosquitto_sub -t test -v &
[1] 23990
incubator-apisix (master) 0
￥ mosquitto_pub -t test -m "Hello" -p 9100
test Hello
```
My stream route conf is:
```
{"plugins":{"mqtt-proxy":{"protocol_level":4,"protocol_name":"MQTT","upstream":{"host":"127.0.0.1","port":1883
```
My config.yaml is:
```
apisix:
#dns_resolver: # If not set, read from `/etc/resolv.conf`
#- 127.0.0.1:1053
enable_admin: true
stream_proxy: # TCP/UDP proxy
only: false
tcp:# TCP proxy port list
- addr: 9100
```
My mosquitto_pub version is:
```
mosquitto_pub --version
mosquitto_pub version 2.0.14 running on libmosquitto 2.0.14.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5814: bug: java plugin error permission denied
tzssangglass commented on issue #5814: URL: https://github.com/apache/apisix/issues/5814#issuecomment-996356616 @sunyu-2020 If you verify this is complete, would you be willing to submit a PR to add documentation about this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5827: init_worker_by_lua error: ./apisix/plugins/prometheus/exporter.lua:17: module 'prometheus' not found:
tzssangglass commented on issue #5827: URL: https://github.com/apache/apisix/issues/5827#issuecomment-996355925 zip file is source code of APISIX, as @spacewander said, you need to build APISIX form source code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #5802: bug: no connection to MQTT broker possible by using mqtt_proxy
spacewander commented on issue #5802:
URL: https://github.com/apache/apisix/issues/5802#issuecomment-996355964
Interesting. Here is the result running on my machine:
```
incubator-apisix (master) 0
￥ mosquitto_sub -t test -v &
[1] 23990
incubator-apisix (master) 0
￥ mosquitto_pub -t test -m "Hello" -p 9100
test Hello
```
My stream route conf is:
```
{"plugins":{"mqtt-proxy":{"protocol_level":4,"protocol_name":"MQTT","upstream":{"host":"127.0.0.1","port":1883
```
My config.yaml is:
```
apisix:
#dns_resolver: # If not set, read from `/etc/resolv.conf`
#- 127.0.0.1:1053
enable_admin: true
stream_proxy: # TCP/UDP proxy
only: false
tcp:# TCP proxy port list
- addr: 9100
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #5829: docs: add offline install to 'how-to-build.md'
leslie-tsang commented on a change in pull request #5829: URL: https://github.com/apache/apisix/pull/5829#discussion_r771035675 ## File path: docs/en/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### Installation via RPM Offline Package(CentOS 7) + +Download APISIX offline RPM package to `./apisix` folder + +```shell +$ sudo mkdir -p apisix +$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +$ sudo yum clean all && yum makecache +$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix Review comment: yep -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on pull request #5823: docs: remove the redundant space between Chinese characters
spacewander commented on pull request #5823: URL: https://github.com/apache/apisix/pull/5823#issuecomment-996346967 What about providing a check to the Chinese doc? We can add a script to check if 1. the last char of the line is not ascii 2. the next line is not empty 3. the first char of the next line is not ascii If so, we can fold the Chinese phrase into one line. Such script can be integrated into the CI: https://github.com/apache/apisix/blob/fce2b44f5fe5c3358ec7dcdeb8fdb5530ee3e8a2/.github/workflows/doc-lint.yml#L22 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5829: docs: add offline install to 'how-to-build.md'
juzhiyuan commented on a change in pull request #5829: URL: https://github.com/apache/apisix/pull/5829#discussion_r771032942 ## File path: docs/en/latest/how-to-build.md ## @@ -54,6 +54,23 @@ $ sudo yum --showduplicates list apisix $ sudo yum install apisix ``` +### Installation via RPM Offline Package(CentOS 7) + +Download APISIX offline RPM package to `./apisix` folder + +```shell +$ sudo mkdir -p apisix +$ sudo yum install -y https://repos.apiseven.com/packages/centos/apache-apisix-repo-1.0-1.noarch.rpm +$ sudo yum clean all && yum makecache +$ sudo yum install -y --downloadonly --downloaddir=./apisix apisix Review comment: `uptime` is a command, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on a change in pull request #5793: docs: sync stream proxy Chinese version
juzhiyuan commented on a change in pull request #5793: URL: https://github.com/apache/apisix/pull/5793#discussion_r771032513 ## File path: docs/zh/latest/stream-proxy.md ## @@ -72,7 +72,11 @@ curl http://127.0.0.1:9080/apisix/admin/stream_routes/1 -H 'X-API-KEY: edd1c9f03 ## 更多 route 匹配选项 -我们可以添加更多的选项来匹配 route。 +我们可以添加更多的选项来匹配 route。目前 stream 路由配置支持 3 个字段进行过滤： + +- server_addr: 接受四层（流式）连接的 APISIX 服务器的地址。 +- server_port: 接受四层（流式）连接的 APISIX 服务器的端口。 Review comment: Hi @tzssangglass, should we use `四层（流式）` or `Stream Route`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5826: request help: How to get request header and response header?
tzssangglass commented on issue #5826: URL: https://github.com/apache/apisix/issues/5826#issuecomment-996345395 `core.request.header()` or `core.request.headers()`, it is easy to search in the code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua
tzssangglass commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-996344675 @zjzwjcbj we can close this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5817: request help: mac m1 make install error cannot mkdir /usr/share/lua
tzssangglass commented on issue #5817: URL: https://github.com/apache/apisix/issues/5817#issuecomment-996344485 Recommended for development on x86 systems, dependency support on M1 is not complete. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #5820: fix(sls-logger): log entry unable get millisecond timestamp
spacewander merged pull request #5820: URL: https://github.com/apache/apisix/pull/5820 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix(sls-logger): log entry unable get millisecond timestamp (#5820)
This is an automated email from the ASF dual-hosted git repository.
spacewander pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new fce2b44 fix(sls-logger): log entry unable get millisecond timestamp
(#5820)
fce2b44 is described below
commit fce2b44f5fe5c3358ec7dcdeb8fdb5530ee3e8a2
Author: 帅进超
AuthorDate: Fri Dec 17 09:06:31 2021 +0800
fix(sls-logger): log entry unable get millisecond timestamp (#5820)
---
apisix/plugins/slslog/rfc5424.lua | 9 +++--
t/plugin/sls-logger.t | 76 +++
2 files changed, 57 insertions(+), 28 deletions(-)
diff --git a/apisix/plugins/slslog/rfc5424.lua
b/apisix/plugins/slslog/rfc5424.lua
index ff73d19..5d09a58 100644
--- a/apisix/plugins/slslog/rfc5424.lua
+++ b/apisix/plugins/slslog/rfc5424.lua
@@ -78,16 +78,15 @@ local Severity = {
DEBUG = LOG_DEBUG,
}
-local os_date = os.date
-local ngx = ngx
-local rfc5424_timestamp_format = "!%Y-%m-%dT%H:%M:%S.000Z"
+local log_util = require("apisix.utils.log-util")
+
+
local _M = { version = 0.1 }
function _M.encode(facility, severity, hostname, appname, pid, project,
logstore, access_key_id, access_key_secret, msg)
local pri = (Facility[facility] * 8 + Severity[severity])
-ngx.update_time()
-local t = os_date(rfc5424_timestamp_format, ngx.now())
+local t = log_util.get_rfc3339_zulu_timestamp()
if not hostname then
hostname = "-"
end
diff --git a/t/plugin/sls-logger.t b/t/plugin/sls-logger.t
index 7e8b1eb..296372c 100644
--- a/t/plugin/sls-logger.t
+++ b/t/plugin/sls-logger.t
@@ -19,7 +19,21 @@ use t::APISIX 'no_plan';
repeat_each(1);
no_long_string();
no_root_location();
-run_tests;
+
+add_block_preprocessor(sub {
+my ($block) = @_;
+
+if ((!defined $block->error_log) && (!defined $block->no_error_log)) {
+$block->set_value("no_error_log", "[error]");
+}
+
+if (!defined $block->request) {
+$block->set_value("request", "GET /t");
+}
+
+});
+
+run_tests();
__DATA__
@@ -37,12 +51,8 @@ __DATA__
ngx.say("done")
}
}
request
-GET /t
--- response_body
done
no_error_log
-[error]
@@ -60,13 +70,9 @@ done
ngx.say("done")
}
}
request
-GET /t
--- response_body
property "access_key_secret" is required
done
no_error_log
-[error]
@@ -84,13 +90,9 @@ done
ngx.say("done")
}
}
request
-GET /t
--- response_body
property "timeout" validation failed: wrong type: expected integer, got string
done
no_error_log
-[error]
@@ -155,12 +157,8 @@ done
ngx.say(body)
}
}
request
-GET /t
--- response_body
passed
no_error_log
-[error]
@@ -169,8 +167,6 @@ passed
GET /hello
--- response_body
hello world
no_error_log
-[error]
--- wait: 1
@@ -188,9 +184,43 @@ hello world
ngx.say(data)
}
}
request
-GET /t
--- response_body
123
no_error_log
-[error]
+
+
+
+=== TEST 7: sls log get milliseconds
+--- config
+location /t {
+content_by_lua_block {
+local function get_syslog_timestamp_millisecond(log_entry)
+local first_idx = string.find(log_entry, " ") + 1
+local last_idx2 = string.find(log_entry, " ", first_idx)
+local rfc3339_date = string.sub(log_entry, first_idx,
last_idx2)
+local rfc3339_len = string.len(rfc3339_date)
+local rfc3339_millisecond = string.sub(rfc3339_date,
rfc3339_len - 4, rfc3339_len - 2)
+return tonumber(rfc3339_millisecond)
+end
+
+math.randomseed(os.time())
+local rfc5424 = require("apisix.plugins.slslog.rfc5424")
+local m = 0
+-- because the millisecond value obtained by `ngx.now` may be `0`
+-- it is executed multiple times to ensure the accuracy of the test
+for i = 1, 5 do
+ngx.sleep(string.format("%0.3f", math.random()))
+local log_entry = rfc5424.encode("SYSLOG", "INFO",
"localhost", "apisix",
+ 123456, "apisix.apache.org",
"apisix.apache.log",
+ "apisix.sls.logger",
"BD274822-96AA-4DA6-90EC-15940FB2",
+ "hello world")
+m = get_syslog_timestamp_millisecond(log_entry) + m
+end
+
+if m > 0 then
+ngx.say("passed")
+end
+}
+}
+--- response_body
+passed
+--- timeout: 5
