[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #937: feat: support forward-auth plugin
tao12345666333 commented on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079839482 You can use kind with v1.21 kubernetes -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] cmssczy commented on pull request #937: feat: support forward-auth plugin
cmssczy commented on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079832900 How do I test `extensions/v1beta1` ingress in my local environment? My local k8s cluster(v1.23.3) do not support this version. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] jwrookie commented on issue #2395: docs: How to reset the password of apisix dashboard?
jwrookie commented on issue #2395: URL: https://github.com/apache/apisix-dashboard/issues/2395#issuecomment-1079827411 https://github.com/apache/apisix-dashboard/blob/162c5d7bcdfa36d76681b2a607267bcb76185cc5/api/conf/conf.yaml#L78-L82 The account and password store in conf.yaml, you can restart dashboard after change it if you want to change -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] soulbird opened a new issue #6729: feat: As a user, I hope apisix can make some restrictions on the custom functions in the serverless plugin, and the use of illegal code will not ca
soulbird opened a new issue #6729:
URL: https://github.com/apache/apisix/issues/6729
### Description
I noticed that the serverless plugin allows users to run custom functions,
but it doesn't seem to have any restrictions. Some illegal code of the user may
cause the apisix service to be unavailable. for example
```bash
curl http://127.0.0.1:9080/apisix/admin/routes/1 -H 'X-API-KEY:
edd1c9f034335f136f87ad84b625c8f1' -X PUT -d '
{
"uri": "/index.html",
"plugins": {
"serverless-pre-function": {
"phase": "rewrite",
"functions" : ["return function() ngx.ctx.api_ctx = nil; end"]
}
},
"upstream": {
"type": "roundrobin",
"nodes": {
"127.0.0.1:1980": 1
}
}
}'
```
And when you request apisix, it won't work
```bash
curl -v http://127.0.0.1:9080/index.html
* Trying 127.0.0.1:9080...
* Connected to 127.0.0.1 (127.0.0.1) port 9080 (#0)
> GET /index.html HTTP/1.1
> Host: 127.0.0.1:9080
> User-Agent: curl/7.77.0
> Accept: */*
>
* Mark bundle as not supporting multiuse
< HTTP/1.1 500 Internal Server Error
< Date: Sun, 27 Mar 2022 02:28:10 GMT
< Content-Type: text/html; charset=utf-8
< Transfer-Encoding: chunked
< Connection: close
< Server: APISIX/2.12.0
<
500 Internal Server Error
body {
width: 35em;
margin: 0 auto;
font-family: Tahoma, Verdana, Arial, sans-serif;
}
```
This is just a simple example, hackers may have many more ways to exploit
this vulnerability to attack your system.
So, I think apisix can make some restrictions on custom functions in
serverless plugins to ensure that they run in a more secure environment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter edited a comment on pull request #937: feat: support forward-auth plugin
codecov-commenter edited a comment on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079819497 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#937](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (cc0656d) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/4da91b7971d3defd137f35de84f107612e6f96bd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4da91b7) will **increase** coverage by `0.15%`. > The diff coverage is `100.00%`. ```diff @@Coverage Diff @@ ## master #937 +/- ## == + Coverage 32.89% 33.05% +0.15% == Files 72 73 +1 Lines7661 7679 +18 == + Hits 2520 2538 +18 Misses 4865 4865 Partials 276 276 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | `61.53% <ø> (ø)` | | | [pkg/kube/translation/annotations/forward\_auth.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvZm9yd2FyZF9hdXRoLmdv) | `100.00% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [4da91b7...cc0656d](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] codecov-commenter commented on pull request #937: feat: support forward-auth plugin
codecov-commenter commented on pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#issuecomment-1079819497 # [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=h1_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) Report > Merging [#937](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (58a3780) into [master](https://codecov.io/gh/apache/apisix-ingress-controller/commit/4da91b7971d3defd137f35de84f107612e6f96bd?el=desc_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) (4da91b7) will **increase** coverage by `0.15%`. > The diff coverage is `100.00%`. ```diff @@Coverage Diff @@ ## master #937 +/- ## == + Coverage 32.89% 33.05% +0.15% == Files 72 73 +1 Lines7661 7679 +18 == + Hits 2520 2538 +18 Misses 4865 4865 Partials 276 276 ``` | [Impacted Files](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) | Coverage Δ | | |---|---|---| | [pkg/kube/translation/annotations.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMuZ28=) | `61.53% <ø> (ø)` | | | [pkg/kube/translation/annotations/forward\_auth.go](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937/diff?src=pr=tree_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation#diff-cGtnL2t1YmUvdHJhbnNsYXRpb24vYW5ub3RhdGlvbnMvZm9yd2FyZF9hdXRoLmdv) | `100.00% <100.00%> (ø)` | | -- [Continue to review full report at Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=continue_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=footer_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Last update [4da91b7...58a3780](https://codecov.io/gh/apache/apisix-ingress-controller/pull/937?src=pr=lastupdated_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral_source=github_content=comment_campaign=pr+comments_term=The+Apache+Software+Foundation). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6725: help request: 内存持续增涨OOM
tzssangglass commented on issue #6725: URL: https://github.com/apache/apisix/issues/6725#issuecomment-1079818811 Is the memory performance of instance `29zhg` normal? Is there any difference? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] SkyeYoung commented on issue #920: [Docs]: Allow single-language blog without creating 404
SkyeYoung commented on issue #920: URL: https://github.com/apache/apisix-website/issues/920#issuecomment-1079816446 > @SkyeYoung would you have time to fix this issue? Yes, I can give it a try. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #937: feat: support forward-auth plugin
tao12345666333 commented on a change in pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#discussion_r835836969 ## File path: pkg/kube/translation/annotations/forward_auth.go ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +package annotations + +import ( + apisixv1 "github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1" +) + +const ( + _forwardAuthURI = AnnotationsPrefix + "uri" + _forwardAuthSSLVerify = AnnotationsPrefix + "ssl-verify" + _forwardAuthRequestHeaders = AnnotationsPrefix + "request-headers" + _forwardAuthUpstreamHeaders = AnnotationsPrefix + "upstream-headers" + _forwardAuthClientHeaders = AnnotationsPrefix + "client-headers" Review comment: For example, add an `auth` prefix -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis commented on pull request #6707: fix: hidding real message when password or username is error
membphis commented on pull request #6707: URL: https://github.com/apache/apisix/pull/6707#issuecomment-1079815823 many thx @liangliang4ward -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: fix: hidding real message when password or username is error (#6707)
This is an automated email from the ASF dual-hosted git repository.
membphis pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/apisix.git
The following commit(s) were added to refs/heads/master by this push:
new ee7771b fix: hidding real message when password or username is error
(#6707)
ee7771b is described below
commit ee7771b34ed2616cec861dc0c84df4a574fb4014
Author: Gaoll
AuthorDate: Sun Mar 27 10:05:16 2022 +0800
fix: hidding real message when password or username is error (#6707)
Co-authored-by: root
---
apisix/plugins/basic-auth.lua| 4 ++--
apisix/plugins/ldap-auth.lua | 2 +-
docs/en/latest/plugins/basic-auth.md | 4 ++--
docs/en/latest/plugins/ldap-auth.md | 4 ++--
docs/zh/latest/plugins/basic-auth.md | 4 ++--
t/plugin/basic-auth.t| 4 ++--
6 files changed, 11 insertions(+), 11 deletions(-)
diff --git a/apisix/plugins/basic-auth.lua b/apisix/plugins/basic-auth.lua
index 235154f..83519bf 100644
--- a/apisix/plugins/basic-auth.lua
+++ b/apisix/plugins/basic-auth.lua
@@ -167,14 +167,14 @@ function _M.rewrite(conf, ctx)
-- 3. check user exists
local cur_consumer = consumers[username]
if not cur_consumer then
-return 401, { message = "Invalid user key in authorization" }
+return 401, { message = "Invalid user authorization" }
end
core.log.info("consumer: ", core.json.delay_encode(cur_consumer))
-- 4. check the password is correct
if cur_consumer.auth_conf.password ~= password then
-return 401, { message = "Password is error" }
+return 401, { message = "Invalid user authorization" }
end
-- 5. hide `Authorization` request header if `hide_credentials` is `true`
diff --git a/apisix/plugins/ldap-auth.lua b/apisix/plugins/ldap-auth.lua
index 59b48f0..6ea32f0 100644
--- a/apisix/plugins/ldap-auth.lua
+++ b/apisix/plugins/ldap-auth.lua
@@ -152,7 +152,7 @@ function _M.rewrite(conf, ctx)
create_consumer_cache, consumer_conf)
local consumer = consumers[userdn]
if not consumer then
-return 401, {message = "Invalid API key in request"}
+return 401, {message = "Invalid user authorization"}
end
consumer_mod.attach_consumer(ctx, consumer, consumer_conf)
diff --git a/docs/en/latest/plugins/basic-auth.md
b/docs/en/latest/plugins/basic-auth.md
index 6f3dab9..10ccc2c 100644
--- a/docs/en/latest/plugins/basic-auth.md
+++ b/docs/en/latest/plugins/basic-auth.md
@@ -105,7 +105,7 @@ HTTP/1.1 401 Unauthorized
$ curl -i -ubar:bar http://127.0.0.1:9080/hello
HTTP/1.1 401 Unauthorized
...
-{"message":"Invalid user key in authorization"}
+{"message":"Invalid user authorization"}
```
- password is invalid:
@@ -114,7 +114,7 @@ HTTP/1.1 401 Unauthorized
$ curl -i -ufoo:foo http://127.0.0.1:9080/hello
HTTP/1.1 401 Unauthorized
...
-{"message":"Password is error"}
+{"message":"Invalid user authorization"}
```
- success:
diff --git a/docs/en/latest/plugins/ldap-auth.md
b/docs/en/latest/plugins/ldap-auth.md
index be76a48..6ca6aec 100644
--- a/docs/en/latest/plugins/ldap-auth.md
+++ b/docs/en/latest/plugins/ldap-auth.md
@@ -104,7 +104,7 @@ HTTP/1.1 401 Unauthorized
$ curl -i -uuser:password1 http://127.0.0.1:9080/hello
HTTP/1.1 401 Unauthorized
...
-{"message":"Invalid user key in authorization"}
+{"message":"Invalid user authorization"}
```
- password is invalid:
@@ -113,7 +113,7 @@ HTTP/1.1 401 Unauthorized
$ curl -i -uuser01:passwordfalse http://127.0.0.1:9080/hello
HTTP/1.1 401 Unauthorized
...
-{"message":"Password is error"}
+{"message":"Invalid user authorization"}
```
- success:
diff --git a/docs/zh/latest/plugins/basic-auth.md
b/docs/zh/latest/plugins/basic-auth.md
index fe44e57..739b048 100644
--- a/docs/zh/latest/plugins/basic-auth.md
+++ b/docs/zh/latest/plugins/basic-auth.md
@@ -105,7 +105,7 @@ HTTP/1.1 401 Unauthorized
$ curl -i -ubar:bar http://127.0.0.1:9080/hello
HTTP/1.1 401 Unauthorized
...
-{"message":"Invalid user key in authorization"}
+{"message":"Invalid user authorization"}
```
- 密码错误：
@@ -114,7 +114,7 @@ HTTP/1.1 401 Unauthorized
$ curl -i -ufoo:foo http://127.0.0.1:9080/hello
HTTP/1.1 401 Unauthorized
...
-{"message":"Password is error"}
+{"message":"Invalid user authorization"}
...
```
diff --git a/t/plugin/basic-auth.t b/t/plugin/basic-auth.t
index 3f0030f..f8cf5ab 100644
--- a/t/plugin/basic-auth.t
+++ b/t/plugin/basic-auth.t
@@ -196,7 +196,7 @@ GET /hello
Authorization: Basic YmFyOmJhcgo=
--- error_code: 401
--- response_body
-{"message":"Invalid user key in authorization"}
+{"message":"Invalid user authorization"}
--- no_error_log
[error]
@@ -209,7 +209,7 @@ GET /hello
Authorization: Basic Zm9vOmZvbwo=
--- error_code: 401
--- response_body
-{"message":"Password is error"}
+{"message":"Invalid user authorization"}
--- no_error_log
[error]
[GitHub] [apisix] membphis closed issue #6703: feat: As a user, when use basic-auth if password or username is error I don't want tell truth message
membphis closed issue #6703: URL: https://github.com/apache/apisix/issues/6703 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] membphis merged pull request #6707: fix: hidding real message when password or username is error
membphis merged pull request #6707: URL: https://github.com/apache/apisix/pull/6707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-website] membphis commented on issue #920: [Docs]: Allow single-language blog without creating 404
membphis commented on issue #920: URL: https://github.com/apache/apisix-website/issues/920#issuecomment-1079815639 @SkyeYoung would you have time to fix this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] cmssczy commented on a change in pull request #937: feat: support forward-auth plugin
cmssczy commented on a change in pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#discussion_r835835940 ## File path: pkg/kube/translation/annotations/forward_auth.go ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +package annotations + +import ( + apisixv1 "github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1" +) + +const ( + _forwardAuthURI = AnnotationsPrefix + "uri" + _forwardAuthSSLVerify = AnnotationsPrefix + "ssl-verify" + _forwardAuthRequestHeaders = AnnotationsPrefix + "request-headers" + _forwardAuthUpstreamHeaders = AnnotationsPrefix + "upstream-headers" + _forwardAuthClientHeaders = AnnotationsPrefix + "client-headers" Review comment: Do you have some suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on pull request #931: feat: delete app_namespaces parameter
tao12345666333 commented on pull request #931: URL: https://github.com/apache/apisix-ingress-controller/pull/931#issuecomment-1079731279 Thanks for your contribution, I am thinking about the specific impact of users upgrading with these recent changes to namespaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Goxiaoy opened a new issue #6728: bug: Can not access opentelemetry header in ext-plugin-pre-req plugin
Goxiaoy opened a new issue #6728:
URL: https://github.com/apache/apisix/issues/6728
### Current Behavior
opentelemetry propagation header will be inject here by `carrier_new`
https://github.com/apache/apisix/blob/38663991c189c3c0d00ab48bcc9664142fabb170/apisix/plugins/opentelemetry.lua#L304-L305
which call
https://github.com/yangxikun/opentelemetry-lua/blob/3f8e88aa31046d1fd4e8b1a51af9b5f2044514ca/lib/opentelemetry/trace/propagation/carrier.lua#L14-L16
```lua
function _M.set(self, name, val)
ngx.req.set_header(name, val)
end
```
This header seems not be able to access during the later
`ext-plugin-pre-req` golang plugin Filter
I want to do some RPC calls in the go plugin with tracing, so I need to
access this header
### Expected Behavior
opentelemetry conext should be propagated to the next plugin
### Error Logs
_No response_
### Steps to Reproduce
1. Run APISIX with docker image
2. Configure plugins `opentelemetry` and `ext-plugin-pre-req` on
3. Access opentelemetry tace header in golang plugin
```
trace := r.Header().Get("traceparent")
```
4. trace is empty
### Environment
- APISIX version (2.13.0):
- Operating system (centos`):
- Plugin runner version, for issues related to plugin runners:
dee7fa0167af0ed8cdcd87d4321a43b194f2a7ed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on a change in pull request #937: feat: support forward-auth plugin
tao12345666333 commented on a change in pull request #937: URL: https://github.com/apache/apisix-ingress-controller/pull/937#discussion_r835783620 ## File path: test/e2e/annotations/forward_auth.go ## @@ -0,0 +1,135 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +package annotations + +import ( + "fmt" + "net/http" + "time" + + "github.com/apache/apisix-ingress-controller/test/e2e/scaffold" + "github.com/onsi/ginkgo" + + "github.com/stretchr/testify/assert" Review comment: need to sort ## File path: pkg/kube/translation/annotations/forward_auth.go ## @@ -0,0 +1,58 @@ +// Licensed to the Apache Software Foundation (ASF) under one or more +// contributor license agreements. See the NOTICE file distributed with +// this work for additional information regarding copyright ownership. +// The ASF licenses this file to You under the Apache License, Version 2.0 +// (the "License"); you may not use this file except in compliance with +// the License. You may obtain a copy of the License at +// +// http://www.apache.org/licenses/LICENSE-2.0 +// +// Unless required by applicable law or agreed to in writing, software +// distributed under the License is distributed on an "AS IS" BASIS, +// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +// See the License for the specific language governing permissions and +// limitations under the License. +package annotations + +import ( + apisixv1 "github.com/apache/apisix-ingress-controller/pkg/types/apisix/v1" +) + +const ( + _forwardAuthURI = AnnotationsPrefix + "uri" + _forwardAuthSSLVerify = AnnotationsPrefix + "ssl-verify" + _forwardAuthRequestHeaders = AnnotationsPrefix + "request-headers" + _forwardAuthUpstreamHeaders = AnnotationsPrefix + "upstream-headers" + _forwardAuthClientHeaders = AnnotationsPrefix + "client-headers" Review comment: I think we should add a clearer name to it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5650: request help: etcd tls connect handshake failed
tzssangglass commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-1079717776 > 1. use api7/apisix-base:1.19.9.1.4 as base image to build，api7/apisix-base:1.19.9.1.4 image use `RESTY_OPENSSL_VERSION="1.1.1g"`; > 2. set etcd tls verify: false; If there is a similar problem, please give a detailed reproduction use case so that I can reproduce it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #6709: feat: file-log-plugin should combine with log-rotate
tzssangglass commented on issue #6709: URL: https://github.com/apache/apisix/issues/6709#issuecomment-1079717169 good idea, we should make the file logger itself support log file rotation.. cc @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5837: request: Expect monitoring metrics to add monitoring of nginx shared memory usage
tzssangglass commented on issue #5837: URL: https://github.com/apache/apisix/issues/5837#issuecomment-1079713346 I changed my mind and I think it's a meaningful enhancemen. Perhaps we can first monitor the nginx.shared.DICT that is used by APISIX, and next we allow users to monitor a custom nginx.shared.DICT (or read the used nginx.shared.DICT directly from the configuration file). cc @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] tzssangglass commented on issue #5246: bug: http request to upstream, roundrobin is imbalance when multi nginx worker process
tzssangglass commented on issue #5246: URL: https://github.com/apache/apisix/issues/5246#issuecomment-1079712602 > Note it: the mentioned `RR` algorithm should be `WRR` or `SWRR`, [Smooth Weighted Round-Robin](https://github.com/phusion/nginx/commit/27e94984486058d73157038f7950a0a36ecc6e35). it's WRR, the `weight` has already been mentioned above. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] liujiabaoaa commented on issue #938: docs: the-hard-way doc is out of date.
liujiabaoaa commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079706394 well. got it. Because I want to understand the process by manually installing yaml files for the first time. Although helm is simple, he didn't understand it very well at first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #938: docs: the-hard-way doc is out of date.
tao12345666333 commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079705779 > 是的。我后来也发现了。我有个问题想请教下。apisix和apisix ingress controller版本的对应关系 在哪里呢？ In README Prerequisites > Apisix ingress controller requires Kubernetes version 1.16+. Because we used CustomResourceDefinition v1 stable API. From the version 1.0.0, APISIX-ingress-controller need to work with Apache APISIX version 2.7+. In fact, their correspondence is maintained in the Helm chart -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] liujiabaoaa commented on issue #938: docs: the-hard-way doc is out of date.
liujiabaoaa commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079705344 I tried to modify the version of apifix ingress controller again. The version of the image is 1.4.0, which has been solved. What I want to know is whether there is a corresponding relationship between the version of APIs IX and the mirrored version of APIs IX ingress controller. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #938: docs: the-hard-way doc is out of date.
tao12345666333 commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079704512 The error is due to the fact that when we introduced the default configuration option default_cluster_base_url , all relevant content was modified globally, but the rest of this document was not updated -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] liujiabaoaa commented on issue #938: apisix ingress controller 启动报错bad configuration: apisix base url is required
liujiabaoaa commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079703660 是的。我后来也发现了。我有个问题想请教下。apisix和apisix ingress controller版本的对应关系 在哪里呢？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #938: apisix ingress controller 启动报错bad configuration: apisix base url is required
tao12345666333 commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079703567 You can try to modify the image to the latest version, and submit a PR to update this document after the deployment is successful, thank you -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-ingress-controller] tao12345666333 commented on issue #938: apisix ingress controller 启动报错bad configuration: apisix base url is required
tao12345666333 commented on issue #938: URL: https://github.com/apache/apisix-ingress-controller/issues/938#issuecomment-1079702236 This documentation is out of date. Please note that the current latest version is v1.4. The image used in your above configuration is 0.5. The most recommended way is to install directly using Helm, which is the only way we currently maintain. ``` helm install apisix apisix/apisix \ --set gateway.type=NodePort \ --set ingress-controller.enabled=true \ --namespace ingress-apisix \ --set ingress-controller.config.apisix.serviceNamespace=ingress-apisix ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhixiongdu027 opened a new pull request #6727: ci: remove unnecessary step
zhixiongdu027 opened a new pull request #6727: URL: https://github.com/apache/apisix/pull/6727 ### Description Fixes #6706 ### Checklist - [ ] I have explained the need for this PR and the problem it solves - [ ] I have explained the changes or the new features added to this PR - [ ] I have added tests corresponding to this change - [ ] I have updated the documentation to reflect this change - [ ] I have verified that this change is backward compatible (If not, please discuss on the [APISIX mailing list](https://github.com/apache/apisix/tree/master#community) first) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] zhixiongdu027 commented on issue #6706: help request: the "Extract branch name" step is unnecessary in some workflow
zhixiongdu027 commented on issue #6706: URL: https://github.com/apache/apisix/issues/6706#issuecomment-1079689823 I will do it -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] liangliang4ward commented on a change in pull request #6707: fix: hidding real message when password or username is error
liangliang4ward commented on a change in pull request #6707:
URL: https://github.com/apache/apisix/pull/6707#discussion_r835761511
##
File path: apisix/plugins/basic-auth.lua
##
@@ -167,14 +167,14 @@ function _M.rewrite(conf, ctx)
-- 3. check user exists
local cur_consumer = consumers[username]
if not cur_consumer then
-return 401, { message = "Invalid user key in authorization" }
+return 401, { message = "Invalid password or username" }
end
core.log.info("consumer: ", core.json.delay_encode(cur_consumer))
-- 4. check the password is correct
if cur_consumer.auth_conf.password ~= password then
-return 401, { message = "Password is error" }
+return 401, { message = "Invalid password or username" }
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] liangliang4ward commented on a change in pull request #6707: fix: hidding real message when password or username is error
liangliang4ward commented on a change in pull request #6707:
URL: https://github.com/apache/apisix/pull/6707#discussion_r835761390
##
File path: apisix/plugins/basic-auth.lua
##
@@ -167,14 +167,14 @@ function _M.rewrite(conf, ctx)
-- 3. check user exists
local cur_consumer = consumers[username]
if not cur_consumer then
-return 401, { message = "Invalid user key in authorization" }
+return 401, { message = "Invalid password or username" }
Review comment:
done. unify "Invalid user authorization"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix] liangliang4ward commented on a change in pull request #6707: fix: hidding real message when password or username is error
liangliang4ward commented on a change in pull request #6707:
URL: https://github.com/apache/apisix/pull/6707#discussion_r835761496
##
File path: apisix/plugins/ldap-auth.lua
##
@@ -152,7 +152,7 @@ function _M.rewrite(conf, ctx)
create_consumer_cache, consumer_conf)
local consumer = consumers[userdn]
if not consumer then
-return 401, {message = "Invalid API key in request"}
+return 401, {message = "Invalid password or username"}
Review comment:
done. unify to " Invalid user authorization"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
[GitHub] [apisix-dashboard] mygrsun commented on issue #2391: does apisix-dashboard support deploy multiple node as loadbalance?
mygrsun commented on issue #2391: URL: https://github.com/apache/apisix-dashboard/issues/2391#issuecomment-1079685216 > > > > > > > > > > yes ,the two dashboard use zhe same etcd。In fact，I use k8s deploy the node。Every nodes has dashboard-apisix and apisix。 > > If it's the same etcd, why not use one Dashboard? if i use only one dashboard ，how to avoid it crash。I want use two node as high reliability -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] yzeng25 commented on pull request #6554: docs: added an Introductory section to the "Getting started"
yzeng25 commented on pull request #6554: URL: https://github.com/apache/apisix/pull/6554#issuecomment-1079684553 LGTM cc @bisakhmondal -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hctech edited a comment on issue #5650: request help: etcd tls connect handshake failed
hctech edited a comment on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-1079672618 1. use api7/apisix-base:1.19.9.1.4 as base image to build，api7/apisix-base:1.19.9.1.4 image use `RESTY_OPENSSL_VERSION="1.1.1g"`; 2. set etcd tls verify: false; -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] hctech commented on issue #5650: request help: etcd tls connect handshake failed
hctech commented on issue #5650: URL: https://github.com/apache/apisix/issues/5650#issuecomment-1079672618 use api7/apisix-base:1.19.9.1.4 as base image to build, set etcd tls verify: false -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] liangliang4ward commented on pull request #6707: fix: hidding real message when password or username is error
liangliang4ward commented on pull request #6707: URL: https://github.com/apache/apisix/pull/6707#issuecomment-1079672090 > Hi @liangliang4ward, you need to use: > > ``` > Fixes #6703 > ``` > > but not > > ``` > Fixes # [(issue)](https://github.com/apache/apisix/issues/6703) > ``` > > in the link ok -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] liangliang4ward commented on issue #6709: feat: file-log-plugin should combine with log-rotate
liangliang4ward commented on issue #6709: URL: https://github.com/apache/apisix/issues/6709#issuecomment-1079671686 I mean ,the file-log-plugin write only one file. I think the file will be very large. we should split them -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #6554: docs: added an Introductory section to the "Getting started"
leslie-tsang commented on a change in pull request #6554: URL: https://github.com/apache/apisix/pull/6554#discussion_r835752431 ## File path: docs/en/latest/getting-started.md ## @@ -20,6 +20,46 @@ title: Getting Started # limitations under the License. # --> +## What is an API Gateway? Review comment: ```suggestion ## What is an API Gateway? ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #6554: docs: added an Introductory section to the "Getting started"
leslie-tsang commented on a change in pull request #6554: URL: https://github.com/apache/apisix/pull/6554#discussion_r835751183 ## File path: docs/en/latest/getting-started.md ## @@ -19,7 +19,45 @@ title: Getting Started # See the License for the specific language governing permissions and # limitations under the License. # ---> +--> + +## What is an API Gateway +An API gateway is an API management tool that acts as a mid layer service between a client and a number backend services. Typically, the API gateway receives the clients requests and processes it by summoning multiple microservices, aggregating the services and returning the appropriate results. + +## What is Apache APISIX +Apache APISIX is an open-source, dynamic and high-performance cloud-native API gateway that delivers the ultimate performance for all your APIs and microservices. Think of APISIX as a service bus that connects APIs and microservices in your cloud-native architecture. +Apache APISIX facilitates interface traffic handling for Websites, Mobile and IoT applications by providing services such as load balancing, dynamic upstream, grayscale publishing, refined routing, current and speed limiting, and many more. + +### The problem APISIX solves + - Help enterprises to solve the difficulties in the transformation of traditional monolithic architecture, so as to achieve rapid iteration of business and products. + - Apache APISIX replaces NGINX and handles traditional north-south traffic. It also replaces Envoy to handle east-west traffic between services. + - Handles Layer 4 and Layer 7 traffic: HTTP, HTTPs, TCP, UDP, MQTT, Dubbo, gRPC, etc. + - It can also be used as a [k8s ingress controller](https://github.com/apache/apisix-ingress-controller). + - Use IdP plugin as Zero-Trust gateway + - Easy to use: APISIX also consists of a built-in low-code dashboard that offers a powerful and flexible interface. You can write your own custom plugins or use custom load balancing algorithms. + - Apache APISIX supports multi-platforms, languages and protocols. + +## Features +Apache APISIX not only covers the traditional functions of NGINX, but also deeply cooperates with Apache SkyWalking in observability, which greatly improves service governance capabilities. Some of the characteristics of the Apache APISIX gateway include: + + - All platforms: Review comment: Almost there. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] leslie-tsang commented on a change in pull request #6554: docs: added an Introductory section to the "Getting started"
leslie-tsang commented on a change in pull request #6554: URL: https://github.com/apache/apisix/pull/6554#discussion_r835751155 ## File path: docs/en/latest/getting-started.md ## @@ -19,7 +19,45 @@ title: Getting Started # See the License for the specific language governing permissions and # limitations under the License. # ---> +--> + +## What is an API Gateway +An API gateway is an API management tool that acts as a mid layer service between a client and a number backend services. Typically, the API gateway receives the clients requests and processes it by summoning multiple microservices, aggregating the services and returning the appropriate results. + +## What is Apache APISIX +Apache APISIX is an open-source, dynamic and high-performance cloud-native API gateway that delivers the ultimate performance for all your APIs and microservices. Think of APISIX as a service bus that connects APIs and microservices in your cloud-native architecture. +Apache APISIX facilitates interface traffic handling for Websites, Mobile and IoT applications by providing services such as load balancing, dynamic upstream, grayscale publishing, refined routing, current and speed limiting, and many more. + +### The problem APISIX solves + - Help enterprises to solve the difficulties in the transformation of traditional monolithic architecture, so as to achieve rapid iteration of business and products. + - Apache APISIX replaces NGINX and handles traditional north-south traffic. It also replaces Envoy to handle east-west traffic between services. + - Handles Layer 4 and Layer 7 traffic: HTTP, HTTPs, TCP, UDP, MQTT, Dubbo, gRPC, etc. + - It can also be used as a [k8s ingress controller](https://github.com/apache/apisix-ingress-controller). + - Use IdP plugin as Zero-Trust gateway + - Easy to use: APISIX also consists of a built-in low-code dashboard that offers a powerful and flexible interface. You can write your own custom plugins or use custom load balancing algorithms. + - Apache APISIX supports multi-platforms, languages and protocols. + +## Features +Apache APISIX not only covers the traditional functions of NGINX, but also deeply cooperates with Apache SkyWalking in observability, which greatly improves service governance capabilities. Some of the characteristics of the Apache APISIX gateway include: + + - All platforms: Review comment: Never mind, do let me know if I can help. :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #6725: help request: 内存持续增涨OOM
kwanhur commented on issue #6725: URL: https://github.com/apache/apisix/issues/6725#issuecomment-1079661060 If ok, suggest you disable all the plugins to eliminate their effects. Then enable plugin one by one. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on issue #5472: docs: apisix/docs/en/latest/how-to-build.md
juzhiyuan commented on issue #5472: URL: https://github.com/apache/apisix/issues/5472#issuecomment-1079656884 > Tutorial videos had been posted, like email [Getting started with Apache APISIX @YouTube](https://www.mail-archive.com/dev@apisix.apache.org/msg04513.html). cc @Boburmirzo @navendu-pottekkat @avinal @hf400159 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #6034: bug: problems caused by stream_proxy (tcp proxy)
kwanhur commented on issue #6034: URL: https://github.com/apache/apisix/issues/6034#issuecomment-1079656214 I guess the key-point was on `vip`, please check the `arp_ignore` `arp_announce` and `rp_filter`. Under using `keepalived` aside with `IPVS`, focus on `ARP` first, see details [here](http://kb.linuxvirtualserver.org/wiki/Using_arp_announce/arp_ignore_to_disable_ARP). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #5837: request: Expect monitoring metrics to add monitoring of nginx shared memory usage
kwanhur commented on issue #5837: URL: https://github.com/apache/apisix/issues/5837#issuecomment-1079650787 Is it like [ngx_slab_stats](https://github.com/alibaba/tengine/tree/master/modules/ngx_slab_stat)? Which supports shared memory allocated from lua-nginx-module. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #5472: docs: apisix/docs/en/latest/how-to-build.md
kwanhur commented on issue #5472: URL: https://github.com/apache/apisix/issues/5472#issuecomment-1079648559 Tutorial videos had been posted, like email [Getting started with Apache APISIX @YouTube](https://www.mail-archive.com/dev@apisix.apache.org/msg04513.html). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #5533: systemctl enable apisix is not avialiable
kwanhur commented on issue #5533: URL: https://github.com/apache/apisix/issues/5533#issuecomment-1079646764 > @lifeblood It does not appear to cause a startup failure，just go to run `systemctl start apisix` start apisix or `systemctl stop apisix` stop apisix Automatically startup apisix when host is arise on restarting, it's a recovery policy. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #5533: systemctl enable apisix is not avialiable
kwanhur commented on issue #5533: URL: https://github.com/apache/apisix/issues/5533#issuecomment-1079646068 I'm sure `systemctl enable apisix` works well on Centos7 with `apisix-2.12.0-0.el7.x86_64`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] kwanhur commented on issue #5246: bug: http request to upstream, roundrobin is imbalance when multi nginx worker process
kwanhur commented on issue #5246: URL: https://github.com/apache/apisix/issues/5246#issuecomment-1079643013 Note it: the mentioned `RR` algorithm should be `WRR` or `SWRR`, [Smooth Weighted Round-Robin](https://github.com/phusion/nginx/commit/27e94984486058d73157038f7950a0a36ecc6e35). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander commented on issue #3289: feat: add a pre-commit framework
spacewander commented on issue #3289: URL: https://github.com/apache/apisix/issues/3289#issuecomment-1079641151 We don't need it yet. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #3289: feat: add a pre-commit framework
spacewander closed issue #3289: URL: https://github.com/apache/apisix/issues/3289 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix-dashboard] alexchan10241 opened a new issue #2395: docs: How to reset the password of apisix dashboard?
alexchan10241 opened a new issue #2395: URL: https://github.com/apache/apisix-dashboard/issues/2395 ### Current State I forgot my account password.Then I can not get access to reset it . Need somebody help,please!!! ### Desired State I forgot my account password.Then I can not get access to reset it . Need somebody help,please!!! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[apisix] branch master updated: docs: update FAQ docs (#6695)
This is an automated email from the ASF dual-hosted git repository. spacewander pushed a commit to branch master in repository https://gitbox.apache.org/repos/asf/apisix.git The following commit(s) were added to refs/heads/master by this push: new 3866399 docs: update FAQ docs (#6695) 3866399 is described below commit 38663991c189c3c0d00ab48bcc9664142fabb170 Author: Navendu Pottekkat AuthorDate: Sat Mar 26 14:05:06 2022 +0530 docs: update FAQ docs (#6695) --- docs/en/latest/FAQ.md | 364 +++--- 1 file changed, 196 insertions(+), 168 deletions(-) diff --git a/docs/en/latest/FAQ.md b/docs/en/latest/FAQ.md index c9d29d5..497e786 100644 --- a/docs/en/latest/FAQ.md +++ b/docs/en/latest/FAQ.md @@ -21,74 +21,97 @@ title: FAQ # --> -## Why a new API gateway? +## Why do I need a new API gateway? -There are new requirements for API gateways in the field of microservices: higher flexibility, higher performance requirements, and cloud native. +As organizations move towards cloud native microservices, there is a need for an API gateway that is performant, flexible, secure and scalable. -## What are the differences between Apache APISIX and other API gateways? +APISIX outperforms other API gateways in these metrics while being platform agnostic and fully dynamic delivering features like supporting multiple protocols, fine-grained routing and multi-language support. -Apache APISIX is based on etcd to save and synchronize configuration, not relational databases such as Postgres or MySQL. +## How does Apache APISIX differ from other API gateways? -This not only eliminates polling, makes the code more concise, but also makes configuration synchronization more real-time. At the same time, there will be no single point in the system, which is more usable. +Apache APISIX differs in the following ways: -In addition, Apache APISIX has dynamic routing and hot loading of plug-ins, which is especially suitable for API management under micro-service system. +- It uses etcd to save and synchronize configurations rather than relational databases like PostgreSQL or MySQL. The real-time event notification system in etcd is easier to scale than in these alternatives. This allows APISIX to synchronize the configuration in real-time, makes the code concise and avoids a single point of failure. +- Fully dynamic. +- Supports [hot loading of Plugins](/docs/apisix/plugins/#hot-reload). -## What's the performance of Apache APISIX? +## What is the performance impact of using Apache APISIX? -One of the goals of Apache APISIX design and development is the highest performance in the industry. Specific test data can be found here：[benchmark](benchmark.md) +Apache APISIX delivers the best performance among other API gateways with a single-core QPS of 18,000 with an average delay of 0.2 ms. -Apache APISIX is the highest performance API gateway with a single-core QPS of 23,000, with an average delay of only 0.6 milliseconds. +Specific results of the performance benchmarks can be found [here](benchmark.md). + +## Which platforms does Apache APISIX support? + +Apache APISIX is platform agnostic and avoids vendor lock-in. It is built for cloud native environments and can run on bare-metal machines to Kubernetes. It even support Apple Silicon chips. + +## What does it mean by "Apache APISIX is fully dynamic"? + +Apache APISIX is fully dynamic in the sense that it doesn't require restarts to change its behavior. + +It does the following dynamically: + +- Reloading Plugins +- Proxy rewrites +- Proxy mirror +- Response rewrites +- Health checks +- Traffic split ## Does Apache APISIX have a user interface？ -Yes. Apache APISIX has an experimental feature called [Apache APISIX Dashboard](https://github.com/apache/apisix-dashboard), which is an independent project apart from Apache APISIX. You can deploy Apache APISIX Dashboard to operate Apache APISIX through the user interface. +Yes. Apache APISIX has an experimental feature called [Apache APISIX Dashboard](https://github.com/apache/apisix-dashboard), which is independent from Apache APISIX. To work with Apache APISIX through a user interface, you can deploy the Apache APISIX Dashboard. -## Can I write my own plugin? +## Can I write my own Plugins for Apache APISIX? -Of course, Apache APISIX provides flexible custom plugins for developers and businesses to write their own logic. +Yes. Apache APISIX is flexible and extensible through the use of custom Plugins that can be specific to user needs. -[How to write plugin](plugin-develop.md) +You can write your own Plugins by referring to [How to write your own Plugins](plugin-develop.md). -## Why we choose etcd as the configuration center? +## Why does Apache APISIX use etcd for the configuration center? -For the configuration center, configuration storage is only the most basic function, and Apache APISIX also needs the following features:
[GitHub] [apisix] spacewander merged pull request #6695: docs: update FAQ docs
spacewander merged pull request #6695: URL: https://github.com/apache/apisix/pull/6695 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] spacewander closed issue #6594: docs: Restructure the FAQ section
spacewander closed issue #6594: URL: https://github.com/apache/apisix/issues/6594 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] soulbird commented on issue #6719: bug: load opentelemetry so, curl /apisix/prometheus/metrics coredump
soulbird commented on issue #6719: URL: https://github.com/apache/apisix/issues/6719#issuecomment-1079621000 I'll take a look -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
