[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1080546332 1. Thanks! Please merge this PR. 2. I will work on the docs for this plugin later in another PR . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1080542558 > @spacewander @ComradeProgrammer The documentation in the PR still needs to be optimized, let's merge this PR first and deal with the documentation in the next PR ? I am glad to hear that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1079957130 revisions have been made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1079579372 rebase made(force-pushed was caused by rebase) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1078583178 Revisions made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1077742615 revisions made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1077536932 revisions have been made according to the requirements. @spacewander @tzssangglass @leslie-tsang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1075837075 revisions have been made according to the requirements. @spacewander @tzssangglass @leslie-tsang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1073878438 I cannot see the reason why CI failed this time because these tests don't fail when I run it locally. Besides, it seems irrelevant with the code I submitted. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1072953295 revisions have been made according to the requirements. @spacewander @tzssangglass @leslie-tsang -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1067935059 Now state has been randomized, other recommended revisions have also been made, and now they are in different commits as mentioned before. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1064692677 > Hello there, Plz don't force push during the review. > > Commit history allows reviewers to see what has changed since the last review, which is useful for them. > > A force-push might **ruin** the review experience and progress. which may leave this PR without anyone **willing** to review. :) I see, I shall pay attention to this in the future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1063604285 @tzssangglass emmm chaos test failed again, could you please rerun this test? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1058784051 revisions have been made accordingly -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1056796360 Well I revoked to the previous correct commit and then manually modified the format, this time maybe it's okay. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1056488837 @spacewander @tzssangglass what kind of test is this? Besides, comparing with my last previous commit, the only change was format in test file t/plugin/auth-casdoor.t, but I passed all the tests in the previous commit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1056330465 @spacewander @tzssangglass what about this time? (revisions have been made) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1054294352 @spacewander revisions have been made -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1053310739 > > hi @ComradeProgrammer, after the CI run is finished, please fix the failure of the CI. I have made changes according to the CI information, and I wonder whether I can have CI run another time , so that I can confirm whether I can pass CI now? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1052120253 @spacewander @tzssangglass Most of the revisions in your comments have been implemented, and tests are also added. I think this code is ready to be reviewed now, THX. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] ComradeProgrammer commented on pull request #6382: feat: add auth plugin for casdoor
ComradeProgrammer commented on pull request #6382: URL: https://github.com/apache/apisix/pull/6382#issuecomment-1047996741 I am extremely flattered, delighted and grateful for this extremely detailed reply and advice from you. Revisions will be made accordingly soon and tests will be added soon together. @spacewander -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
