[GitHub] [apisix] Firstsawyou commented on a change in pull request #3943: test: make plugin/log-rotate.t stable

[GitBox]

Firstsawyou commented on a change in pull request #3943:
URL: https://github.com/apache/apisix/pull/3943#discussion_r603784591



##
File path: t/plugin/log-rotate.t
##
@@ -90,8 +90,8 @@ __DATA__
 --- config
 location /t {
 content_by_lua_block {
-ngx.log(ngx.WARN, "start xx")
 ngx.sleep(0.1)
+ngx.log(ngx.WARN, "start xx")

Review comment:
   Got it, thanks for the answer.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] Firstsawyou commented on a change in pull request #3943: test: make plugin/log-rotate.t stable

[GitBox]

Firstsawyou commented on a change in pull request #3943:
URL: https://github.com/apache/apisix/pull/3943#discussion_r603752965



##
File path: t/plugin/log-rotate.t
##
@@ -90,8 +90,8 @@ __DATA__
 --- config
 location /t {
 content_by_lua_block {
-ngx.log(ngx.WARN, "start xx")
 ngx.sleep(0.1)
+ngx.log(ngx.WARN, "start xx")

Review comment:
   Why does the execution order of ngx.sleep and ngx.log affect the 
stability of the test?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org