[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3660: chore: update makefile install to install everything in conf
Yiyiyimu commented on a change in pull request #3660: URL: https://github.com/apache/apisix/pull/3660#discussion_r582769476 ## File path: Makefile ## @@ -143,9 +143,8 @@ install: default $(INSTALL) -d /usr/local/apisix/ $(INSTALL) -d /usr/local/apisix/logs/ $(INSTALL) -d /usr/local/apisix/conf/cert - $(INSTALL) conf/mime.types /usr/local/apisix/conf/mime.types - $(INSTALL) conf/config.yaml /usr/local/apisix/conf/config.yaml - $(INSTALL) conf/config-default.yaml /usr/local/apisix/conf/config-default.yaml + $(INSTALL) conf/*.types /usr/local/apisix/conf/ + $(INSTALL) conf/*.yaml /usr/local/apisix/conf/ Review comment: Changed This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3660: chore: update makefile install to install everything in conf
Yiyiyimu commented on a change in pull request #3660: URL: https://github.com/apache/apisix/pull/3660#discussion_r582529217 ## File path: Makefile ## @@ -143,9 +143,8 @@ install: default $(INSTALL) -d /usr/local/apisix/ $(INSTALL) -d /usr/local/apisix/logs/ $(INSTALL) -d /usr/local/apisix/conf/cert - $(INSTALL) conf/mime.types /usr/local/apisix/conf/mime.types - $(INSTALL) conf/config.yaml /usr/local/apisix/conf/config.yaml - $(INSTALL) conf/config-default.yaml /usr/local/apisix/conf/config-default.yaml + $(INSTALL) conf/*.types /usr/local/apisix/conf/ + $(INSTALL) conf/*.yaml /usr/local/apisix/conf/ Review comment: Thanks for the suggestion! Since we need everything under `/conf`, as what we did when creating tarball, I think it's fine to use `*`. Besides, in `make install`, it seems people intend to this kind of style. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] Yiyiyimu commented on a change in pull request #3660: chore: update makefile install to install everything in conf
Yiyiyimu commented on a change in pull request #3660: URL: https://github.com/apache/apisix/pull/3660#discussion_r582442941 ## File path: Makefile ## @@ -143,9 +143,7 @@ install: default $(INSTALL) -d /usr/local/apisix/ $(INSTALL) -d /usr/local/apisix/logs/ $(INSTALL) -d /usr/local/apisix/conf/cert - $(INSTALL) conf/mime.types /usr/local/apisix/conf/mime.types - $(INSTALL) conf/config.yaml /usr/local/apisix/conf/config.yaml - $(INSTALL) conf/config-default.yaml /usr/local/apisix/conf/config-default.yaml + $(INSTALL) conf/* /usr/local/apisix/conf/ Review comment: We need ssl ca placeholders to start APISIX. See #3013 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
