[GitHub] [apisix] aseaday commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
aseaday commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-978797764 Or add randomsed in apisix/patch.lua -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aseaday commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
aseaday commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-978797427 > I prefer patch `math.randomseed` way If we patch the math.randomsee globally as the [kong](https://github.com/Kong/kong/blob/fb7a68d497c1104779d650014ba6521bf129f726/kong/globalpatches.lua?_pjax=%23js-repo-pjax-container%2C%20div%5Bitemtype%3D%22http%3A%2F%2Fschema.org%2FSoftwareSourceCode%22%5D%20main%2C%20%5Bdata-pjax-container%5D#L241-L342) way, we need to add a module as the global patch. Is it a good choice to put the module in the core? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aseaday commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
aseaday commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-977992974 > After a careful look at the two implementations, the core is the same. > > Let's do it. I want to fix this bug as an first step to contribute to apisix. As an newbie, I had one question: 1. Need we to patch the math.randomseed or just fix the id problem? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aseaday commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
aseaday commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-977969074 > how about this way? > > https://github.com/kubernetes/ingress-nginx/blob/30809c066cd027079cbb32dccc8a101d6fbffdcb/rootfs/etc/nginx/lua/lua_ingress.lua#L44 It seems like the same as Kong one? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] aseaday commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments
aseaday commented on issue #5417: URL: https://github.com/apache/apisix/issues/5417#issuecomment-977921614 Considering a more stable production purpose use, how about we did our best in the k8s environment or something else? [Project Hipsor](http://www.irisa.fr/caps/projects/hipsor/) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
