[GitHub] [apisix] ccxhwmy commented on pull request #7099: init elasticsearch-logger.lua

2022-08-12 Thread GitBox


ccxhwmy commented on PR #7099:
URL: https://github.com/apache/apisix/pull/7099#issuecomment-1213119807

   > > > @spacewander @tzssangglass #7643 for this issue,It's up to you
   > > 
   > > 
   > > Thanks for your contribution, let's do it.
   > 
   > @ccxhwmy As mentioned above, you should use the elasticsearch bulk API 
(endpoint/index/_bulk)..but I noticed you didn't. 
   
   Yes, I will implement this suggestion, Thank you.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] ccxhwmy commented on pull request #7099: init elasticsearch-logger.lua

2022-08-11 Thread GitBox


ccxhwmy commented on PR #7099:
URL: https://github.com/apache/apisix/pull/7099#issuecomment-1211885931

   > > 
   > 
   > > Hi~ I noticed that you seem to have no time to deal with this pr, and 
I'm interested in it, would you please let me continue to come up with this 
issue? : )
   > 
   > @ccxhwmy I have no way to automate the automated testing,I think you can 
build on what I've done.. I have read the PR you submitted,and I noticed that 
you didn't complete the logic of X-PACK certification, but i have finished.
   
   I will refer to what you have finished, thank you very much! 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



[GitHub] [apisix] ccxhwmy commented on pull request #7099: init elasticsearch-logger.lua

2022-08-10 Thread GitBox


ccxhwmy commented on PR #7099:
URL: https://github.com/apache/apisix/pull/7099#issuecomment-1210704274

   Hi~
   I noticed that you seem to have no time to deal with this pr, and I'm 
interested in it, would you please let me continue to come up with this issue? 
: )


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org