[GitHub] [apisix] dmsolr commented on a change in pull request #5550: feat: support to log response body

[GitBox]

dmsolr commented on a change in pull request #5550:
URL: https://github.com/apache/apisix/pull/5550#discussion_r756558576



##
File path: t/plugin/http-logger.t
##
@@ -108,7 +108,43 @@ done
 
 
 
-=== TEST 4: add plugin
+=== TEST 4: check log schema(include_resp_body_expr)

Review comment:
   updated




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

[GitHub] [apisix] dmsolr commented on a change in pull request #5550: feat: support to log response body

[GitBox]

dmsolr commented on a change in pull request #5550:
URL: https://github.com/apache/apisix/pull/5550#discussion_r756529615



##
File path: docs/zh/latest/plugins/kafka-logger.md
##
@@ -56,8 +56,10 @@ title: kafka-logger
 | buffer_duration  | integer | 可选   | 60 | [1,...] | 
必须先处理批次中最旧条目的最长期限（以秒为单位）。 |
 | max_retry_count  | integer | 可选   | 0  | [0,...] | 
从处理管道中移除之前的最大重试次数。 |
 | retry_delay  | integer | 可选   | 1  | [0,...] | 
如果执行失败，则应延迟执行流程的秒数。   |
-| include_req_body | boolean | 可选   | false  | [false, true] | 是否包括请求 
body。false： 表示不包含请求的 body ；true： 表示包含请求的 body。注意：如果请求 body 没办法完全放在内存中，由于 Nginx 
的限制，我们没有办法把它记录下来。|
-| include_req_body_expr | array  | 可选|   | | 当 
`include_req_body` 开启时, 基于 
[lua-resty-expr](https://github.com/api7/lua-resty-expr) 
表达式的结果进行记录。如果该选项存在，只有在表达式为真的时候才会记录请求 body。 |
+| include_req_body | boolean | 可选   | false  | [false, true] | 是否包括请求 
body。false： 表示不包含请求的 body ； true： 表示包含请求的 body 。|

Review comment:
   Sorry. 
   I think there is the same limitation in the http-logger plugin. Right?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org