[GitHub] [apisix] iamayushdas edited a comment on pull request #4175: docs: fix broken links and ids in plugins

2021-05-04 Thread GitBox


iamayushdas edited a comment on pull request #4175:
URL: https://github.com/apache/apisix/pull/4175#issuecomment-831805292


   @spacewander what do you think about adding or moreover nesting example 
inside authentication -> hmac-auth -> example: hmac generate signature ?
   @KishaniKandasamy want to know your opinion too


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] iamayushdas edited a comment on pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox


iamayushdas edited a comment on pull request #4175:
URL: https://github.com/apache/apisix/pull/4175#issuecomment-831686349


   @KishaniKandasamy what do you think about adding or nesting it into 
authentication -> hmac-auth -> Signature generate example, or 
   you can add a section of example as a type of doc inside authentication,
   do you agree?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] iamayushdas edited a comment on pull request #4175: docs: fix broken links and ids in plugins

2021-05-03 Thread GitBox


iamayushdas edited a comment on pull request #4175:
URL: https://github.com/apache/apisix/pull/4175#issuecomment-831275128


   @Yiyiyimu @tokers have a look to this please


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org