[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-810660808 > Sorry for my rude behavior. But we **really really have an ongoing PR and this one won't be accepted**. > Your commits have created much noise in my notification inbox. Sorry for the noises in your notification inbox. I hope that didn't borther you. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-810121182 @spacewander Excuse me, the nacos test case failed, because it could not find the nacos cluster. How could I complete this e2e test? It seems that I have to modify `config.yaml` to add the nacos config, and setup a nacos enviroment for test case, and register the services into Nacos. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809864565 > GitHub action is not stable enough. Try to push a new commit again. It works. Thanks, ze xuan~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809848507 @spacewander @membphis Execuse me, why the checks stopped here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] imxhf commented on pull request #3934: feat: Discovery Nacos
imxhf commented on pull request #3934: URL: https://github.com/apache/apisix/pull/3934#issuecomment-809271644 > Thanks for your contribution. > However, we already have an ongoing PR: #3820 > > I take a first look at yours. Your implementation has namespaceId and groupName, and an individual way to refresh the token. > > Maybe you can optimize that PR after it's merged? OK~ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
