[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-832613243 Each Plugin PR will have both Chinese & English changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-832612967 Hi, to prevent from misleading PRs or contents, I will split them into smaller PRs. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831648865 After reviewing Chinese versions, I will submit PRs to update EN. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831641900 > Please fix English doc first @moonming Please review Chinese docs first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831641725 > Is it necessary to use docusaurus special syntax? Why not use directly? Those contents are used in the docs site, this syntax will be rendered as `Admonitions Box`. ![image](https://user-images.githubusercontent.com/2106987/116953146-1a01f900-acbf-11eb-9e1e-2d1971f64114.png) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831629657 After discuss with @Yiyiyimu, I agree with him, this is more challenge for a non-CN speaker, you could pick other issues like `Web Test` or `Featrures` or `bugfix` issues. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831345303 @iamayushdas ok! Once this PR is merged without incorrect contents, then you could start doing it :) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation (Chinese)
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831087183 For docs in English, I would prefer submitting a new PR ✌️ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-831085744 > I mean you should change `Access-Controll-Max-Age` to `Access-Control-Max-Age` Done -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-830138361 Hi @Yiyiyimu, I have added some other plugins, this PR is ready for review. (10 Plugins in Chinese) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-830135151 I use `Control` according to MDN[1], does this mean they are different? [1] https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Access-Control-Max-Age -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] juzhiyuan commented on pull request #4155: docs: improve plugins' documentation
juzhiyuan commented on pull request #4155: URL: https://github.com/apache/apisix/pull/4155#issuecomment-828988879 I see there have a wrong check 😳😳 ![image](https://user-images.githubusercontent.com/2106987/116513086-a4331180-a8fb-11eb-9795-bf1fdd183482.png) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org