[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox


juzhiyuan commented on pull request #5823:
URL: https://github.com/apache/apisix/pull/5823#issuecomment-996404873


   Get it, I will create an issue to track this 🥳


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox


juzhiyuan commented on pull request #5823:
URL: https://github.com/apache/apisix/pull/5823#issuecomment-996403248


   > So if you use [Prettier](https://prettier.io/) in the website, you can 
just configure it to `proseWrap: 'none'` and it will collapse all wrapping line 
breaks.
   
   Just to make sure, do you mean to use Prettier to format all markdown files 
in this repo? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] juzhiyuan commented on pull request #5823: docs: remove the redundant space between Chinese characters

2021-12-16 Thread GitBox


juzhiyuan commented on pull request #5823:
URL: https://github.com/apache/apisix/pull/5823#issuecomment-996398822


   > I honestly think this is a legitimate fix and we can just fix this 
everywhere if needed
   
   Hi @Josh-Cena, I can't clearly remember why we have breaking lines in our 
docs 😅 And +1 from me to improve the original docs by folding Chinese phrases 
into one line. @Nidaozi Would you please have a try?
   
   
![image](https://user-images.githubusercontent.com/2106987/146481960-3ae2ed0f-e92f-49f7-b331-151520454587.png)
   
   Hi @spacewander, how about improving those markdown files first, then 
deciding if we need to implement the CI? Just to make sure, you mean we could 
use CI to check all coming Chinese documentation changes, right? 😄


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org