[GitHub] [apisix] membphis commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments

2021-12-02 Thread GitBox


membphis commented on issue #5417:
URL: https://github.com/apache/apisix/issues/5417#issuecomment-984582668


   > Or add randomsed in apisix/patch.lua
   
   I prefer this way. what is your opinion? @spacewander 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments

2021-11-24 Thread GitBox


membphis commented on issue #5417:
URL: https://github.com/apache/apisix/issues/5417#issuecomment-978781045


   I prefer patch `math.randomseed` way


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments

2021-11-24 Thread GitBox


membphis commented on issue #5417:
URL: https://github.com/apache/apisix/issues/5417#issuecomment-978780822


   Which one is the best, then use which one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments

2021-11-24 Thread GitBox


membphis commented on issue #5417:
URL: https://github.com/apache/apisix/issues/5417#issuecomment-977980006


   After a careful look at the two implementations, the core is the same.
   
   Let's do it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org




[GitHub] [apisix] membphis commented on issue #5417: bug: auto-generated apisix id is likely to be duplicated in containerized environments

2021-11-24 Thread GitBox


membphis commented on issue #5417:
URL: https://github.com/apache/apisix/issues/5417#issuecomment-977955790


   how about this way? 
   
   
https://github.com/kubernetes/ingress-nginx/blob/30809c066cd027079cbb32dccc8a101d6fbffdcb/rootfs/etc/nginx/lua/lua_ingress.lua#L44
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@apisix.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org