[GitHub] [apisix] moonming commented on a change in pull request #3871: docs: admin-api.md document adds configuration https example
moonming commented on a change in pull request #3871: URL: https://github.com/apache/apisix/pull/3871#discussion_r603862264 ## File path: docs/en/latest/admin-api.md ## @@ -657,12 +659,32 @@ After the execution is successful, nodes will not retain the original data, and ``` +Example 2: Create upstream and configure the scheme as `https`. + +```shell +# Create upstream and configure the scheme as `https` Review comment: Please check other desc too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3871: docs: admin-api.md document adds configuration https example
moonming commented on a change in pull request #3871: URL: https://github.com/apache/apisix/pull/3871#discussion_r603770459 ## File path: docs/zh/latest/admin-api.md ## @@ -665,11 +668,52 @@ HTTP/1.1 200 OK ``` +示例二：如何使用 HTTPS 的 scheme 将请求代理到上游。 Review comment: 将客户端请求代理到上游https服务 ## File path: docs/en/latest/admin-api.md ## @@ -571,12 +571,16 @@ Config Example: "key": "", "name": "upstream-for-test", "desc": "hello world", +"scheme": "http", # The scheme used when communicating with upstream, the default is `http` } ``` -Example： +**Example:** + +Example 1: Create an upstream and modify the corresponding data. Review comment: modify what data? please desc more detail ## File path: docs/en/latest/admin-api.md ## @@ -657,12 +659,54 @@ After the execution is successful, nodes will not retain the original data, and ``` +Example 2: How to proxy requests to upstream with HTTPS scheme. Review comment: Example 2: How to proxy client request to `https` upstream service -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3871: docs: admin-api.md document adds configuration https example
moonming commented on a change in pull request #3871: URL: https://github.com/apache/apisix/pull/3871#discussion_r598264713 ## File path: docs/en/latest/admin-api.md ## @@ -657,12 +659,32 @@ After the execution is successful, nodes will not retain the original data, and ``` +Example 2: Create upstream and configure the scheme as `https`. + +```shell +# Create upstream and configure the scheme as `https` Review comment: @Firstsawyou any update？ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
[GitHub] [apisix] moonming commented on a change in pull request #3871: docs: admin-api.md document adds configuration https example
moonming commented on a change in pull request #3871: URL: https://github.com/apache/apisix/pull/3871#discussion_r597679185 ## File path: docs/en/latest/admin-api.md ## @@ -657,12 +659,32 @@ After the execution is successful, nodes will not retain the original data, and ``` +Example 2: Create upstream and configure the scheme as `https`. Review comment: This is an example of proxying to upstream https ## File path: docs/en/latest/admin-api.md ## @@ -657,12 +659,32 @@ After the execution is successful, nodes will not retain the original data, and ``` +Example 2: Create upstream and configure the scheme as `https`. + +```shell +# Create upstream and configure the scheme as `https` Review comment: We need a complete example, from apisix configuration to client access -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
