spacewander commented on a change in pull request #3943:
URL: https://github.com/apache/apisix/pull/3943#discussion_r603758443



##########
File path: t/plugin/log-rotate.t
##########
@@ -90,8 +90,8 @@ __DATA__
 --- config
     location /t {
         content_by_lua_block {
-            ngx.log(ngx.WARN, "start xxxxxx")
             ngx.sleep(0.1)
+            ngx.log(ngx.WARN, "start xxxxxx")

Review comment:
       It's obvious. We should ensure the log not be rotated.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to